Re: [U-Boot] [PATCH] boot cmds: convert to getenv_yesno() with autostart

2011-01-11 Thread Wolfgang Denk
Dear Mike Frysinger, In message 201012071657.42065.vap...@gentoo.org you wrote: On Tuesday, December 07, 2010 16:51:41 Wolfgang Denk wrote: Mike Frysinger wrote: hrm, after running this through our test bench, it seems the old code and new code are not functionality equivalent. it

Re: [U-Boot] [PATCH] boot cmds: convert to getenv_yesno() with autostart

2011-01-11 Thread Mike Frysinger
On Tuesday, January 11, 2011 15:04:37 Wolfgang Denk wrote: Mike Frysinger wrote: On Tuesday, December 07, 2010 16:51:41 Wolfgang Denk wrote: Mike Frysinger wrote: hrm, after running this through our test bench, it seems the old code and new code are not functionality equivalent. it

Re: [U-Boot] [PATCH] boot cmds: convert to getenv_yesno() with autostart

2010-12-07 Thread Wolfgang Denk
Dear Mike Frysinger, In message 201012010634.19596.vap...@gentoo.org you wrote: hrm, after running this through our test bench, it seems the old code and new code are not functionality equivalent. it boils down to default values when the env var is not set. some places interpret this to

Re: [U-Boot] [PATCH] boot cmds: convert to getenv_yesno() with autostart

2010-12-07 Thread Mike Frysinger
On Tuesday, December 07, 2010 16:51:41 Wolfgang Denk wrote: Mike Frysinger wrote: hrm, after running this through our test bench, it seems the old code and new code are not functionality equivalent. it boils down to default values when the env var is not set. some places interpret this to

Re: [U-Boot] [PATCH] boot cmds: convert to getenv_yesno() with autostart

2010-12-07 Thread Wolfgang Denk
Dear Mike Frysinger, In message 201012071657.42065.vap...@gentoo.org you wrote: In addition to the default values, there is the difference that the documentation states that autostart has to be set to yes, i. e. a plain y is not supposed to mean 'yes'. consider it an enhancement then ?

Re: [U-Boot] [PATCH] boot cmds: convert to getenv_yesno() with autostart

2010-12-07 Thread Mike Frysinger
On Tuesday, December 07, 2010 17:19:38 Wolfgang Denk wrote: Mike Frysinger wrote: In addition to the default values, there is the difference that the documentation states that autostart has to be set to yes, i. e. a plain y is not supposed to mean 'yes'. consider it an enhancement

Re: [U-Boot] [PATCH] boot cmds: convert to getenv_yesno() with autostart

2010-12-01 Thread Mike Frysinger
On Sunday, November 28, 2010 16:02:49 Wolfgang Denk wrote: Mike Frysinger wrote: Use the new helper func to clean up duplicate logic handling of the autostart env var. Signed-off-by: Mike Frysinger vap...@gentoo.org --- common/cmd_fdc.c |3 +-- common/cmd_fdos.c |2 +-

Re: [U-Boot] [PATCH] boot cmds: convert to getenv_yesno() with autostart

2010-11-28 Thread Wolfgang Denk
Dear Mike Frysinger, In message 1287573475-6737-1-git-send-email-vap...@gentoo.org you wrote: Use the new helper func to clean up duplicate logic handling of the autostart env var. Signed-off-by: Mike Frysinger vap...@gentoo.org --- common/cmd_fdc.c |3 +-- common/cmd_fdos.c |2