Re: [U-Boot] USB-CDC with musb controller

2010-08-11 Thread Remy Bohmer
Hi, 2010/8/11 Stefano Babic sba...@denx.de: Vitaly Kuzmichev wrote: Hi Vitaly, I also have some fixes for ether.c. How should I send them for review? Through this mailing list or make 'git push' into private branch to u-boot-usb.git repo? My two cents. I would prefer to send patches

Re: [U-Boot] [PATCH] USB-CDC: called handle_interrupts inside usb_eth_send

2010-08-11 Thread Remy Bohmer
Hi Stefano, 2010/8/11 Stefano Babic sba...@denx.de: The patch removes an endless loop  in the usb_eth_send if the tx_complete is not called before going in the loop. The driver interrupt routine is called allowing the driver to check if the TX is completed. Signed-off-by: Stefano Babic

Re: [U-Boot] [PATCH] USB-CDC: called handle_interrupts inside usb_eth_send

2010-08-12 Thread Remy Bohmer
Hi Stefano, 2010/8/12 Stefano Babic sba...@denx.de: Remy Bohmer wrote: Hi Stefano, Hi Remy, +       packet_sent=0; This line breaks the at91sam9261 code. Can you please fix this? This means to me that tx_complete() is not called for at91sam9261, as it supposed to be (or better, as I

[U-Boot] [PATCH 0/3] Integrate new USB gadget layer and USB CDC-ECM driver layer

2010-08-12 Thread Remy Bohmer
Hi, Here is a series of 3 patches that add support for USB-CDC-ECM to U-boot. With this series it will become possible to use U-boot as an Ethernet gadget device. It can, for example, be used to download via TFTP files from a TFTP via USB-ethernet, while U-boot functions as a USB-device. It does

[U-Boot] [PATCH 2/3] Connect the AT91 UDC to USB CDC-ethernet support

2010-08-12 Thread Remy Bohmer
. Signed-off-by: Thomas Smits ts.sm...@gmail.com Signed-off-by: Remy Bohmer li...@bohmer.net --- arch/arm/include/asm/arch-at91/at91_dbgu.h | 69 ++ arch/arm/include/asm/arch-at91/cpu.h | 99 ++ drivers/usb/gadget/Makefile|1 + drivers/usb/gadget/at91_udc.c

Re: [U-Boot] [PATCH] usb: musb: setup TXCOUNT for Blackfin musb

2010-08-12 Thread Remy Bohmer
Hi, 2010/8/9 Mike Frysinger vap...@gentoo.org: From: Bryan Wu bryan...@analog.com The Blackfin implementation of musb has a TXCOUNT register that needs to be programmed when transmitting data. Signed-off-by: Bryan Wu bryan...@analog.com Signed-off-by: Cliff Cai cliff@analog.com

Re: [U-Boot] [PATCH v2] usb: musb: set target address for non-multipoint devices

2010-08-12 Thread Remy Bohmer
Hi, 2010/8/10 Mike Frysinger vap...@gentoo.org: From: Bryan Wu bryan...@analog.com Signed-off-by: Bryan Wu bryan...@analog.com Signed-off-by: Cliff Cai cliff@analog.com Signed-off-by: Mike Frysinger vap...@gentoo.org --- v2        - use writeb instead of writew as pointed out by

Re: [U-Boot] [PATCH] usb: musb: only write CLRDATATOG when appropriate

2010-08-12 Thread Remy Bohmer
Hi, 2010/8/10 Mike Frysinger vap...@gentoo.org: On Tue, Aug 10, 2010 at 6:26 AM, Sergei Shtylyov wrote: Mike Frysinger wrote: --- a/drivers/usb/musb/musb_hcd.c +++ b/drivers/usb/musb/musb_hcd.c        } else { -               if (!toggle) -                      

Re: [U-Boot] [PATCH] usb: musb: only write CLRDATATOG when appropriate

2010-08-12 Thread Remy Bohmer
Hi Mike, 2010/8/9 Mike Frysinger vap...@gentoo.org: From: Bryan Wu bryan...@analog.com This is a change similar to what is already in the Linux driver.  We should only program the CLRDATATOG bit when the current mode indicates that it is needed. Signed-off-by: Bryan Wu bryan...@analog.com

Re: [U-Boot] [PATCH 3/8] USB-CDC: Linux-like debug printout

2010-08-12 Thread Remy Bohmer
Hi, 2010/8/12 Vitaly Kuzmichev vkuzmic...@mvista.com: Take debug printout macros back from linux-2.6.27 and make them more useful and more compatible. Signed-off-by: Vitaly Kuzmichev vkuzmic...@mvista.com ---  drivers/usb/gadget/ether.c |   65 +++-

Re: [U-Boot] [PATCH 0/8] USB: gadget: fix porting bugs

2010-08-12 Thread Remy Bohmer
Hi, 2010/8/12 Vitaly Kuzmichev vkuzmic...@mvista.com: 1) Restuct Makefile to unable usage old and new stacks simultaneously 4) Fix in_ep, out_ep, ep0 and status_ep confusions 5) Replace 'strcpy' by 'strlcpy' 6) Fix possible oops on stat_req-buf initialization OK 2) Add lost 'qmult'

Re: [U-Boot] [PATCH 2/3] Connect the AT91 UDC to USB CDC-ethernet support

2010-08-12 Thread Remy Bohmer
Hi, 2010/8/12 Reinhard Meyer u-b...@emk-elektronik.de: Dear Remy Bohmer, This patch implements the low-level part of the USB CDC layer for AT91 Other boards can use this patch as an example to connect their own. diff --git a/arch/arm/include/asm/arch-at91/at91_dbgu.h b/arch/arm/include/asm

Re: [U-Boot] [PATCH 3/8] USB-CDC: Linux-like debug printout

2010-08-13 Thread Remy Bohmer
Hi, 2010/8/13 Vitaly Kuzmichev vkuzmic...@mvista.com: Hi Remy, No, it does not. DEBUG is defined as dev_err and dev_err is defined as printf. Anyway I can change it. Please do not top-post! On 08/12/2010 10:33 PM, Remy Bohmer wrote: @@ -37,8 +37,10 @@  #define dev_err(x, stuff

Re: [U-Boot] [PATCH 2/3] Connect the AT91 UDC to USB CDC-ethernet support

2010-08-13 Thread Remy Bohmer
Hi, 3. I did not follow the whole USB patches, my concern is what touches AT91, but please explain to me what for we need a board under u-boot to be a USB device. Since u-boot per se is not multitasking how is the traffic handled while at the command prompt? There is no traffic handled

Re: [U-Boot] [PATCH 2/3] Connect the AT91 UDC to USB CDC-ethernet support

2010-08-13 Thread Remy Bohmer
Hi Wolfgang, 2010/8/12 Wolfgang Denk w...@denx.de: Dear Remy Bohmer, In message aanlkti=z0sx9yrxgh-_ogcpduxhyrhadnerhvvbon...@mail.gmail.com you wrote: Use struct access for SoC registers. Offset adressing is depreciated. See the struct in my at91_dbgu.h. Use readl/writel to access

Re: [U-Boot] [PATCH 2/3] Connect the AT91 UDC to USB CDC-ethernet support

2010-08-13 Thread Remy Bohmer
Hi, 2010/8/13 Reinhard Meyer u-b...@emk-elektronik.de: Dear Remy Bohmer, 3. I did not follow the whole USB patches, my concern is what touches AT91, but please explain to me what for we need a board under u-boot to be a USB device. Since u-boot per se is not multitasking how is the traffic

Re: [U-Boot] [PATCH 2/3] Connect the AT91 UDC to USB CDC-ethernet support

2010-08-13 Thread Remy Bohmer
Hi Wolfgang, 2010/8/13 Wolfgang Denk w...@denx.de: Dear Remy Bohmer, Well, if your argument is true that the current code can easily be kept in sync with Linux, then why is it already 8 kernel releases old? Because it lives already for a real long time in the u-boot-usb tree with no requests

Re: [U-Boot] [PATCH 3/8] USB-CDC: Linux-like debug printout

2010-08-13 Thread Remy Bohmer
Hi, DEBUG is already a well-defined name. Any different use of the same name will result in the patches being rejected. Please fix this! I also object against names like WARN, ERROR and INFO. They are just too dangerous. Agree. Remy ___ U-Boot

Re: [U-Boot] [PATCH 1/8] USB-CDC: Restuct USB gadget Makefile

2010-08-13 Thread Remy Bohmer
Hi, 2010/8/12 Vitaly Kuzmichev vkuzmic...@mvista.com: Prohibit simultaneous usage of both old and new gadget stacks and allow UDC drivers to be dependent on CONFIG_USB_ETHER. Signed-off-by: Vitaly Kuzmichev vkuzmic...@mvista.com ---  drivers/usb/gadget/Makefile |    9 ++---  1 files

Re: [U-Boot] [PATCH 2/8] USB-CDC: Add lost 'qmult' definition

2010-08-13 Thread Remy Bohmer
Hi, 2010/8/12 Vitaly Kuzmichev vkuzmic...@mvista.com: Add lost 'qmult' definition for High Speed devices and make it configurable through CONFIG_USB_ETH_QMULT. Signed-off-by: Vitaly Kuzmichev vkuzmic...@mvista.com ---  drivers/usb/gadget/ether.c |    6 ++  1 files changed, 6

Re: [U-Boot] [PATCH v2 3/8] USB-CDC: Use native debug printout macros

2010-08-13 Thread Remy Bohmer
Hi, 2010/8/13 Vitaly Kuzmichev vkuzmic...@mvista.com: Replace Linux-like debug printout macros by native ones. Signed-off-by: Vitaly Kuzmichev vkuzmic...@mvista.com ---  drivers/usb/gadget/ether.c |   99 ---  1 files changed, 46 insertions(+), 53

Re: [U-Boot] [PATCH v2 5/8] USB-CDC: Replace 'strcpy' by 'strlcpy'

2010-08-13 Thread Remy Bohmer
Hi, 2010/8/13 Vitaly Kuzmichev vkuzmic...@mvista.com: Replace 'strcpy' by more safe 'strlcpy' that is implemented in ether.c Signed-off-by: Vitaly Kuzmichev vkuzmic...@mvista.com ---  drivers/usb/gadget/ether.c |    6 +++---  1 files changed, 3 insertions(+), 3 deletions(-) Applied to

Re: [U-Boot] [PATCH v2 4/8] USB-CDC: Correct freeing usb requests

2010-08-13 Thread Remy Bohmer
Hi, 2010/8/13 Vitaly Kuzmichev vkuzmic...@mvista.com: Fix in_ep and out_ep confusion (rx_req was allocated from out_ep, not from in_ep) and add lost dev-req freeing. Signed-off-by: Vitaly Kuzmichev vkuzmic...@mvista.com ---  drivers/usb/gadget/ether.c |    9 +++--  1 files changed, 7

Re: [U-Boot] [PATCH v2 6/8] USB-CDC: Correct stat_req initialization

2010-08-13 Thread Remy Bohmer
Hi, 2010/8/13 Vitaly Kuzmichev vkuzmic...@mvista.com: Fix possible oops on stat_req-buf initialization and fix ep0 and status_ep confusion (last one is just intended for stat_req keeping). Signed-off-by: Vitaly Kuzmichev vkuzmic...@mvista.com Signed-off-by: Stefano Babic sba...@denx.de ---

Re: [U-Boot] [PATCH v2 8/8] USB-CDC: change simple_strtol to simple_strtoul

2010-08-13 Thread Remy Bohmer
Hi, 2010/8/13 Vitaly Kuzmichev vkuzmic...@mvista.com: The patch is based on commit bb9496c6f7e853e5d4edd5397c9d45f1968d623c (done by Julia Lawall ju...@diku.dk) from linux-2.6.git. Since num is unsigned, it would seem better to use simple_strtoul that simple_strtol. Signed-off-by: Vitaly

Re: [U-Boot] [PATCH v2 3/8] USB-CDC: Use native debug printout macros

2010-08-13 Thread Remy Bohmer
Hi, 2010/8/13 Wolfgang Denk w...@denx.de: Dear Remy Bohmer, In message aanlktikbeesekkuaecpzbwm3ramjkjcpkk=ykrnhw...@mail.gmail.com you wrote: +#define DEBUG +#undef DEBUG Applied to u-boot-usb/cdc branch after removing ' #define DEBUG' as Sergei suggested. NAK. Please also remove

Re: [U-Boot] [PATCH V2 1/2] USB-CDC: correct wrong alignment in ether.c

2010-08-14 Thread Remy Bohmer
Hi, 2010/8/14 Stefano Babic sba...@denx.de: The buffer for the status request must be word aligned because it is accessed with 32 bit pointer in the eth_status_complete function. Signed-off-by: Stefano Babic sba...@denx.de ---  drivers/usb/gadget/ether.c |    2 +-  1 files changed, 1

Re: [U-Boot] [PATCH V2 1/2] USB-CDC: correct wrong alignment in ether.c

2010-08-14 Thread Remy Bohmer
Hi, 2010/8/14 Sergei Shtylyov sshtyl...@mvista.com: Hello. Stefano Babic wrote: The buffer for the status request must be word aligned because it is accessed with 32 bit pointer in the eth_status_complete function. Signed-off-by: Stefano Babic sba...@denx.de [...] diff --git

Re: [U-Boot] [PATCH V2 2/2] USB-CDC: called handle_interrupts inside usb_eth_send

2010-08-14 Thread Remy Bohmer
...@denx.de --- Changes from V1: - Comments by Remy Bohmer: moved usb_ep_queue inside timeout to not break at91 code Sorry, patch does not apply any more after applying the series from Vitaly yesterday. please rebase. Kind regards, Remy ___ U-Boot mailing

Re: [U-Boot] [PATCH V3 2/2] USB-CDC: called handle_interrupts inside usb_eth_send

2010-08-15 Thread Remy Bohmer
Hi, 2010/8/15 Stefano Babic sba...@denx.de: The patch removes an endless loop  in the usb_eth_send if the tx_complete is not called before going in the loop. The driver interrupt routine is called allowing the driver to check if the TX is completed. Signed-off-by: Stefano Babic

Re: [U-Boot] [PATCH V3 1/2] USB-CDC: correct wrong alignment in ether.c

2010-08-15 Thread Remy Bohmer
Hi, 2010/8/15 Stefano Babic sba...@denx.de: The buffer for the status request must be word aligned because it is accessed with 32 bit pointer in the eth_status_complete function. Signed-off-by: Stefano Babic sba...@denx.de ---  drivers/usb/gadget/ether.c |    2 +-  1 files changed, 1

Re: [U-Boot] Debugging, Why USB is not stable

2010-08-31 Thread Remy Bohmer
Hi Detlev, 2010/8/30 Detlev Zundel d...@denx.de: Hi Gérald, I have some few problems with usb start / reset commands on last uboot. USB hard drive are not always detected. Is there something I missed ? Only the fact that USB is a nightmare to work with.  No, honestly, we have a

Re: [U-Boot] [PATCH] usb: fix usb start problem with SMSC USB hub and Toshiba USB stick

2010-09-01 Thread Remy Bohmer
Hi, 2010/8/31 Anatolij Gustschin ag...@denx.de: Checking the status field of the qTD token in the current code do not take into acount cases where endpoint stall (halted) bit is set together with some other status bits. As a result clearing stall on an endpoint won't be done if other status

Re: [U-Boot] [PATCH 0/3] USB keyboard driver rework (round 2)

2011-11-26 Thread Remy Bohmer
] USB: Add usb_event_poll() to get keyboards working with EHCI Message-Id: 1316977676-10284-1-git-send-email-marek.va...@gmail.com Cc: Mike Frysinger vap...@gentoo.org Cc: Remy Bohmer li...@bohmer.net Cc: Wolfgang Denk w...@denx.de Marek Vasut (3):  USB: Squash checkpatch warnings in usb_kbd.c

Re: [U-Boot] [PATCH] ehci-fsl: correct size of ehci caplength

2011-11-26 Thread Remy Bohmer
Hi, 2011/10/18 Kumar Gala ga...@kernel.crashing.org: On Oct 17, 2011, at 1:16 PM, Wolfgang Grandegger wrote: According to the EHCI specification the Capability Register Length has a size of 8 bits. Signed-off-by: Wolfgang Grandegger w...@denx.de --- include/usb/ehci-fsl.h |   25

Re: [U-Boot] [PATCH 1/5] pxa: fix usb host register mismatch

2011-11-26 Thread Remy Bohmer
Hi 2011/10/17 Stefan Herbrechtsmeier sherb...@cit-ec.uni-bielefeld.de: Signed-off-by: Stefan Herbrechtsmeier sherb...@cit-ec.uni-bielefeld.de CC: Marek Vasut marek.va...@gmail.com CC: Remy Bohmer  li...@bohmer.net ---  arch/arm/cpu/pxa/usb.c                   |    2 +-  arch/arm/include/asm

Re: [U-Boot] [PATCH 2/5] pxa: activate the first usb host port on pxa27x by default

2011-11-26 Thread Remy Bohmer
Hi, 2011/10/17 Stefan Herbrechtsmeier sherb...@cit-ec.uni-bielefeld.de: The pxa27x has 3 usb host ports. Activate all by default. Signed-off-by: Stefan Herbrechtsmeier sherb...@cit-ec.uni-bielefeld.de CC: Marek Vasut marek.va...@gmail.com CC: Remy Bohmer  li...@bohmer.net ---  arch/arm/cpu

Re: [U-Boot] [PATCH 3/5] pxa: convert pxa27x_udc to use read and write functions

2011-11-26 Thread Remy Bohmer
Hi, 2011/10/17 Marek Vasut marek.va...@gmail.com: On Monday, October 17, 2011 05:22:48 PM Stefan Herbrechtsmeier wrote: Signed-off-by: Stefan Herbrechtsmeier sherb...@cit-ec.uni-bielefeld.de CC: Marek Vasut marek.va...@gmail.com CC: Remy Bohmer  li...@bohmer.net --- Hi Stefan, this patch

Re: [U-Boot] [PATCH 4/5] usbtty: init endpoints prior to startup events

2011-11-26 Thread Remy Bohmer
: Remy Bohmer  li...@bohmer.net ---  drivers/serial/usbtty.c |    4 ++--  1 files changed, 2 insertions(+), 2 deletions(-) Applied to u-boot-usb Kind regards, Remy ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 5/5] pxa: fix relocation

2011-11-26 Thread Remy Bohmer
Hi, 2011/10/17 Stefan Herbrechtsmeier sherb...@cit-ec.uni-bielefeld.de: The current relocation don't work correct, as it doesn't clear the initial ram (dcache) after relocation. This leads to missing bootargs during Linux boot. Additionally the current relocation use the sdram address for the

Re: [U-Boot] [PATCH] usb: align usb_endpoint_descriptor to 16-bit boundary

2011-11-26 Thread Remy Bohmer
Hi, 2011/10/20 Stefan Kristiansson stefan.kristians...@saunalahti.fi: The usb_endpoint_descriptor struct is 7 bytes large and is defined as an array (ep_desc[USB_MAXENDPOINTS]) in the usb_interface struct in include/usb.h This fact will result in that every odd index in that array will

Re: [U-Boot] [PATCH v5 1/3] usb:gadget:s5p USB Device Controller (UDC) implementation

2011-11-26 Thread Remy Bohmer
...@samsung.com Cc: Minkyu Kang mk7.k...@samsung.com Cc: Remy Bohmer li...@bohmer.net --- Changes for v2:        - Coding cleanups and fixes        - s3c_udc* files history and origination added        - regs-otg.h rewritten to use structs instedad of          #defines Changes for v3:        - D

Re: [U-Boot] [PATCH v1 3/3] usb:gadget:s5p Enable the USB Gadget framework at C210 Universal

2011-11-26 Thread Remy Bohmer
Hi, 2011/10/27 Lukasz Majewski l.majew...@samsung.com: This commit enables support for USB Gadgets on the C210 Universal reference target. Signed-off-by: Lukasz Majewski l.majew...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Minkyu Kang mk7.k...@samsung.com ---

Re: [U-Boot] [PATCH v2 3/3] usb:gadget:s5p Support for USB Mass Storage Gadget at GONI

2011-11-26 Thread Remy Bohmer
Hi, 2011/10/18 Lukasz Majewski l.majew...@samsung.com: This patch adds support for USB Mass Storage Gadget on the Samsung's GONI reference target Signed-off-by: Lukasz Majewski l.majew...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Remy Bohmer li...@bohmer.net Cc

Re: [U-Boot] [PATCH 2/2] usb: add help for missing start subcommand

2011-11-26 Thread Remy Bohmer
Hi, 2011/11/2 Veli-Pekka Peltola veli-pekka.pelt...@bluegiga.com: Signed-off-by: Veli-Pekka Peltola veli-pekka.pelt...@bluegiga.com Cc: Remy Bohmer li...@bohmer.net --- When I first time used USB framework it was not so obvious to start with usb reset to get everything going on. So lets add

Re: [U-Boot] [PATCH 1/2] cosmetic: remove excess whitespace from usb command help

2011-11-26 Thread Remy Bohmer
Hi, 2011/11/2 Veli-Pekka Peltola veli-pekka.pelt...@bluegiga.com: Signed-off-by: Veli-Pekka Peltola veli-pekka.pelt...@bluegiga.com Cc: Remy Bohmer li...@bohmer.net ---  common/cmd_usb.c |   10 +-  1 files changed, 5 insertions(+), 5 deletions(-) Applied to u-boot-usb. Thanks. Kind

Re: [U-Boot] [PATCH] drivers/usb/host/ehci-mxc.c: Fix GCC 4.6 warning

2011-11-26 Thread Remy Bohmer
Hi, 2011/11/19 Anatolij Gustschin ag...@denx.de: Fix: ehci-mxc.c: In function 'ehci_hcd_init': ehci-mxc.c:113:6: warning: variable 'tmp' set but not used [-Wunused-but-set-variable] Signed-off-by: Anatolij Gustschin ag...@denx.de ---  drivers/usb/host/ehci-mxc.c |    3 +--  1 files

Re: [U-Boot] [PATCH 4/5] usbtty: init endpoints prior to startup events

2011-11-30 Thread Remy Bohmer
Hi Stefan, 2011/11/28 Stefan Herbrechtsmeier sherb...@cit-ec.uni-bielefeld.de: Am 26.11.2011 23:25, schrieb Remy Bohmer: 2011/10/17 Stefan Herbrechtsmeiersherb...@cit-ec.uni-bielefeld.de: On some usb device controllers (pxa) the endpoint configuration must be programmed prior to enable

Re: [U-Boot] [PATCH 5/9] drivers/usb/gadget/core.c: Fix GCC 4.6 warning

2011-12-04 Thread Remy Bohmer
Hi, 2011/12/3 Anatolij Gustschin ag...@denx.de: Fix: core.c: In function 'usbd_device_event_irq': core.c:596:21: warning: variable 'state' set but not used [-Wunused-but-set-variable] Signed-off-by: Anatolij Gustschin ag...@denx.de Cc: Remy Bohmer li...@bohmer.net ---  drivers/usb/gadget

Re: [U-Boot] [PATCH 4/9] drivers/usb/musb/musb_udc.c: Fix GCC 4.6 warning

2011-12-04 Thread Remy Bohmer
] musb_udc.c:165:5: warning: variable 'intrusb' set but not used [-Wunused-but-set-variable] Signed-off-by: Anatolij Gustschin ag...@denx.de Cc: Remy Bohmer li...@bohmer.net ---  drivers/usb/musb/musb_udc.c |    8 +++-  1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/usb

Re: [U-Boot] [PATCH v2 13/17] tegra: usb: Add support for Tegra USB peripheral

2011-12-04 Thread Remy Bohmer
kernel fdt) - Improve debug() printouts in case of failure to init USB  drivers/usb/host/Makefile                 |    1 +  drivers/usb/host/ehci-tegra.c             |   63 + As for this USB part: Acked-by: Remy Bohmer li...@bohmer.net Kind regards, Remy

Re: [U-Boot] [PATCH v2 11/17] usb: Add support for data alignment

2011-12-04 Thread Remy Bohmer
Hi, 2011/12/3 Simon Glass s...@chromium.org: CONFIG_USB_EHCI_DATA_ALIGN sets the required alignment of data for USB packets (e.g. 4 means word-aligned). This is required for Tegra to operate. Signed-off-by: Simon Glass s...@chromium.org --- Changes in v2: - Tidy code style in USB buffer

Re: [U-Boot] [PATCH 6/9] drivers/usb/gadget/ep0.c: Fix GCC 4.6 warning

2011-12-04 Thread Remy Bohmer
Hi, 2011/12/3 Anatolij Gustschin ag...@denx.de: Fix: ep0.c: In function 'ep0_get_descriptor': ep0.c:187:8: warning: variable 'cp' set but not used [-Wunused-but-set-variable] Signed-off-by: Anatolij Gustschin ag...@denx.de Cc: Remy Bohmer li...@bohmer.net ---  drivers/usb/gadget/ep0.c

[U-Boot] Pull request: u-boot-usb

2011-12-10 Thread Remy Bohmer
The following changes since commit c4eba6ec5c58083b38340724c006294c7a4fe2eb: common/usb_kbd.c: fix bug introduced in commit 00b7d6e (2011-12-09 12:09:35 +0100) are available in the git repository at: git://git.denx.de/u-boot-usb.git master Lei Wen (1): USB: gadaget: add Marvell

Re: [U-Boot] [PATCH v2 11/17] usb: Add support for data alignment

2011-12-10 Thread Remy Bohmer
Hi Simon, 2011/12/6 Simon Glass s...@chromium.org: I do not really like this solution. Maybe we can introduce something like an usbbuf_alloc() function that takes care of the alignment. This saves the memcpy() for every transmit. I know it has more impact if we do it like that, but I think

Re: [U-Boot] [PATCH] ehci: speed up initialization

2011-12-10 Thread Remy Bohmer
Hi, 2011/12/5 Vincent Palatin vpala...@chromium.org: According to EHCI specification v1.0, the controller should stabilize the power on a port at most 20 ms after the port power bit transition. So, we put this setting in the virtual descriptor corresponding field, (bPwrOn2PwrGood = 10 = 10 x

Re: [U-Boot] [PATCH v3 11/16] usb: Add support for txfifo threshold

2011-12-10 Thread Remy Bohmer
+++  drivers/usb/host/ehci.h     |    6 +-  3 files changed, 15 insertions(+), 1 deletions(-) Since it is part of a bigger series: Acked-by: Remy Bohmer li...@bohmer.net Kind regards, Remy ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de

Re: [U-Boot] [PATCH 0/9] MX5x USB support

2011-12-10 Thread Remy Bohmer
Hi Marek, 2011/12/7 Marek Vasut marek.va...@gmail.com: This patchset adds the USB support for MX5x. Most of the code is based on work of Wolfgang Grandegger with modifications done by various other authors. I also included version of ULPI support code cleaned up by Igor Grinberg. NOTE: I'd

Re: [U-Boot] [PATCH 0/9] MX5x USB support

2011-12-10 Thread Remy Bohmer
Hi Marek, If some of the patches didn't make it through gmail because of the different From:, please check git://git.denx.de/u-boot-marex.git, usb branch. Pulling it failed. Can you please rebase it on top of current u-boot-usb, then I will pull it from there. Kind regards, Remy

Re: [U-Boot] [PATCH v1 3/3] usb:gadget:s5p Enable the USB Gadget framework at C210 Universal

2011-12-11 Thread Remy Bohmer
Hi Lukasz, 2011/11/27 Remy Bohmer li...@bohmer.net: Hi, 2011/10/27 Lukasz Majewski l.majew...@samsung.com: This commit enables support for USB Gadgets on the C210 Universal reference target. Signed-off-by: Lukasz Majewski l.majew...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p

[U-Boot] Pull request: u-boot-usb

2011-12-11 Thread Remy Bohmer
The following changes since commit c90a4dd79cb17abb46689f27ff9f1c971362d6e2: post/post.c: Use lldiv for 64-bit divisions (2011-12-10 23:15:14 +0100) are available in the git repository at: git://git.denx.de/u-boot-usb.git master Jana Rapava (1): USB: Add generic ULPI layer and a

Re: [U-Boot] [PATCH v3] AT91: pio: Add PIO3 features

2011-12-15 Thread Remy Bohmer
-by: Hong Xu hong...@atmel.com Maybe this helps getting this patch rolling again: Acked-by: Remy Bohmer li...@bohmer.net Kind regards, Remy ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2 1/4] USB: ULPI: switch argument type from u8 to unsigned

2011-12-16 Thread Remy Bohmer
Hi, 2011/12/16 Simon Glass s...@chromium.org: On Tue, Dec 13, 2011 at 10:16 PM, Igor Grinberg grinb...@compulab.co.il wrote: There is no benefit in using u8, so switch to unsigned to reduce the binary image size (by 20 bytes). Signed-off-by: Igor Grinberg grinb...@compulab.co.il Acked-by:

Re: [U-Boot] [PATCH 2/4] USB: ULPI: clean a mixup of return types

2011-12-16 Thread Remy Bohmer
Hi, 2011/12/12 Igor Grinberg grinb...@compulab.co.il: Clean a mixup between u32 and int as a return type for functions returning error values. Use int as it is native (and widely used) return type. Signed-off-by: Igor Grinberg grinb...@compulab.co.il ---  drivers/usb/ulpi/ulpi-viewport.c |

Re: [U-Boot] [PATCH 3/4] USB: ULPI: increase error case verbosity

2011-12-16 Thread Remy Bohmer
Hi, 2011/12/12 Igor Grinberg grinb...@compulab.co.il: Add the argument value to the error message. Signed-off-by: Igor Grinberg grinb...@compulab.co.il ---  drivers/usb/ulpi/ulpi.c |   12 ++--  1 files changed, 6 insertions(+), 6 deletions(-) Applied to -u-boot-usb. Thanks. Kind

Re: [U-Boot] [PATCH v3 3/3] usb:gadget:s5p Enable the USB Gadget framework at Exynos4210 (C210 Universal)

2011-12-16 Thread Remy Bohmer
...@samsung.com CC: Remy Bohmer li...@bohmer.net --- Changes for v2:        - Rename the S5PC210_Universal to Exynos4210 Changes for v3:        - status check removed        - SAFEOUT1 LDO enabled for USB operation        - Reorder of USB LDOs Applied to u-boot-usb. Thanks. Kind regards, Remy

Re: [U-Boot] [PATCH v2 1/1] USB: Use (get|put)_unaligned for accessing wMaxPacketSize

2011-12-16 Thread Remy Bohmer
, a macro. Cc: Minkyu Kang mk7.k...@samsung.com Cc: Remy Bohmer li...@bohmer.net OpenRISC: Tested-by: Stefan Kristiansson stefan.kristians...@saunalahti.fi Beagleboard xM, Pandaboard run-tested, s5p_goni build-tested. Signed-off-by: Tom Rini tr...@ti.com ---  common/cmd_usb.c

Re: [U-Boot] [PATCH 4/4] README: add documentation for CONFIG_USB_ULPI*

2011-12-16 Thread Remy Bohmer
Hi, 2011/12/16 Simon Glass s...@chromium.org: Hi Remy, On Fri, Dec 16, 2011 at 12:10 PM, Remy Bohmer li...@bohmer.net wrote: Hi Igor, Here the configs are documented. I admit, it is not that brilliant documentation... Are you planning to post an update of this patch? The rest

[U-Boot] Pull request: u-boot-usb

2011-12-16 Thread Remy Bohmer
The following changes since commit 06e42c6e2ce269667daecd6229d0b7c813838203: Merge branch 'ag...@denx.de' of git://git.denx.de/u-boot-staging (2011-12-12 14:51:16 +0100) are available in the git repository at: git://git.denx.de/u-boot-usb.git master Igor Grinberg (4): USB: ULPI:

Re: [U-Boot] [PATCH] USB: move keyboard polling from EHCI driver into kbd driver

2011-12-17 Thread Remy Bohmer
Hi, 2011/12/16 Allen Martin amar...@nvidia.com: This removes dependency on global variable new from EHCI driver with CONFIG_SYS_USB_EVENT_POLL turned on and gets USB keyboard working with EHCI driver again. Signed-off-by: Allen Martin amar...@nvidia.com ---  common/usb_kbd.c            |  

Re: [U-Boot] [PATCH] ehci: speed up initialization

2011-12-19 Thread Remy Bohmer
Hi Wolfgang, 2011/12/19 Wolfgang Grandegger w...@grandegger.com: On 12/19/2011 01:51 PM, Vincent Palatin wrote: On Mon, Dec 19, 2011 at 04:07, Wolfgang Grandegger w...@grandegger.com wrote: I just realized that this patch breaks usb start on my mx53loco board: The device is not found at

Re: [U-Boot] [PATCH v8 2/4] Add Ethernet hardware MAC address framework to usbnet

2011-06-20 Thread Remy Bohmer
Hi, 2011/6/14 Simon Glass s...@chromium.org: Built-in Ethernet adapters support setting the mac address by means of a ethaddr environment variable for each interface (ethaddr, eth1addr, eth2addr). This adds similar support to the USB network side, using the names usbethaddr, usbeth1addr,

Re: [U-Boot] [PATCH v8 1/4] Add support for SMSC95XX USB 2.0 10/100MBit Ethernet Adapter

2011-06-20 Thread Remy Bohmer
Hi, 2011/6/14 Simon Glass s...@chromium.org: The SMSC95XX is a USB hub with a built-in Ethernet adapter. This adds support for this, using the USB host network framework. Changes for v2: - Coding style cleanup - Changed some comments as suggested Changes for v3: - Change turbo_mode to

Re: [U-Boot] [PATCH v8 3/4] Add documentation for USB Host Networking

2011-06-20 Thread Remy Bohmer
Hi, 2011/6/14 Simon Glass s...@chromium.org: This describes what it is for, devices supported, how to enable for your board in U-Boot, setting up the server, and notes about MAC addresses. Changes for v6: - Adjust documentation file according to Wolfgang's comments Signed-off-by: Simon

Re: [U-Boot] [PATCH v8 4/4] Put common autoload code into auto_load() function

2011-06-20 Thread Remy Bohmer
Hi, 2011/6/14 Simon Glass s...@chromium.org: This is a small clean-up patch. Changes for v8:  - Fix typo in auto_load Signed-off-by: Simon Glass s...@chromium.org Tested-by: Eric Bénard e...@eukrea.com --- Applied to u-boot-usb AFTER cleaning up commit message (Change history of the

[U-Boot] Pull request: u-boot-usb

2011-06-25 Thread Remy Bohmer
The following changes since commit 9623c158f6a5150a21c25026bfba79e7ff7912f5: Merge branch 'master' of git://git.denx.de/u-boot-arm (2011-06-23 15:37:33 +0200) are available in the git repository at: git://git.denx.de/u-boot-usb.git master Cliff Cai (1): musb: process control messages

Re: [U-Boot] [PATCH] usb: convert to partial linking

2011-06-25 Thread Remy Bohmer
Hi, 2011/6/25 Mike Frysinger vap...@gentoo.org: Looks like this was missed during the conversion to partial linking. Signed-off-by: Mike Frysinger vap...@gentoo.org ---  Makefile                 |    2 +-  drivers/usb/eth/Makefile |    4 ++--  2 files changed, 3 insertions(+), 3

Re: [U-Boot] [PATCH 0/2] usb:gadget: Linux USB Gadget framework

2011-07-05 Thread Remy Bohmer
Hi, 2011/7/5 Lukasz Majewski l.majew...@samsung.com: Included commits provide Linux USB gadget support for U-boot. The USB Gadget infrastructure is running on top of the Samsung's UDC OTG controller. The code has been tested on the GONI (S5PC110) reference target. Files:

[U-Boot] Pull request: u-boot-usb

2009-12-20 Thread Remy Bohmer
The following changes since commit bb3bcfa2426cc6a0aecec7270e3ee67ca843a125: Wolfgang Denk (1): Merge branch 'next' of ../next are available in the git repository at: git://git.denx.de/u-boot-usb.git master Ajay Kumar Gupta (1): omap3evm: musb: add USB config Mahavir Jain

Re: [U-Boot] [PATCH 3/4 v5] DA8xx: Add MUSB host support

2009-12-21 Thread Remy Bohmer
Hi, 2009/12/21 Gupta, Ajay Kumar ajay.gu...@ti.com: Remy, How about USB patches from me supporting MUSB on DA8xx platform? Okay let's check... 2009/11/17 Gupta, Ajay Kumar ajay.gu...@ti.com: Remy, Any comment on DA8xx USB support patches? These patch set depends on DA8xx base support

Re: [U-Boot] [PATCH 0/4 v7] DA8xx: USB support

2009-12-22 Thread Remy Bohmer
Hi, 2009/12/22 Ajay Kumar Gupta ajay.gu...@ti.com: Hi, These patch set have been refreshed and created against mainline master branch. Changes from v6: Added missing drivers/usb/musb/da8xx.c/h files. Applied the series to u-boot-usb Thanks. Remy

Re: [U-Boot] [PATCH 1/5] usb: musb: make sure the register layout is packed

2009-12-22 Thread Remy Bohmer
Hi, 2009/12/17 Mike Frysinger vap...@gentoo.org: Signed-off-by: Mike Frysinger vap...@gentoo.org ---  drivers/usb/musb/musb_core.h |    2 +-  1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/usb/musb/musb_core.h b/drivers/usb/musb/musb_core.h index f9da3f0..5e01b98

Re: [U-Boot] [PATCH 3/5] usb: musb: make multipoint optional

2009-12-22 Thread Remy Bohmer
Hi, 2009/12/17 Mike Frysinger vap...@gentoo.org: From: Bryan Wu bryan...@analog.com The multipoint handling under MUSB is optional, and some parts (like the Blackfin processor) do not implement support for it. Signed-off-by: Bryan Wu bryan...@analog.com Signed-off-by: Cliff Cai

Re: [U-Boot] [PATCH 4/5] usb: musb: change rxcsr register from write to read/modify/write

2009-12-22 Thread Remy Bohmer
Hi, 2009/12/17 Mike Frysinger vap...@gentoo.org: From: Bryan Wu bryan...@analog.com The RX Control/Status register has bits that we want to preserve, so don't just write out a single bit.  Preserve the others bits in the process. The original code posted to the u-boot list had this

Re: [U-Boot] [PATCH 5/5] usb: musb: add support for Blackfin MUSB

2009-12-22 Thread Remy Bohmer
Hi, 2009/12/17 Mike Frysinger vap...@gentoo.org: From: Bryan Wu bryan...@analog.com Signed-off-by: Bryan Wu bryan...@analog.com Signed-off-by: Cliff Cai cliff@analog.com Signed-off-by: Mike Frysinger vap...@gentoo.org ---  drivers/usb/musb/Makefile                   |    1 +  

Re: [U-Boot] [PATCH] omap3: fix compile warning

2009-12-27 Thread Remy Bohmer
Hi, 2009/12/24 Sanjeev Premi pr...@ti.com: This patch fixes this warning during compile: omap3.c: In function 'musb_platform_init': omap3.c:126: warning: label 'end' defined but not used Problem reported by: Dirk behme[dirk.be...@googlemail.com] Signed-off-by: Sanjeev Premi pr...@ti.com

Re: [U-Boot] [PATCH] musb: Add host support for DM365 EVM

2010-01-09 Thread Remy Bohmer
Hi, I have put some comments inline: @@ -41,10 +42,24 @@ struct davinci_usb_regs *dregs;  static u8 phy_on(void)  {        u32 timeout; +       u32 val; This variable is only used when DAVINCI_DM365EVM is set, so it will produce a warning if it is not set.        /* Wait until the USB

Re: [U-Boot] [PATCH 3/3] Adds EHCI definitions to sequoia board configuration file.

2010-01-09 Thread Remy Bohmer
Hi, 2010/1/6 Chris Zhang ch...@seamicro.com: Adds required definitions for EHCI support in sequoia configuration file. But still keeps the OHCI as default driver. Signed-off-by: Chris Zhang ch...@seamicro.com --- Applied to u-boot-usb Thanks. Remy

Re: [U-Boot] [PATCH 2/3] Add ppc440epx USB ehci support.

2010-01-09 Thread Remy Bohmer
Hi, 2010/1/6 Chris Zhang ch...@seamicro.com: Currently ppc440epx uses OHCI for USB full-speed support. This change adds support for EHCI. Signed-off-by: Chris Zhang ch...@seamicro.com --- Applied to u-boot-usb Thanks. Remy ___ U-Boot mailing list

Re: [U-Boot] [PATCH 1/3] Fix EHCI port reset.

2010-01-09 Thread Remy Bohmer
Hi, 2010/1/6 Chris Zhang ch...@seamicro.com: In USB ehci driver, the port reset is not terminated. EHCI spec says A host  controller must terminate the reset and stabilize the state of the port within  2 milliseconds. Without termination, a port stays at reset state. This is  observed on

Re: [U-Boot] [PATCH] PCIe, USB: Replace 'end point' references with 'endpoint'

2010-01-09 Thread Remy Bohmer
touches board files I suggest this patch goes through the board maintainers tree. Acked-by: Remy Bohmer li...@bohmer.net Remy ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2 9/9] usbd driver support for SPEAr SoCs

2010-01-09 Thread Remy Bohmer
these issues: Acked-by: Remy Bohmer li...@bohmer.net I suggest the series are being kept together, so Tom do you take it in your tree? Kind regards, Remy ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] Pull request: u-boot-usb

2010-01-09 Thread Remy Bohmer
The following changes since commit 6ca9da4d42aeb43df5ef29f7d0518009df583b2f: Wolfgang Denk (1): Merge branch 'master' of git://git.denx.de/u-boot-ppc4xx are available in the git repository at: git://git.denx.de/u-boot-usb.git master Ajay Kumar Gupta (4): DA830: Add pinmux for

Re: [U-Boot] [PATCH] musb: Add host support for DM365 EVM

2010-01-11 Thread Remy Bohmer
Hi, @@ -41,10 +42,24 @@ struct davinci_usb_regs *dregs;  static u8 phy_on(void)  {        u32 timeout; +       u32 val; This variable is only used when  DAVINCI_DM365EVM is set, so it will produce a warning if it is not set. MSP - We could either initialize the variable or guard its

Re: [U-Boot] [PATCH] usb: musb: add virtual root hub control support

2010-01-12 Thread Remy Bohmer
Hi, 2010/1/9 Mike Frysinger vap...@gentoo.org: From: Bryan Wu bryan...@analog.com For MUSB devices that do not support multipoint (hubs), we have to emulate a root hub so that we can support core operations like resetting ports. Signed-off-by: Bryan Wu bryan...@analog.com Signed-off-by:

Re: [U-Boot] [PATCH] usb: musb: fix Blackfin DMA register padding

2010-01-19 Thread Remy Bohmer
Hi, 2010/1/19 Mike Frysinger vap...@gentoo.org: From: Cliff Cai cliff@analog.com The conversion from offsets to C structs lost a little padding in the DMA register map.  Accessing endpoints other than ep0 with DMA would fail as the addresses wouldn't be adjusted correctly.

Re: [U-Boot] USB storage problem with SCSI commands

2010-01-24 Thread Remy Bohmer
Hi, 2010/1/24 Alexander Varnin fenix...@mail.ru: Hello. I'm making custom version of u-boot for our device, based on 1.1.6. Please use a recent version of U-boot. This version is old and outdated. I can't get usb storage to work. Would not surprise me. A lot of (USB) fixes have been

Re: [U-Boot] [PATCH v2] musb: Add host support for DM365 EVM

2010-01-27 Thread Remy Bohmer
Hi Prathap, Please post patch updates to an existing list in the future. That would increase response times... ;-) But nevertheless: Applied to u-boot-usb Thanks. Remy 2010/1/11 Prathap Srinivas msprat...@ti.com: Add support for musb host on DM365 EVM. Signed-off-by: Prathap Srinivas

Re: [U-Boot] [patch 1/2 V2] fix USB initialisation procedure

2010-01-29 Thread Remy Bohmer
Hi, 2010/1/29 Daniel Hellstrom dan...@gaisler.com: Hello, Please see my comment on commit 48867208444cb2a82e2af9c3249e90b7ed4a1751 below. Remy Bohmer wrote: The max packet size is encoded as 0,1,2,3 for 8,16,32,64 bytes. At some places directly 8,16,32,64 was used instead of the encoded

Re: [U-Boot] [PATCH 1/1] USB: usb_control_msg wait for driver ISR to set status.

2010-02-01 Thread Remy Bohmer
Hi Daniel, 2010/2/1 Daniel Hellstrom dan...@gaisler.com: This patch changes usb_control_msg back to the state prior to commit 48867208444cb2a82e2af9c3249e90b7ed4a1751. The USB driver ISR routine may update the status. Signed-off-by: Daniel Hellstrom dan...@gaisler.com ---  common/usb.c |  

<    1   2   3   4   5   6   >