Re: [U-Boot-Users] [PATCH 1/2] AT572D940HF-EB Support v2 (SDHC support part 1)

2008-06-13 Thread Wolfgang Denk
In message [EMAIL PROTECTED] you wrote: If you want to see changes right now, then just replace the existing file with the Diopsis file and do a diff. No, this is not the way we work. We submit patches that can be reviewed, not chunks of code that the reviewer has to anayze with additional,

Re: [U-Boot-Users] [PATCH 1/2] AT572D940HF-EB Support v2 (SDHC support part 1)

2008-06-13 Thread Haavard Skinnemoen
Ulf Samuelsson [EMAIL PROTECTED] wrote: No, this is not the way we work. We submit patches that can be reviewed, not chunks of code that the reviewer has to anayze with additional, unnecessary efforts. Antonio submits a working patchset which is structured in the same manner as

[U-Boot-Users] [PATCH 1/2] AT572D940HF-EB Support v2 (SDHC support part 1)

2008-06-12 Thread Antonio R. Costa
This patch add support for SD/SDHC cards to AT572D940HF-EB and more generally is a proposal for all Atmel chips. Dued to that I placed atmel_mci.c under the board directory. Plaese give me some feedbacks. The implementation of the CSD interpretation has been re-worked completely. Bit fields are

Re: [U-Boot-Users] [PATCH 1/2] AT572D940HF-EB Support v2 (SDHC support part 1)

2008-06-12 Thread Haavard Skinnemoen
On Thu, 12 Jun 2008 19:19:47 +0200 Ulf Samuelsson [EMAIL PROTECTED] wrote: Haavard Skinnemoen wrote: It's a bit hard to see what your proposal is all about when you create a new file instead of modifying the exising one... If you want to see changes right now, then just replace the

Re: [U-Boot-Users] [PATCH 1/2] AT572D940HF-EB Support v2 (SDHC support part 1)

2008-06-12 Thread Ulf Samuelsson
Haavard Skinnemoen wrote: On Thu, 12 Jun 2008 19:19:47 +0200 Ulf Samuelsson [EMAIL PROTECTED] wrote: Haavard Skinnemoen wrote: It's a bit hard to see what your proposal is all about when you create a new file instead of modifying the exising one... If you want to see changes right now,