Re: [U-Boot] [PATCH 3/9] nand driver support for SPEAr SoCs

2010-01-04 Thread Scott Wood 
On Wed, Dec 16, 2009 at 02:48:24PM +0530, Vipin KUMAR wrote:
 
 Signed-off-by: Vipin vipin.ku...@st.com

Acked-by: Scott Wood scottw...@freescale.com

Some of the whitespace is a bit inconsistent, though:

 +int spear_nand_init(struct nand_chip *nand)
 +{
 + writel(FSMC_DEVWID_8 | FSMC_DEVTYPE_NAND | FSMC_ENABLE | FSMC_WAITON,
 + fsmc_regs_p-genmemctrl_pc);
 + writel(readl(fsmc_regs_p-genmemctrl_pc) | FSMC_TCLR_1 | FSMC_TAR_1,
 + fsmc_regs_p-genmemctrl_pc);

Here you continue with two tabs...

 + writel(FSMC_THIZ_1 | FSMC_THOLD_4 | FSMC_TWAIT_6 | FSMC_TSET_0,
 +fsmc_regs_p-genmemctrl_comm);
 + writel(FSMC_THIZ_1 | FSMC_THOLD_4 | FSMC_TWAIT_6 | FSMC_TSET_0,
 +fsmc_regs_p-genmemctrl_attrib);

...and here with one tab plus 7 spaces.

 + nand-ecc.layout  = spear_nand_ecclayout;

There's an extra space before '=' here.

-Scott
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 3/9] nand driver support for SPEAr SoCs

2010-01-04 Thread Vipin KUMAR 
Hello Scott,

 
 Acked-by: Scott Wood scottw...@freescale.com
 
 Some of the whitespace is a bit inconsistent, though:
 
  +int spear_nand_init(struct nand_chip *nand)
  +{
  +   writel(FSMC_DEVWID_8 | FSMC_DEVTYPE_NAND | FSMC_ENABLE |
 FSMC_WAITON,
  +   fsmc_regs_p-genmemctrl_pc);
  +   writel(readl(fsmc_regs_p-genmemctrl_pc) | FSMC_TCLR_1 |
 FSMC_TAR_1,
  +   fsmc_regs_p-genmemctrl_pc);
 
 Here you continue with two tabs...


Thanks for pointing out. I would correct this in next revision of
patch-set

  +   writel(FSMC_THIZ_1 | FSMC_THOLD_4 | FSMC_TWAIT_6 | FSMC_TSET_0,
  +  fsmc_regs_p-genmemctrl_comm);
  +   writel(FSMC_THIZ_1 | FSMC_THOLD_4 | FSMC_TWAIT_6 | FSMC_TSET_0,
  +  fsmc_regs_p-genmemctrl_attrib);
 
 ...and here with one tab plus 7 spaces.
 
  +   nand-ecc.layout  = spear_nand_ecclayout;
 
 There's an extra space before '=' here.
 

Corrected.

Thanks for reviewing

Best Regards
Vipin

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot