Re: [U-Boot] [PATCH V3 07/11] fec_mxc: add support for MX51 processor

2010-02-01 Thread Stefano Babic
Ben Warren wrote: Hi Stefano, Hi Ben, Your driver shouldn't touch the environment (i.e. no getenv/setenv calls). Just save the value from ROM into edev-enetaddr, like this: if (fec_get_hwaddr(edev, ethaddr) == 0) memcpy(edev-enetaddr, ethaddr, 6); The core net code will take care of

Re: [U-Boot] [PATCH V3 07/11] fec_mxc: add support for MX51 processor

2010-01-31 Thread Ben Warren
Hi Stefano, Sorry for taking so long to provide feedback here. My requests should be pretty quick :) Stefano Babic wrote: The patch add support for the Freescale mx51 processor to the FEC ethernet driver. Signed-off-by: Stefano Babic sba...@denx.de --- drivers/net/fec_mxc.c | 68