[Bug 1046461] Re: [UIFe] UOA integration needs to support multiple accounts

2012-09-13 Thread Alberto Mardegan
Patch is ready for review (I hope I submitted it on the correct project): https://code.launchpad.net/~mardy/shotwell/uoa-update/+merge/124126 ** Branch linked: lp:~mardy/shotwell/uoa-update -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to

[Bug 1046461] Re: [UIFe] UOA integration needs to support multiple accounts

2012-09-11 Thread Alberto Mardegan
Hi Adam, and sorry for the late reply. I didn't explain the issue properly, so I'll try again. :-) The current situation is: 1) The user chooses a picture and chooses the Publish option from the menu 2) A dialog appears, showing a combobox with the available services, and a login button 3)

[Bug 1046461] Re: [UIFe] UOA integration needs to support multiple accounts

2012-09-11 Thread Aaron Bentley
Alberto, I find that it is uncommon that the Oauth token has expired. I have never been prompted to login on the website before publishing, so clicking the login button seems pointless. If the OAuth web site is truly a pop-up, I can see the problem with automatically launching it, since it would

[Bug 1046461] Re: [UIFe] UOA integration needs to support multiple accounts

2012-09-11 Thread Alberto Mardegan
Hi Aaron, thanks for your advice! So, the embedding can be done, in theory, but I wouldn't recommend it for a series of reasons of which the main one is the dialog sizing. But your suggestion of checking whether the OAuth token is still valid before showing the login button is a good one.

[Bug 1046461] Re: [UIFe] UOA integration needs to support multiple accounts

2012-09-07 Thread Alberto Mardegan
For improving discoverability, I plan to have an Add more accounts... element as the last one in the services selector, which will open the Online Accounts panel. Calum, unless you propose something else, I'll go for this implementation. ** Changed in: shotwell (Ubuntu) Status: New = In

[Bug 1046461] Re: [UIFe] UOA integration needs to support multiple accounts

2012-09-07 Thread Calum Pringle
Alternatively, Shotwell could maintain it's list of compatible accounts as is, but for accounts that are not activated display this https://docs.google.com/a/canonical.com/document/d/1UwAQTXgEyZSD3di6fAUS0W18rKxh8TXb1TwsmkgbGG0/edit#heading=h.9dy9njhiq1qo -- You received this bug notification

[Bug 1046461] Re: [UIFe] UOA integration needs to support multiple accounts

2012-09-07 Thread Calum Pringle
Sorry, I actually had this written here : https://docs.google.com/a/canonical.com/document/d/1UwAQTXgEyZSD3di6fAUS0W18rKxh8TXb1TwsmkgbGG0/edit#bookmark=kix.lzetjp1y4jv1 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1046461] Re: [UIFe] UOA integration needs to support multiple accounts

2012-09-07 Thread Alberto Mardegan
About the login/logout buttons, I wouldn't remove them: without them, the session will start as soon as the value of the service selector changes, blocking the user from selecting another service. Indeed it would make sense to remove them, but only if the overall publishing flow is changed (for

[Bug 1046461] Re: [UIFe] UOA integration needs to support multiple accounts

2012-09-07 Thread Adam Dingle
Alberto, I don't understand. Today, I can select a service and log in, but that doesn't block me from selecting another service. Couldn't we remove the buttons and simply log in automatically whenever the user selects any service? Why would the service selector need to be a dialog in this case?