Nice catch.
While we're at it, instead of checking the kernel version, we can simply
do #ifdef CONFIG_UIDGID_STRICT_TYPE_CHECKS and use __kuid_val (which in
turn only does return uid.val)
** Changed in: nvidia-graphics-drivers-331-updates (Ubuntu)
Status: Fix Released = In Progress
**
** Branch linked: lp:ubuntu/trusty-proposed/nvidia-graphics-
drivers-331-updates
** Branch linked: lp:ubuntu/trusty-proposed/nvidia-graphics-drivers-331
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
This bug was fixed in the package nvidia-graphics-drivers-331-updates -
331.20-0ubuntu9
---
nvidia-graphics-drivers-331-updates (331.20-0ubuntu9) trusty; urgency=low
* debian/dkms_nvidia_uvm/patches/buildfix_kernel_3.12.patch:
- Apparently the kuid change doesn't affect only
So the reason I decided to check for kernel version instead of
CONFIG_UIDGID_STRICT_TYPE_CHECKS was for possible future proofing. If
the kernel in the future fragments with yet another config option for
kuid_t, they would likely implement another __kuid_val function for
that, and the patch would
Support for the latest kernels has been added with 331.20-0ubuntu8
driver into Trusty.
** Changed in: nvidia-graphics-drivers-331-updates (Ubuntu)
Status: Confirmed = Fix Released
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to
The buildfix_kernel_3.12.patch breaks building on vanilla 3.12 kernels.
The module builds fine without it on 3.12.6
In file included from
/var/lib/dkms/nvidia-331-updates-uvm/331.20/build/nvidia_uvm_common.h:49:0,
from
So it looks like the buildfix_kernel_3.12.patch is missing a check for
CONFIG_UIDGID_STRICT_TYPE_CHECKS. The change to kuid_t only happens if
that config flag is enabled.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
** Patch added: Fix building with CONFIG_UIDGID_STRICT_TYPE_CHECKS enabled
https://bugs.launchpad.net/ubuntu/+source/nvidia-graphics-drivers-331-updates/+bug/1252664/+attachment/3943946/+files/buildfix_CONFIG_UIDGID_STRICT_TYPE_CHECKS.patch
--
You received this bug notification because you
I dug through git, and kuid_t/kgid_t were introduced in kernel 3.5. The
proper thing to do is to call __kuid_val(uid) to convert to uid_t on
these kernels. The bug isn't a problem introduced with kernel 3.12. It
is a problem with all kernels compiled with
CONFIG_UIDGID_STRICT_TYPE_CHECKS. This
The module that fails to build is the uvm module. The
nvidia-331-updates-331 module seems to build quite successfully, and
produce the correct module.
** Package changed: nvidia-graphics-drivers-331 (Ubuntu) = nvidia-
graphics-drivers-331-updates (Ubuntu)
--
You received this bug notification
Here is a recent make log from an affected machine. Is there any other
diagnositic info that would help to resolve this issue?
** Attachment added: Make log from attempt to re-install
nvidia-331-updates-uvm-331.20
The uvm module is the one that fails to build.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1252664
Title:
nvidia-331-uvm 331.20-0ubuntu1: nvidia-331-uvm kernel module failed to
build [error:
It works in 3.11.10 kernel.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1252664
Title:
nvidia-331-uvm 331.20-0ubuntu1: nvidia-331-uvm kernel module failed to
build [error: incompatible types
** Summary changed:
- nvidia-331-uvm 331.20-0ubuntu1: nvidia-331-uvm kernel module failed to build
+ nvidia-331-uvm 331.20-0ubuntu1: nvidia-331-uvm kernel module failed to build
[error: incompatible types when assigning to type ‘uid_t’ from type ‘kuid_t’]
--
You received this bug notification
14 matches
Mail list logo
