[Bug 1912371] Re: [MIR] flashrom + libftdi

2021-07-14 Thread Launchpad Bug Tracker
This bug was fixed in the package fwupd - 1.5.11-0ubuntu2 --- fwupd (1.5.11-0ubuntu2) impish; urgency=medium * Compile with the flashrom plugin in Ubuntu now that flashrom is in main (LP: #1912371) -- William 'jawn-smith' Wilson Tue, 29 Jun 2021 10:08:47 -0500 ** Changed

[Bug 1912371] Re: [MIR] flashrom + libftdi

2021-07-07 Thread Steve Langasek
Override component to main flashrom 1.2-5 in impish: universe/electronics -> main flashrom 1.2-5 in impish amd64: universe/electronics/extra/100% -> main flashrom 1.2-5 in impish arm64: universe/electronics/extra/100% -> main flashrom 1.2-5 in impish armhf: universe/electronics/extra/100% -> main

[Bug 1912371] Re: [MIR] flashrom + libftdi

2021-07-06 Thread Christian Ehrhardt 
** Changed in: flashrom (Ubuntu) Status: In Progress => Fix Committed ** Changed in: fwupd (Ubuntu) Status: In Progress => Fix Committed ** Changed in: libftdi1 (Ubuntu) Status: In Progress => Fix Committed -- You received this bug notification because you are a member of

[Bug 1912371] Re: [MIR] flashrom + libftdi

2021-07-01 Thread Mario Limonciello
** Also affects: fwupd (Ubuntu) Importance: Undecided Status: New ** Changed in: fwupd (Ubuntu) Status: New => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1912371

[Bug 1912371] Re: [MIR] flashrom + libftdi

2021-06-29 Thread William Wilson
This patch enables fwupd to build with the flashrom plugin enabled on Ubuntu. ** Patch added: "lp1912371_fwupd_build_with_flashrom.debdiff" https://bugs.launchpad.net/ubuntu/+source/flashrom/+bug/1912371/+attachment/5507958/+files/lp1912371_fwupd_build_with_flashrom.debdiff -- You received

[Bug 1912371] Re: [MIR] flashrom + libftdi

2021-06-29 Thread Christian Ehrhardt 
We clarified that Doko on 2021-03-11 really meant to MIR-ack the check on libftdi. Thereby this is now actually fully ready and waiting for an upload of fwupd to pull it in. Updating the state accordingly. ** Changed in: flashrom (Ubuntu) Status: New => In Progress ** Changed in:

[Bug 1912371] Re: [MIR] flashrom + libftdi

2021-06-04 Thread William Wilson
That should fix the udev rules issue. ** Patch added: "Lintian Cleanup with udev fix" https://bugs.launchpad.net/ubuntu/+source/flashrom/+bug/1912371/+attachment/5502490/+files/lp1912371_lintian_cleanup.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs,

[Bug 1912371] Re: [MIR] flashrom + libftdi

2021-06-04 Thread William Wilson
Yes, they were included in the package twice. Once in debian/flashrom.udev and once in util/z60_flashrom.rules. The debian/flashrom.udev was causing a lintian warning, so I removed that and added a section to meson.build that installs z60_flashrom.rules to the correct location in a way that

[Bug 1912371] Re: [MIR] flashrom + libftdi

2021-06-03 Thread Alex Murray
@jawn-smith: was the removal of the udev rules intentional? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1912371 Title: [MIR] flashrom + libftdi To manage notifications about this bug go to:

[Bug 1912371] Re: [MIR] flashrom + libftdi

2021-06-03 Thread William Wilson
The attached patch cleans up the lintian warnings and errors in flashrom. ** Patch added: "Lintian Cleanup" https://bugs.launchpad.net/ubuntu/+source/flashrom/+bug/1912371/+attachment/5502234/+files/lp1912371_lintian_cleanup.debdiff -- You received this bug notification because you are a

[Bug 1912371] Re: [MIR] flashrom + libftdi

2021-05-31 Thread Alex Murray
** Package changed: libftdi (Ubuntu) => libftdi1 (Ubuntu) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1912371 Title: [MIR] flashrom + libftdi To manage notifications about this bug go to:

[Bug 1912371] Re: [MIR] flashrom + libftdi

2021-05-20 Thread Matthias Klose
yes, disabling lto explicitly for the build seems reasonable -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1912371 Title: [MIR] flashrom + libftdi To manage notifications about this bug go to:

[Bug 1912371] Re: [MIR] flashrom + libftdi

2021-05-19 Thread William Wilson
This debdiff corrects the accidentally left in debug statement and adds `optimize=-lto` to DEB_BUILD_MAINT_OPTIONS. Tests are succeeding again. ** Patch added: "lp1912371_v2.debdiff"

Re: [Bug 1912371] Re: [MIR] flashrom + libftdi

2021-05-19 Thread Carl-Daniel Hailfinger
Hi, I thought we had deactivated the github bugtracker because flashrom development does not happen at github. The github mirror of flashrom is there purely for people who are unwilling or unable (due to corporate restrictions etc.) to download the source code from our self-hosted git trees. I'll

Re: [Bug 1912371] Re: [MIR] flashrom + libftdi

2021-05-19 Thread Stefan Tauner
On Wed, 19 May 2021 06:52:55 - Alex Murray <1912...@bugs.launchpad.net> wrote: > These failures of the mocked tests have been reported upstream at > https://github.com/flashrom/flashrom/issues/186 by others but no > response Hi there, I was the flashrom maintainer till a few years ago.

[Bug 1912371] Re: [MIR] flashrom + libftdi

2021-05-19 Thread Alex Murray
These failures of the mocked tests have been reported upstream at https://github.com/flashrom/flashrom/issues/186 by others but no response - however I am pretty sure this is due to the use of LTO in impish - cmocka is known to fail with LTO due to the use of --wrap which doesn't play nicely with

[Bug 1912371] Re: [MIR] flashrom + libftdi

2021-05-18 Thread Alex Murray
I am trying to do the security review of flashrom for this MIR but currently it FTBFS with the attached debdiff in comment 9 - the build log is attached. Can this please be resolved (along with removing the 'WILLIAM we're doing tests!' part of the output :) ** Attachment added:

[Bug 1912371] Re: [MIR] flashrom + libftdi

2021-03-12 Thread William Wilson
I have reviewed flashrom along with fwupd and I don't see anything that looks like it will cause problems. The flashrom documentation recommends using vendors' flashing utilities when possible for laptops, and there is a link to that page of the documentation in the manpage. I have attached a

[Bug 1912371] Re: [MIR] flashrom + libftdi

2021-03-11 Thread Matthias Klose
** Changed in: libftdi (Ubuntu) Assignee: Matthieu Clemenceau (mclemenceau) => Ubuntu Security Team (ubuntu-security) ** Changed in: libftdi (Ubuntu) Status: Incomplete => New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to

[Bug 1912371] Re: [MIR] flashrom + libftdi

2021-03-10 Thread William Wilson
[Summary] This package is safe to include in main. This does need a security review, so I'll assign ubuntu-security List of specific binary packages to be promoted to main: * ftdi-eeprom * libftdi1-2 * libftdi1-dev * libftdi1-doc * libftdipp1-3 * libftdipp1-dev * python3-ftdi1

[Bug 1912371] Re: [MIR] flashrom + libftdi

2021-03-09 Thread Matthieu Clemenceau
@paelzer, Sorry for dropping this, I saw the ping this morning on ubuntu-meeting, I'll put this in front of the team for review. I missed the notification. Thanks for the reminder. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.