This bug was fixed in the package fwupd - 1.7.7-1ubuntu2
---
fwupd (1.7.7-1ubuntu2) kinetic; urgency=medium
* d/t/ci: don't stderr-fail the autopkgtest on modprobe error
+ it's optional as tests can be skipped, if mtdram module isn't there
-- Lukas Märdian Wed, 18 May 2022
Ugh! Indeed, fixed.
https://github.com/fwupd/fwupd/pull/4645
https://launchpad.net/ubuntu/+source/fwupd/1.7.7-1ubuntu2
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1973598
Title:
mtd-self-test
> ci FAIL stderr: modprobe: FATAL: Module mtdram not
found in directory /lib/modules/5.4.0-109-generic
No good deed goes unpunished. I think you'll want to redirect the
stderr output from modprobe to stdout to make autopkgtest happy.
--
You received this bug notification
Thanks Lukas!
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1973598
Title:
mtd-self-test failure on arm64 (mtdram module)
To manage notifications about this bug go to:
** Changed in: fwupd (Ubuntu)
Status: New => In Progress
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1973598
Title:
mtd-self-test failure on arm64 (mtdram module)
To manage notifications
Sounds like a plan! Done.
Thanks for all of your feedback!
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1973598
Title:
mtd-self-test failure on arm64 (mtdram module)
To manage notifications
> Ah! Sure, no problem. I wasn't aware of this. Here you go:
https://github.com/fwupd/fwupd/pull/4641
Thanks!
> I only included the "modprobe" change in this PR, as IMO it does not
really make sense to ship the distro patch in this upstream
"contrib/debian" directory, as the upstream repo
Ah! Sure, no problem. I wasn't aware of this. Here you go:
https://github.com/fwupd/fwupd/pull/4641
I only included the "modprobe" change in this PR, as IMO it does not
really make sense to ship the distro patch in this upstream
"contrib/debian" directory, as the upstream repo already contains
We keep the packaging at
https://github.com/fwupd/fwupd/tree/main/contrib/debian/tests. If you
can bring the review there, that is ideal as this is the root of what
goes into Debian and Ubuntu.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to
I'm not sure what you mean by "contrib/debian"? The patch should apply
cleanly to the upstream Debian package, too. (Well, one might want to
change the version number.)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
** Patch added: "3-fix-mtd-tests.debdiff"
https://bugs.launchpad.net/ubuntu/+source/fwupd/+bug/1973598/+attachment/5590395/+files/3-fix-mtd-tests.debdiff
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
Can you bring it to upstream packaging in contrib/debian?
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1973598
Title:
mtd-self-test failure on arm64 (mtdram module)
To manage notifications about
Yes, I like this approach much better. LGTM!
I'd also suggest to call "modprobe mtdram" prior to running the tests,
so that the new mtd test are actually executed. See attached debdiff.
This way it works for arm64 (skipping the test due to mtd0 not being
provided by mtdram) and works for
Here's the cleaner solution:
https://github.com/fwupd/fwupd/commit/eca29c11faa5b1258be8fa253beeebe753bad4fa
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1973598
Title:
mtd-self-test failure on
** Tags added: patch
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1973598
Title:
mtd-self-test failure on arm64 (mtdram module)
To manage notifications about this bug go to:
It's running in KVM. (armhf is the exception, running inside LXD
container)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1973598
Title:
mtd-self-test failure on arm64 (mtdram module)
To manage
Is autopkgtest running on "real" hardware?
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1973598
Title:
mtd-self-test failure on arm64 (mtdram module)
To manage notifications about this bug go to:
I think the question we'd need to ask first is: Why is there a /dev/mtd0
inside Ubuntu's arm64 autopkgtest VM?
At no point during the tests do we modprobe the "mtdram" driver. So it is
expected that /dev/mtd0 is not there and this test is skipped (as is the case
for Debian and Ubuntu != arm64).
I suspect the self tests need to check the name is "mtdram test device"
before running.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1973598
Title:
mtd-self-test failure on arm64 (mtdram module)
While we have the luxury of time with kinetic, I'd rather we figure out
why the test fails rather than just skipping it. If the test is
failing, the plugin may fail too!
It seems that this code should be reading the "size" attribute from sysfs and
comparing it
(here
** Patch added: "1-disable-mtd-self-test.debdiff"
https://bugs.launchpad.net/ubuntu/+source/fwupd/+bug/1973598/+attachment/5590042/+files/1-disable-mtd-self-test.debdiff
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
** Description changed:
version 1.7.7-1 of fwupd introduced a new "mtd-self-test" which fails
- the autopkgtest on ubuntu/kinetic/arm64.
+ the autopkgtest on ubuntu/kinetic/arm64. (https://salsa.debian.org/efi-
+ team/fwupd/-/commit/4d65d2014945e2e4f55a3192bf0f50beb68b1e3b)
The "mtd" test
22 matches
Mail list logo
