[Bug 950183] Re: puppetmaster-passenger postinst creates wrong certificate files and puppetmaster vhost if puppet config print has an error

2012-03-16 Thread Launchpad Bug Tracker
This bug was fixed in the package puppet - 2.7.11-1ubuntu1 --- puppet (2.7.11-1ubuntu1) precise; urgency=low [ Marc Cluet ] * debian/patches/puppet-12844: Cherry picked patch from upstream 2.7.12 to revert new agent lockfile behaviour as it breaks upgrades from versions

[Bug 950183] Re: puppetmaster-passenger postinst creates wrong certificate files and puppetmaster vhost if puppet config print has an error

2012-03-16 Thread Launchpad Bug Tracker
This bug was fixed in the package puppet - 2.7.11-1ubuntu1 --- puppet (2.7.11-1ubuntu1) precise; urgency=low [ Marc Cluet ] * debian/patches/puppet-12844: Cherry picked patch from upstream 2.7.12 to revert new agent lockfile behaviour as it breaks upgrades from versions

[Bug 950183] Re: puppetmaster-passenger postinst creates wrong certificate files and puppetmaster vhost if puppet config print has an error

2012-03-09 Thread Marc Cluet
** Changed in: puppet (Ubuntu) Assignee: (unassigned) = Marc Cluet (lynxman) ** Changed in: puppet (Ubuntu) Status: Triaged = Fix Committed -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to puppet in Ubuntu.

[Bug 950183] Re: puppetmaster-passenger postinst creates wrong certificate files and puppetmaster vhost if puppet config print has an error

2012-03-09 Thread Launchpad Bug Tracker
** Branch linked: lp:~lynxman/ubuntu/precise/puppet/puppetlabsfixbug12844 -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to puppet in Ubuntu. https://bugs.launchpad.net/bugs/950183 Title: puppetmaster-passenger postinst creates wrong

[Bug 950183] Re: puppetmaster-passenger postinst creates wrong certificate files and puppetmaster vhost if puppet config print has an error

2012-03-09 Thread Marc Cluet
debdiff from 2.7.11-1 to 2.7.11-1ubuntu2 ** Patch added: puppet_2.7.11-1ubuntu2.debdiff https://bugs.launchpad.net/ubuntu/+source/puppet/+bug/950183/+attachment/2839127/+files/puppet_2.7.11-1ubuntu2.debdiff -- You received this bug notification because you are a member of Ubuntu Server

[Bug 950183] Re: puppetmaster-passenger postinst creates wrong certificate files and puppetmaster vhost if puppet config print has an error

2012-03-09 Thread Marc Cluet
This is the proper one, apologies ** Patch removed: puppet_2.7.11-1ubuntu2.debdiff https://bugs.launchpad.net/ubuntu/+source/puppet/+bug/950183/+attachment/2839127/+files/puppet_2.7.11-1ubuntu2.debdiff ** Patch added: puppet_2.7.11-1ubuntu2.debdiff

[Bug 950183] Re: puppetmaster-passenger postinst creates wrong certificate files and puppetmaster vhost if puppet config print has an error

2012-03-09 Thread Ubuntu Foundation's Bug Bot
The attachment puppet_2.7.11-1ubuntu2.debdiff of this bug report has been identified as being a patch in the form of a debdiff. The ubuntu- sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. In the event that this is in fact not a patch

[Bug 950183] Re: puppetmaster-passenger postinst creates wrong certificate files and puppetmaster vhost if puppet config print has an error

2012-03-09 Thread Marc Cluet
** Changed in: puppet (Ubuntu) Assignee: (unassigned) = Marc Cluet (lynxman) ** Changed in: puppet (Ubuntu) Status: Triaged = Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 950183] Re: puppetmaster-passenger postinst creates wrong certificate files and puppetmaster vhost if puppet config print has an error

2012-03-09 Thread Launchpad Bug Tracker
** Branch linked: lp:~lynxman/ubuntu/precise/puppet/puppetlabsfixbug12844 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/950183 Title: puppetmaster-passenger postinst creates wrong certificate files

[Bug 950183] Re: puppetmaster-passenger postinst creates wrong certificate files and puppetmaster vhost if puppet config print has an error

2012-03-09 Thread Marc Cluet
debdiff from 2.7.11-1 to 2.7.11-1ubuntu2 ** Patch added: puppet_2.7.11-1ubuntu2.debdiff https://bugs.launchpad.net/ubuntu/+source/puppet/+bug/950183/+attachment/2839127/+files/puppet_2.7.11-1ubuntu2.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which

[Bug 950183] Re: puppetmaster-passenger postinst creates wrong certificate files and puppetmaster vhost if puppet config print has an error

2012-03-09 Thread Marc Cluet
This is the proper one, apologies ** Patch removed: puppet_2.7.11-1ubuntu2.debdiff https://bugs.launchpad.net/ubuntu/+source/puppet/+bug/950183/+attachment/2839127/+files/puppet_2.7.11-1ubuntu2.debdiff ** Patch added: puppet_2.7.11-1ubuntu2.debdiff

[Bug 950183] Re: puppetmaster-passenger postinst creates wrong certificate files and puppetmaster vhost if puppet config print has an error

2012-03-09 Thread Ubuntu Foundation's Bug Bot
The attachment puppet_2.7.11-1ubuntu2.debdiff of this bug report has been identified as being a patch in the form of a debdiff. The ubuntu- sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. In the event that this is in fact not a patch

[Bug 950183] Re: puppetmaster-passenger postinst creates wrong certificate files and puppetmaster vhost if puppet config print has an error

2012-03-08 Thread Adam Gandelman
Hey Glen-- Thanks for reporting this and helping us make Ubuntu better! I believe the issue here is that 'puppet config print' returns 0 on failure. The maintainer script is 'set -e', but in this case the errors are not caught. I'm wondering the script should be attempting to parse err: from

[Bug 950183] Re: puppetmaster-passenger postinst creates wrong certificate files and puppetmaster vhost if puppet config print has an error

2012-03-08 Thread Adam Gandelman
** Changed in: puppet (Ubuntu) Status: New = Confirmed -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to puppet in Ubuntu. https://bugs.launchpad.net/bugs/950183 Title: puppetmaster-passenger postinst creates wrong certificate

[Bug 950183] Re: puppetmaster-passenger postinst creates wrong certificate files and puppetmaster vhost if puppet config print has an error

2012-03-08 Thread Glenn Aaldering
Adem, I can confirm that if it returns 0 on failure, which is really bad behaviour. Its really sad that such simple things can cause so much trouble. For now the fastest fix is to see if err: is returned by puppet config print in the postinst before even doing anything and if so the postinst

[Bug 950183] Re: puppetmaster-passenger postinst creates wrong certificate files and puppetmaster vhost if puppet config print has an error

2012-03-08 Thread Adam Gandelman
** Changed in: puppet (Ubuntu) Status: Confirmed = Triaged -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to puppet in Ubuntu. https://bugs.launchpad.net/bugs/950183 Title: puppetmaster-passenger postinst creates wrong

[Bug 950183] Re: puppetmaster-passenger postinst creates wrong certificate files and puppetmaster vhost if puppet config print has an error

2012-03-08 Thread Glenn Aaldering
Ok, I think the puppet config print variable should be changed to puppet --configprint variable: # puppet config print abc; echo $? err: Could not parse /etc/puppet/puppet.conf: Could not match line abc at /etc/puppet/puppet.conf:bla invalid parameter: abc 0 # puppet --configprint abc; echo $?

[Bug 950183] Re: puppetmaster-passenger postinst creates wrong certificate files and puppetmaster vhost if puppet config print has an error

2012-03-08 Thread Glenn Aaldering
Yeah, that does the trick. Replace puppet config print in the postinst with puppet --configprint and this bug can be resolved: root@host:/etc# dpkg -i puppetmaster-passenger_2.7.11-1_all.deb Selecting previously unselected package puppetmaster-passenger. (Reading database ... 25803 files and

[Bug 950183] Re: puppetmaster-passenger postinst creates wrong certificate files and puppetmaster vhost if puppet config print has an error

2012-03-08 Thread Adam Gandelman
Hey Glen-- Thanks for reporting this and helping us make Ubuntu better! I believe the issue here is that 'puppet config print' returns 0 on failure. The maintainer script is 'set -e', but in this case the errors are not caught. I'm wondering the script should be attempting to parse err: from

[Bug 950183] Re: puppetmaster-passenger postinst creates wrong certificate files and puppetmaster vhost if puppet config print has an error

2012-03-08 Thread Adam Gandelman
** Changed in: puppet (Ubuntu) Status: New = Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/950183 Title: puppetmaster-passenger postinst creates wrong certificate files and

[Bug 950183] Re: puppetmaster-passenger postinst creates wrong certificate files and puppetmaster vhost if puppet config print has an error

2012-03-08 Thread Glenn Aaldering
Adem, I can confirm that if it returns 0 on failure, which is really bad behaviour. Its really sad that such simple things can cause so much trouble. For now the fastest fix is to see if err: is returned by puppet config print in the postinst before even doing anything and if so the postinst

[Bug 950183] Re: puppetmaster-passenger postinst creates wrong certificate files and puppetmaster vhost if puppet config print has an error

2012-03-08 Thread Adam Gandelman
** Changed in: puppet (Ubuntu) Status: Confirmed = Triaged -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/950183 Title: puppetmaster-passenger postinst creates wrong certificate files and

[Bug 950183] Re: puppetmaster-passenger postinst creates wrong certificate files and puppetmaster vhost if puppet config print has an error

2012-03-08 Thread Glenn Aaldering
Ok, I think the puppet config print variable should be changed to puppet --configprint variable: # puppet config print abc; echo $? err: Could not parse /etc/puppet/puppet.conf: Could not match line abc at /etc/puppet/puppet.conf:bla invalid parameter: abc 0 # puppet --configprint abc; echo $?

[Bug 950183] Re: puppetmaster-passenger postinst creates wrong certificate files and puppetmaster vhost if puppet config print has an error

2012-03-08 Thread Glenn Aaldering
Yeah, that does the trick. Replace puppet config print in the postinst with puppet --configprint and this bug can be resolved: root@host:/etc# dpkg -i puppetmaster-passenger_2.7.11-1_all.deb Selecting previously unselected package puppetmaster-passenger. (Reading database ... 25803 files and