** Changed in: oxide
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1599771
Title:
Webview appears to think it's in focus when typing in the addressbar
To
** Changed in: oxide
Status: Confirmed => In Progress
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1599771
Title:
Webview appears to think it's in focus when typing in the addressbar
To
The real cause here is we rely on focusOut(In)Event to check for
activeFocus item. but the any check of ActiveFocus (hasActiveFocus or
window->activeFocusItem) inside focusout/in event give incorrect result.
when another item is focused(location bar), window->activeFocusItem()
return null not the
** Changed in: oxide
Milestone: branch-1.20 => branch-1.21
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1599771
Title:
Webview appears to think it's in focus when typing in the addressbar
To
Re-opening as the change had to be reverted because it caused a
regression (bug #1649577).
** Changed in: oxide
Status: Fix Released => Confirmed
** Changed in: oxide
Milestone: branch-1.19 => branch-1.20
--
You received this bug notification because you are a member of Ubuntu
Bugs,
** Changed in: oxide
Milestone: None => branch-1.19
** Changed in: oxide
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1599771
Title:
Webview
FIxed with
https://code.launchpad.net/~santoshbit2007/oxide/+git/oxide/+merge/301475
** Merge proposal linked:
https://code.launchpad.net/~santoshbit2007/oxide/+git/oxide/+merge/301475
** Changed in: oxide
Status: In Progress => Fix Committed
--
You received this bug notification
Ready for review:
ttps://code.launchpad.net/~santoshbit2007/oxide/+git/oxide/+merge/301475
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1599771
Title:
Webview appears to think it's in focus when
** Changed in: oxide
Status: Triaged => In Progress
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1599771
Title:
Webview appears to think it's in focus when typing in the addressbar
To
QQuickWindow::activeFocusItem() is fine , I was just doubtful with it being
null.
I am going to patch it with using same
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1599771
Title:
Webview
Whatever we do, we should stop using QQuickItem::hasActiveFocus() for
the reason outlined in comment 8. I don't understand the issue with
QQuickWindow::activeFocusItem() though - it looks like it's cleared to
nullptr before a focus out event and initialized to the new focus item
before a focus in
Could bug #1566373 be related?
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1599771
Title:
Webview appears to think it's in focus when typing in the addressbar
To manage notifications about this
QQuickWindow::activeFocusItem will still be tricky.
There seems to be fundamental issue with focus events sent.
FocusEvent are only sent to Item when its activeFocus = true;
So when we focus is removed from item it won't immediately set
activeFocus=false(since item won't get focus event
** Changed in: oxide
Status: Confirmed => Triaged
** Changed in: oxide
Importance: Undecided => Medium
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1599771
Title:
Webview appears to
I think I'd prefer to just use QQuickWindow::activeFocusItem in
oxide::qquick::ContentsView::HasFocus(). From looking at the code, I
don't even think that QQuickItem::hasActiveFocus has the correct
semantics as it will indicate active focus for ancestors of the active
focus item which isn't really
it seems focusOutEvent comes too early to QQuickItem. by that time
activefocus is not updated, so it still holds earlier value.
Once activeFocus of QQuickItem is changed we get
ItemChanged(http://doc.qt.io/qt-5/qquickitem.html#ItemChange-enum).
I tested it OxideQQuickWebView::itemChange has
(after looking at QQuickWindowPrivate::setFocusInScope)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1599771
Title:
Webview appears to think it's in focus when typing in the addressbar
To manage
I suspect that oxide::qquick::ContentsView::HasFocus also needs to
verify that item_ == item_->window()->activeFocusItem()
(http://doc.qt.io/qt-5/qquickwindow.html#activeFocusItem-prop). It looks
like this is cleared before dispatching QQuickItem::focusOutEvent(),
whereas
I think I know where the issue is: when the OxideQQuickWebView is
getting a focusOut event, it’s calling WebContentsView::FocusChanged(),
which checks whether the view has focus by calling
WebContentsView::HasFocus(), but at this point it returns true.
** Changed in: webbrowser-app (Ubuntu)
Olivier Surprising it is,
I was checking from oxide side, and QQuickWeview activeFocus is set to true.
So I was doubting issue in webbrowser-app
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1599771
I can reliably reproduce the bug on my desktop.
I have instrumented the browser to print a debug statement every time
the activeFocus property of the WebView changes (in Browser.qml):
WebViewImpl {
onActiveFocusChanged: console.log("webview.activeFocus =", activeFocus)
}
And indeed when
** Changed in: oxide
Assignee: (unassigned) => Santosh (santoshbit2007)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1599771
Title:
Webview appears to think it's in focus when typing in the
22 matches
Mail list logo
