Re: [PATCH 1/2] libc: fix setting return value and errno in fallocate()

On September 17, 2015 11:52:55 PM GMT+02:00, Rich Felker wrote: >On Thu, Sep 17, 2015 at 09:27:40PM +0200, Bernhard Reutner-Fischer >wrote: >> On September 17, 2015 6:16:48 PM GMT+02:00, Yuriy Kolerov > wrote: >> >Hi Rich. >> > >> >fallocate must

RE: [PATCH 1/2] libc: fix setting return value and errno in fallocate()

] On Behalf Of Rich Felker Sent: Friday, September 18, 2015 12:53 AM To: Bernhard Reutner-Fischer Cc: Yuriy Kolerov; uclibc@uclibc.org; vineet.gup...@synopsys.com; alexey.brod...@synopsys.com; francois.bed...@synopsys.com Subject: Re: [PATCH 1/2] libc: fix setting return value and errno in fallocate

RE: [PATCH 1/2] libc: fix setting return value and errno in fallocate()

uclibc.org; vineet.gup...@synopsys.com; alexey.brod...@synopsys.com; francois.bed...@synopsys.com Subject: Re: [PATCH 1/2] libc: fix setting return value and errno in fallocate() On September 16, 2015 9:20:31 PM GMT+02:00, Waldemar Brodkorb <w...@openadk.org> wrote: >Hi Yuriy, > >can you

RE: [PATCH 1/2] libc: fix setting return value and errno in fallocate()

1/2] libc: fix setting return value and errno in fallocate() On Thu, Sep 17, 2015 at 03:56:55PM +, Yuriy Kolerov wrote: > Hi Waldemar and Bernhard. > > First of all sorry for the absent of the detailed explanation of my > fixes. I'm going to send a second version of patch

Re: [PATCH 1/2] libc: fix setting return value and errno in fallocate()

On September 17, 2015 6:07:38 PM GMT+02:00, Rich Felker wrote: >On Thu, Sep 17, 2015 at 03:56:55PM +, Yuriy Kolerov wrote: >> Hi Waldemar and Bernhard. >> >> First of all sorry for the absent of the detailed explanation of my >> fixes. I'm going to send a second version of

Re: [PATCH 1/2] libc: fix setting return value and errno in fallocate()

On Thu, Sep 17, 2015 at 03:56:55PM +, Yuriy Kolerov wrote: > Hi Waldemar and Bernhard. > > First of all sorry for the absent of the detailed explanation of my > fixes. I'm going to send a second version of patches after our > discussion. > > The problem is that fallocate does not pass LTP

RE: [PATCH 1/2] libc: fix setting return value and errno in fallocate()

Thursday, September 17, 2015 7:08 PM >To: Yuriy Kolerov >Cc: Bernhard Reutner-Fischer; Waldemar Brodkorb; uclibc@uclibc.org; >vineet.gup...@synopsys.com; alexey.brod...@synopsys.com; >francois.bed...@synopsys.com >Subject: Re: [PATCH 1/2] libc: fix setting return value and errno in

Re: [PATCH 1/2] libc: fix setting return value and errno in fallocate()

On Thu, Sep 17, 2015 at 09:27:40PM +0200, Bernhard Reutner-Fischer wrote: > On September 17, 2015 6:16:48 PM GMT+02:00, Yuriy Kolerov > wrote: > >Hi Rich. > > > >fallocate must return 0 or -1. However posix_fallocate my return an > >error code. So I think it would be

Re: [PATCH 1/2] libc: fix setting return value and errno in fallocate()

Hi Yuriy, can you explain why these patches are useful? Better standard conformance? Testsuite or runtime fixes? Thanks Waldemar Yuriy Kolerov wrote, > Signed-off-by: Yuriy Kolerov > --- > libc/sysdeps/linux/common/fallocate.c | 13 - >

Re: [PATCH 1/2] libc: fix setting return value and errno in fallocate()

On September 16, 2015 9:20:31 PM GMT+02:00, Waldemar Brodkorb wrote: >Hi Yuriy, > >can you explain why these patches are useful? posix_fallocate does not set errno, the non-standard, Linux fallocate does, according to its manpage (and returns -1 upon error). >Better standard

[PATCH 1/2] libc: fix setting return value and errno in fallocate()

Signed-off-by: Yuriy Kolerov --- libc/sysdeps/linux/common/fallocate.c | 13 - libc/sysdeps/linux/common/fallocate64.c | 11 +++ 2 files changed, 15 insertions(+), 9 deletions(-) diff --git a/libc/sysdeps/linux/common/fallocate.c