Re: What is the preferred code style for uclibc?

2008-12-09 Thread Khem Raj
On (08/12/08 17:44), Rob Landley wrote: On Tuesday 02 December 2008 12:04:47 Khem Raj wrote: On (02/12/08 16:27), Bernd Schmidt wrote: Denys Vlasenko wrote: I merely plan to follow the agreed-on style in the code I touch. IMO for code that is just touched, following the

Re: What is the preferred code style for uclibc?

2008-12-08 Thread Rob Landley
On Tuesday 02 December 2008 12:04:47 Khem Raj wrote: On (02/12/08 16:27), Bernd Schmidt wrote: Denys Vlasenko wrote: I merely plan to follow the agreed-on style in the code I touch. IMO for code that is just touched, following the existing style in that file is best. may be we

Re: What is the preferred code style for uclibc?

2008-12-02 Thread Bernhard Reutner-Fischer
On Mon, Dec 01, 2008 at 08:44:55PM +0100, Denys Vlasenko wrote: Hi Bernhard, folks, Can you indicate what coding style you prefer in uclibc? Curretly we have a mixture of all kinds, GNU style with its uniquely difficult placement of {}s: if (set == NULL || signo = 0 || signo = NSIG) {

Re: What is the preferred code style for uclibc?

2008-12-02 Thread Bernd Schmidt
Denys Vlasenko wrote: I merely plan to follow the agreed-on style in the code I touch. IMO for code that is just touched, following the existing style in that file is best. Bernd -- This footer brought to you by insane German lawmakers. Analog Devices GmbH Wilhelm-Wagenfeld-Str. 6

Re: What is the preferred code style for uclibc?

2008-12-02 Thread Khem Raj
On (02/12/08 16:27), Bernd Schmidt wrote: Denys Vlasenko wrote: I merely plan to follow the agreed-on style in the code I touch. IMO for code that is just touched, following the existing style in that file is best. may be we should mention reccomended style in the dev guide Thx -Khem

What is the preferred code style for uclibc?

2008-12-01 Thread Denys Vlasenko
Hi Bernhard, folks, Can you indicate what coding style you prefer in uclibc? Curretly we have a mixture of all kinds, GNU style with its uniquely difficult placement of {}s: if (set == NULL || signo = 0 || signo = NSIG) { __set_errno (EINVAL); return -1; } indent-by-4

Re: What is the preferred code style for uclibc?

2008-12-01 Thread Carmelo AMOROSO
Denys Vlasenko wrote: Hi Bernhard, folks, Can you indicate what coding style you prefer in uclibc? Hi Denys, my preferred style is kernel's one, I don't think uclibc has a preferred one, even if, yesy, a Coding style rules could be useful. Curretly we have a mixture of all kinds, GNU