Re: [uportal-dev] maven plugin won't build with ResourcesAggregatorImplTest

2009-11-16 Thread Nicholas Blair
This was related to my prior discussion about YUI Compressor and UP-2505. In short, the only YUI Compressor available via maven is version 2.3.6 - which is broken. I have installed 2.4.2 locally, and modified the pom to use it, and verified it works. Per my last comment on

Re: [uportal-dev] maven plugin won't build with ResourcesAggregatorImplTest

2009-11-16 Thread Jen Bourey
Hi Nick, I've added the yuicompressor 2.4.2 jar to the Jasig third party repository ( http://developer.jasig.org/repo/content/repositories/3rd-party/). - Jen On Mon, Nov 16, 2009 at 2:38 PM, Nicholas Blair nicholas.bl...@gmail.comwrote: This was related to my prior discussion about YUI

Re: [uportal-dev] maven plugin won't build with ResourcesAggregatorImplTest

2009-11-16 Thread Nicholas Blair
Excellent - I'll get the projects updated. Thanks! On Mon, Nov 16, 2009 at 1:50 PM, Jen Bourey jbou...@unicon.net wrote: Hi Nick, I've added the yuicompressor 2.4.2 jar to the Jasig third party repository (http://developer.jasig.org/repo/content/repositories/3rd-party/). - Jen On Mon,

Re: [uportal-dev] maven plugin won't build with ResourcesAggregatorImplTest

2009-11-16 Thread Susan Bramhall
Fails on unix too but in different place.. --- Test set: org.jasig.portal.web.skin.ResourcesAggregatorImplTest --- Tests run: 6,

Re: [uportal-dev] maven plugin won't build with ResourcesAggregatorImplTest

2009-11-16 Thread Nicholas Blair
Just committed a fix for how the tests construct the path to their temporary directory, update and try again. On Mon, Nov 16, 2009 at 3:43 PM, Susan Bramhall susan.bramh...@yale.edu wrote: Fails on unix too but in different place..

Re: [uportal-dev] maven plugin won't build with ResourcesAggregatorImplTest

2009-11-16 Thread Susan Bramhall
Yes, D: is local and same file system as running mvn on. I do have delete on that directory and can delete it manually. Susan Nicholas Blair wrote: There is a method annotated with @After (runs "after" each test) to clean up temporary files created by the test. The tests use the System

Re: [uportal-dev] maven plugin won't build with ResourcesAggregatorImplTest

2009-11-16 Thread Susan Bramhall
YAY. Build successful now on Unix. Windows still complaining. I can research that a bit more. Whadda pain. Susan Nicholas Blair wrote: Just committed a fix for how the tests construct the path to their temporary directory, update and try again. On Mon, Nov 16, 2009 at 3:43 PM, Susan

Re: [uportal-dev] maven plugin won't build with ResourcesAggregatorImplTest

2009-11-16 Thread Nicholas Blair
Yes, unfortunately YUICompressor's methods for compressing javascript and css depend on FileReader and FileWriter, which are concrete. If we want to have unit tests for resource aggregation, the only way to pull it off is by creating and deleting these temporary files. I'll take a look at how

Re: [uportal-dev] maven plugin won't build with ResourcesAggregatorImplTest

2009-11-16 Thread Nicholas Blair
I've just checked in a change to the cleanup method in that test class. Can you try the build on Windows again to see if the changes have helped? Thanks! Nick On Mon, Nov 16, 2009 at 4:02 PM, Nicholas Blair nicholas.bl...@gmail.com wrote: Yes, unfortunately YUICompressor's methods for

Re: [uportal-dev] maven plugin won't build with ResourcesAggregatorImplTest

2009-11-16 Thread Susan Bramhall
Still getting stuck on delete of one file. In one attempt I was NOT able to delete it manually so am guessing some resource needs to be closed so the file can be removed. The only failure is now on removing \uportal3_aggr2_temp.js. Susan Nicholas Blair wrote: I've just checked in a change