Re: [uportal-dev] maven plugin won't build with ResourcesAggregatorImplTest

2009-11-16 Thread Nicholas Blair
This was related to my prior discussion about YUI Compressor and UP-2505.

In short, the only YUI Compressor available via maven is version 2.3.6
- which is broken.

I have installed 2.4.2 locally, and modified the pom to use it, and
verified it works.

Per my last comment on http://www.ja-sig.org/issues/browse/UP-2505 -
this task is complete-able if we can get YUI Compressor 2.4.2 in a
maven repository.
If we can do that, I can make the last commits to get the resource
aggregator mojo in the maven-uportal-plugin ready for use.

On Mon, Nov 16, 2009 at 1:18 PM, Susan Bramhall susan.bramh...@yale.edu wrote:
 I've updated the maven plugin to throw the proper failure exception when
 appropriate so it does not end with BUILD SUCCESSFUL after a failure.
 Integrating this change in, I picked up some recent changes committed by
 Nick Blair.  These seem to be setting up for new skin function in up 3.2.
 I'm assuming this is all no problem for people using the plugin for uP 3.1.
 However, the plugin will no longer build for me.  I get test failures on the
 build (see stack trace below).  I'd be grateful to know if this builds for
 other people.  Nick?

 I think it might be a good idea to tag this so we can have a stable version
 for our use in production while preparation for future uPortal function is
 added.

 Thanks,
 Susan

 surefire report:
 ===

 ---
 Test set: org.jasig.portal.web.skin.ResourcesAggregatorImplTest
 ---
 Tests run: 5, Failures: 0, Errors: 5, Skipped: 0, Time elapsed: 0.313 sec
  FAILURE!
 testControl(org.jasig.portal.web.skin.ResourcesAggregatorImplTest)  Time
 elapsed: 0.25 sec   ERROR!
 java.lang.RuntimeException
     at
 com.yahoo.platform.yui.compressor.JavaScriptCompressor.printSourceNumber(JavaScriptCompressor.java:299)
     at
 com.yahoo.platform.yui.compressor.JavaScriptCompressor.parse(JavaScriptCompressor.java:335)
     at
 com.yahoo.platform.yui.compressor.JavaScriptCompressor.init(JavaScriptCompressor.java:532)
     at
 org.jasig.portal.web.skin.ResourcesAggregatorImpl.aggregateJsList(ResourcesAggregatorImpl.java:418)
     at
 org.jasig.portal.web.skin.ResourcesAggregatorImpl.aggregate(ResourcesAggregatorImpl.java:226)
     at
 org.jasig.portal.web.skin.ResourcesAggregatorImplTest.testControl(ResourcesAggregatorImplTest.java:34)
     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
     at
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
     at
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
     at java.lang.reflect.Method.invoke(Method.java:597)
     at org.junit.internal.runners.TestMethod.invoke(TestMethod.java:59)
     at
 org.junit.internal.runners.MethodRoadie.runTestMethod(MethodRoadie.java:98)
     at org.junit.internal.runners.MethodRoadie$2.run(MethodRoadie.java:79)
     at
 org.junit.internal.runners.MethodRoadie.runBeforesThenTestThenAfters(MethodRoadie.java:87)
     at org.junit.internal.runners.MethodRoadie.runTest(MethodRoadie.java:77)
     at org.junit.internal.runners.MethodRoadie.run(MethodRoadie.java:42)
     at
 org.junit.internal.runners.JUnit4ClassRunner.invokeTestMethod(JUnit4ClassRunner.java:88)
     at
 org.junit.internal.runners.JUnit4ClassRunner.runMethods(JUnit4ClassRunner.java:51)
     at
 org.junit.internal.runners.JUnit4ClassRunner$1.run(JUnit4ClassRunner.java:44)
     at
 org.junit.internal.runners.ClassRoadie.runUnprotected(ClassRoadie.java:27)
     at
 org.junit.internal.runners.ClassRoadie.runProtected(ClassRoadie.java:37)
     at
 org.junit.internal.runners.JUnit4ClassRunner.run(JUnit4ClassRunner.java:42)
     at
 org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:62)
     at
 org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140)
     at
 org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:127)
     at org.apache.maven.surefire.Surefire.run(Surefire.java:177)
     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
     at
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
     at
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
     at java.lang.reflect.Method.invoke(Method.java:597)
     at
 org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:345)
     at
 org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1009)

 testControl(org.jasig.portal.web.skin.ResourcesAggregatorImplTest)  Time
 elapsed: 0.266 sec   ERROR!
 java.io.IOException: Unable to delete file:
 d:\susan\temp\1\resources-aggregator-impl-test-output\skin-test1\uportal3_aggr2_temp.js
     at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:1390)
     at 

Re: [uportal-dev] maven plugin won't build with ResourcesAggregatorImplTest

2009-11-16 Thread Jen Bourey
Hi Nick,

I've added the yuicompressor 2.4.2 jar to the Jasig third party repository (
http://developer.jasig.org/repo/content/repositories/3rd-party/).

- Jen


On Mon, Nov 16, 2009 at 2:38 PM, Nicholas Blair nicholas.bl...@gmail.comwrote:

 This was related to my prior discussion about YUI Compressor and UP-2505.

 In short, the only YUI Compressor available via maven is version 2.3.6
 - which is broken.

 I have installed 2.4.2 locally, and modified the pom to use it, and
 verified it works.

 Per my last comment on http://www.ja-sig.org/issues/browse/UP-2505 -
 this task is complete-able if we can get YUI Compressor 2.4.2 in a
 maven repository.
 If we can do that, I can make the last commits to get the resource
 aggregator mojo in the maven-uportal-plugin ready for use.

 On Mon, Nov 16, 2009 at 1:18 PM, Susan Bramhall susan.bramh...@yale.edu
 wrote:
  I've updated the maven plugin to throw the proper failure exception when
  appropriate so it does not end with BUILD SUCCESSFUL after a failure.
  Integrating this change in, I picked up some recent changes committed by
  Nick Blair.  These seem to be setting up for new skin function in up 3.2.
  I'm assuming this is all no problem for people using the plugin for uP
 3.1.
  However, the plugin will no longer build for me.  I get test failures on
 the
  build (see stack trace below).  I'd be grateful to know if this builds
 for
  other people.  Nick?
 
  I think it might be a good idea to tag this so we can have a stable
 version
  for our use in production while preparation for future uPortal function
 is
  added.
 
  Thanks,
  Susan
 
  surefire report:
  ===
 
 
 ---
  Test set: org.jasig.portal.web.skin.ResourcesAggregatorImplTest
 
 ---
  Tests run: 5, Failures: 0, Errors: 5, Skipped: 0, Time elapsed: 0.313 sec
   FAILURE!
  testControl(org.jasig.portal.web.skin.ResourcesAggregatorImplTest)  Time
  elapsed: 0.25 sec   ERROR!
  java.lang.RuntimeException
  at
 
 com.yahoo.platform.yui.compressor.JavaScriptCompressor.printSourceNumber(JavaScriptCompressor.java:299)
  at
 
 com.yahoo.platform.yui.compressor.JavaScriptCompressor.parse(JavaScriptCompressor.java:335)
  at
 
 com.yahoo.platform.yui.compressor.JavaScriptCompressor.init(JavaScriptCompressor.java:532)
  at
 
 org.jasig.portal.web.skin.ResourcesAggregatorImpl.aggregateJsList(ResourcesAggregatorImpl.java:418)
  at
 
 org.jasig.portal.web.skin.ResourcesAggregatorImpl.aggregate(ResourcesAggregatorImpl.java:226)
  at
 
 org.jasig.portal.web.skin.ResourcesAggregatorImplTest.testControl(ResourcesAggregatorImplTest.java:34)
  at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
  at
 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
  at
 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
  at java.lang.reflect.Method.invoke(Method.java:597)
  at org.junit.internal.runners.TestMethod.invoke(TestMethod.java:59)
  at
 
 org.junit.internal.runners.MethodRoadie.runTestMethod(MethodRoadie.java:98)
  at
 org.junit.internal.runners.MethodRoadie$2.run(MethodRoadie.java:79)
  at
 
 org.junit.internal.runners.MethodRoadie.runBeforesThenTestThenAfters(MethodRoadie.java:87)
  at
 org.junit.internal.runners.MethodRoadie.runTest(MethodRoadie.java:77)
  at org.junit.internal.runners.MethodRoadie.run(MethodRoadie.java:42)
  at
 
 org.junit.internal.runners.JUnit4ClassRunner.invokeTestMethod(JUnit4ClassRunner.java:88)
  at
 
 org.junit.internal.runners.JUnit4ClassRunner.runMethods(JUnit4ClassRunner.java:51)
  at
 
 org.junit.internal.runners.JUnit4ClassRunner$1.run(JUnit4ClassRunner.java:44)
  at
 
 org.junit.internal.runners.ClassRoadie.runUnprotected(ClassRoadie.java:27)
  at
  org.junit.internal.runners.ClassRoadie.runProtected(ClassRoadie.java:37)
  at
 
 org.junit.internal.runners.JUnit4ClassRunner.run(JUnit4ClassRunner.java:42)
  at
 
 org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:62)
  at
 
 org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140)
  at
 
 org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:127)
  at org.apache.maven.surefire.Surefire.run(Surefire.java:177)
  at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
  at
 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
  at
 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
  at java.lang.reflect.Method.invoke(Method.java:597)
  at
 
 org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:345)
  at
 
 

Re: [uportal-dev] maven plugin won't build with ResourcesAggregatorImplTest

2009-11-16 Thread Nicholas Blair
Excellent - I'll get the projects updated.

Thanks!

On Mon, Nov 16, 2009 at 1:50 PM, Jen Bourey jbou...@unicon.net wrote:
 Hi Nick,

 I've added the yuicompressor 2.4.2 jar to the Jasig third party repository
 (http://developer.jasig.org/repo/content/repositories/3rd-party/).

 - Jen


 On Mon, Nov 16, 2009 at 2:38 PM, Nicholas Blair nicholas.bl...@gmail.com
 wrote:

 This was related to my prior discussion about YUI Compressor and UP-2505.

 In short, the only YUI Compressor available via maven is version 2.3.6
 - which is broken.

 I have installed 2.4.2 locally, and modified the pom to use it, and
 verified it works.

 Per my last comment on http://www.ja-sig.org/issues/browse/UP-2505 -
 this task is complete-able if we can get YUI Compressor 2.4.2 in a
 maven repository.
 If we can do that, I can make the last commits to get the resource
 aggregator mojo in the maven-uportal-plugin ready for use.

 On Mon, Nov 16, 2009 at 1:18 PM, Susan Bramhall susan.bramh...@yale.edu
 wrote:
  I've updated the maven plugin to throw the proper failure exception when
  appropriate so it does not end with BUILD SUCCESSFUL after a failure.
  Integrating this change in, I picked up some recent changes committed by
  Nick Blair.  These seem to be setting up for new skin function in up
  3.2.
  I'm assuming this is all no problem for people using the plugin for uP
  3.1.
  However, the plugin will no longer build for me.  I get test failures on
  the
  build (see stack trace below).  I'd be grateful to know if this builds
  for
  other people.  Nick?
 
  I think it might be a good idea to tag this so we can have a stable
  version
  for our use in production while preparation for future uPortal function
  is
  added.
 
  Thanks,
  Susan
 
  surefire report:
  ===
 
 
  ---
  Test set: org.jasig.portal.web.skin.ResourcesAggregatorImplTest
 
  ---
  Tests run: 5, Failures: 0, Errors: 5, Skipped: 0, Time elapsed: 0.313
  sec
   FAILURE!
  testControl(org.jasig.portal.web.skin.ResourcesAggregatorImplTest)  Time
  elapsed: 0.25 sec   ERROR!
  java.lang.RuntimeException
      at
 
  com.yahoo.platform.yui.compressor.JavaScriptCompressor.printSourceNumber(JavaScriptCompressor.java:299)
      at
 
  com.yahoo.platform.yui.compressor.JavaScriptCompressor.parse(JavaScriptCompressor.java:335)
      at
 
  com.yahoo.platform.yui.compressor.JavaScriptCompressor.init(JavaScriptCompressor.java:532)
      at
 
  org.jasig.portal.web.skin.ResourcesAggregatorImpl.aggregateJsList(ResourcesAggregatorImpl.java:418)
      at
 
  org.jasig.portal.web.skin.ResourcesAggregatorImpl.aggregate(ResourcesAggregatorImpl.java:226)
      at
 
  org.jasig.portal.web.skin.ResourcesAggregatorImplTest.testControl(ResourcesAggregatorImplTest.java:34)
      at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      at
 
  sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
      at
 
  sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
      at java.lang.reflect.Method.invoke(Method.java:597)
      at org.junit.internal.runners.TestMethod.invoke(TestMethod.java:59)
      at
 
  org.junit.internal.runners.MethodRoadie.runTestMethod(MethodRoadie.java:98)
      at
  org.junit.internal.runners.MethodRoadie$2.run(MethodRoadie.java:79)
      at
 
  org.junit.internal.runners.MethodRoadie.runBeforesThenTestThenAfters(MethodRoadie.java:87)
      at
  org.junit.internal.runners.MethodRoadie.runTest(MethodRoadie.java:77)
      at org.junit.internal.runners.MethodRoadie.run(MethodRoadie.java:42)
      at
 
  org.junit.internal.runners.JUnit4ClassRunner.invokeTestMethod(JUnit4ClassRunner.java:88)
      at
 
  org.junit.internal.runners.JUnit4ClassRunner.runMethods(JUnit4ClassRunner.java:51)
      at
 
  org.junit.internal.runners.JUnit4ClassRunner$1.run(JUnit4ClassRunner.java:44)
      at
 
  org.junit.internal.runners.ClassRoadie.runUnprotected(ClassRoadie.java:27)
      at
  org.junit.internal.runners.ClassRoadie.runProtected(ClassRoadie.java:37)
      at
 
  org.junit.internal.runners.JUnit4ClassRunner.run(JUnit4ClassRunner.java:42)
      at
 
  org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:62)
      at
 
  org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140)
      at
 
  org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:127)
      at org.apache.maven.surefire.Surefire.run(Surefire.java:177)
      at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      at
 
  sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
      at
 
  sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
      at java.lang.reflect.Method.invoke(Method.java:597)
      

Re: [uportal-dev] maven plugin won't build with ResourcesAggregatorImplTest

2009-11-16 Thread Susan Bramhall




Fails on unix too but in different place..

---
Test set: org.jasig.portal.web.skin.ResourcesAggregatorImplTest
---
Tests run: 6, Failures: 3, Errors: 3, Skipped: 0, Time elapsed: 0.019
sec  FAILURE!
testControl(org.jasig.portal.web.skin.ResourcesAggregatorImplTest)
Time elapsed: 0.003 sec  FAILURE!
java.lang.AssertionError: 
 at org.junit.Assert.fail(Assert.java:74)
 at org.junit.Assert.assertTrue(Assert.java:37)
 at org.junit.Assert.assertTrue(Assert.java:46)
 at
org.jasig.portal.web.skin.ResourcesAggregatorImplTest.testControl(ResourcesAggregatorImplTest.java:28)
 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
 at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
 at java.lang.reflect.Method.invoke(Method.java:597)
 at org.junit.internal.runners.TestMethod.invoke(TestMethod.java:59)
 at
org.junit.internal.runners.MethodRoadie.runTestMethod(MethodRoadie.java:98)
 at
org.junit.internal.runners.MethodRoadie$2.run(MethodRoadie.java:79)
 at
org.junit.internal.runners.MethodRoadie.runBeforesThenTestThenAfters(MethodRoadie.java:87)
 at
org.junit.internal.runners.MethodRoadie.runTest(MethodRoadie.java:77)
 at org.junit.internal.runners.MethodRoadie.run(MethodRoadie.java:42)
 at
org.junit.internal.runners.JUnit4ClassRunner.invokeTestMethod(JUnit4ClassRunner.java:88)
 at
org.junit.internal.runners.JUnit4ClassRunner.runMethods(JUnit4ClassRunner.java:51)
 at
org.junit.internal.runners.JUnit4ClassRunner$1.run(JUnit4ClassRunner.java:44)
 at
org.junit.internal.runners.ClassRoadie.runUnprotected(ClassRoadie.java:27)
 at
org.junit.internal.runners.ClassRoadie.runProtected(ClassRoadie.java:37)
 at
org.junit.internal.runners.JUnit4ClassRunner.run(JUnit4ClassRunner.java:42)
 at
org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:62)
 at
org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140)
 at
org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:127)
 at org.apache.maven.surefire.Surefire.run(Surefire.java:177)
 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
 at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
 at java.lang.reflect.Method.invoke(Method.java:597)
 at
org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:345)
 at
org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1009)
  
testControl(org.jasig.portal.web.skin.ResourcesAggregatorImplTest)
Time elapsed: 0.008 sec  ERROR!
java.io.FileNotFoundException: File does not exist:
/tmpresources-aggregator-impl-test-output
 at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:1386)
 at
org.jasig.portal.web.skin.ResourcesAggregatorImplTest.cleanupTempDir(ResourcesAggregatorImplTest.java:142)
 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
 at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
 at java.lang.reflect.Method.invoke(Method.java:597)
 at
org.junit.internal.runners.MethodRoadie.runAfters(MethodRoadie.java:138)
 at
org.junit.internal.runners.MethodRoadie.runBeforesThenTestThenAfters(MethodRoadie.java:92)
 at
org.junit.internal.runners.MethodRoadie.runTest(MethodRoadie.java:77)
 at org.junit.internal.runners.MethodRoadie.run(MethodRoadie.java:42)
 at
org.junit.internal.runners.JUnit4ClassRunner.invokeTestMethod(JUnit4ClassRunner.java:88)
 at
org.junit.internal.runners.JUnit4ClassRunner.runMethods(JUnit4ClassRunner.java:51)
 at
org.junit.internal.runners.JUnit4ClassRunner$1.run(JUnit4ClassRunner.java:44)
 at
org.junit.internal.runners.ClassRoadie.runUnprotected(ClassRoadie.java:27)
 at
org.junit.internal.runners.ClassRoadie.runProtected(ClassRoadie.java:37)
 at
org.junit.internal.runners.JUnit4ClassRunner.run(JUnit4ClassRunner.java:42)
 at
org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:62)
 at
org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140)
 at
org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:127)
 at org.apache.maven.surefire.Surefire.run(Surefire.java:177)
 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
 at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
 at java.lang.reflect.Method.invoke(Method.java:597)
 at

Re: [uportal-dev] maven plugin won't build with ResourcesAggregatorImplTest

2009-11-16 Thread Nicholas Blair
Just committed a fix for how the tests construct the path to their
temporary directory, update and try again.



On Mon, Nov 16, 2009 at 3:43 PM, Susan Bramhall susan.bramh...@yale.edu wrote:
 Fails on unix too but in different place..
 

 ---
 Test set: org.jasig.portal.web.skin.ResourcesAggregatorImplTest
 ---
 Tests run: 6, Failures: 3, Errors: 3, Skipped: 0, Time elapsed: 0.019 sec
  FAILURE!
 testControl(org.jasig.portal.web.skin.ResourcesAggregatorImplTest)  Time
 elapsed: 0.003 sec   FAILURE!
 java.lang.AssertionError:
     at org.junit.Assert.fail(Assert.java:74)
     at org.junit.Assert.assertTrue(Assert.java:37)
     at org.junit.Assert.assertTrue(Assert.java:46)
     at
 org.jasig.portal.web.skin.ResourcesAggregatorImplTest.testControl(ResourcesAggregatorImplTest.java:28)
     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
     at
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
     at
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
     at java.lang.reflect.Method.invoke(Method.java:597)
     at org.junit.internal.runners.TestMethod.invoke(TestMethod.java:59)
     at
 org.junit.internal.runners.MethodRoadie.runTestMethod(MethodRoadie.java:98)
     at org.junit.internal.runners.MethodRoadie$2.run(MethodRoadie.java:79)
     at
 org.junit.internal.runners.MethodRoadie.runBeforesThenTestThenAfters(MethodRoadie.java:87)
     at org.junit.internal.runners.MethodRoadie.runTest(MethodRoadie.java:77)
     at org.junit.internal.runners.MethodRoadie.run(MethodRoadie.java:42)
     at
 org.junit.internal.runners.JUnit4ClassRunner.invokeTestMethod(JUnit4ClassRunner.java:88)
     at
 org.junit.internal.runners.JUnit4ClassRunner.runMethods(JUnit4ClassRunner.java:51)
     at
 org.junit.internal.runners.JUnit4ClassRunner$1.run(JUnit4ClassRunner.java:44)
     at
 org.junit.internal.runners.ClassRoadie.runUnprotected(ClassRoadie.java:27)
     at
 org.junit.internal.runners.ClassRoadie.runProtected(ClassRoadie.java:37)
     at
 org.junit.internal.runners.JUnit4ClassRunner.run(JUnit4ClassRunner.java:42)
     at
 org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:62)
     at
 org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140)
     at
 org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:127)
     at org.apache.maven.surefire.Surefire.run(Surefire.java:177)
     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
     at
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
     at
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
     at java.lang.reflect.Method.invoke(Method.java:597)
     at
 org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:345)
     at
 org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1009)

 testControl(org.jasig.portal.web.skin.ResourcesAggregatorImplTest)  Time
 elapsed: 0.008 sec   ERROR!
 java.io.FileNotFoundException: File does not exist:
 /tmpresources-aggregator-impl-test-output
     at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:1386)
     at
 org.jasig.portal.web.skin.ResourcesAggregatorImplTest.cleanupTempDir(ResourcesAggregatorImplTest.java:142)
     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
     at
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
     at
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
     at java.lang.reflect.Method.invoke(Method.java:597)
     at
 org.junit.internal.runners.MethodRoadie.runAfters(MethodRoadie.java:138)
     at
 org.junit.internal.runners.MethodRoadie.runBeforesThenTestThenAfters(MethodRoadie.java:92)
     at org.junit.internal.runners.MethodRoadie.runTest(MethodRoadie.java:77)
     at org.junit.internal.runners.MethodRoadie.run(MethodRoadie.java:42)
     at
 org.junit.internal.runners.JUnit4ClassRunner.invokeTestMethod(JUnit4ClassRunner.java:88)
     at
 org.junit.internal.runners.JUnit4ClassRunner.runMethods(JUnit4ClassRunner.java:51)
     at
 org.junit.internal.runners.JUnit4ClassRunner$1.run(JUnit4ClassRunner.java:44)
     at
 org.junit.internal.runners.ClassRoadie.runUnprotected(ClassRoadie.java:27)
     at
 org.junit.internal.runners.ClassRoadie.runProtected(ClassRoadie.java:37)
     at
 org.junit.internal.runners.JUnit4ClassRunner.run(JUnit4ClassRunner.java:42)
     at
 org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:62)
     at
 org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140)
     at
 

Re: [uportal-dev] maven plugin won't build with ResourcesAggregatorImplTest

2009-11-16 Thread Susan Bramhall




Yes, D: is local and same file system as running mvn on. I do have
delete on that directory and can delete it manually. 
Susan

Nicholas Blair wrote:

  There is a method annotated with @After (runs "after" each test) to
clean up temporary files created by the test. The tests use the System
property java.io.tmpdir to use as a root for these temporary files.

I don't really know much about why that wouldn't work on windowsdo
you have permission to delete files under d:\susan\temp?
Is your d: drive a local or a remote filesystem?

On Mon, Nov 16, 2009 at 3:27 PM, Susan Bramhall susan.bramh...@yale.edu wrote:
  
  
Thanks to you both I am now down to just the errors caused by unable to
delete temp files:

java.io.IOException: Unable to delete file:
d:\susan\temp\1\resources-aggregator-impl-test-output\skin-test1\uportal3_aggr2_temp.js

One for each test in ResourcesAggregatorImplTest.  Not sure why I get that
and you don't.  I am running under windows which does not like to delete
open files.  Maybe this is not getting closed?

Susan


Nicholas Blair wrote:

I've just checked in the changes necessary to fix the tests - you
should not have any problem building maven-uportal-plugin if you
update to the trunk.



On Mon, Nov 16, 2009 at 2:07 PM, Nicholas Blair
nicholas.bl...@gmail.com wrote:


Excellent - I'll get the projects updated.

Thanks!

On Mon, Nov 16, 2009 at 1:50 PM, Jen Bourey jbou...@unicon.net wrote:


Hi Nick,

I've added the yuicompressor 2.4.2 jar to the Jasig third party repository
(http://developer.jasig.org/repo/content/repositories/3rd-party/).

- Jen


On Mon, Nov 16, 2009 at 2:38 PM, Nicholas Blair nicholas.bl...@gmail.com
wrote:


This was related to my prior discussion about YUI Compressor and UP-2505.

In short, the only YUI Compressor available via maven is version 2.3.6
- which is broken.

I have installed 2.4.2 locally, and modified the pom to use it, and
verified it works.

Per my last comment on http://www.ja-sig.org/issues/browse/UP-2505 -
this task is "complete-able" if we can get YUI Compressor 2.4.2 in a
maven repository.
If we can do that, I can make the last commits to get the "resource
aggregator" mojo in the maven-uportal-plugin ready for use.

On Mon, Nov 16, 2009 at 1:18 PM, Susan Bramhall susan.bramh...@yale.edu
wrote:


I've updated the maven plugin to throw the proper failure exception when
appropriate so it does not end with BUILD SUCCESSFUL after a failure.
Integrating this change in, I picked up some recent changes committed by
Nick Blair.  These seem to be setting up for new skin function in up
3.2.
I'm assuming this is all no problem for people using the plugin for uP
3.1.
However, the plugin will no longer build for me.  I get test failures on
the
build (see stack trace below).  I'd be grateful to know if this builds
for
other people.  Nick?

I think it might be a good idea to tag this so we can have a stable
version
for our use in production while preparation for future uPortal function
is
added.

Thanks,
Susan

surefire report:
===


---
Test set: org.jasig.portal.web.skin.ResourcesAggregatorImplTest

---
Tests run: 5, Failures: 0, Errors: 5, Skipped: 0, Time elapsed: 0.313
sec
 FAILURE!
testControl(org.jasig.portal.web.skin.ResourcesAggregatorImplTest)  Time
elapsed: 0.25 sec   ERROR!
java.lang.RuntimeException
at

com.yahoo.platform.yui.compressor._javascript_Compressor.printSourceNumber(_javascript_Compressor.java:299)
at

com.yahoo.platform.yui.compressor._javascript_Compressor.parse(_javascript_Compressor.java:335)
at

com.yahoo.platform.yui.compressor._javascript_Compressor.init(_javascript_Compressor.java:532)
at

org.jasig.portal.web.skin.ResourcesAggregatorImpl.aggregateJsList(ResourcesAggregatorImpl.java:418)
at

org.jasig.portal.web.skin.ResourcesAggregatorImpl.aggregate(ResourcesAggregatorImpl.java:226)
at

org.jasig.portal.web.skin.ResourcesAggregatorImplTest.testControl(ResourcesAggregatorImplTest.java:34)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at

sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at

sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.junit.internal.runners.TestMethod.invoke(TestMethod.java:59)
at

org.junit.internal.runners.MethodRoadie.runTestMethod(MethodRoadie.java:98)
at
org.junit.internal.runners.MethodRoadie$2.run(MethodRoadie.java:79)
at

org.junit.internal.runners.MethodRoadie.runBeforesThenTestThenAfters(MethodRoadie.java:87)
at
org.junit.internal.runners.MethodRoadie.runTest(MethodRoadie.java:77)
at org.junit.internal.runners.MethodRoadie.run(MethodRoadie.java:42)
at


Re: [uportal-dev] maven plugin won't build with ResourcesAggregatorImplTest

2009-11-16 Thread Susan Bramhall




YAY. Build successful now on Unix. Windows still complaining. I can
research that a bit more. Whadda pain.
Susan

Nicholas Blair wrote:

  Just committed a fix for how the tests construct the path to their
temporary directory, update and try again.



On Mon, Nov 16, 2009 at 3:43 PM, Susan Bramhall susan.bramh...@yale.edu wrote:
  
  
Fails on unix too but in different place..


---
Test set: org.jasig.portal.web.skin.ResourcesAggregatorImplTest
---
Tests run: 6, Failures: 3, Errors: 3, Skipped: 0, Time elapsed: 0.019 sec
 FAILURE!
testControl(org.jasig.portal.web.skin.ResourcesAggregatorImplTest)  Time
elapsed: 0.003 sec   FAILURE!
java.lang.AssertionError:
at org.junit.Assert.fail(Assert.java:74)
at org.junit.Assert.assertTrue(Assert.java:37)
at org.junit.Assert.assertTrue(Assert.java:46)
at
org.jasig.portal.web.skin.ResourcesAggregatorImplTest.testControl(ResourcesAggregatorImplTest.java:28)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.junit.internal.runners.TestMethod.invoke(TestMethod.java:59)
at
org.junit.internal.runners.MethodRoadie.runTestMethod(MethodRoadie.java:98)
at org.junit.internal.runners.MethodRoadie$2.run(MethodRoadie.java:79)
at
org.junit.internal.runners.MethodRoadie.runBeforesThenTestThenAfters(MethodRoadie.java:87)
at org.junit.internal.runners.MethodRoadie.runTest(MethodRoadie.java:77)
at org.junit.internal.runners.MethodRoadie.run(MethodRoadie.java:42)
at
org.junit.internal.runners.JUnit4ClassRunner.invokeTestMethod(JUnit4ClassRunner.java:88)
at
org.junit.internal.runners.JUnit4ClassRunner.runMethods(JUnit4ClassRunner.java:51)
at
org.junit.internal.runners.JUnit4ClassRunner$1.run(JUnit4ClassRunner.java:44)
at
org.junit.internal.runners.ClassRoadie.runUnprotected(ClassRoadie.java:27)
at
org.junit.internal.runners.ClassRoadie.runProtected(ClassRoadie.java:37)
at
org.junit.internal.runners.JUnit4ClassRunner.run(JUnit4ClassRunner.java:42)
at
org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:62)
at
org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140)
at
org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:127)
at org.apache.maven.surefire.Surefire.run(Surefire.java:177)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at
org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:345)
at
org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1009)

testControl(org.jasig.portal.web.skin.ResourcesAggregatorImplTest)  Time
elapsed: 0.008 sec   ERROR!
java.io.FileNotFoundException: File does not exist:
/tmpresources-aggregator-impl-test-output
at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:1386)
at
org.jasig.portal.web.skin.ResourcesAggregatorImplTest.cleanupTempDir(ResourcesAggregatorImplTest.java:142)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at
org.junit.internal.runners.MethodRoadie.runAfters(MethodRoadie.java:138)
at
org.junit.internal.runners.MethodRoadie.runBeforesThenTestThenAfters(MethodRoadie.java:92)
at org.junit.internal.runners.MethodRoadie.runTest(MethodRoadie.java:77)
at org.junit.internal.runners.MethodRoadie.run(MethodRoadie.java:42)
at
org.junit.internal.runners.JUnit4ClassRunner.invokeTestMethod(JUnit4ClassRunner.java:88)
at
org.junit.internal.runners.JUnit4ClassRunner.runMethods(JUnit4ClassRunner.java:51)
at
org.junit.internal.runners.JUnit4ClassRunner$1.run(JUnit4ClassRunner.java:44)
at
org.junit.internal.runners.ClassRoadie.runUnprotected(ClassRoadie.java:27)
at
org.junit.internal.runners.ClassRoadie.runProtected(ClassRoadie.java:37)
at
org.junit.internal.runners.JUnit4ClassRunner.run(JUnit4ClassRunner.java:42)
at
org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:62)
at
org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140)
at

Re: [uportal-dev] maven plugin won't build with ResourcesAggregatorImplTest

2009-11-16 Thread Nicholas Blair
Yes, unfortunately YUICompressor's methods for compressing javascript
and css depend on FileReader and FileWriter, which are concrete. If we
want to have unit tests for resource aggregation, the only way to pull
it off is by creating and deleting these temporary files.

I'll take a look at how setup and teardown for this test can be improved.

On Mon, Nov 16, 2009 at 3:48 PM, Susan Bramhall susan.bramh...@yale.edu wrote:
 YAY.  Build successful now on Unix.  Windows still complaining.  I can
 research that a bit more.  Whadda pain.
 Susan

 Nicholas Blair wrote:

 Just committed a fix for how the tests construct the path to their
 temporary directory, update and try again.



 On Mon, Nov 16, 2009 at 3:43 PM, Susan Bramhall susan.bramh...@yale.edu
 wrote:


 Fails on unix too but in different place..
 

 ---
 Test set: org.jasig.portal.web.skin.ResourcesAggregatorImplTest
 ---
 Tests run: 6, Failures: 3, Errors: 3, Skipped: 0, Time elapsed: 0.019 sec
  FAILURE!
 testControl(org.jasig.portal.web.skin.ResourcesAggregatorImplTest)  Time
 elapsed: 0.003 sec   FAILURE!
 java.lang.AssertionError:
 at org.junit.Assert.fail(Assert.java:74)
 at org.junit.Assert.assertTrue(Assert.java:37)
 at org.junit.Assert.assertTrue(Assert.java:46)
 at
 org.jasig.portal.web.skin.ResourcesAggregatorImplTest.testControl(ResourcesAggregatorImplTest.java:28)
 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 at
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
 at
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
 at java.lang.reflect.Method.invoke(Method.java:597)
 at org.junit.internal.runners.TestMethod.invoke(TestMethod.java:59)
 at
 org.junit.internal.runners.MethodRoadie.runTestMethod(MethodRoadie.java:98)
 at org.junit.internal.runners.MethodRoadie$2.run(MethodRoadie.java:79)
 at
 org.junit.internal.runners.MethodRoadie.runBeforesThenTestThenAfters(MethodRoadie.java:87)
 at org.junit.internal.runners.MethodRoadie.runTest(MethodRoadie.java:77)
 at org.junit.internal.runners.MethodRoadie.run(MethodRoadie.java:42)
 at
 org.junit.internal.runners.JUnit4ClassRunner.invokeTestMethod(JUnit4ClassRunner.java:88)
 at
 org.junit.internal.runners.JUnit4ClassRunner.runMethods(JUnit4ClassRunner.java:51)
 at
 org.junit.internal.runners.JUnit4ClassRunner$1.run(JUnit4ClassRunner.java:44)
 at
 org.junit.internal.runners.ClassRoadie.runUnprotected(ClassRoadie.java:27)
 at
 org.junit.internal.runners.ClassRoadie.runProtected(ClassRoadie.java:37)
 at
 org.junit.internal.runners.JUnit4ClassRunner.run(JUnit4ClassRunner.java:42)
 at
 org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:62)
 at
 org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140)
 at
 org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:127)
 at org.apache.maven.surefire.Surefire.run(Surefire.java:177)
 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 at
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
 at
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
 at java.lang.reflect.Method.invoke(Method.java:597)
 at
 org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:345)
 at
 org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1009)

 testControl(org.jasig.portal.web.skin.ResourcesAggregatorImplTest)  Time
 elapsed: 0.008 sec   ERROR!
 java.io.FileNotFoundException: File does not exist:
 /tmpresources-aggregator-impl-test-output
 at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:1386)
 at
 org.jasig.portal.web.skin.ResourcesAggregatorImplTest.cleanupTempDir(ResourcesAggregatorImplTest.java:142)
 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 at
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
 at
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
 at java.lang.reflect.Method.invoke(Method.java:597)
 at
 org.junit.internal.runners.MethodRoadie.runAfters(MethodRoadie.java:138)
 at
 org.junit.internal.runners.MethodRoadie.runBeforesThenTestThenAfters(MethodRoadie.java:92)
 at org.junit.internal.runners.MethodRoadie.runTest(MethodRoadie.java:77)
 at org.junit.internal.runners.MethodRoadie.run(MethodRoadie.java:42)
 at
 org.junit.internal.runners.JUnit4ClassRunner.invokeTestMethod(JUnit4ClassRunner.java:88)
 at
 org.junit.internal.runners.JUnit4ClassRunner.runMethods(JUnit4ClassRunner.java:51)
 at
 

Re: [uportal-dev] maven plugin won't build with ResourcesAggregatorImplTest

2009-11-16 Thread Nicholas Blair
I've just checked in a change to the cleanup method in that test
class. Can you try the build on Windows again to see if the changes
have helped?

Thanks!
Nick

On Mon, Nov 16, 2009 at 4:02 PM, Nicholas Blair
nicholas.bl...@gmail.com wrote:
 Yes, unfortunately YUICompressor's methods for compressing javascript
 and css depend on FileReader and FileWriter, which are concrete. If we
 want to have unit tests for resource aggregation, the only way to pull
 it off is by creating and deleting these temporary files.

 I'll take a look at how setup and teardown for this test can be improved.

 On Mon, Nov 16, 2009 at 3:48 PM, Susan Bramhall susan.bramh...@yale.edu 
 wrote:
 YAY.  Build successful now on Unix.  Windows still complaining.  I can
 research that a bit more.  Whadda pain.
 Susan

 Nicholas Blair wrote:

 Just committed a fix for how the tests construct the path to their
 temporary directory, update and try again.



 On Mon, Nov 16, 2009 at 3:43 PM, Susan Bramhall susan.bramh...@yale.edu
 wrote:


 Fails on unix too but in different place..
 

 ---
 Test set: org.jasig.portal.web.skin.ResourcesAggregatorImplTest
 ---
 Tests run: 6, Failures: 3, Errors: 3, Skipped: 0, Time elapsed: 0.019 sec
  FAILURE!
 testControl(org.jasig.portal.web.skin.ResourcesAggregatorImplTest)  Time
 elapsed: 0.003 sec   FAILURE!
 java.lang.AssertionError:
     at org.junit.Assert.fail(Assert.java:74)
     at org.junit.Assert.assertTrue(Assert.java:37)
     at org.junit.Assert.assertTrue(Assert.java:46)
     at
 org.jasig.portal.web.skin.ResourcesAggregatorImplTest.testControl(ResourcesAggregatorImplTest.java:28)
     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
     at
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
     at
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
     at java.lang.reflect.Method.invoke(Method.java:597)
     at org.junit.internal.runners.TestMethod.invoke(TestMethod.java:59)
     at
 org.junit.internal.runners.MethodRoadie.runTestMethod(MethodRoadie.java:98)
     at org.junit.internal.runners.MethodRoadie$2.run(MethodRoadie.java:79)
     at
 org.junit.internal.runners.MethodRoadie.runBeforesThenTestThenAfters(MethodRoadie.java:87)
     at org.junit.internal.runners.MethodRoadie.runTest(MethodRoadie.java:77)
     at org.junit.internal.runners.MethodRoadie.run(MethodRoadie.java:42)
     at
 org.junit.internal.runners.JUnit4ClassRunner.invokeTestMethod(JUnit4ClassRunner.java:88)
     at
 org.junit.internal.runners.JUnit4ClassRunner.runMethods(JUnit4ClassRunner.java:51)
     at
 org.junit.internal.runners.JUnit4ClassRunner$1.run(JUnit4ClassRunner.java:44)
     at
 org.junit.internal.runners.ClassRoadie.runUnprotected(ClassRoadie.java:27)
     at
 org.junit.internal.runners.ClassRoadie.runProtected(ClassRoadie.java:37)
     at
 org.junit.internal.runners.JUnit4ClassRunner.run(JUnit4ClassRunner.java:42)
     at
 org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:62)
     at
 org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140)
     at
 org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:127)
     at org.apache.maven.surefire.Surefire.run(Surefire.java:177)
     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
     at
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
     at
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
     at java.lang.reflect.Method.invoke(Method.java:597)
     at
 org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:345)
     at
 org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1009)

 testControl(org.jasig.portal.web.skin.ResourcesAggregatorImplTest)  Time
 elapsed: 0.008 sec   ERROR!
 java.io.FileNotFoundException: File does not exist:
 /tmpresources-aggregator-impl-test-output
     at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:1386)
     at
 org.jasig.portal.web.skin.ResourcesAggregatorImplTest.cleanupTempDir(ResourcesAggregatorImplTest.java:142)
     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
     at
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
     at
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
     at java.lang.reflect.Method.invoke(Method.java:597)
     at
 org.junit.internal.runners.MethodRoadie.runAfters(MethodRoadie.java:138)
     at
 org.junit.internal.runners.MethodRoadie.runBeforesThenTestThenAfters(MethodRoadie.java:92)
     at org.junit.internal.runners.MethodRoadie.runTest(MethodRoadie.java:77)
     at 

Re: [uportal-dev] maven plugin won't build with ResourcesAggregatorImplTest

2009-11-16 Thread Susan Bramhall




Still getting stuck on delete of one file. In one attempt I was NOT
able to delete it manually so am guessing some resource needs to be
closed so the file can be removed. The only failure is now on removing
\uportal3_aggr2_temp.js.
Susan

Nicholas Blair wrote:

  I've just checked in a change to the cleanup method in that test
class. Can you try the build on Windows again to see if the changes
have helped?

Thanks!
Nick

On Mon, Nov 16, 2009 at 4:02 PM, Nicholas Blair
nicholas.bl...@gmail.com wrote:
  
  
Yes, unfortunately YUICompressor's methods for compressing _javascript_
and css depend on FileReader and FileWriter, which are concrete. If we
want to have unit tests for resource aggregation, the only way to pull
it off is by creating and deleting these temporary files.

I'll take a look at how setup and teardown for this test can be improved.

On Mon, Nov 16, 2009 at 3:48 PM, Susan Bramhall susan.bramh...@yale.edu wrote:


  YAY.  Build successful now on Unix.  Windows still complaining.  I can
research that a bit more.  Whadda pain.
Susan

Nicholas Blair wrote:

Just committed a fix for how the tests construct the path to their
temporary directory, update and try again.



On Mon, Nov 16, 2009 at 3:43 PM, Susan Bramhall susan.bramh...@yale.edu
wrote:


Fails on unix too but in different place..


---
Test set: org.jasig.portal.web.skin.ResourcesAggregatorImplTest
---
Tests run: 6, Failures: 3, Errors: 3, Skipped: 0, Time elapsed: 0.019 sec
 FAILURE!
testControl(org.jasig.portal.web.skin.ResourcesAggregatorImplTest)  Time
elapsed: 0.003 sec   FAILURE!
java.lang.AssertionError:
at org.junit.Assert.fail(Assert.java:74)
at org.junit.Assert.assertTrue(Assert.java:37)
at org.junit.Assert.assertTrue(Assert.java:46)
at
org.jasig.portal.web.skin.ResourcesAggregatorImplTest.testControl(ResourcesAggregatorImplTest.java:28)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.junit.internal.runners.TestMethod.invoke(TestMethod.java:59)
at
org.junit.internal.runners.MethodRoadie.runTestMethod(MethodRoadie.java:98)
at org.junit.internal.runners.MethodRoadie$2.run(MethodRoadie.java:79)
at
org.junit.internal.runners.MethodRoadie.runBeforesThenTestThenAfters(MethodRoadie.java:87)
at org.junit.internal.runners.MethodRoadie.runTest(MethodRoadie.java:77)
at org.junit.internal.runners.MethodRoadie.run(MethodRoadie.java:42)
at
org.junit.internal.runners.JUnit4ClassRunner.invokeTestMethod(JUnit4ClassRunner.java:88)
at
org.junit.internal.runners.JUnit4ClassRunner.runMethods(JUnit4ClassRunner.java:51)
at
org.junit.internal.runners.JUnit4ClassRunner$1.run(JUnit4ClassRunner.java:44)
at
org.junit.internal.runners.ClassRoadie.runUnprotected(ClassRoadie.java:27)
at
org.junit.internal.runners.ClassRoadie.runProtected(ClassRoadie.java:37)
at
org.junit.internal.runners.JUnit4ClassRunner.run(JUnit4ClassRunner.java:42)
at
org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:62)
at
org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140)
at
org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:127)
at org.apache.maven.surefire.Surefire.run(Surefire.java:177)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at
org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:345)
at
org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1009)

testControl(org.jasig.portal.web.skin.ResourcesAggregatorImplTest)  Time
elapsed: 0.008 sec   ERROR!
java.io.FileNotFoundException: File does not exist:
/tmpresources-aggregator-impl-test-output
at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:1386)
at
org.jasig.portal.web.skin.ResourcesAggregatorImplTest.cleanupTempDir(ResourcesAggregatorImplTest.java:142)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at
org.junit.internal.runners.MethodRoadie.runAfters(MethodRoadie.java:138)
at