Re: Re: Re: GC issues after upgrading from 1.8 to 1.10

2022-11-18 Thread Gary Gregory
That's right, the code in git master no longer allocates objects to implement hashCode(). Gary On Fri, Nov 18, 2022, 16:32 Alex Herbert wrote: > On Fri, 18 Nov 2022 at 17:21, Dan Tran wrote: > > > > Hi Alex, > > > > could you elaborate on 'fixed the problem'? is it at your side and at the > >

Re: Re: Re: GC issues after upgrading from 1.8 to 1.10

2022-11-18 Thread Alex Herbert
On Fri, 18 Nov 2022 at 17:21, Dan Tran wrote: > > Hi Alex, > > could you elaborate on 'fixed the problem'? is it at your side and at the > commons-text side? I believe the 'fixed the problem' is that the change to the TextStringBuilder hashCode method has now been reverted in commons-text to

Re: Re: Re: GC issues after upgrading from 1.8 to 1.10

2022-11-18 Thread Dan Tran
Hi Alex, could you elaborate on 'fixed the problem'? is it at your side and at the commons-text side? Thanks -D On Thu, Nov 17, 2022 at 1:21 PM Pavel Belousov wrote: > Nope, I don't think I created the account. Let's skip this for now, Gary > already helped us and fixed the problem, so if I

RE: Re: Re: GC issues after upgrading from 1.8 to 1.10

2022-11-17 Thread Pavel Belousov
Nope, I don't think I created the account. Let's skip this for now, Gary already helped us and fixed the problem, so if I need the access one more time I will let you know. Thank you! On 2022/11/17 16:54:48 Alex Herbert wrote: > On Thu, 17 Nov 2022 at 16:37, Pavel Belousov > wrote: > > > Yes,

Re: GC issues after upgrading from 1.8 to 1.10

2022-11-17 Thread sebb
On Thu, 17 Nov 2022 at 15:40, Alex Herbert wrote: > > On Thu, 17 Nov 2022 at 13:34, Gilles Sadowski wrote: > > > > Hello. > > > > Le jeu. 17 nov. 2022 à 13:38, Pavel Belousov > > a écrit : > > > > > > [...] > > > > > > As I cannot sign up for your jira, [...] > > > > What do you mean? > >

Re: Re: GC issues after upgrading from 1.8 to 1.10

2022-11-17 Thread Alex Herbert
On Thu, 17 Nov 2022 at 16:37, Pavel Belousov wrote: > Yes, please create the account with `pavelbelousov` user name. That username already exists. Did you previously create an account? Alex - To unsubscribe, e-mail:

RE: Re: GC issues after upgrading from 1.8 to 1.10

2022-11-17 Thread Pavel Belousov
Hi Alex, Yes, please create the account with `pavelbelousov` user name. Thank you! On 2022/11/17 15:39:22 Alex Herbert wrote: > On Thu, 17 Nov 2022 at 13:34, Gilles Sadowski wrote: > > > > Hello. > > > > Le jeu. 17 nov. 2022 à 13:38, Pavel Belousov > > a écrit : > > > > > > [...] > > > > > >

RE: Re: GC issues after upgrading from 1.8 to 1.10

2022-11-17 Thread Pavel Belousov
Hi Gary, Here it is: https://github.com/apache/commons-text/pull/387 Thank you! On 2022/11/17 12:53:02 Gary Gregory wrote: > Hello Pavel, > > Feel free to create a PR on GitHub. > > Gary > > On Thu, Nov 17, 2022, 07:38 Pavel Belousov > wrote: > > > Hi, > > > > After the upgrade of the

Re: GC issues after upgrading from 1.8 to 1.10

2022-11-17 Thread Alex Herbert
On Thu, 17 Nov 2022 at 13:34, Gilles Sadowski wrote: > > Hello. > > Le jeu. 17 nov. 2022 à 13:38, Pavel Belousov > a écrit : > > > > [...] > > > > As I cannot sign up for your jira, [...] > > What do you mean? Recent changes by Infra to prevent spam have blocked user sign-up to Jira. An account

Re: GC issues after upgrading from 1.8 to 1.10

2022-11-17 Thread Gilles Sadowski
Hello. Le jeu. 17 nov. 2022 à 13:38, Pavel Belousov a écrit : > > [...] > > As I cannot sign up for your jira, [...] What do you mean? Regards, Gilles - To unsubscribe, e-mail: user-unsubscr...@commons.apache.org For

Re: GC issues after upgrading from 1.8 to 1.10

2022-11-17 Thread Gary Gregory
Hello Pavel, Feel free to create a PR on GitHub. Gary On Thu, Nov 17, 2022, 07:38 Pavel Belousov wrote: > Hi, > > After the upgrade of the `commons-text` library from 1.8 to 1.10 we faced a > higher number of garbage collections and higher times of garbage > collection. For now we rolled back

GC issues after upgrading from 1.8 to 1.10

2022-11-17 Thread Pavel Belousov
Hi, After the upgrade of the `commons-text` library from 1.8 to 1.10 we faced a higher number of garbage collections and higher times of garbage collection. For now we rolled back to 1.8 but as I had some vulnerabilities we do want to upgrade. We are actively using the `TextStringBuilder` class,