Re: Help with migrating one of OpenJPA classes to commons-collections4

2018-12-18 Thread Gilles
Hi. On Tue, 18 Dec 2018 20:54:22 +0700, Maxim Solodovnik wrote: Hello Gilles, I read documentation and as far as I can see To perform release I need rights to create branch git remote -v origin g...@github.com:apache/commons-collections.git (fetch) origin

Re: Help with migrating one of OpenJPA classes to commons-collections4

2018-12-18 Thread Maxim Solodovnik
Hello Gilles, I read documentation and as far as I can see To perform release I need rights to create branch git remote -v origin g...@github.com:apache/commons-collections.git (fetch) origin g...@github.com:apache/commons-collections.git (push) git push -u origin 4.3-release ERROR: Permission

Re: Help with migrating one of OpenJPA classes to commons-collections4

2018-12-18 Thread Maxim Solodovnik
Thanks Gilles, will try to create RC tonight On Tue, 18 Dec 2018 at 15:55, Gilles wrote: > Hi. > > On Tue, 18 Dec 2018 09:52:15 +0700, Maxim Solodovnik wrote: > > I can create RC, no problem > > But > > 1) I need my signing key [1] to be added to official KEYS > > The file is here: >

Re: Help with migrating one of OpenJPA classes to commons-collections4

2018-12-18 Thread Gilles
Hi. On Tue, 18 Dec 2018 09:52:15 +0700, Maxim Solodovnik wrote: I can create RC, no problem But 1) I need my signing key [1] to be added to official KEYS The file is here: https://dist.apache.org/repos/dist/release/commons/KEYS 2) Do you have description of your release process? I was

Re: Help with migrating one of OpenJPA classes to commons-collections4

2018-12-17 Thread Maxim Solodovnik
I can create RC, no problem But 1) I need my signing key [1] to be added to official KEYS 2) Do you have description of your release process? I was unable to find one 3) most probably I will need some rights [1] https://github.com/apache/openmeetings/blob/master/KEYS#L88 On Tue, 18 Dec 2018 at

Re: Help with migrating one of OpenJPA classes to commons-collections4

2018-12-17 Thread sebb
On Mon, 17 Dec 2018 at 15:38, Gary Gregory wrote: > > I am on the road driving this week, my availability is limited. > > WRT being a RM, I think you need PMC karma for that. Sebb might be able to > confirm. Creating the dist/dev release candidate only requires project committer karma; Commons

Re: Help with migrating one of OpenJPA classes to commons-collections4

2018-12-17 Thread Gary Gregory
I am on the road driving this week, my availability is limited. WRT being a RM, I think you need PMC karma for that. Sebb might be able to confirm. Gary On Mon, Dec 17, 2018, 03:59 Gilles Hi. > > On Mon, 17 Dec 2018 15:12:16 +0700, Maxim Solodovnik wrote: > > Hello Gary, > > > > Is there any

Re: Help with migrating one of OpenJPA classes to commons-collections4

2018-12-17 Thread Gilles
Hi. On Mon, 17 Dec 2018 15:12:16 +0700, Maxim Solodovnik wrote: Hello Gary, Is there any progress? :) Suggestion: Be the release manager of 4.3. Regards, Gilles On Tue, 4 Dec 2018 at 00:07, Gary Gregory wrote: [...]

Re: Help with migrating one of OpenJPA classes to commons-collections4

2018-12-17 Thread Maxim Solodovnik
Hello Gary, Is there any progress? :) On Tue, 4 Dec 2018 at 00:07, Gary Gregory wrote: > There are a couple of issues. I'll try to take a look tonight. > > Gary > > On Mon, Dec 3, 2018 at 9:24 AM Maxim Solodovnik > wrote: > > > Hello, > > > > OpenJpa release is blocked by absence of

Re: Help with migrating one of OpenJPA classes to commons-collections4

2018-12-03 Thread Gary Gregory
There are a couple of issues. I'll try to take a look tonight. Gary On Mon, Dec 3, 2018 at 9:24 AM Maxim Solodovnik wrote: > Hello, > > OpenJpa release is blocked by absence of commons-collections release > Are there any blockers? > > On Mon, 26 Nov 2018 at 20:08, Maxim Solodovnik > wrote: >

Re: Help with migrating one of OpenJPA classes to commons-collections4

2018-12-03 Thread Maxim Solodovnik
Hello, OpenJpa release is blocked by absence of commons-collections release Are there any blockers? On Mon, 26 Nov 2018 at 20:08, Maxim Solodovnik wrote: > Hello Gary, > > any news regarding release? :))) > > On Tue, 13 Nov 2018 at 12:51, Maxim Solodovnik > wrote: > >> Many thanks :) >> >> On

Re: Help with migrating one of OpenJPA classes to commons-collections4

2018-11-26 Thread Maxim Solodovnik
Hello Gary, any news regarding release? :))) On Tue, 13 Nov 2018 at 12:51, Maxim Solodovnik wrote: > Many thanks :) > > On Tue, 13 Nov 2018 at 12:50, Gary Gregory wrote: > >> I hope someone will take the time to do this over the US Thanksgiving >> holidays perhaps. >> >> Gary >> >> On Mon,

Re: Help with migrating one of OpenJPA classes to commons-collections4

2018-11-12 Thread Maxim Solodovnik
Many thanks :) On Tue, 13 Nov 2018 at 12:50, Gary Gregory wrote: > I hope someone will take the time to do this over the US Thanksgiving > holidays perhaps. > > Gary > > On Mon, Nov 12, 2018, 22:37 Maxim Solodovnik > > Hello Gary, > > > > we all are volunteers :) > > Why I'm asking: it will be

Re: Help with migrating one of OpenJPA classes to commons-collections4

2018-11-12 Thread Gary Gregory
I hope someone will take the time to do this over the US Thanksgiving holidays perhaps. Gary On Mon, Nov 12, 2018, 22:37 Maxim Solodovnik Hello Gary, > > we all are volunteers :) > Why I'm asking: it will be blocker for OpenJPA release > > On Tue, 16 Oct 2018 at 19:39, Gary Gregory wrote: > >

Re: Help with migrating one of OpenJPA classes to commons-collections4

2018-11-12 Thread Maxim Solodovnik
Hello Gary, we all are volunteers :) Why I'm asking: it will be blocker for OpenJPA release On Tue, 16 Oct 2018 at 19:39, Gary Gregory wrote: > Hi, > > There is no ETA, and since we are all volunteers, it depends on who wants > to step up and take the time to do it. > > Gary > > On Mon, Oct

Re: Help with migrating one of OpenJPA classes to commons-collections4

2018-10-16 Thread Gary Gregory
Hi, There is no ETA, and since we are all volunteers, it depends on who wants to step up and take the time to do it. Gary On Mon, Oct 15, 2018, 22:23 Maxim Solodovnik wrote: > Hello Gary, > > SNAPSHOT works for us expected :) > There is no rush, I just want to get some ETA :) > > On Tue, 16

Re: Help with migrating one of OpenJPA classes to commons-collections4

2018-10-15 Thread Maxim Solodovnik
Hello Gary, SNAPSHOT works for us expected :) There is no rush, I just want to get some ETA :) On Tue, 16 Oct 2018 at 00:07, Gary Gregory wrote: > Are there any open issues we want to address for 4.3 is the SNAPSHOT OK as > is? > > Gary > > On Mon, Oct 15, 2018 at 10:42 AM Maxim Solodovnik >

Re: Help with migrating one of OpenJPA classes to commons-collections4

2018-10-15 Thread Gary Gregory
Are there any open issues we want to address for 4.3 is the SNAPSHOT OK as is? Gary On Mon, Oct 15, 2018 at 10:42 AM Maxim Solodovnik wrote: > Hello Benedikt, > > I would like to remind you about 4.3 release :) > > On Tue, 25 Sep 2018 at 20:45, Maxim Solodovnik > wrote: > > > > Great, > > > >

Re: Help with migrating one of OpenJPA classes to commons-collections4

2018-10-15 Thread Maxim Solodovnik
Hello Benedikt, I would like to remind you about 4.3 release :) On Tue, 25 Sep 2018 at 20:45, Maxim Solodovnik wrote: > > Great, > > Thanks a million! > > On Tue, 25 Sep 2018 at 20:39, Benedikt Ritter wrote: >> >> Am Di., 25. Sep. 2018 um 15:36 Uhr schrieb Benedikt Ritter < >>

Re: Help with migrating one of OpenJPA classes to commons-collections4

2018-09-25 Thread Benedikt Ritter
Am Di., 25. Sep. 2018 um 15:36 Uhr schrieb Benedikt Ritter < brit...@apache.org>: > Hello Maxim, > Am Mo., 24. Sep. 2018 um 05:32 Uhr schrieb Maxim Solodovnik < > solomax...@gmail.com>: > >> Hello, >> >> could you please create 4.3-SNAPSHOT build? >> > > I'll check whether I have permission to

Re: Help with migrating one of OpenJPA classes to commons-collections4

2018-09-25 Thread Benedikt Ritter
Hello Maxim, Am Mo., 24. Sep. 2018 um 05:32 Uhr schrieb Maxim Solodovnik < solomax...@gmail.com>: > Hello, > > could you please create 4.3-SNAPSHOT build? > I'll check whether I have permission to publish a SNAPSHOT build to the SNAPSHOT repo. > > And if you have any estimates on 4.3 release,

Re: Help with migrating one of OpenJPA classes to commons-collections4

2018-09-23 Thread Maxim Solodovnik
Hello, could you please create 4.3-SNAPSHOT build? And if you have any estimates on 4.3 release, could you please share it? :) On Thu, 20 Sep 2018 at 17:58, Maxim Solodovnik wrote: > One more question: it seems there is no 4.3-SNAPSHOT build available > Could you please create it? > > On

Re: Help with migrating one of OpenJPA classes to commons-collections4

2018-09-20 Thread Maxim Solodovnik
One more question: it seems there is no 4.3-SNAPSHOT build available Could you please create it? On Thu, 20 Sep 2018 at 12:47, Maxim Solodovnik wrote: > > Hello Gary, > > I have tested changes, everything works as expected > Thanks a lot! > > I have closed PR, but have no rights to close JIRA :(

Re: Help with migrating one of OpenJPA classes to commons-collections4

2018-09-19 Thread Maxim Solodovnik
Hello Gary, I have tested changes, everything works as expected Thanks a lot! I have closed PR, but have no rights to close JIRA :( Do you have any plans for 4.3 release? On Wed, 19 Sep 2018 at 22:11, Gary Gregory wrote: > > Maxim, > Thank you for your patch. > I created

Re: Help with migrating one of OpenJPA classes to commons-collections4

2018-09-19 Thread Gary Gregory
Maxim, Thank you for your patch. I created https://issues.apache.org/jira/browse/COLLECTIONS-696 and committed you patch to git master. Please verify and close the Jira ticket and GitHub PR. Thank you, Gary On Wed, Sep 19, 2018 at 1:24 AM Maxim Solodovnik wrote: > Done:

Re: Help with migrating one of OpenJPA classes to commons-collections4

2018-09-19 Thread Maxim Solodovnik
Done: https://github.com/apache/commons-collections/pull/51 Could you please take a look at this PR? On Thu, 6 Sep 2018 at 03:17, Gary Gregory wrote: > > Hi, > > Your best shot would be to submit a PR on GitHub which includes a unit test > that exercises the new code. > >

Re: Help with migrating one of OpenJPA classes to commons-collections4

2018-09-05 Thread Gary Gregory
Hi, Your best shot would be to submit a PR on GitHub which includes a unit test that exercises the new code. https://github.com/apache/commons-collections Thank you, Gary On Wed, Sep 5, 2018 at 10:12 AM Maxim Solodovnik wrote: > Would it be possible to modify the code of

Re: Help with migrating one of OpenJPA classes to commons-collections4

2018-09-05 Thread Maxim Solodovnik
Would it be possible to modify the code of AbstractReferenceMap.java as follows? diff --git a/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java b/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java index 0eda632f..81f60b4b 100644 ---

Re: Help with migrating one of OpenJPA classes to commons-collections4

2018-09-03 Thread Maxim Solodovnik
Thanks a lot for the answer, OpenJPA ReferenceHashMap overrides purge method to be able to call custom methods keyExpired/valueExpired [1] I see no way to migrate this code without massive copy/paste or reflection ... Maybe you can suggest something? Or maybe commons-collections API can be

Re: Help with migrating one of OpenJPA classes to commons-collections4

2018-09-03 Thread Julio Oliveira
What is realy your problem??.. On Sat, Sep 1, 2018, 5:46 AM Maxim Solodovnik wrote: > Hello, > > I'm trying to migrate code of Apache OpenJPA from commons-collections > to commons-collections4 > > The only real issue so far with migrating this class > >

[collections] Help with migrating one of OpenJPA classes to commons-collections4

2018-09-02 Thread Maxim Solodovnik
Correct prefix is added to subject On Sat, Sep 1, 2018 at 3:45 PM Maxim Solodovnik wrote: > > Hello, > > I'm trying to migrate code of Apache OpenJPA from commons-collections > to commons-collections4 > > The only real issue so far with migrating this class >

Help with migrating one of OpenJPA classes to commons-collections4

2018-09-01 Thread Maxim Solodovnik
Hello, I'm trying to migrate code of Apache OpenJPA from commons-collections to commons-collections4 The only real issue so far with migrating this class https://github.com/apache/openjpa/blob/trunk/openjpa-lib/src/main/java/org/apache/openjpa/lib/util/ReferenceHashMap.java#L112 code of