[uml-devel] Remove l1-shift from the patchset

2006-01-19 Thread Blaisorblade
Again, please, remove the l1-shift patch from the patchset. All these three options are already set by arch/i386/Kconfig.cpu which we include (and with more accurate values). Simply, Kconfig doesn't warn for duplicated symbols, it chooses either one.

Re: [uml-devel] [PATCH 8/8] uml: avoid CONFIG_NR_CPUS undeclared bogus error messages

2006-01-19 Thread Blaisorblade
On Thursday 19 January 2006 05:21, Jeff Dike wrote: On Thu, Jan 19, 2006 at 12:55:23AM +0100, Paolo 'Blaisorblade' Giarrusso wrote: -extern struct task_struct *idle_threads[NR_CPUS]; - BTW, this isn't the only problem there. There are three declarations towards the bottom with struct

Re: [uml-devel] [PATCH 8/8] uml: avoid CONFIG_NR_CPUS undeclared bogus error messages

2006-01-19 Thread Jeff Dike
On Thu, Jan 19, 2006 at 04:01:28PM +0100, Blaisorblade wrote: Gerd Knorr in his tty patch, instead, used forward declarations, like: struct task_struct; what about that? I don't think so. At least when you use void *, you are using a type that's not incorrect. In userspace code, those