Re: [uml-user] [PATCH 1/1] um: ubd: Fix data corruption

2010-10-05 Thread Tejun Heo
On 10/04/2010 09:51 PM, Chris Frey wrote: On Mon, Oct 04, 2010 at 06:37:36PM +0200, Tejun Heo wrote: Hello, sorry about chiming in later. I was off last week. No problem, I'm eager to test patches to fix this. I think we're on the right track. The problem with Jens' patch

Re: [uml-user] [PATCH 1/1] um: ubd: Fix data corruption

2010-10-05 Thread Tejun Heo
Hello, sorry about chiming in later. I was off last week. On 09/29/2010 08:34 AM, Chris Frey wrote: On Wed, Sep 29, 2010 at 02:21:07PM +0900, Jens Axboe wrote: This seems to imply that the original commit pin pointed is not the only issue we have in that code atm. I think we need to find

[uml-user] [PATCH v2.6.36-rc7] ubd: fix incorrect sector handling during request restart

2010-10-15 Thread Tejun Heo
, so it's difficult to tell where blk_rq_pos(req) currently is. Add ubd-rq_pos to keep track of the issue position and use it to correctly restart io_req issue. Signed-off-by: Tejun Heo t...@kernel.org Reported-by: Richard Weinberger rich...@nod.at Tested-by: Richard Weinberger rich...@nod.at

Re: [uml-user] [PATCH 1/1] um: ubd: Fix data corruption

2010-10-15 Thread Tejun Heo
Hello, On 10/14/2010 04:20 PM, richard -rw- weinberger wrote: It does not work for me. But the error is a different one. :-) Without your patch I've never got this kernel trace. [ 59.85] kworker/0:1: page allocation failure. order:0, mode:0x20 Hmm... you're seeing out of memory

Re: [uml-user] [PATCH 1/1] um: ubd: Fix data corruption

2010-10-15 Thread Tejun Heo
Hello, Can you please try this one then? It seems to work here but I can't reproduce the original problem reliably so I'm not really sure. Thanks. diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drivers/ubd_kern.c index 1bcd208..9734994 100644 --- a/arch/um/drivers/ubd_kern.c +++

Re: [uml-devel] [PATCH] uml: Fix build breakage after slab.h changes

2010-04-18 Thread Tejun Heo
Hello, On 04/19/2010 01:37 AM, Jan Kiszka wrote: We now have to to include linux/slab.h explicitly for kmalloc friends. Files that build against host headers already get their prototypes via um_malloc.h, linux/slab.h may even be unavailable. Hmmm... my test um build was okay but I don't know

Re: [uml-devel] [PATCH] uml: Fix build breakage after slab.h changes

2010-04-19 Thread Tejun Heo
On 04/19/2010 04:35 PM, Jan Kiszka wrote: Good question. Does such a tree exist? I'm sitting on a few more um cleanups fixes, and so far I'm working against Linus' tree as I failed to find anything more recent. Well, in that case, I'll route this one through percpu. Thanks. -- tejun

Re: [uml-devel] [PATCH] uml: Fix build breakage after slab.h changes

2010-04-19 Thread Tejun Heo
On 04/19/2010 01:37 AM, Jan Kiszka wrote: We now have to to include linux/slab.h explicitly for kmalloc friends. Files that build against host headers already get their prototypes via um_malloc.h, linux/slab.h may even be unavailable. Signed-off-by: Jan Kiszka jan.kis...@web.de applied to

Re: [uml-devel] [PATCH 1/1] um: ubd: Fix data corruption

2010-10-05 Thread Tejun Heo
Hello, sorry about chiming in later. I was off last week. On 09/29/2010 08:34 AM, Chris Frey wrote: On Wed, Sep 29, 2010 at 02:21:07PM +0900, Jens Axboe wrote: This seems to imply that the original commit pin pointed is not the only issue we have in that code atm. I think we need to find

Re: [uml-devel] [PATCH 1/1] um: ubd: Fix data corruption

2010-10-05 Thread Tejun Heo
On 10/04/2010 09:51 PM, Chris Frey wrote: On Mon, Oct 04, 2010 at 06:37:36PM +0200, Tejun Heo wrote: Hello, sorry about chiming in later. I was off last week. No problem, I'm eager to test patches to fix this. I think we're on the right track. The problem with Jens' patch

Re: [uml-devel] [PATCH 1/1] um: ubd: Fix data corruption

2010-10-15 Thread Tejun Heo
Hello, Can you please try this one then? It seems to work here but I can't reproduce the original problem reliably so I'm not really sure. Thanks. diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drivers/ubd_kern.c index 1bcd208..9734994 100644 --- a/arch/um/drivers/ubd_kern.c +++

Re: [uml-devel] [PATCH 1/1] um: ubd: Fix data corruption

2010-10-15 Thread Tejun Heo
Hello, On 10/14/2010 04:20 PM, richard -rw- weinberger wrote: It does not work for me. But the error is a different one. :-) Without your patch I've never got this kernel trace. [ 59.85] kworker/0:1: page allocation failure. order:0, mode:0x20 Hmm... you're seeing out of memory

[uml-devel] [PATCH v2.6.36-rc7] ubd: fix incorrect sector handling during request restart

2010-10-15 Thread Tejun Heo
, so it's difficult to tell where blk_rq_pos(req) currently is. Add ubd-rq_pos to keep track of the issue position and use it to correctly restart io_req issue. Signed-off-by: Tejun Heo t...@kernel.org Reported-by: Richard Weinberger rich...@nod.at Tested-by: Richard Weinberger rich...@nod.at

[uml-devel] [RFC PATCH] percpu: always align percpu output section to PAGE_SIZE

2010-10-27 Thread Tejun Heo
raises the alignment of percpu area. As the area is in .init, there shouldn't be any noticeable difference. This problem was discovered by David Howells while debugging boot failure on mn10300. Signed-off-by: Tejun Heo t...@kernel.org Cc: Mike Frysinger vap...@gentoo.org Cc: uclinux-dist-de

Re: [uml-devel] um: this_cpu_cmpxchg16b_emu

2011-04-12 Thread Tejun Heo
On Tue, Apr 12, 2011 at 08:41:11PM +0200, Richard Weinberger wrote: Am Dienstag 12 April 2011, 20:10:37 schrieb Christoph Lameter: On Tue, 12 Apr 2011, Richard Weinberger wrote: This patch implements this_cpu_cmpxchg16b_emu() for UML. Is this really necessary? Just undefine

Re: [uml-devel] [PATCH] print_worker_info: Handle pointer with more care

2013-08-16 Thread Tejun Heo
On Fri, Aug 16, 2013 at 06:15:07PM +0200, Richard Weinberger wrote: On UML I hit the case that pwq is NULL. Then we oops at pwq-wq... Hmmm? I'm confused. pwq-wq is pwq's pointer + wq's offset in pwq. It doesn't involve dereferencing pwq-wq. Maybe uml isn't implementing probe_kernel_thread()?

Re: [uml-devel] [PATCH] print_worker_info: Handle pointer with more care

2013-08-16 Thread Tejun Heo
Hello, On Fri, Aug 16, 2013 at 06:38:58PM +0200, Richard Weinberger wrote: cc'ing uml people. Hey, guys, workqueue uses proble_kernel_read() to print out workqueue related information during oops because those events are completely asynchronous and workqueue states may not be

Re: [uml-devel] [PATCH] Free percpu allocation info for uniprocessor system

2014-08-16 Thread Tejun Heo
On Tue, Aug 12, 2014 at 09:36:15PM +0800, Honggang Li wrote: Currently, only SMP system free the percpu allocation info. Uniprocessor system should free it too. For example, one x86 UML virtual machine with 256MB memory, UML kernel wastes one page memory. Signed-off-by: Honggang Li