Re: cookie configurations for Tomcat 7

2020-03-31 Thread Lazar Kirchev
Chris, Did you managed to check the PR? Lazar On Tue, Mar 10, 2020 at 5:41 PM Lazar Kirchev wrote: > Chris, > > Any update on this? Did you have a chance to have a look on the PR? > > Lazar > > On Wed, Mar 4, 2020 at 10:55 AM Lazar Kirchev > wrote: > >> Ch

Re: cookie configurations for Tomcat 7

2020-03-10 Thread Lazar Kirchev
Chris, Any update on this? Did you have a chance to have a look on the PR? Lazar On Wed, Mar 4, 2020 at 10:55 AM Lazar Kirchev wrote: > Chris, Martin, > > Here is the PR: https://github.com/apache/tomcat/pull/252 > > Lazar > > On Sat, Feb 29, 2020 at 8:27 AM Mar

Re: cookie configurations for Tomcat 7

2020-03-04 Thread Lazar Kirchev
Chris, Martin, Here is the PR: https://github.com/apache/tomcat/pull/252 Lazar On Sat, Feb 29, 2020 at 8:27 AM Martin Grigorov wrote: > On Fri, Feb 28, 2020 at 7:31 PM Lazar Kirchev > wrote: > > > Chris, > > > > I just thought that I have some concerns pas

Re: cookie configurations for Tomcat 7

2020-02-28 Thread Lazar Kirchev
it needs - from the Response. What do you think? Lazar On Fri, Feb 28, 2020, 17:08 Lazar Kirchev wrote: > > Chris, > > Actually in my preferred option the implementation in the > CookieProcessorBase should not be no-op, but it should call > CookieProcessor.generateCookie(Cook

Re: cookie configurations for Tomcat 7

2020-02-28 Thread Lazar Kirchev
be replaced with calls to the new method. Lazar On Fri, Feb 28, 2020 at 3:58 PM Lazar Kirchev wrote: > Chris, > > Yes, I will prepare a PR in the next days. However, as Tomcat 8.5 should > be able to work both on Java 7 and Java 8, interface default methods can't > be used. So w

Re: cookie configurations for Tomcat 7

2020-02-28 Thread Lazar Kirchev
z < ch...@christopherschultz.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Lazar, > > On 2/24/20 02:05, Lazar Kirchev wrote: > > Chris, > > > > CookieProcessor.generateCookie(Map<> requestHeaders, Cookie) will > > work perfectly for

Re: cookie configurations for Tomcat 7

2020-02-23 Thread Lazar Kirchev
EGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Lazar, > > On 2/21/20 10:29, Lazar Kirchev wrote: > > Yes, the SameSite attribute is still in a draft and this causes > > the mess, at least partly.> And yes, I was thinking about something > > like that - CookiePr

Re: cookie configurations for Tomcat 7

2020-02-21 Thread Lazar Kirchev
topher Schultz < ch...@christopherschultz.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Lazar, > > On 2/14/20 05:36, Lazar Kirchev wrote: > > Chris, > > > > Just FYI or in case someone else hits this problem. > > > > Ac

Re: cookie configurations for Tomcat 7

2020-02-14 Thread Lazar Kirchev
such flexibility, only the response wrapper helps. Do you think that it makes sense to provide a mechanism in the CookieProcessor to get access to the request headers in order to check the user agent? Kind regards, Lazar On Tue, Feb 4, 2020 at 5:54 PM Lazar Kirchev wrote: > Thanks a lot Chris! I wish I co

Re: cookie configurations for Tomcat 7

2020-02-04 Thread Lazar Kirchev
56 > > Lazar, > > On 2/3/20 5:42 AM, Lazar Kirchev wrote: > > Chris, > > > > With "having control on the server but not on the application" I > > meant that I could make changes on the server, but I have no > > control to make modification on the a

Re: cookie configurations for Tomcat 7

2020-02-03 Thread Lazar Kirchev
d as a configuration to the CookieProcessor implementation. Is it possible to achieve this reliably in Tomcat 7? Lazar On Fri, Jan 31, 2020 at 6:03 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Lazar, > &

Re: cookie configurations for Tomcat 7

2020-01-30 Thread Lazar Kirchev
nsidered odd, you should encode it in a > safe way that doesn't require that you play other games with the > cookie value. > > For example, base64 encoding a cookie value should make it > header-safe, as long as you make sure to use a base64 encoder that > doesn't add newlines. >

cookie configurations for Tomcat 7

2020-01-27 Thread Lazar Kirchev
Hello, In Tomcat >= 8 there is the CookieProcessor in which cookie configurations could be made, including for SameSite cookie. Is there any way to configure this in Tomcat 7? Or the only way is to configure it manually in code? Kind regards, Lazar

Re: Fix for DBCP-518

2019-05-08 Thread Lazar Kirchev
Great, thanks a lot Mark! On Fri, May 3, 2019 at 9:42 PM Mark Thomas wrote: > On 26/04/2019 17:27, Mark Thomas wrote: > > On 24/04/2019 16:28, Lazar Kirchev wrote: > >> Hello, > >> > >> Any update on this? > > > > No specific plans but I can do an

Re: Fix for DBCP-518

2019-04-24 Thread Lazar Kirchev
Hello, Any update on this? Regards, Lazar On Tue, Apr 16, 2019 at 4:28 PM Lazar Kirchev wrote: > Hello, > > Do you have any plans to get the fix for > https://issues.apache.org/jira/browse/DBCP-518 in the Tomcat 8.5 clone of > the Commons DBCP? > The commits with t

Fix for DBCP-518

2019-04-16 Thread Lazar Kirchev
Hello, Do you have any plans to get the fix for https://issues.apache.org/jira/browse/DBCP-518 in the Tomcat 8.5 clone of the Commons DBCP? The commits with the fix are https://github.com/apache/commons-dbcp/commit/81aea944160608838cb2d7cdfb0d9b6893a655d9,

Re: Supported callbacks in Tomcat JASPIC implementation

2017-11-21 Thread Lazar Kirchev
ch...@christopherschultz.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Mark and Lazar, > > On 11/18/17 10:05 AM, Mark Thomas wrote: > > On 18/11/17 14:20, Lazar Kirchev wrote: > >> Hello Marc, > >> > >> Do you think it makes sense to make t

Re: Supported callbacks in Tomcat JASPIC implementation

2017-11-20 Thread Lazar Kirchev
> Do you think it makes sense to make the CallbackHandler implementation > > class configurable, e.g. to be able to specify its name via a property? > > As a property on the authenticator? I don't see why not. Yes, something like that: https://github.com/apache/tomcat/pull/93 > > In > > this

Re: Supported callbacks in Tomcat JASPIC implementation

2017-11-18 Thread Lazar Kirchev
://bz.apache.org/bugzilla/show_bug.cgi?id=61784 All fixes are really very small. Regards, Lazar On Wed, Nov 8, 2017 at 5:51 PM, Lazar Kirchev <lazar.kirc...@gmail.com> wrote: > Yes, my mistake - 3.5, not 4.5. But the content is the same. > > Thanks Mark! > > On Wed, Nov 8,

Re: Supported callbacks in Tomcat JASPIC implementation

2017-11-08 Thread Lazar Kirchev
Yes, my mistake - 3.5, not 4.5. But the content is the same. Thanks Mark! On Wed, Nov 8, 2017 at 5:38 PM, Mark Thomas <ma...@apache.org> wrote: > On 08/11/2017 12:00, Lazar Kirchev wrote: > > Hello, > > > > According to the JASSPIC spec version 1.1, chapter 4.5, The &

Supported callbacks in Tomcat JASPIC implementation

2017-11-08 Thread Lazar Kirchev
Hello, According to the JASSPIC spec version 1.1, chapter 4.5, The CallbackHandler should support CallerPrincipalCallback, GroupPrincipalCallback, PasswordValidationCallback, as well as CertStoreCallback, PrivateKeyCallback, SecretKeyCallback and TrustStoreCallback. However, in Tomcat 8.5.*

Re: Default response charset

2017-10-25 Thread Lazar Kirchev
Thanks a lot Mark! On Wed, Oct 25, 2017 at 12:51 PM, Mark Thomas <ma...@apache.org> wrote: > On 25/10/17 10:23, Mark Thomas wrote: > > On 24/10/17 07:36, Lazar Kirchev wrote: > >> Hello, > >> > >> Change http://svn.apache.org/viewvc?view=revisio

Default response charset

2017-10-24 Thread Lazar Kirchev
Hello, Change http://svn.apache.org/viewvc?view=revision=1801052 tries, in case no charset is specified for the response, to determine a default one based on the content language if such is present. For en and fr languages the ISO-8859-1 charset is used as default. However, this is done for all

Tomcat 8 slow shutdown on Windows 10

2017-07-27 Thread Lazar Kirchev
Hello, I am observing slow shutdown of Tomcat 8 on Windows 10 - some 9 - 11 seconds. I observed this first with Tomcat 8.5.16, but then checked it on older versions and I found the same from 8.5.11 onward. Before that it stops for less than a second. Most time is spent in stopping the protocol

Re: Issue when the Content-Type request header specifies invalid charset

2017-07-07 Thread Lazar Kirchev
Thanks Mark, Here is the issue: https://bz.apache.org/bugzilla/show_bug.cgi?id=61264 Lazar On Fri, Jul 7, 2017 at 11:22 AM, Mark Thomas <ma...@apache.org> wrote: > On 07/07/17 08:44, Lazar Kirchev wrote: > > Hello, > > > > Prior to Tomcat 8.5.15 if the Content-Ty

Issue when the Content-Type request header specifies invalid charset

2017-07-07 Thread Lazar Kirchev
Hello, Prior to Tomcat 8.5.15 if the Content-Type request header specifies an invalid charset, then the HttpServletRequest.getReader() throws a UnsupportedEncodingException (from its javadoc:it should throw such an exception if the character set encoding used is not supported and the text cannot

Re: Jsp character encoding configuration

2017-02-23 Thread Lazar Kirchev
Thanks Mark! Here it is: https://bz.apache.org/bugzilla/show_bug.cgi?id=60769 On Tue, Feb 21, 2017 at 9:49 PM, Mark Thomas <ma...@apache.org> wrote: > On 18/02/2017 16:32, Lazar Kirchev wrote: > > I noticed something else strange. If in an jspx file I declare one and > > the

Re: Jsp character encoding configuration

2017-02-18 Thread Lazar Kirchev
from that specified in page directive (WINDOWS-1252)", while on older Tomcat 8.5 I get no error and the page is displayed. I attach the sample1.war with this jspx file. Kind regards, Lazar On Sat, Feb 18, 2017 at 4:48 PM, Lazar Kirchev <lazar.kirc...@gmail.com> wrote: > Hello, > >

Jsp character encoding configuration

2017-02-18 Thread Lazar Kirchev
Hello, According to the JSP 2.3 spec, section 3.3.4 (Declaring page encodings): "It is also a translation-time error to name different encodings in the prolog / text declaration of the document in XML syntax and in a JSP configuration element matching the document. It is legal to name the same

Configuring certificate for ssl support on Tomcat 8.5

2016-08-31 Thread Lazar Kirchev
Hello, According to Tomcat 8.5 documentation [1] when JSSE is used if the key alias is not specified through the attribute certificateKeyAlias of Certificate entry, then "... the first key read from the keystore will be used...". However, when the property is not specified Tomcat tries to use a

Re: Increased memory consumption due to url encoding

2016-08-10 Thread Lazar Kirchev
. Regards, Lazar On Tue, Aug 9, 2016 at 7:27 PM, Christopher Schultz < ch...@christopherschultz.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Lazar, > > On 8/9/16 8:40 AM, Lazar Kirchev wrote: > > Hello! When handling requests which make use of

Increased memory consumption due to url encoding

2016-08-09 Thread Lazar Kirchev
Hello! When handling requests which make use of request dispatcher, Tomcat 7.0.70 allocates more memory in comparison to 7.0.69. This seems to come from the encoding of the path introduced with this change http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/

Using ServletContainerInitializer for 2.5 applications

2012-04-11 Thread Lazar Kirchev
Hello, In servlet 3.0 specification ServletContainerInitilizer class is defined to allow programatic addition of servlet/filters/listeners. I am using a ServletContextInitializer to add a ServletContextListener to the ServletContext. I use Tomcat 7.0.25. This works fine if the web.xml major

Re: Using ServletContainerInitializer for 2.5 applications

2012-04-11 Thread Lazar Kirchev
I want the ServletContainerInitializer to be called for all applications I deploy, not only with web.xml version 3.0, but also with lower version. Is this possible? On Wed, Apr 11, 2012 at 3:17 PM, Mikolaj Rydzewski m...@ceti.pl wrote: On 11.04.2012 14:10, Lazar Kirchev wrote: In servlet 3.0

Re: Using ServletContainerInitializer for 2.5 applications

2012-04-11 Thread Lazar Kirchev
On Wed, Apr 11, 2012 at 3:54 PM, Caldarale, Charles R chuck.caldar...@unisys.com wrote: From: Lazar Kirchev [mailto:lazar.kirc...@gmail.com] Subject: Re: Using ServletContainerInitializer for 2.5 applications I want the ServletContainerInitializer to be called for all applications I