Re: Passing client certificate through Nginx to Tomcat SSL Valve

2017-06-05 Thread Mark Thomas
On 29/05/17 16:05, Christopher Schultz wrote: > Lucas, > > On 5/27/17 9:41 AM, Lucas Ventura Carro wrote: >>> On 23/06/2016 12:58, Mark Thomas wrote: Smarter sounds good to >>> me. Why not try and write a patch for this? > >> I work faster with github pull-requests :) >>

Re: Passing client certificate through Nginx to Tomcat SSL Valve

2017-05-29 Thread Mark Thomas
On 29/05/17 17:02, Christopher Schultz wrote: > Mark, > > On 5/29/17 11:40 AM, Christopher Schultz wrote: >> Mark, > >> On 6/23/16 7:58 AM, Mark Thomas wrote: >>> On a related topic, I wonder how tolerant >>> CertificateFactory.generateCertificate() is since that will have >>> an impact on

Re: Passing client certificate through Nginx to Tomcat SSL Valve

2017-05-29 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 5/29/17 11:40 AM, Christopher Schultz wrote: > Mark, > > On 6/23/16 7:58 AM, Mark Thomas wrote: >> On a related topic, I wonder how tolerant >> CertificateFactory.generateCertificate() is since that will have >> an impact on exactly how

Re: Passing client certificate through Nginx to Tomcat SSL Valve

2017-05-29 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 6/23/16 7:58 AM, Mark Thomas wrote: > On a related topic, I wonder how tolerant > CertificateFactory.generateCertificate() is since that will have > an impact on exactly how smart the SSLValve needs to be. Tested with Oracle Java

Re: Passing client certificate through Nginx to Tomcat SSL Valve

2017-05-29 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Lucas, On 5/27/17 9:41 AM, Lucas Ventura Carro wrote: >> On 23/06/2016 12:58, Mark Thomas wrote: Smarter sounds good to >> me. Why not try and write a patch for this? > > I work faster with github pull-requests :) >

Re: Passing client certificate through Nginx to Tomcat SSL Valve

2017-05-27 Thread Lucas Ventura Carro
> On 23/06/2016 12:58, Mark Thomas wrote: > Smarter sounds good to me. Why not try and write a patch for this? I work faster with github pull-requests :) https://github.com/apache/tomcat80/pull/8 > On a related topic, I wonder how tolerant > CertificateFactory.generateCertificate() is since that

Re: Passing client certificate through Nginx to Tomcat SSL Valve

2016-06-23 Thread Mark Thomas
On 23/06/2016 12:51, Lucas Ventura Carro wrote: > And here comes the incompatibility: Nginx replaces new lines with tab > characters, but the valve only try to change white spaces. > Should not be the SSL Valve smarter and try to replace one or multiple > whitespaces (the regex '\s+')? Or at