Re: getRequestURI() in relation to Connector.URIEncoding

2013-02-18 Thread Rainer Jung
On 17.02.2013 23:00, Mike Wilson wrote: Mark Thomas wrote: On 17/02/2013 16:54, André Warnier wrote: Mike Wilson wrote: snip/ Example 2: path /ä in binary Unicode GET /.. [0xC3,0xA4] request.getRequestURI() - /.. [0xC3,0xA4] request.getPathInfo() - /ä snip/ I believe that

Re: getRequestURI() in relation to Connector.URIEncoding

2013-02-18 Thread Rainer Jung
On 17.02.2013 23:57, André Warnier wrote: Mike Wilson wrote: Mark Thomas wrote: On 17/02/2013 16:54, André Warnier wrote: Mike Wilson wrote: snip/ Example 2: path /ä in binary Unicode GET /.. [0xC3,0xA4] request.getRequestURI() - /.. [0xC3,0xA4] request.getPathInfo() - /ä snip/

Re: getRequestURI() in relation to Connector.URIEncoding

2013-02-18 Thread Mark Thomas
On 18/02/2013 09:54, Rainer Jung wrote: On 17.02.2013 23:57, André Warnier wrote: Otherwise, my feeling is that it will cost you quite a number of beers to stop Mark from fixing what could potentially be a security issue, now that he's sniffed it. :) Not sure whether Mark's sniffing

Re: getRequestURI() in relation to Connector.URIEncoding

2013-02-18 Thread André Warnier
Mark Thomas wrote: On 18/02/2013 09:54, Rainer Jung wrote: On 17.02.2013 23:57, André Warnier wrote: Otherwise, my feeling is that it will cost you quite a number of beers to stop Mark from fixing what could potentially be a security issue, now that he's sniffed it. :) Not sure whether

Re: getRequestURI() in relation to Connector.URIEncoding

2013-02-18 Thread Mark Thomas
On 18/02/2013 11:44, André Warnier wrote: Mark Thomas wrote: On 18/02/2013 09:54, Rainer Jung wrote: On 17.02.2013 23:57, André Warnier wrote: Otherwise, my feeling is that it will cost you quite a number of beers to stop Mark from fixing what could potentially be a security issue, now

RE: getRequestURI() in relation to Connector.URIEncoding

2013-02-18 Thread Mike Wilson
[multiple inline responses] Rainer Jung wrote: I doubt that such URLs are invalid - not based on any code inspection, but simply on the fact that mod_jk decoded percent encoding before forwarding for a long time (5.5 years, from Oct. 2001 to May 2007, version 1.2.0 to 1.2.22). Since version

RE: getRequestURI() in relation to Connector.URIEncoding

2013-02-17 Thread Mike Wilson
Hi Chris, I'm aware of the two levels of encoding but I'm wondering whether servlet specification writers were :-) Here are two examples from Tomcat 7 running with URIEncoding=UTF-8. Example 1: path /ä in URL-encoded Unicode as sent from browser GET /%C3%A4 request.getRequestURI() - /%C3%A4

Re: getRequestURI() in relation to Connector.URIEncoding

2013-02-17 Thread André Warnier
Mike Wilson wrote: Hi Chris, I'm aware of the two levels of encoding but I'm wondering whether servlet specification writers were :-) Here are two examples from Tomcat 7 running with URIEncoding=UTF-8. Example 1: path /ä in URL-encoded Unicode as sent from browser GET /%C3%A4

Re: getRequestURI() in relation to Connector.URIEncoding

2013-02-17 Thread Mark Thomas
On 17/02/2013 16:54, André Warnier wrote: Mike Wilson wrote: snip/ Example 2: path /ä in binary Unicode GET /.. [0xC3,0xA4] request.getRequestURI() - /.. [0xC3,0xA4] request.getPathInfo() - /ä snip/ I believe that your example #2 above is simply illegal. One is not supposed to

Re: [OT] getRequestURI() in relation to Connector.URIEncoding

2013-02-17 Thread André Warnier
Mike Wilson wrote: ... Example 2: path /ä in binary Unicode GET /.. [0xC3,0xA4] To nitpick : this is not binary Unicode. It is simply non-URL-encoded, raw UTF-8, which is itself an encoding of Unicode. The Unicode codepoint of ä is 0xE4 (decimal 228), usually represented as U+00E4.

RE: getRequestURI() in relation to Connector.URIEncoding

2013-02-17 Thread Mike Wilson
Mark Thomas wrote: On 17/02/2013 16:54, André Warnier wrote: Mike Wilson wrote: snip/ Example 2: path /ä in binary Unicode GET /.. [0xC3,0xA4] request.getRequestURI() - /.. [0xC3,0xA4] request.getPathInfo() - /ä snip/ I believe that your example #2 above is simply

Re: getRequestURI() in relation to Connector.URIEncoding

2013-02-17 Thread André Warnier
Mike Wilson wrote: Mark Thomas wrote: On 17/02/2013 16:54, André Warnier wrote: Mike Wilson wrote: snip/ Example 2: path /ä in binary Unicode GET /.. [0xC3,0xA4] request.getRequestURI() - /.. [0xC3,0xA4] request.getPathInfo() - /ä snip/ I believe that your example #2 above is

Re: getRequestURI() in relation to Connector.URIEncoding

2013-02-14 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mike, On 2/14/13 9:51 AM, Mike Wilson wrote: I can see that even if you specify URIEncoding=UTF-8 in server.xml, calls to HttpServletRequest.getRequestURI() will still return an undecoded String. (This is probably because of the specification