subject:"Re\: \[vchkpw\] \[SPAM\] valias remove alias"

Re: [vchkpw] [SPAM] valias remove alias

2015-09-18 Thread Drew Wells


On 09/17/2015 04:55 PM, Matt Brookings wrote:

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 09/17/2015 10:52 AM, Drew Wells wrote:

I basically did a diff from 5.4.29 to 5.4.33 and implemented that diff to 
5.5.0, some of it
had already been done to 5.5.0 and alot of it centered around the snprintf tidy 
up's and the
string_list implementation. The attached patch does not include any of the 
changes I
recently sent to the mailing list, just the changes from 5.4.[29->33].

This patch was generated from the 5.5.0 .tar.bz2, I had a look at SVN trunk and 
from what I could
see, it was 5.4.34.

The trunk on Sourceforge is the current 5.5.0.  The 5.4 series only appears in 
the tags and branches
area now.  I'll look over this patch and get it applied.  Thanks for putting it 
together!

I've just noticed a tiny problem with the previous patch I sent, so here 
is an updated version, this version also includes the missing '#include 
"pwstr.h"' in vadduser.c which causes a segfault on my dev environment 
so thought I should just include it.
The tiny problem was "string_list *aliases" instead of "string_list 
aliases" in vadddomain() in vpopmail.c.



!DSPAM:55fbf97841551215118515!
diff -uPr vpopmail-5.5.0.orig/backends/mysql/vmysql.c 
vpopmail-5.5.0/backends/mysql/vmysql.c
--- vpopmail-5.5.0.orig/backends/mysql/vmysql.c 2010-11-05 18:37:23.0 
+
+++ vpopmail-5.5.0/backends/mysql/vmysql.c  2015-09-18 12:36:07.561092988 
+0100
@@ -1785,10 +1785,10 @@
 limits->maxforwards = atoi(row[2]);
 limits->maxautoresponders = atoi(row[3]);
 limits->maxmailinglists = atoi(row[4]);
-limits->diskquota = atoi(row[5]);
-limits->maxmsgcount = atoi(row[6]);
-limits->defaultquota = atoi(row[7]);
-limits->defaultmaxmsgcount = atoi(row[8]);
+limits->diskquota = strtoll(row[5], NULL, 10);
+limits->maxmsgcount = strtoll(row[6], NULL, 10);
+limits->defaultquota = strtoll(row[7], NULL, 10);
+limits->defaultmaxmsgcount = strtoll(row[8], NULL, 10);
 limits->disable_pop = atoi(row[9]);
 limits->disable_imap = atoi(row[10]);
 limits->disable_dialup = atoi(row[11]);
@@ -1808,8 +1808,8 @@
 limits->perm_maillist_users = perm & VLIMIT_DISABLE_ALL;
 perm >>= VLIMIT_DISABLE_BITS;
 limits->perm_maillist_moderators = perm & VLIMIT_DISABLE_ALL;
-limits->perm_quota = atoi(row[23]);
-limits->perm_defaultquota = atoi(row[24]);
+limits->perm_quota = strtoll(row[23], NULL, 10);
+limits->perm_defaultquota = strtoll(row[24], NULL, 10);
 }
 mysql_free_result(res_read);
 
@@ -1830,7 +1830,7 @@
 "diskquota = %d, maxmsgcount = %d, defaultquota = %d, 
defaultmaxmsgcount = %d, "
 "disable_pop = %d, disable_imap = %d, disable_dialup = %d, "
 "disable_passwordchanging = %d, disable_webmail = %d, disable_relay = 
%d, "
-"disable_smtp = %d, disable_spamassassin = %d, delete_spam = %d, 
perm_account = %d, "
+"disable_smtp = %d, disable_spamassassin = %d, delete_spam = %d, 
disable_maildrop = %d, perm_account = %d, "
 "perm_alias = %d, perm_forward = %d, perm_autoresponder = %d, 
perm_maillist = %d, "
 "perm_quota = %d, perm_defaultquota = %d "
 "ON DUPLICATE KEY UPDATE "
@@ -1847,7 +1847,7 @@
 limits->diskquota, limits->maxmsgcount, limits->defaultquota, 
limits->defaultmaxmsgcount,
 limits->disable_pop, limits->disable_imap, limits->disable_dialup,
 limits->disable_passwordchanging, limits->disable_webmail, 
limits->disable_relay,
-limits->disable_smtp, limits->disable_spamassassin, 
limits->delete_spam, limits->perm_account,
+limits->disable_smtp, limits->disable_spamassassin, 
limits->delete_spam, limits->disable_maildrop, limits->perm_account,
 limits->perm_alias, limits->perm_forward, limits->perm_autoresponder,
 (limits->perm_maillist |
 (limits->perm_maillist_users << VLIMIT_DISABLE_BITS) |
diff -uPr vpopmail-5.5.0.orig/backends/mysql/vmysql.h.in 
vpopmail-5.5.0/backends/mysql/vmysql.h.in
--- vpopmail-5.5.0.orig/backends/mysql/vmysql.h.in  2010-11-05 
18:37:23.0 +
+++ vpopmail-5.5.0/backends/mysql/vmysql.h.in   2015-09-18 12:36:07.561092988 
+0100
@@ -268,10 +268,10 @@
   maxforwards  INT(10) NOT NULL DEFAULT -1, \
   maxautorespondersINT(10) NOT NULL DEFAULT -1, \
   maxmailinglists  INT(10) NOT NULL DEFAULT -1, \
-  diskquotaINT(12) NOT NULL DEFAULT 0, \
-  maxmsgcount  INT(12) NOT NULL DEFAULT 0, \
-  defaultquota INT(12) NOT NULL DEFAULT 0, \
-  defaultmaxmsgcount   INT(12) NOT NULL DEFAULT 0, \
+  diskquotaBIGINT UNSIGNED NOT NULL DEFAULT 0, \
+  maxmsgcount  BIGINT UNSIGNED NOT NULL DEFAULT 0, \
+  defaultquota BIGINT UNSIGNED NOT NULL DEFAULT 0, \
+

Re: [vchkpw] [SPAM] valias remove alias

2015-09-18 Thread Matt Brookings

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 09/18/2015 09:30 AM, Drew Wells wrote:
> On 09/18/2015 03:23 PM, Matt Brookings wrote:
>> -BEGIN PGP SIGNED MESSAGE- Hash: SHA1
>> 
>> Applies perfectly!  Thanks!
>> 
>> On 09/18/2015 09:21 AM, Drew Wells wrote:
>>> On 09/18/2015 02:47 PM, Matt Brookings wrote:
 -BEGIN PGP SIGNED MESSAGE- Hash: SHA1
 
 Drew, I know you've put a lot of effort into these patches, but they do 
 not succeed
 against the 5.5.0 trunk.  Patches should be made against the most recent 
 revision, which
 can be checked out via Subversion from Sourceforge.
 
 On 09/18/2015 08:11 AM, Drew Wells wrote:
> On 09/17/2015 04:55 PM, Matt Brookings wrote:
>> -BEGIN PGP SIGNED MESSAGE- Hash: SHA1
>> 
>> On 09/17/2015 10:52 AM, Drew Wells wrote:
> I basically did a diff from 5.4.29 to 5.4.33 and implemented that 
> diff to 5.5.0,
> some of it had already been done to 5.5.0 and alot of it centered 
> around the
> snprintf tidy up's and the string_list implementation. The attached 
> patch does
> not include any of the changes I recently sent to the mailing list, 
> just the
> changes from 5.4.[29->33].
>>> This patch was generated from the 5.5.0 .tar.bz2, I had a look at SVN 
>>> trunk and from
>>> what I could see, it was 5.4.34.
>> The trunk on Sourceforge is the current 5.5.0.  The 5.4 series only 
>> appears in the
>> tags and branches area now.  I'll look over this patch and get it 
>> applied.  Thanks for
>> putting it together!
>> 
> And lastly for now, someone has done a lot of work in tidying up/making 
> safe all the
> calls to snprintf(), the attached patch completes this work (I think).  
> This patch comes
> after the 5.4.[29->33] patch I did.
> 
> 
>>> Ok, have have downloaded a snapshot .zip file from Sourceforge 
>>> (vpopmail-code-1034.zip) and 
>>> applied the changes to that and attached the patch.  This is the 
>>> 5.4.[29-33] changes patch,
>>> I'll do the snprintf() one later.  Let me know if you need me to do 
>>> anything else with it.
>> 
> Not a problem do excuse my use of the 5.5.0 tar, I'll use SVN trunk from now 
> on.  Here is the 
> snprintf() patch for vpopmail-code-1034.zip.

No problem.  Thanks for your work!
- -- 
/*
Matt Brookings    GnuPG Key 62817373
Software developer Systems technician
Inter7 Internet Technologies, Inc. (815)776-9465
*/
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.22 (GNU/Linux)

iQEcBAEBAgAGBQJV/CJIAAoJEOjQVexigXNzUEQH+wV4Si57TawcIHdnggKhZpav
6Swf4CUPZIfLrM6chNkIrTnR2seb0W3qCIqmMdbo3nzUIfLzMw3ZOikCBKF6hoWq
zQUij+eXwTLWe8JbT4/c3fACBmq4BspJj7q4kIAeypu4hqdjDpxAxVvNmoYh3FCQ
CC3LX0E3PbPHp7mKgzXRQtVrnB9ePxTgu9ZR529BUpI4dwz2FXx+FgmcC/hvBFad
mOBh5vYgVfql0rGWmw/TkWLRNxJzR4ffHIYg7h1jJ6QSMrn/Px4pdGNmOzGIf+tV
asoUPWUIKLL1MlPeV/jviTw0Or7es6ZGbsd+pZl6TEkhowySGB72oexrVTDQXF4=
=ZHVf
-END PGP SIGNATURE-

Re: [vchkpw] [SPAM] valias remove alias

2015-09-18 Thread Matt Brookings

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Drew, I know you've put a lot of effort into these patches, but they do not 
succeed against the
5.5.0 trunk.  Patches should be made against the most recent revision, which 
can be checked out via
Subversion from Sourceforge.

On 09/18/2015 08:11 AM, Drew Wells wrote:
> On 09/17/2015 04:55 PM, Matt Brookings wrote:
>> -BEGIN PGP SIGNED MESSAGE- Hash: SHA1
>> 
>> On 09/17/2015 10:52 AM, Drew Wells wrote:
> I basically did a diff from 5.4.29 to 5.4.33 and implemented that diff to 
> 5.5.0, some of
> it had already been done to 5.5.0 and alot of it centered around the 
> snprintf tidy up's
> and the string_list implementation. The attached patch does not include 
> any of the
> changes I recently sent to the mailing list, just the changes from 
> 5.4.[29->33].
>>> This patch was generated from the 5.5.0 .tar.bz2, I had a look at SVN trunk 
>>> and from what I
>>> could see, it was 5.4.34.
>> The trunk on Sourceforge is the current 5.5.0.  The 5.4 series only appears 
>> in the tags and
>> branches area now.  I'll look over this patch and get it applied.  Thanks 
>> for putting it
>> together!
>> 
> And lastly for now, someone has done a lot of work in tidying up/making safe 
> all the calls to 
> snprintf(), the attached patch completes this work (I think).  This patch 
> comes after the
> 5.4.[29->33] patch I did.
> 
> 


- -- 
/*
Matt Brookings    GnuPG Key 62817373
Software developer Systems technician
Inter7 Internet Technologies, Inc. (815)776-9465
*/
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.22 (GNU/Linux)

iQEcBAEBAgAGBQJV/BXnAAoJEOjQVexigXNzPxkH/jKWMcIwdkpN9xy8OhYHQGuF
+FwowoDJSsEpkJU6flSSWjYvpC0/NJeejzWLWHW0bq7m0ulobpq4z4x4Q7lUlxId
nu7a4+v29qgDw3ccuyIpx+DmgF2DEqi7t/QZlTNeCJ4YzsMBkcUrJI8twoF+RTX/
/8aifV4/+J69V5GrKAMePRIRIaZicVd0NNgLrnaG096r8r7n02jH5G2PTPF0s6Vh
AVaSehh7sxTCBlm8sH08orxLRqRsLakvy3zlxogeLnipJxWLxgQQdkAL8GcfvPIz
LPlXovqegvNtEGrmsAwIP6mXansd0qqC0vTDpUz4ikHXso7ntKHRieHrT4lrevE=
=tzfn
-END PGP SIGNATURE-

Re: [vchkpw] [SPAM] valias remove alias

2015-09-18 Thread Drew Wells


On 09/17/2015 04:55 PM, Matt Brookings wrote:

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 09/17/2015 10:52 AM, Drew Wells wrote:

I basically did a diff from 5.4.29 to 5.4.33 and implemented that diff to 
5.5.0, some of it
had already been done to 5.5.0 and alot of it centered around the snprintf tidy 
up's and the
string_list implementation. The attached patch does not include any of the 
changes I
recently sent to the mailing list, just the changes from 5.4.[29->33].

This patch was generated from the 5.5.0 .tar.bz2, I had a look at SVN trunk and 
from what I could
see, it was 5.4.34.

The trunk on Sourceforge is the current 5.5.0.  The 5.4 series only appears in 
the tags and branches
area now.  I'll look over this patch and get it applied.  Thanks for putting it 
together!

And lastly for now, someone has done a lot of work in tidying up/making 
safe all the calls to snprintf(), the attached patch completes this work 
(I think).  This patch comes after the 5.4.[29->33] patch I did.



!DSPAM:55fc0d7341552094314991!
diff -uPr vpopmail-5.5.0.orig/vpopmaild.c vpopmail-5.5.0/vpopmaild.c
--- vpopmail-5.5.0.orig/vpopmaild.c 2015-09-18 13:58:22.048093642 +0100
+++ vpopmail-5.5.0/vpopmaild.c  2015-09-18 14:08:11.117095122 +0100
@@ -429,7 +429,7 @@
 return(-2);
   } 
 
-//  snprintf(WriteBuf,sizeof(WriteBuf), RET_OK_MORE);
+//  snprintf(WriteBuf,sizeof(WriteBuf), "%s", RET_OK_MORE);
 //  wait_write();
 
   AuthVpw.pw_name = strdup(tmpvpw->pw_name);
@@ -460,7 +460,7 @@
 logged_in = 1;
 
   if(output_type < 2 ) {
-snprintf(WriteBuf,sizeof(WriteBuf), RET_OK_MORE);
+snprintf(WriteBuf,sizeof(WriteBuf), "%s", RET_OK_MORE);
 wait_write();
 
 snprintf(WriteBuf,sizeof(WriteBuf), "vpopmail_dir_bin %s" RET_CRLF, 
VPOPMAIL_DIR_BIN);
@@ -485,10 +485,10 @@
 
 send_user_info();
 
-snprintf(WriteBuf, sizeof(WriteBuf), "." RET_CRLF);
+snprintf(WriteBuf, sizeof(WriteBuf), "%s", "." RET_CRLF);
   }
   else
-snprintf(WriteBuf,sizeof(WriteBuf), RET_OK);
+snprintf(WriteBuf,sizeof(WriteBuf), "%s", RET_OK);
 
   return(0);
 }
@@ -525,7 +525,7 @@
 return(-1);
   }
 
-  snprintf(WriteBuf,sizeof(WriteBuf), RET_OK);
+  snprintf(WriteBuf,sizeof(WriteBuf), "%s", RET_OK);
   if ((ret=vadduser(TmpUser, TmpDomain, password, TmpUser, USE_POP )) < 0 ) {
 snprintf(WriteBuf,sizeof(WriteBuf),RET_ERR "0.305 %s" RET_CRLF, 
verror(ret));
 return(-1);
@@ -564,7 +564,7 @@
 return(-1);
   }
 
-  snprintf(WriteBuf,sizeof(WriteBuf), RET_OK);
+  snprintf(WriteBuf,sizeof(WriteBuf), "%s", RET_OK);
   return(0);
 }
 
@@ -626,7 +626,7 @@
   }
   
 
-  snprintf(WriteBuf,sizeof(WriteBuf), RET_OK);
+  snprintf(WriteBuf,sizeof(WriteBuf), "%s", RET_OK);
   wait_write();
 
   while(fgets(ReadBuf,sizeof(ReadBuf),stdin)!=NULL ) {
@@ -751,7 +751,7 @@
   if ( (ret=vauth_setpw( tmpvpw, TmpDomain )) != 0 ) {
 snprintf(WriteBuf,sizeof(WriteBuf),RET_ERR "0.507 %s" RET_CRLF, 
verror(ret)); 
   } else {
-snprintf(WriteBuf,sizeof(WriteBuf), RET_OK);
+snprintf(WriteBuf,sizeof(WriteBuf), "%s", RET_OK);
   }
 
   return(0);
@@ -787,11 +787,11 @@
 return(-1);
   } 
 
-  snprintf(WriteBuf,sizeof(WriteBuf), RET_OK_MORE);
+  snprintf(WriteBuf,sizeof(WriteBuf), "%s", RET_OK_MORE);
   wait_write();
 
   send_user_info(tmpvpw);
-  snprintf(WriteBuf, sizeof(WriteBuf), "." RET_CRLF);
+  snprintf(WriteBuf, sizeof(WriteBuf), "%s", "." RET_CRLF);
   return(0);
 
 }
@@ -826,120 +826,79 @@
 
   } else {
 
-if ( tmpvpw->pw_gid & NO_PASSWD_CHNG ) {
-  snprintf(WriteBuf, sizeof(WriteBuf), "no_password_change 1" RET_CRLF);
-} else {
-  snprintf(WriteBuf, sizeof(WriteBuf), "no_password_change 0" RET_CRLF);
-}
+snprintf(WriteBuf, sizeof(WriteBuf), "no_password_change %d" RET_CRLF,
+  tmpvpw->pw_gid & NO_PASSWD_CHNG ? 1 : 0);
 wait_write();
 
-if ( tmpvpw->pw_gid & NO_POP ) {
-  snprintf(WriteBuf, sizeof(WriteBuf), "no_pop 1" RET_CRLF);
-} else {
-  snprintf(WriteBuf, sizeof(WriteBuf), "no_pop 0" RET_CRLF);
-}
+snprintf(WriteBuf, sizeof(WriteBuf), "no_pop %d" RET_CRLF,
+  tmpvpw->pw_gid & NO_POP ? 1 : 0);
 wait_write();
 
-if ( tmpvpw->pw_gid & NO_WEBMAIL ) {
-  snprintf(WriteBuf, sizeof(WriteBuf), "no_webmail 1" RET_CRLF);
-} else {
-  snprintf(WriteBuf, sizeof(WriteBuf), "no_webmail 0" RET_CRLF);
-}
+snprintf(WriteBuf, sizeof(WriteBuf), "no_webmail %d" RET_CRLF,
+  tmpvpw->pw_gid & NO_WEBMAIL ? 1 : 0);
 wait_write();
 
-if ( tmpvpw->pw_gid & NO_IMAP ) {
-  snprintf(WriteBuf, sizeof(WriteBuf), "no_imap 1" RET_CRLF);
-} else {
-  snprintf(WriteBuf, sizeof(WriteBuf), "no_imap 0" RET_CRLF);
-}
+snprintf(WriteBuf, sizeof(WriteBuf), "no_imap %d" RET_CRLF,
+  tmpvpw->pw_gid & NO_IMAP ? 1 : 0);
 wait_write();
 
-if ( tmpvpw->pw_gid & BOUNCE_MAIL ) {
-  snprintf(WriteBuf, sizeof(WriteBuf), "bounce_mail 1" RET_CRLF);
-} else {
-  snprintf(WriteBuf, sizeof(WriteBuf), "bounce_mail

Re: [vchkpw] [SPAM] valias remove alias

2015-09-17 Thread Drew Wells


On 09/15/2015 02:26 PM, Alessio Cecchi wrote:

Il 15/09/2015 15:10, Drew Wells ha scritto:

On 09/15/2015 11:06 AM, Alessio Cecchi wrote:


Il 15/09/2015 11:22, Drew Wells ha scritto:

In vpopmail-5.5.0 (and I think all 5.4.x)


Hi Drew,

I suggest to install (and debug) vpopmail-5.4.33 that is more stable,
reliable (and recent) than 5.5.0. Whan I try to use 5.5.0 I found many
bug and problems tha new features.

Why you need vpopmail-5.5.0 ?

I have been using vpopmail-5.4.x (currently vpopmail-5.4.33) for years
and have always added this patch, so in an attempt get 5.5.0 towards
stable I thought I'd send this patch.  This patch is also applicable to
the 5.4.x branch.
The reason I want to use 5.5.0 is the shared library support which means
I don't need to recompile netqmail and dovecot (and others) each time I
make changes to vpopmail.
I've not found that many bugs with vpopmail-5.5.0 to be honest.


I remember some problems with vpopmaild (that I'm using for password 
change via webmail), with large quota size, and a missing flag in 
MySQL limits for disable_maildrop.


Vpomail-5.5.0 was started from 5.4.28 so change from 5.4.29 to 5.4.33 
are missing (please correct me if I'm wrong).


If you have others useful patch for vpopmail-5.4 you are welcome :-)

Thanks

I have created a patch for vpopmail-5.5.0 which incoporates all the 
changes from 5.4.29 to 5.4.33, does anyone want this patch or has work 
in vpopmail-5.5.0 stalled ?


!DSPAM:55faa2a041552051216344!

Re: [vchkpw] [SPAM] valias remove alias

2015-09-17 Thread Drew Wells


On 09/17/2015 04:55 PM, Matt Brookings wrote:

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 09/17/2015 10:52 AM, Drew Wells wrote:

I basically did a diff from 5.4.29 to 5.4.33 and implemented that diff to 
5.5.0, some of it
had already been done to 5.5.0 and alot of it centered around the snprintf tidy 
up's and the
string_list implementation. The attached patch does not include any of the 
changes I
recently sent to the mailing list, just the changes from 5.4.[29->33].

This patch was generated from the 5.5.0 .tar.bz2, I had a look at SVN trunk and 
from what I could
see, it was 5.4.34.

The trunk on Sourceforge is the current 5.5.0.  The 5.4 series only appears in 
the tags and branches
area now.  I'll look over this patch and get it applied.  Thanks for putting it 
together!

Not a problem at all.  As you probably saw there are a few patches I 
sent to the list that cover a couple of other issues with the 5.5.0.tar.bz2.


!DSPAM:55fae2d441556321250516!

Re: [vchkpw] [SPAM] valias remove alias

2015-09-17 Thread Drew Wells


On 09/17/2015 04:04 PM, Matt Brookings wrote:

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Was this patch generated with the SVN trunk (5.5.0)?

On 09/17/2015 09:57 AM, Drew Wells wrote:

On 09/17/2015 03:37 PM, Matt Brookings wrote:

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1

On 09/17/2015 06:23 AM, Drew Wells wrote:

I have created a patch for vpopmail-5.5.0 which incoporates all the changes 
from 5.4.29 to
5.4.33, does anyone want this patch or has work in vpopmail-5.5.0 stalled ?

Drew, I'd be happy to take a look at this.  What changes did you add?


I basically did a diff from 5.4.29 to 5.4.33 and implemented that diff to 
5.5.0, some of it had
already been done to 5.5.0 and alot of it centered around the snprintf tidy 
up's and the
string_list implementation. The attached patch does not include any of the 
changes I recently
sent to the mailing list, just the changes from 5.4.[29->33].


This patch was generated from the 5.5.0 .tar.bz2, I had a look at SVN 
trunk and from what I could see, it was 5.4.34.


!DSPAM:55fae1c241551761131543!

Re: [vchkpw] [SPAM] valias remove alias

2015-09-17 Thread Matt Brookings

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 09/17/2015 10:52 AM, Drew Wells wrote:
>>> I basically did a diff from 5.4.29 to 5.4.33 and implemented that diff to 
>>> 5.5.0, some of it
>>> had already been done to 5.5.0 and alot of it centered around the snprintf 
>>> tidy up's and the 
>>> string_list implementation. The attached patch does not include any of the 
>>> changes I
>>> recently sent to the mailing list, just the changes from 5.4.[29->33].
>> 
> This patch was generated from the 5.5.0 .tar.bz2, I had a look at SVN trunk 
> and from what I could
> see, it was 5.4.34.

The trunk on Sourceforge is the current 5.5.0.  The 5.4 series only appears in 
the tags and branches
area now.  I'll look over this patch and get it applied.  Thanks for putting it 
together!
- -- 
/*
Matt Brookings    GnuPG Key 62817373
Software developer Systems technician
Inter7 Internet Technologies, Inc. (815)776-9465
*/
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.22 (GNU/Linux)

iQEcBAEBAgAGBQJV+uJcAAoJEOjQVexigXNzXowIALkzVHSRgVq3Ojq1Pv32jdI4
vRaX0jDhbhNzDTCPex5tcwLB71olOm2LYzV/GKBoXudeZYz/SjppccCk43FRhZnj
h76PKiI1484e4kRD1JYkgjP85YKh0I5if2eeL28zm7fDb8qwNG3Djs2xyH9m5+wN
nlPfEtF+e1Pi5PBa8WDFHilF+P6XlV5kwxsuXmZV8JD8EogyplMAs1ksteA6tmJH
vXEAB4xJfstVB6l27mxq1VVNqyE0KUN4inCuxVuuS/nUxJI576V6B/kUQ+DyVANj
ce4gD45L7YzWs4PAwnEcdseai82Jag4J6UaRIhLwTYEwridI1D9GnA7ZSHOmoK8=
=Pl67
-END PGP SIGNATURE-

Re: [vchkpw] [SPAM] valias remove alias

2015-09-17 Thread Drew Wells


On 09/17/2015 03:37 PM, Matt Brookings wrote:

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 09/17/2015 06:23 AM, Drew Wells wrote:

I have created a patch for vpopmail-5.5.0 which incoporates all the changes 
from 5.4.29 to
5.4.33, does anyone want this patch or has work in vpopmail-5.5.0 stalled ?

Drew, I'd be happy to take a look at this.  What changes did you add?

I basically did a diff from 5.4.29 to 5.4.33 and implemented that diff 
to 5.5.0, some of it had already been done to 5.5.0 and alot of it 
centered around the snprintf tidy up's and the string_list implementation.
The attached patch does not include any of the changes I recently sent 
to the mailing list, just the changes from 5.4.[29->33].



!DSPAM:55fad4d841551123915585!
diff -uPr vpopmail-5.5.0.orig/backends/mysql/vmysql.c 
vpopmail-5.5.0/backends/mysql/vmysql.c
--- vpopmail-5.5.0.orig/backends/mysql/vmysql.c 2010-11-05 18:37:23.0 
+
+++ vpopmail-5.5.0/backends/mysql/vmysql.c  2015-09-17 11:41:02.724095923 
+0100
@@ -1785,10 +1785,10 @@
 limits->maxforwards = atoi(row[2]);
 limits->maxautoresponders = atoi(row[3]);
 limits->maxmailinglists = atoi(row[4]);
-limits->diskquota = atoi(row[5]);
-limits->maxmsgcount = atoi(row[6]);
-limits->defaultquota = atoi(row[7]);
-limits->defaultmaxmsgcount = atoi(row[8]);
+limits->diskquota = strtoll(row[5], NULL, 10);
+limits->maxmsgcount = strtoll(row[6], NULL, 10);
+limits->defaultquota = strtoll(row[7], NULL, 10);
+limits->defaultmaxmsgcount = strtoll(row[8], NULL, 10);
 limits->disable_pop = atoi(row[9]);
 limits->disable_imap = atoi(row[10]);
 limits->disable_dialup = atoi(row[11]);
@@ -1808,8 +1808,8 @@
 limits->perm_maillist_users = perm & VLIMIT_DISABLE_ALL;
 perm >>= VLIMIT_DISABLE_BITS;
 limits->perm_maillist_moderators = perm & VLIMIT_DISABLE_ALL;
-limits->perm_quota = atoi(row[23]);
-limits->perm_defaultquota = atoi(row[24]);
+limits->perm_quota = strtoll(row[23], NULL, 10);
+limits->perm_defaultquota = strtoll(row[24], NULL, 10);
 }
 mysql_free_result(res_read);
 
@@ -1830,7 +1830,7 @@
 "diskquota = %d, maxmsgcount = %d, defaultquota = %d, 
defaultmaxmsgcount = %d, "
 "disable_pop = %d, disable_imap = %d, disable_dialup = %d, "
 "disable_passwordchanging = %d, disable_webmail = %d, disable_relay = 
%d, "
-"disable_smtp = %d, disable_spamassassin = %d, delete_spam = %d, 
perm_account = %d, "
+"disable_smtp = %d, disable_spamassassin = %d, delete_spam = %d, 
disable_maildrop = %d, perm_account = %d, "
 "perm_alias = %d, perm_forward = %d, perm_autoresponder = %d, 
perm_maillist = %d, "
 "perm_quota = %d, perm_defaultquota = %d "
 "ON DUPLICATE KEY UPDATE "
@@ -1847,7 +1847,7 @@
 limits->diskquota, limits->maxmsgcount, limits->defaultquota, 
limits->defaultmaxmsgcount,
 limits->disable_pop, limits->disable_imap, limits->disable_dialup,
 limits->disable_passwordchanging, limits->disable_webmail, 
limits->disable_relay,
-limits->disable_smtp, limits->disable_spamassassin, 
limits->delete_spam, limits->perm_account,
+limits->disable_smtp, limits->disable_spamassassin, 
limits->delete_spam, limits->disable_maildrop, limits->perm_account,
 limits->perm_alias, limits->perm_forward, limits->perm_autoresponder,
 (limits->perm_maillist |
 (limits->perm_maillist_users << VLIMIT_DISABLE_BITS) |
diff -uPr vpopmail-5.5.0.orig/backends/mysql/vmysql.h.in 
vpopmail-5.5.0/backends/mysql/vmysql.h.in
--- vpopmail-5.5.0.orig/backends/mysql/vmysql.h.in  2010-11-05 
18:37:23.0 +
+++ vpopmail-5.5.0/backends/mysql/vmysql.h.in   2015-09-17 11:41:02.725095861 
+0100
@@ -268,10 +268,10 @@
   maxforwards  INT(10) NOT NULL DEFAULT -1, \
   maxautorespondersINT(10) NOT NULL DEFAULT -1, \
   maxmailinglists  INT(10) NOT NULL DEFAULT -1, \
-  diskquotaINT(12) NOT NULL DEFAULT 0, \
-  maxmsgcount  INT(12) NOT NULL DEFAULT 0, \
-  defaultquota INT(12) NOT NULL DEFAULT 0, \
-  defaultmaxmsgcount   INT(12) NOT NULL DEFAULT 0, \
+  diskquotaBIGINT UNSIGNED NOT NULL DEFAULT 0, \
+  maxmsgcount  BIGINT UNSIGNED NOT NULL DEFAULT 0, \
+  defaultquota BIGINT UNSIGNED NOT NULL DEFAULT 0, \
+  defaultmaxmsgcount   BIGINT UNSIGNED NOT NULL DEFAULT 0, \
   disable_pop  TINYINT(1) NOT NULL DEFAULT 0, \
   disable_imap TINYINT(1) NOT NULL DEFAULT 0, \
   disable_dialup   TINYINT(1) NOT NULL DEFAULT 0, \
diff -uPr vpopmail-5.5.0.orig/backfill.c vpopmail-5.5.0/backfill.c
--- vpopmail-5.5.0.orig/backfill.c  2010-11-05 18:37:22.0 +
+++ vpopmail-5.5.0/backfill.c   2015-09-17

Re: [vchkpw] [SPAM] valias remove alias

2015-09-17 Thread Matt Brookings

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 09/17/2015 06:23 AM, Drew Wells wrote:
> I have created a patch for vpopmail-5.5.0 which incoporates all the changes 
> from 5.4.29 to
> 5.4.33, does anyone want this patch or has work in vpopmail-5.5.0 stalled ?

Drew, I'd be happy to take a look at this.  What changes did you add?
- -- 
/*
Matt Brookings    GnuPG Key 62817373
Software developer Systems technician
Inter7 Internet Technologies, Inc. (815)776-9465
*/
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.22 (GNU/Linux)

iQEcBAEBAgAGBQJV+tA3AAoJEOjQVexigXNzpoAIAJHChv9aNWE5TGdYIRVExQxs
cKyi14LUwIMupA3HX4GNTTBy9bMF6HVgWxMqRA3WOq3KzRGhwi2fT9J1lQseaC5X
U4Fd5qQ8eeiYcl8yakT+ZPjwDRSLbkNX98akynm1QDT92/YNgaZ55F6aE2uH2IVg
8rMDw96OohaJJHGCt9XZouTEuQZgTZKunWoKYMgpqvH5NdCvDxP2SgeOu7uRLPoM
e5w1Gqc2p9xP0VxgmqMPEl5Yp8uTQXfUjQrbw2Soe55OnnJXtxoJ3gCrPxdwAgLj
pHxZXJjon+681cYOJr+xX6grUuPuZIlV1y3WRzvgo8m1sD/VFq8WN/roWNYV0EA=
=LSon
-END PGP SIGNATURE-

Re: [vchkpw] [SPAM] valias remove alias

2015-09-17 Thread Matt Brookings

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Was this patch generated with the SVN trunk (5.5.0)?

On 09/17/2015 09:57 AM, Drew Wells wrote:
> On 09/17/2015 03:37 PM, Matt Brookings wrote:
>> -BEGIN PGP SIGNED MESSAGE- Hash: SHA1
>> 
>> On 09/17/2015 06:23 AM, Drew Wells wrote:
>>> I have created a patch for vpopmail-5.5.0 which incoporates all the changes 
>>> from 5.4.29 to 
>>> 5.4.33, does anyone want this patch or has work in vpopmail-5.5.0 stalled ?
>> Drew, I'd be happy to take a look at this.  What changes did you add?
>> 
> I basically did a diff from 5.4.29 to 5.4.33 and implemented that diff to 
> 5.5.0, some of it had 
> already been done to 5.5.0 and alot of it centered around the snprintf tidy 
> up's and the
> string_list implementation. The attached patch does not include any of the 
> changes I recently
> sent to the mailing list, just the changes from 5.4.[29->33].

- -- 
/*
Matt Brookings    GnuPG Key 62817373
Software developer Systems technician
Inter7 Internet Technologies, Inc. (815)776-9465
*/
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.22 (GNU/Linux)

iQEcBAEBAgAGBQJV+tZ9AAoJEOjQVexigXNzbnYH/2CBtOVqqKBntlGUYQNMzf46
PEyxaODsZjaBmyJKBSL7lU30UzEanbWTbo1XSCj7lx+YRB7v9e90SMDVSbYXbaDh
I2WGhqD+dHVOBbi7b+WtLPAeixPnFOS5EMcWggL+OK9xbF55WsFDQhz7b3wNJGmR
4klK0mEG6a22l2cScAjH7afXzRJpy/Vz6RpBvW+1wGz8R0nRPw6VDpiiiPbqLSpr
S4uDboSTdo2Ah6dFXQDns2Au/JYYB+Ip33f+rYaTyNjL4dUq9Emg/hZNFyy11KgU
0ldCRPX+h1EKtNoh65FAxRWF8tlCYufjw1M9E30neO48dwDVV5AyDRALKxdOjvA=
=6IBz
-END PGP SIGNATURE-

[vchkpw] Auto-Re: [vchkpw] [SPAM] valias remove alias

2015-09-15 Thread zhaopin

尊敬的同学：您好！

您的求职简历已经收到，我们会尽快进行阅评，之后再决定是否与您面谈！


  中信泰富（中国）投资有限公司
 人力资源部

!DSPAM:55f7e35941551360728760!

Re: [vchkpw] [SPAM] valias remove alias

2015-09-15 Thread Alessio Cecchi



Il 15/09/2015 11:22, Drew Wells ha scritto:

In vpopmail-5.5.0 (and I think all 5.4.x)


Hi Drew,

I suggest to install (and debug) vpopmail-5.4.33 that is more stable, 
reliable (and recent) than 5.5.0. Whan I try to use 5.5.0 I found many 
bug and problems tha new features.


Why you need vpopmail-5.5.0 ?
--
Alessio Cecchi
https://www.linkedin.com/in/alessice

!DSPAM:55f7edb641552122517293!

Re: [vchkpw] [SPAM] valias remove alias

2015-09-15 Thread Drew Wells


On 09/15/2015 02:26 PM, Alessio Cecchi wrote:

Il 15/09/2015 15:10, Drew Wells ha scritto:

On 09/15/2015 11:06 AM, Alessio Cecchi wrote:


Il 15/09/2015 11:22, Drew Wells ha scritto:

In vpopmail-5.5.0 (and I think all 5.4.x)


Hi Drew,

I suggest to install (and debug) vpopmail-5.4.33 that is more stable,
reliable (and recent) than 5.5.0. Whan I try to use 5.5.0 I found many
bug and problems tha new features.

Why you need vpopmail-5.5.0 ?

I have been using vpopmail-5.4.x (currently vpopmail-5.4.33) for years
and have always added this patch, so in an attempt get 5.5.0 towards
stable I thought I'd send this patch.  This patch is also applicable to
the 5.4.x branch.
The reason I want to use 5.5.0 is the shared library support which means
I don't need to recompile netqmail and dovecot (and others) each time I
make changes to vpopmail.
I've not found that many bugs with vpopmail-5.5.0 to be honest.


I remember some problems with vpopmaild (that I'm using for password 
change via webmail), with large quota size, and a missing flag in 
MySQL limits for disable_maildrop.


Vpomail-5.5.0 was started from 5.4.28 so change from 5.4.29 to 5.4.33 
are missing (please correct me if I'm wrong).


If you have others useful patch for vpopmail-5.4 you are welcome :-)

Thanks

If that is the case (the missing 5.4.29 -> 5.4.33 changes) I'll have a 
look and get those changes into 5.5.0, I'd really like to use the shared 
library support.


!DSPAM:55f81f7741555484815027!

Re: [vchkpw] [SPAM] valias remove alias

Re: [vchkpw] [SPAM] valias remove alias

Re: [vchkpw] [SPAM] valias remove alias

Re: [vchkpw] [SPAM] valias remove alias

Re: [vchkpw] [SPAM] valias remove alias

Re: [vchkpw] [SPAM] valias remove alias

Re: [vchkpw] [SPAM] valias remove alias

Re: [vchkpw] [SPAM] valias remove alias

Re: [vchkpw] [SPAM] valias remove alias

Re: [vchkpw] [SPAM] valias remove alias

Re: [vchkpw] [SPAM] valias remove alias

[vchkpw] Auto-Re: [vchkpw] [SPAM] valias remove alias

Re: [vchkpw] [SPAM] valias remove alias

Re: [vchkpw] [SPAM] valias remove alias

14 matches

Site Navigation

Mail list logo

Footer information