Re: Patch

2005-09-23 Thread Llewellyn Falco
Sorry, apparently i am being a bit confusing. the patch was rather large (six lines of code) so i can understand why i should have explained it more clearly, The patch is against 3 issues, 1 of them i submitted when the old bugzilla, the other 2 don't exist. but there is a unit

[jira] Updated: (VELOCITY-381) Silent Failure of a toString that return null

2005-09-23 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-381?page=all ] Will Glass-Husain updated VELOCITY-381: --- Attachment: patch2.txt correct patch by Llwellyn Falco and Dan Powell Silent Failure of a toString that return null

[jira] Created: (VELOCITY-404) Uberspect - info is created wrong / premature blocking of invalid methods

2005-09-23 Thread Will Glass-Husain (JIRA)
Uberspect - info is created wrong / premature blocking of invalid methods - Key: VELOCITY-404 URL: http://issues.apache.org/jira/browse/VELOCITY-404 Project: Velocity Type: Bug Components:

[jira] Updated: (VELOCITY-404) Uberspect - info is created wrong / premature blocking of invalid methods

2005-09-23 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-404?page=all ] Will Glass-Husain updated VELOCITY-404: --- Attachment: patch1.txt patch submitted by Llewellyn Falco and Dan Powell on dev list Uberspect - info is created wrong / premature blocking

Re: svn commit: r290942 [1/2] - in /jakarta/velocity/core/trunk/src/test/org/apache/velocity: test/ test/eventhandler/ test/misc/ test/provider/ test/view/ util/

2005-09-23 Thread Daniel L. Rall
On Thu, 22 Sep 2005, [EMAIL PROTECTED] wrote: Author: henning Date: Thu Sep 22 06:32:34 2005 New Revision: 290942 URL: http://svn.apache.org/viewcvs?rev=290942view=rev Log: - Clean up imports using Eclipse - Remove trailing blanks This type of clean-up makes merging changes in my

Re: Patch

2005-09-23 Thread Will Glass-Husain
Thanks - appreciate the explanation. I threw the patches in our issue tracker. I should have time to review it tonight or tomorrow. At first glance they look almost perfect. Not to beat a dead horse, but using JIRA is more than busy work. It really does make life easier for the

[jira] Updated: (VELOCITY-404) Uberspect - info is created wrong / premature blocking of invalid methods

2005-09-23 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-404?page=all ] Will Glass-Husain updated VELOCITY-404: --- Fix Version: (was: Tools-2.0) Uberspect - info is created wrong / premature blocking of invalid methods

svn commit: r291173 - /jakarta/velocity/core/trunk/build/build.xml

2005-09-23 Thread wglass
Author: wglass Date: Fri Sep 23 10:50:40 2005 New Revision: 291173 URL: http://svn.apache.org/viewcvs?rev=291173view=rev Log: add javacc parser task. resolves VELOCITY-222. Modified: jakarta/velocity/core/trunk/build/build.xml Modified: jakarta/velocity/core/trunk/build/build.xml URL:

ant test broken

2005-09-23 Thread Will Glass-Husain
Henning, FYI: ant test now fails on ClassLoaderChangeTest. maven test works fine, so I think it's something about the new test config. By the way, I really like the fact that you can just drop new test classes in - no need to edit the build files anymore. WILL

[jira] Updated: (VELOCITY-404) Uberspect - info is created wrong / premature blocking of invalid methods

2005-09-23 Thread Llewellyn Falco (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-404?page=all ] Llewellyn Falco updated VELOCITY-404: - Attachment: InfoOnExceptionUberspect.java Uberspect - info is created wrong / premature blocking of invalid methods

[jira] Updated: (VELOCITY-404) Uberspect - info is created wrong / premature blocking of invalid methods

2005-09-23 Thread Llewellyn Falco (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-404?page=all ] Llewellyn Falco updated VELOCITY-404: - Attachment: InfoOnExceptionUberspect.java Uberspect - info is created wrong / premature blocking of invalid methods

[jira] Updated: (VELOCITY-404) Uberspect - info is created wrong / premature blocking of invalid methods

2005-09-23 Thread Llewellyn Falco (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-404?page=all ] Llewellyn Falco updated VELOCITY-404: - Attachment: InfoOnExceptionTest.java Uberspect - info is created wrong / premature blocking of invalid methods

[jira] Updated: (VELOCITY-404) Uberspect - info is created wrong / premature blocking of invalid methods

2005-09-23 Thread Llewellyn Falco (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-404?page=all ] Llewellyn Falco updated VELOCITY-404: - Attachment: StringResourceLoader.java Uberspect - info is created wrong / premature blocking of invalid methods

[jira] Commented: (VELOCITY-404) Uberspect - info is created wrong / premature blocking of invalid methods

2005-09-23 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-404?page=comments#action_12330341 ] Will Glass-Husain commented on VELOCITY-404: Thanks - now I see what your test is trying to do. Probably we'll reformat the test to make it similar to the

[jira] Commented: (VELOCITY-350) Base Equality on toString() when operands are of different classes

2005-09-23 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-350?page=comments#action_12330344 ] Will Glass-Husain commented on VELOCITY-350: I've gone ahead and added this. We still need a doc patch, so I'm leaving this open. Base Equality on

svn commit: r291252 - in /jakarta/velocity/core/trunk: src/java/org/apache/velocity/runtime/parser/node/ src/test/org/apache/velocity/test/ test/templates/ test/templates/compare/

2005-09-23 Thread wglass
Author: wglass Date: Fri Sep 23 22:34:39 2005 New Revision: 291252 URL: http://svn.apache.org/viewcvs?rev=291252view=rev Log: equality and not equality now based on toString when classes are different. See VELOCITY-350 Modified:

[jira] Resolved: (VELOCITY-98) #parse / #include causing ClassCastException

2005-09-23 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-98?page=all ] Will Glass-Husain resolved VELOCITY-98: --- Resolution: Fixed Since test case passes, I'm closing this issue. Please reopen if you find it still exists. #parse / #include causing

svn commit: r291254 - /jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/resource/loader/ClasspathResourceLoader.java

2005-09-23 Thread wglass
Author: wglass Date: Fri Sep 23 22:48:44 2005 New Revision: 291254 URL: http://svn.apache.org/viewcvs?rev=291254view=rev Log: Fixed VELOCITY-382. ClasspathResourceLoader now throws exception when template not found. Modified:

[jira] Resolved: (VELOCITY-382) getResourceStream returns null instead of throwing an ResourceNotFoundException

2005-09-23 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-382?page=all ] Will Glass-Husain resolved VELOCITY-382: Resolution: Fixed I'm assuming you are referring to ClasspathResourceLoader. There was definitely a problem in that it returned null