Author: dlr
Date: Mon Sep 26 23:29:11 2005
New Revision: 291829
URL: http://svn.apache.org/viewcvs?rev=291829view=rev
Log:
* src/java/org/apache/velocity/runtime/VelocimacroFactory.java
(addVelocimacro): Use a StringBuffer rather than String concatenation
when creating a log message in a
Author: dlr
Date: Mon Sep 26 23:45:26 2005
New Revision: 291831
URL: http://svn.apache.org/viewcvs?rev=291831view=rev
Log:
Documentation and logging improvements.
* src/java/org/apache/velocity/runtime/directive/Macro.java
(processAndRegister): Improved JavaDoc. Updated arguments for call to
[EMAIL PROTECTED] writes:
That makes sense to me as well. Not a big deal to switch
over - it was
probably worth trying the other way first.
I'll have a go at it later tonight.
You should at least ping the infrastructure guys, though. This is not
'our' JIRA, it's the ASF one.
As I said,
[EMAIL PROTECTED] writes:
Hi,
+/**
+ * For debugging purposes. Formats the arguments from
+ * codeargArray/code and appends them to codebuf/code.
+ */
+private static StringBuffer formatArgArray(StringBuffer buf,
+ String[]
You should at least ping the infrastructure guys, though. This is not
'our' JIRA, it's the ASF one.
Good point... I'll drop a line over there first.
Timo
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands,
[ http://issues.apache.org/jira/browse/VELOCITY-407?page=all ]
Daniel Rall updated VELOCITY-407:
-
Summary: Templates vs. static content should be resolvable via file
naming pattern (was: Templates should follow the double extension naming
[
http://issues.apache.org/jira/browse/VELOCITY-403?page=comments#action_12330552
]
Daniel Rall commented on VELOCITY-403:
--
Logging should absolutely not be a no-op under any circumstances. :-)
Enhance Velocity's LogSystem and internal use thereof
[ http://issues.apache.org/jira/browse/VELOCITY-358?page=all ]
Daniel Rall updated VELOCITY-358:
-
Bugzilla Id: (was: 33634)
Summary: Add documetation for the #literal directive (was: Want
#literal documetation)
Fix Version: 1.5
Author: dlr
Date: Tue Sep 27 01:07:17 2005
New Revision: 291855
URL: http://svn.apache.org/viewcvs?rev=291855view=rev
Log:
* xdocs/docs/user-guide.xml
(StringLiterals): Renamed from String Literals to Literals (the
label, not the anchor). Added a section on the #literal()
directive.
[ http://issues.apache.org/jira/browse/VELOCITY-358?page=all ]
Daniel Rall resolved VELOCITY-358:
--
Resolution: Fixed
* xdocs/docs/user-guide.xml
(StringLiterals): Renamed from String Literals to Literals (the
label, not the anchor). Added a
Author: henning
Date: Tue Sep 27 01:54:33 2005
New Revision: 291862
URL: http://svn.apache.org/viewcvs?rev=291862view=rev
Log:
If we have getter/setters, let's use them.
Modified:
jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/VelocimacroFactory.java
Modified:
Author: henning
Date: Tue Sep 27 02:13:18 2005
New Revision: 291868
URL: http://svn.apache.org/viewcvs?rev=291868view=rev
Log:
factor out common Macro printout routine. Add some javadocs.
Modified:
jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/VelocimacroFactory.java
Author: henning
Date: Tue Sep 27 02:38:36 2005
New Revision: 291876
URL: http://svn.apache.org/viewcvs?rev=291876view=rev
Log:
Removed FindBugs report (Exception was too broad, replaced with
IllegalAccessException), cleaned up error messages.
I was wondering if there should be a standard way to
To whom it may engage...
This is an automated request, but not an unsolicited one. For
more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at [EMAIL PROTECTED]
Project jakarta-velocity has an issue affecting its community integration.
This issue
Author: henning
Date: Tue Sep 27 02:43:52 2005
New Revision: 291877
URL: http://svn.apache.org/viewcvs?rev=291877view=rev
Log:
Serializable is already implemented in superclass (found by findbugs)
Modified:
[
http://issues.apache.org/jira/browse/VELOCITY-407?page=comments#action_12330561
]
Claude Brisson commented on VELOCITY-407:
-
I thought I would get more approbation than that on this one...
Thanks for rephrasing the description, but how comes you
Author: henning
Date: Tue Sep 27 02:51:12 2005
New Revision: 291879
URL: http://svn.apache.org/viewcvs?rev=291879view=rev
Log:
remove unused methods (found by Findbugs)
Modified:
jakarta/velocity/core/trunk/src/java/org/apache/velocity/io/VelocityWriter.java
Author: henning
Date: Tue Sep 27 03:10:05 2005
New Revision: 291888
URL: http://svn.apache.org/viewcvs?rev=291888view=rev
Log:
remove potential did not close stream issue. Found by findbugs
Modified:
jakarta/velocity/core/trunk/src/java/org/apache/velocity/util/StringUtils.java
Modified:
Author: henning
Date: Tue Sep 27 03:10:18 2005
New Revision: 291889
URL: http://svn.apache.org/viewcvs?rev=291889view=rev
Log:
add a comment about findbugs issue.
Modified:
jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/RuntimeInstance.java
Modified:
Henning, have you seen a spot where it would be reasonable to pass in the
directory base name as some sort of configuration parameter? Seems odd to
leave it hard-coded like this.
- Dan
On Sun, 25 Sep 2005, [EMAIL PROTECTED] wrote:
Author: henning
Date: Sun Sep 25 07:03:20 2005
New Revision:
Author: henning
Date: Tue Sep 27 03:10:50 2005
New Revision: 291890
URL: http://svn.apache.org/viewcvs?rev=291890view=rev
Log:
Remove some findbugs issues, including a number of System.exit()
calls.
Modified:
jakarta/velocity/core/trunk/src/java/org/apache/velocity/convert/WebMacro.java
On Sat, 24 Sep 2005, Henning P. Schmiedehausen wrote:
Daniel L. Rall dlr@finemaltcoding.com writes:
On Thu, 22 Sep 2005, [EMAIL PROTECTED] wrote:
Author: henning
Date: Thu Sep 22 06:32:34 2005
New Revision: 290942
URL: http://svn.apache.org/viewcvs?rev=290942view=rev
Log:
-
On Sat, 24 Sep 2005, Will Glass-Husain wrote:
Dan,
I think this type of activity is rare but needs to occur in the short term.
Henning's comment about linters was a good reason why.
There's some new momentum to clean up the code base, fix the outstanding
bugs, and issue a release.
On Sun, 25 Sep 2005, [EMAIL PROTECTED] wrote:
Author: wglass
Date: Sun Sep 25 00:03:09 2005
New Revision: 291378
URL: http://svn.apache.org/viewcvs?rev=291378view=rev
Log:
pass template info to uberspector for methods and properties
...
---
Any reason for the leading whitespace character in these error messages?
On Sat, 24 Sep 2005, [EMAIL PROTECTED] wrote:
Author: wglass
Date: Fri Sep 23 23:04:39 2005
New Revision: 291256
URL: http://svn.apache.org/viewcvs?rev=291256view=rev
Log:
check to see if Velocity was initialized
Yeah, never a big deal with version control. :-)
On Sat, 24 Sep 2005, Will Glass-Husain wrote:
fair enough. I put a note on JIRA a few days ago as well. I figured I
could always reverse the commit if anyone cared.
WILL
- Original Message -
From: Henning P. Schmiedehausen
This commit also removed a call to node.jjtGetChild(0).getFirstToken(),
which wasn't used. AFAICT, this method doesn't have any necessary
side-effects, but it would be nice if the change was mentioned in the
log.
svn ps --revprop -r291691 -F change-log.txt 'svn:log'
On Mon, 26 Sep 2005, [EMAIL
On Mon, 26 Sep 2005, Henning P. Schmiedehausen wrote:
Will Glass-Husain [EMAIL PROTECTED] writes:
Hey -
That's a non backwards-compatible change.
Yes.
Where did we document this would happen in 1.3 or 1.4?
In the header of the class. It was deprecated in 1.1 and we kept it
I'm okay with this, though a little iffy about the build succeeding and
producing different results depending upon what's in your classpath.
Perhaps the release build could be more stringent, and actually fail in
the case where it might otherwise just not build some of the classes.
On Mon, 26
On Tue, 27 Sep 2005, Henning P. Schmiedehausen wrote:
[EMAIL PROTECTED] writes:
Hi,
+/**
+ * For debugging purposes. Formats the arguments from
+ * codeargArray/code and appends them to codebuf/code.
+ */
+private static StringBuffer formatArgArray(StringBuffer
Follow the policy suggested by Tim in that case. Otherwise, use your best
judgement.
On the Subversion project, we simply don't allow non-committers or unknown
contributors to file bugs, which is more work, but keeps the issue tracker
_very_ clean. I'm not suggesting that approach for the
Hi,
I didn't know about that page. I do like the idea of major.minor.patch,
but we haven't used three number versioning in the past so we would have
to start it for 1.5 (1.5.0?).
The alternative would be the old Turbine deprecation rules, which work
pretty well for seldom released projects like
Ok, so how about this (I admit that I'm guilty of removing trailing
blanks from some files that I work on and sneak these changes in):
I keep my fingers still until we have all the code changes in and call
it RC1. Afterwards we do one big rush to clean up these issues like
trailing blanks and
Daniel Rall [EMAIL PROTECTED] writes:
Henning, have you seen a spot where it would be reasonable to pass in the
directory base name as some sort of configuration parameter? Seems odd to
leave it hard-coded like this.
Well, we can extend all the test cases from BaseTestCase and set it
there.
Daniel Rall [EMAIL PROTECTED] writes:
On Sat, 24 Sep 2005, Henning P. Schmiedehausen wrote:
Will Glass-Husain [EMAIL PROTECTED] writes:
I'd like to keep the javacc output in the source tree.
That's perfectly fine with me. Another idea: Don't keep it in src/java
but e.g. in
Daniel Rall [EMAIL PROTECTED] writes:
This commit also removed a call to node.jjtGetChild(0).getFirstToken(),
which wasn't used. AFAICT, this method doesn't have any necessary
side-effects, but it would be nice if the change was mentioned in the
log.
Yep, forgot to log that. Sorry.
I've
Daniel Rall [EMAIL PROTECTED] writes:
I'm okay with this, though a little iffy about the build succeeding and
producing different results depending upon what's in your classpath.
Perhaps the release build could be more stringent, and actually fail in
the case where it might otherwise just not
Author: henning
Date: Tue Sep 27 03:58:18 2005
New Revision: 291900
URL: http://svn.apache.org/viewcvs?rev=291900view=rev
Log:
Remove another dead local storage issue found by Findbugs
Modified:
jakarta/velocity/core/trunk/src/java/org/apache/velocity/convert/WebMacro.java
Modified:
Author: henning
Date: Tue Sep 27 03:58:41 2005
New Revision: 291901
URL: http://svn.apache.org/viewcvs?rev=291901view=rev
Log:
Make sure that all streams are closed at all times (again, found by
Findbugs)
Modified:
Author: henning
Date: Tue Sep 27 03:59:16 2005
New Revision: 291902
URL: http://svn.apache.org/viewcvs?rev=291902view=rev
Log:
remove an unnecessary null test and make sure that
all streams are always closed (Findbugs)
Modified:
Author: henning
Date: Tue Sep 27 04:01:36 2005
New Revision: 291905
URL: http://svn.apache.org/viewcvs?rev=291905view=rev
Log:
Closing output streams seems to be tricky business. Another problem
found by findbugs.
Also reference the static fields in the class by using the
VelocityServlet
On Sep 27, 2005, at 4:41 AM, Henning Schmiedehausen wrote:
Hi,
I didn't know about that page. I do like the idea of
major.minor.patch,
but we haven't used three number versioning in the past so we would
have
to start it for 1.5 (1.5.0?).
The alternative would be the old Turbine
[
http://issues.apache.org/jira/browse/VELOCITY-403?page=comments#action_12330586
]
Will Glass-Husain commented on VELOCITY-403:
Daniel - makes sense. Alternate suggestion. If logging is not configured,
send to standard out instead of
A null check isn't needed as the item is always constructed above in one of
three clauses.
Good catch about the missing log messages - will try to be more
thorough.
Thanks for all your feedback!
WILL
- Original Message -
From: Daniel Rall [EMAIL PROTECTED]
To: Velocity Developers
Given how old this class is, I'm ok with removing it. But I'm equally okay
with letting any committer (Geir?) say keep it in.
It's 6 in the morning here - I'll read the article later. Might be useful
to write a Velocity versioning policy up and stick it on the Wiki with the
other dev info.
Author: wglass
Date: Tue Sep 27 06:53:10 2005
New Revision: 291938
URL: http://svn.apache.org/viewcvs?rev=291938view=rev
Log:
remove extra spaces in error message
Modified:
jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/RuntimeInstance.java
Modified:
i like major.minor.patch
i like neat codebases, so the deprecate in A, leave in B, remove in
C sounds good to me.
as for forcing people to rewrite, i don't think anyone is forcing
them to use a new version. if they don't want to rewrite and their
app is stable with an older version, they should
[
http://issues.apache.org/jira/browse/VELOCITY-403?page=comments#action_12330602
]
Nathan Bubna commented on VELOCITY-403:
---
Ok, i've actually put a little time in on a patch for this. here's a progress
update:
1) agreed on sending logging to
[
http://issues.apache.org/jira/browse/VELOCITY-407?page=comments#action_12330603
]
Tim Colson commented on VELOCITY-407:
-
VelocityViewServlet.getTemplate() method should append .vtl
to the URI by default (and only handle .vtl files in
its
i like major.minor.patch
+1
For most packages, I tend to avoid x.x.0 and wait for x.x.1 or x.x.2
before upgrading. (And if it's an Atlassian product, I tend to wait for
x.x.4)
i like neat codebases, so the deprecate in A, leave in B, remove in
C sounds good to me.
I'm not sure I understand
Gump failure in test-clean target - can't find testcases.xml file
-
Key: VELOCITY-408
URL: http://issues.apache.org/jira/browse/VELOCITY-408
Project: Velocity
Type: Bug
Components: Build
i meant dep in 1.0, leave in 1.1, remove in 1.2
Ok, then I'm solid +1
major versions shouldn't care about B.C. patches shouldn't mess with
anything more than they have to.
+1
Timo
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
[
http://issues.apache.org/jira/browse/VELOCITY-407?page=comments#action_12330609
]
Claude Brisson commented on VELOCITY-407:
-
Ok then, I guess I extrapolated my own perception of the problem...
And you're right, you have to map all the files to
Hi,
Some thoughts after a little more AM coffee.
Re: major/minor/patch versions. Once 1.5 is released I'd like
to do more frequent releases with bug fixes. It's frustrating for users to
report a bug and hear this is fixed but not released. I think it'd be
beneficial to release 1.5.1, 1.5.2,
Author: dlr
Date: Tue Sep 27 11:11:06 2005
New Revision: 292010
URL: http://svn.apache.org/viewcvs?rev=292010view=rev
Log:
* build/build.xml
(test-clean): Corrected regression introduced in r291407, when the
project element's basedir attribute was changed from . to
...
Issue:
Author: wglass
Date: Tue Sep 27 11:18:29 2005
New Revision: 292012
URL: http://svn.apache.org/viewcvs?rev=292012view=rev
Log:
changed UBERSPECT_CLASSNAME and PARSER_POOL_SIZE constants to be public since
these are user-accessible properties
Modified:
beneficial to release 1.5.1, 1.5.2, etc every couple of
I'd suggest point releases when they make sense... criteria to be
determined on the list.
version called 1.5.0 may discourage users. Why not just
start with 1.5?
1.5, 1.5.1, 1.5.2 is fine with me.
Re: deprecation. My opinion -
FYI :-)
I'm busy during the day, but will make the change asap.
Timo
-Original Message-
From: Leo Simons [mailto:[EMAIL PROTECTED]
Sent: Tuesday, September 27, 2005 4:22 AM
To: Tim Colson (tcolson)
Cc: Apache Infrastructure
Subject: Re: Approval for separate Jira project for
Hi,
Just to be clear. VelocityServlet should absolutely stay in the core until
a 2.0 release. There's no reason to break any existing applications by
taking it out. (And I'm sure there are applications written 3 years ago
using Velocity that are still running).
There's no downside to
Just to be clear. VelocityServlet should absolutely stay in
the core until a 2.0 release.
There's no reason to break any existing applications by
taking it out.
Yes, sorry, I do agree on this case. It was a bad example followed up
with another bad example. :-)
I'd hate for deprecated
On Tue, 27 Sep 2005, Henning P. Schmiedehausen wrote:
Daniel Rall [EMAIL PROTECTED] writes:
Henning, have you seen a spot where it would be reasonable to pass in the
directory base name as some sort of configuration parameter? Seems odd to
leave it hard-coded like this.
Well, we can
On Tue, 27 Sep 2005, [EMAIL PROTECTED] wrote:
Author: henning
Date: Tue Sep 27 02:38:36 2005
New Revision: 291876
URL: http://svn.apache.org/viewcvs?rev=291876view=rev
Log:
Removed FindBugs report (Exception was too broad, replaced with
IllegalAccessException), cleaned up error messages.
Thanks!
On Tue, 27 Sep 2005, [EMAIL PROTECTED] wrote:
Author: henning
Date: Tue Sep 27 02:13:18 2005
New Revision: 291868
URL: http://svn.apache.org/viewcvs?rev=291868view=rev
Log:
factor out common Macro printout routine. Add some javadocs.
Modified:
On 9/27/05, Daniel L. Rall dlr@finemaltcoding.com wrote:
On Tue, 27 Sep 2005, [EMAIL PROTECTED] wrote:
Author: henning
Date: Tue Sep 27 02:38:36 2005
New Revision: 291876
URL: http://svn.apache.org/viewcvs?rev=291876view=rev
Log:
Removed FindBugs report (Exception was too broad,
Sifting through the backlog, I noticed this one from Shawn went without
a reply.
The culture seems to be mostly mailing list-based... over the years, it
seems that we all have varied schedules, so we're not often both online
and available to chat.
The lists seem to work well and are archived.
Tim Colson \(tcolson\) [EMAIL PROTECTED] writes:
i like major.minor.patch
+1
For most packages, I tend to avoid x.x.0 and wait for x.x.1 or x.x.2
before upgrading. (And if it's an Atlassian product, I tend to wait for
x.x.4)
I do, too. However, we have such a long release cycles, that a three
[EMAIL PROTECTED] writes:
Thanks. You're too quick for me, guys... ;-)
Best regards
Henning
Author: dlr
Date: Tue Sep 27 11:11:06 2005
New Revision: 292010
URL: http://svn.apache.org/viewcvs?rev=292010view=rev
Log:
* build/build.xml
(test-clean): Corrected
Tim Colson \(tcolson\) [EMAIL PROTECTED] writes:
I usually hang out on #turbine @ freenode (that is a really quiet
channel), but my client is multi-server capable so if we can agree on
a channel and a net, this would be fine by me.
Best regards
Henning
Sifting through
On Tue, 27 Sep 2005, Nathan Bubna wrote:
i make it a habit to always look over the svn diff output before
committing anything. this makes it pretty hard to miss unintended
formatting changes.
Ditto. I verify my log message aginst the diff output.
On 9/27/05, Will Glass-Husain [EMAIL
Author: dlr
Date: Tue Sep 27 17:08:12 2005
New Revision: 292075
URL: http://svn.apache.org/viewcvs?rev=292075view=rev
Log:
* www/svn_1.3_releasenotes.html
Added 'status --show-updates' patch as a TODO item.
Modified:
On Tue, 27 Sep 2005, Nathan Bubna wrote:
On 9/27/05, Daniel L. Rall dlr@finemaltcoding.com wrote:
On Tue, 27 Sep 2005, [EMAIL PROTECTED] wrote:
Author: henning
Date: Tue Sep 27 02:38:36 2005
New Revision: 291876
URL: http://svn.apache.org/viewcvs?rev=291876view=rev
Log:
* www/svn_1.3_releasenotes.html
Added 'status --show-updates' patch as a TODO item.
I think you're mixing your projects, Daniel. As long as the code stays in
the right repos I guess its ok. :-)
WILL
- Original Message -
From: [EMAIL PROTECTED]
To: [EMAIL PROTECTED]
Sent:
Thanks Daniel,
The latest velocity gump run just passed :-)
Niall
- Original Message -
From: Daniel Rall (JIRA) [EMAIL PROTECTED]
Sent: Tuesday, September 27, 2005 7:12 PM
[ http://issues.apache.org/jira/browse/VELOCITY-408?page=all ]
Daniel Rall resolved VELOCITY-408:
FYI. In case anyone else was wondering about this...
WILL
- Original Message -
From: Sander Temme (JIRA) [EMAIL PROTECTED]
To: [EMAIL PROTECTED]
Sent: Tuesday, September 27, 2005 5:40 PM
Subject: [jira] Closed: (INFRA-564) Stop automatic bugzilla emails for
Velocity
[
On Tue, 27 Sep 2005, Will Glass-Husain wrote:
* www/svn_1.3_releasenotes.html
Added 'status --show-updates' patch as a TODO item.
I think you're mixing your projects, Daniel. As long as the code stays in
the right repos I guess its ok. :-)
Heh, thanks -- fixed. No, it was in the
On Tue, 20 Sep 2005, [EMAIL PROTECTED] wrote:
Author: wglass
Date: Mon Sep 19 22:43:25 2005
New Revision: 290365
URL: http://svn.apache.org/viewcvs?rev=290365view=rev
Log:
If configuration for resource loader cache is invalid, use defaults.
Patch by Daniel Rall from VELOCITY-199.
...
Author: wglass
Date: Tue Sep 27 20:47:42 2005
New Revision: 292114
URL: http://svn.apache.org/viewcvs?rev=292114view=rev
Log:
fix trivial tab issue
Modified:
jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/resource/loader/ResourceLoader.java
Modified:
It's a tab vs. space issue. I think that was before I turned convert tab
to 4 spaces on in the Eclipse editor.
Thanks,
WILL
- Original Message -
From: Daniel L. Rall dlr@finemaltcoding.com
To: Velocity Developers List velocity-dev@jakarta.apache.org
Cc: [EMAIL PROTECTED]
Sent:
78 matches
Mail list logo
