Tim Colson [EMAIL PROTECTED] writes:
Thanks for getting this rolling, Tim!
Best regards
Henning
Well -- if you hadn't noticed the 60 or so emails... the VELTOOLS jira
project has been created and I moved the issues pertaining to tools
over there. (oddly, when fixing an
[EMAIL PROTECTED] writes:
-rsvc.warn(JarResourceLoader : you are using a deprecated
configuration
+log.warn(JarResourceLoader : you are using a deprecated
configuration
Ah, I see that Nathan's patch deprecated rsvc.debug() etc. Good move!
There is the issue
[
http://issues.apache.org/jira/browse/VELOCITY-193?page=comments#action_12331019
]
Henning Schmiedehausen commented on VELOCITY-193:
-
I tried the test program with a lot of memory (-Xmx1024m) and found the
following interesting fact (I
Author: henning
Date: Sat Oct 1 03:10:22 2005
New Revision: 292943
URL: http://svn.apache.org/viewcvs?rev=292943view=rev
Log:
add yours truly to the list of developers
Modified:
jakarta/velocity/core/trunk/project.xml
Modified: jakarta/velocity/core/trunk/project.xml
URL:
Author: henning
Date: Sat Oct 1 03:58:33 2005
New Revision: 292947
URL: http://svn.apache.org/viewcvs?rev=292947view=rev
Log:
Make sure that the output stream always gets close. Has the side
effect, that getStackTrace will always return the right stack trace as
the IOException can only be thrown
Author: henning
Date: Sat Oct 1 03:59:35 2005
New Revision: 292948
URL: http://svn.apache.org/viewcvs?rev=292948view=rev
Log:
Remove redundant local stores (both found by FindBugs)
Modified:
jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/directive/Macro.java
Author: henning
Date: Sat Oct 1 04:09:37 2005
New Revision: 292953
URL: http://svn.apache.org/viewcvs?rev=292953view=rev
Log:
We can actually do even a bit better by turning the
PrintWriter/StringWriter combo around. Funny how hard it is to get
that small piece of code really right...
Modified:
Author: henning
Date: Sat Oct 1 04:16:17 2005
New Revision: 292955
URL: http://svn.apache.org/viewcvs?rev=292955view=rev
Log:
Removing a String concatenation in a loop, thus improving a possible
StringBuffer.append(StringBuffer) situation. Defuse and comment it.
(String concat found by
Author: henning
Date: Sat Oct 1 04:28:17 2005
New Revision: 292957
URL: http://svn.apache.org/viewcvs?rev=292957view=rev
Log:
Check a number of generic catch Exception instances found by
Findbugs and replace them either with more specialized Exceptions or
document which Exceptions are caught.
Author: henning
Date: Sat Oct 1 04:39:27 2005
New Revision: 292958
URL: http://svn.apache.org/viewcvs?rev=292958view=rev
Log:
- make a constant really static
- remove a String(String) C'tor. Strings are immutable so the
assignment is really ok.
(Both found by Findbugs)
Modified:
Author: henning
Date: Sat Oct 1 04:50:24 2005
New Revision: 292962
URL: http://svn.apache.org/viewcvs?rev=292962view=rev
Log:
Same code used for two branches (found by findbugs)
Modified:
jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/log/AvalonLogChute.java
Modified:
Author: henning
Date: Sat Oct 1 05:00:13 2005
New Revision: 292963
URL: http://svn.apache.org/viewcvs?rev=292963view=rev
Log:
Removed a possible NPE when rsvc.getProperty might decide to return
neither a String nor a List.
Modified:
Author: henning
Date: Sat Oct 1 05:10:59 2005
New Revision: 292964
URL: http://svn.apache.org/viewcvs?rev=292964view=rev
Log:
make sure that a non LogSystem/non LogChute object passed into the
LogManager is not just silently ignored but logged at warn level
(might even be error).
Modified:
Author: henning
Date: Sat Oct 1 05:19:19 2005
New Revision: 292967
URL: http://svn.apache.org/viewcvs?rev=292967view=rev
Log:
more eol fixup
Modified:
jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/log/Log.java
(contents, props changed)
Modified:
Author: henning
Date: Sat Oct 1 05:19:40 2005
New Revision: 292968
URL: http://svn.apache.org/viewcvs?rev=292968view=rev
Log:
More EOL fixup
Modified:
jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/log/LogChuteSystem.java
(contents, props changed)
Modified:
Author: henning
Date: Sat Oct 1 05:20:09 2005
New Revision: 292969
URL: http://svn.apache.org/viewcvs?rev=292969view=rev
Log:
even _more_ eol fixup...
Modified:
jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/log/RuntimeLoggerLog.java
(contents, props changed)
I was trying to wrap my brain around the current log code, following a
possible null pointer dereference in LogManager and found a twisted
little maze of code...
Nathan, as this is your baby, do you object to some of the following
changes:
- Nuke the public C'tor for Log(). Do we want anyone
Author: henning
Date: Sat Oct 1 05:35:24 2005
New Revision: 292971
URL: http://svn.apache.org/viewcvs?rev=292971view=rev
Log:
Remove unread fields (found by findbugs)
Modified:
jakarta/velocity/core/trunk/src/java/org/apache/velocity/app/event/implement/IncludeRelativePath.java
Author: henning
Date: Sat Oct 1 05:36:19 2005
New Revision: 292972
URL: http://svn.apache.org/viewcvs?rev=292972view=rev
Log:
Make variable names start with lowercase letters. All variables are
private, so this is a non user visible change.
Modified:
Author: henning
Date: Sat Oct 1 05:37:24 2005
New Revision: 292973
URL: http://svn.apache.org/viewcvs?rev=292973view=rev
Log:
Don't leave fields uninitialized (found by findbugs)
Modified:
jakarta/velocity/core/trunk/src/java/org/apache/velocity/app/event/implement/IncludeNotFound.java
Author: henning
Date: Sat Oct 1 05:38:30 2005
New Revision: 292974
URL: http://svn.apache.org/viewcvs?rev=292974view=rev
Log:
Make constant definitions final.
Modified:
jakarta/velocity/core/trunk/src/java/org/apache/velocity/anakia/Escape.java
Author: henning
Date: Sat Oct 1 05:40:06 2005
New Revision: 292975
URL: http://svn.apache.org/viewcvs?rev=292975view=rev
Log:
fixup incomplete field synchronization. Also make inner class static
(does not need 'this').
Modified:
Author: henning
Date: Sat Oct 1 05:40:39 2005
New Revision: 292976
URL: http://svn.apache.org/viewcvs?rev=292976view=rev
Log:
make inner classes static
Modified:
jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/directive/Foreach.java
Author: henning
Date: Sat Oct 1 05:46:32 2005
New Revision: 292977
URL: http://svn.apache.org/viewcvs?rev=292977view=rev
Log:
Yet another concat string in loop occurence, found by findbugs
Modified:
Author: henning
Date: Sat Oct 1 05:59:31 2005
New Revision: 292978
URL: http://svn.apache.org/viewcvs?rev=292978view=rev
Log:
static Introspector object? Now that scares me.
And makes me wonder if ever anyone has tried to run two different
VelocityEngine instances with different Introspectors
Author: henning
Date: Sat Oct 1 06:00:40 2005
New Revision: 292979
URL: http://svn.apache.org/viewcvs?rev=292979view=rev
Log:
Defuse potential NPE. (findbugs)
Modified:
jakarta/velocity/core/trunk/src/java/org/apache/velocity/texen/ant/TexenTask.java
Modified:
Author: henning
Date: Sat Oct 1 06:11:39 2005
New Revision: 292980
URL: http://svn.apache.org/viewcvs?rev=292980view=rev
Log:
Remove String(String) C'tor.
Can anyone tell me whether this whole code segment is actually
correct? Because a method returning 'null' and not having a void
return type
Author: henning
Date: Sat Oct 1 06:14:31 2005
New Revision: 292981
URL: http://svn.apache.org/viewcvs?rev=292981view=rev
Log:
Remove possible NPE for error path
Modified:
jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/resource/loader/JarResourceLoader.java
Modified:
Good catch.
I'm really appreciating the open source approach here of multiple eyes on
the same code.
WILL
- Original Message -
From: [EMAIL PROTECTED]
To: [EMAIL PROTECTED]
Sent: Saturday, October 01, 2005 5:59 AM
Subject: svn commit: r292978 -
[
http://issues.apache.org/jira/browse/VELOCITY-78?page=comments#action_12331028
]
Nathan Bubna commented on VELOCITY-78:
--
Yes, and no. This bug affected both Log4JLogSystem and the deprecated
SimpleLog4JLogSystem.
the patch for VELOCITY-403 fixes
[
http://issues.apache.org/jira/browse/VELOCITY-403?page=comments#action_12331029
]
Nathan Bubna commented on VELOCITY-403:
---
Good question. If i get some time later this weekend, i'll grep around the
docs for anything about the old LogSystem
This looks like a great plan. I'm excited to see 1.5 out the door.
On the planning note, i hope to get VelocityTools 1.2 out before
Christmas (i really want it to beat 1.5 out of the gate, if only by a
little bit). the only real holdup there is the Tomcat 5.5 issue and
giving some attention to
sounds good, but on Veltag, i think it would eventually be a better
fit for veltools than the core. it's web-oriented and would benefit
greatly from some attention and toolbox support. also, my company is
doing a lot more jsp these days. despite the improvements in it
lately, i really don't
yeah, i'm pretty sure that's some early work of Geir's or Gabriel's.
i believe it was the predecessor to veltools. i say kill it; it has
been both superceded and abandoned. :)
On 9/30/05, Will Glass-Husain [EMAIL PROTECTED] wrote:
Hi,
Related to my last email, there's a folder in contrib
On 10/1/05, Henning P. Schmiedehausen [EMAIL PROTECTED] wrote:
[EMAIL PROTECTED] writes:
-rsvc.warn(JarResourceLoader : you are using a deprecated
configuration
+log.warn(JarResourceLoader : you are using a deprecated
configuration
Ah, I see that Nathan's
[
http://issues.apache.org/jira/browse/VELOCITY-193?page=comments#action_12331030
]
Nathan Bubna commented on VELOCITY-193:
---
yes, this was fixed as part of VELOCITY-403.
the shutdown()/finalize() (see above) in AvalonLogChute were added to unset the
On 10/1/05, Henning P. Schmiedehausen [EMAIL PROTECTED] wrote:
I was trying to wrap my brain around the current log code, following a
possible null pointer dereference in LogManager and found a twisted
little maze of code...
Nathan, as this is your baby, do you object to some of the following
[ http://issues.apache.org/jira/browse/VELOCITY-403?page=all ]
Nathan Bubna updated VELOCITY-403:
--
Attachment: docs.logging.patch
Ok. here's a patch for the developer's guide and the logging examples. :)
Enhance Velocity's LogSystem and internal use
[
http://issues.apache.org/jira/browse/VELOCITY-193?page=comments#action_12331036
]
Nathan Bubna commented on VELOCITY-193:
---
the patch to VELOCITY-78 for SimpleLog4JLogSystem should be the end of this bug.
Memory/logger leak with multiple
[ http://issues.apache.org/jira/browse/VELOCITY-78?page=all ]
Nathan Bubna updated VELOCITY-78:
-
Attachment: simplelog4jlogsystem.patch
before/just-in-case you ask...
apply this and then there should be no question about resolving the bug.
[
http://issues.apache.org/jira/browse/VELOCITY-403?page=comments#action_12331037
]
Nathan Bubna commented on VELOCITY-403:
---
while patching the docs, i noticed that in the Velocity Configuration Keys and
Values section of the dev guide
[
http://issues.apache.org/jira/browse/VELOCITY-403?page=comments#action_12331038
]
Nathan Bubna commented on VELOCITY-403:
---
while patching the dev guide i noticed the following in the Configuration Keys
and Values section:
Nathan Bubna [EMAIL PROTECTED] writes:
On 10/1/05, Henning P. Schmiedehausen [EMAIL PROTECTED] wrote:
[EMAIL PROTECTED] writes:
-rsvc.warn(JarResourceLoader : you are using a deprecated
configuration
+log.warn(JarResourceLoader : you are using a deprecated
[
http://issues.apache.org/jira/browse/VELOCITY-403?page=comments#action_12331041
]
Will Glass-Husain commented on VELOCITY-403:
makes sense to me.
Enhance Velocity's LogSystem and internal use thereof
Not intentionally. The only change I made to Nathan's patch was updating
log4j in build/lib
There were a couple of spots where (for some bizarre reason) my Eclipse
couldn't match the patch file. (all the LogSystem classes, for example).
Maybe it was an EOL issue. I fixed all those by hand,
This code block looks ok to me. We can't remove this because that would be
incompatible. If we remove this check and always return for bad methods
then
$validobject.nullMethod()
would echo $validobject.nullMethod() pre-update and empty string
post-update.
WILL
- Original Message
Author: wglass
Date: Sat Oct 1 18:30:30 2005
New Revision: 293051
URL: http://svn.apache.org/viewcvs?rev=293051view=rev
Log:
bizarrely, I missed this in the VELOCITY-403 patch.
I suspect all the delete/add combinations caused patch to miss the changes.
Modified:
Author: wglass
Date: Sat Oct 1 18:33:55 2005
New Revision: 293052
URL: http://svn.apache.org/viewcvs?rev=293052view=rev
Log:
doc patch from Nathan for new LogChute interface
Modified:
jakarta/velocity/core/trunk/xdocs/docs/developer-guide.xml
Modified:
Author: wglass
Date: Sat Oct 1 18:34:20 2005
New Revision: 293053
URL: http://svn.apache.org/viewcvs?rev=293053view=rev
Log:
change LoggerExample to use LogChute
Modified:
jakarta/velocity/core/trunk/examples/logger_example/LoggerExample.java
Modified:
[
http://issues.apache.org/jira/browse/VELOCITY-403?page=comments#action_12331042
]
Will Glass-Husain commented on VELOCITY-403:
docs.logging.patch applied. Leaving this open. The stack trace issue is still
unresolved and there might be
Author: wglass
Date: Sat Oct 1 21:11:55 2005
New Revision: 293068
URL: http://svn.apache.org/viewcvs?rev=293068view=rev
Log:
Properly close the appender. Addresses Velocity-193 and Velocity-78.
Modified:
[ http://issues.apache.org/jira/browse/VELOCITY-193?page=all ]
Will Glass-Husain resolved VELOCITY-193:
Resolution: Fixed
Ok, applied the patch. I agree with Henning that relying on finalize is not
perfect, but it should be a big
[ http://issues.apache.org/jira/browse/VELOCITY-78?page=all ]
Will Glass-Husain resolved VELOCITY-78:
---
Resolution: Fixed
Thanks for giving in, Nathan and making the patch.
I agree with Henning's comment in Velocity-193 that relying on
[ http://issues.apache.org/jira/browse/VELOCITY-75?page=all ]
Will Glass-Husain resolved VELOCITY-75:
---
Resolution: Fixed
Velocity-403 has been applied. (includes fix to this issue).
Send all log output to System.out in the event that
[
http://issues.apache.org/jira/browse/VELOCITY-373?page=comments#action_12331059
]
Will Glass-Husain commented on VELOCITY-373:
Malcom,
Just as a heads-up. If you are willing and have the time to restructure this
patch, we'll need it by
Nathan,
I agree. Veltag would fit nicely in Velocity-Tools. Though it's a little
different in nature than the other items you have there. Maybe there's a
way of setting it up to automatically load tools so that it integrates with
the framework. Regardless, it'd be nice to give it a little
Dear Wiki user,
You have subscribed to a wiki page or wiki category on Jakarta-velocity Wiki
for change notification.
The following page has been changed by WillGlassHusain:
http://wiki.apache.org/jakarta-velocity/ContributedCode
The comment on the change is:
Move files from contrib to Wiki
Dear Wiki user,
You have subscribed to a wiki page or wiki category on Jakarta-velocity Wiki
for change notification.
The following page has been changed by WillGlassHusain:
http://wiki.apache.org/jakarta-velocity/EnhydraVelocity
The comment on the change is:
move from contrib
New page:
This
Dear Wiki user,
You have subscribed to a wiki page or wiki category on Jakarta-velocity Wiki
for change notification.
The following page has been changed by WillGlassHusain:
http://wiki.apache.org/jakarta-velocity/EmacsVtlMode
The comment on the change is:
moved from contrib to Wiki
New page:
Dear Wiki user,
You have subscribed to a wiki page or wiki category on Jakarta-velocity Wiki
for change notification.
The following page has been changed by WillGlassHusain:
http://wiki.apache.org/jakarta-velocity/IntelliJTemplates
New page:
IntelliJ-Live-Template.xml is a set of templates for
Dear Wiki user,
You have subscribed to a wiki page or wiki category on Jakarta-velocity Wiki
for change notification.
The following page has been changed by WillGlassHusain:
http://wiki.apache.org/jakarta-velocity/JEditTemplate
The comment on the change is:
move from contrib to Wiki
New page:
Dear Wiki user,
You have subscribed to a wiki page or wiki category on Jakarta-velocity Wiki
for change notification.
The following page has been changed by WillGlassHusain:
http://wiki.apache.org/jakarta-velocity/UltraEdit
The comment on the change is:
move from contrib to Wiki
New page:
Dear Wiki user,
You have subscribed to a wiki page or wiki category on Jakarta-velocity Wiki
for change notification.
The following page has been changed by WillGlassHusain:
http://wiki.apache.org/jakarta-velocity/JEditTemplate
The comment on the change is:
add file name
Dear Wiki user,
You have subscribed to a wiki page or wiki category on Jakarta-velocity Wiki
for change notification.
The following page has been changed by WillGlassHusain:
http://wiki.apache.org/jakarta-velocity/UltraEdit
The comment on the change is:
boldface file name
Dear Wiki user,
You have subscribed to a wiki page or wiki category on Jakarta-velocity Wiki
for change notification.
The following page has been changed by WillGlassHusain:
http://wiki.apache.org/jakarta-velocity/IntelliJTemplates
The comment on the change is:
add file name
Dear Wiki user,
You have subscribed to a wiki page or wiki category on Jakarta-velocity Wiki
for change notification.
The following page has been changed by WillGlassHusain:
http://wiki.apache.org/jakarta-velocity/EmacsVtlMode
The comment on the change is:
add file name
Dear Wiki user,
You have subscribed to a wiki page or wiki category on Jakarta-velocity Wiki
for change notification.
The following page has been changed by WillGlassHusain:
http://wiki.apache.org/jakarta-velocity/StdErrLogSystem
The comment on the change is:
move from contrib to Wiki
New
[ http://issues.apache.org/jira/browse/VELOCITY-400?page=all ]
Will Glass-Husain resolved VELOCITY-400:
Resolution: Fixed
kept experimental items by committers - renamed experimental. permanently
dropped early velocity-struts code. moved
Author: wglass
Date: Sat Oct 1 22:02:58 2005
New Revision: 293073
URL: http://svn.apache.org/viewcvs?rev=293073view=rev
Log:
clean up contrib directory, rename experimental. VELOCITY-400.
Added:
jakarta/velocity/core/trunk/experimental/
69 matches
Mail list logo
