Hi,
I fully agree with you here and it really is a good thing that this bug
got found and fixed. Yes, really nice job finding that, Alexey. The
whole business around hashCode() and equals() is very often overlooked
and was apparently so by us. It is good that there are contributors to
find and
[ http://issues.apache.org/jira/browse/VELOCITY-453?page=all ]
Alexey Panchenko updated VELOCITY-453:
--
Attachment: ASTMethod.java.patch2006-09-28
[PATCH] Fix IntrospectionCacheData caching
--
Will Glass-Husain wrote:
I'll take responsibility to work with Alexey in cleaning this up.
Though to be fair, you are holding the patch to a higher standard than
the original. Of course the original had a bug.
I have added the following patch to VELOCITY-453
It is small patch, so it could
Hi Alexey,
thanks a lot for your patch. I like it and we should apply it. I very
much appreciate that you understood my mail as peer review and not
critique per se.
[...]
This is just waste of processor cycles.
The Class does not override the equals().
Hm. It does not for the Sun JDK and
To whom it may engage...
This is an automated request, but not an unsolicited one. For
more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at [EMAIL PROTECTED]
Project jakarta-velocity-test has an issue affecting its community integration.
This
To whom it may engage...
This is an automated request, but not an unsolicited one. For
more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at [EMAIL PROTECTED]
Project jakarta-velocity-test has an issue affecting its community integration.
This
To whom it may engage...
This is an automated request, but not an unsolicited one. For
more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at [EMAIL PROTECTED]
Project jakarta-velocity-test has an issue affecting its community integration.
This
FYI.
* I applied Alexey's modified patch. (much appreciated)
* I applied Alexey's new hashCode routine. seems reasonable to me.
* I added NPE checks to equals and hash code. While Alexey's point
these are never needed is a good one, I worry about the consequence of
adding code in the future
Author: wglass
Date: Thu Sep 28 13:19:29 2006
New Revision: 451013
URL: http://svn.apache.org/viewvc?view=revrev=451013
Log:
Modified recent method cache patch to improve style and robustness. Revised
equals hashcode, added equals unit test. Related to VELOCITY-453.
Added:
Will Glass-Husain wrote:
* I applied Alexey's modified patch. (much appreciated)
You missed one point - MethodCacheKey is a static class in my patch.
The methodName is copied from the ASTMethod into the MethodCacheKey,
so the MethodCacheKey doesn't need access to it's parent class.
* I
Hi Alexey,
Thanks for the note. I made MethodCacheKey a public inner class so
that we could access it from the unit test. Couldn't figure out a
better way to do this, though suggestions are welcome.
I know, the NPE checks seem a little silly. Still, the checks are
cheap. I worry that the
Author: wglass
Date: Thu Sep 28 21:59:53 2006
New Revision: 451120
URL: http://svn.apache.org/viewvc?view=revrev=451120
Log:
tweaked inner class of method cache. Related to VELOCITY-453.
Modified:
jakarta/velocity/engine/trunk/src/java/org/apache/velocity/runtime/parser/node/ASTMethod.java
Will Glass-Husain wrote:
Hi Alexey,
Thanks for the note. I made MethodCacheKey a public inner class so
that we could access it from the unit test. Couldn't figure out a
better way to do this, though suggestions are welcome.
@@ -320,7 +341,7 @@
* public access (and complete
13 matches
Mail list logo
