Re: [RFC PATCH 1/2] random: emit reseed notifications for PRNGs

2023-08-23 Thread Greg KH
On Wed, Aug 23, 2023 at 12:08:35PM +0200, Babis Chalios wrote: > > > On 23/8/23 12:06, Greg KH wrote: > > CAUTION: This email originated from outside of the organization. Do not > > click links or open attachments unless you can confirm the sender and know &g

Re: [RFC PATCH 1/2] random: emit reseed notifications for PRNGs

2023-08-23 Thread Greg KH
On Wed, Aug 23, 2023 at 11:27:11AM +0200, Babis Chalios wrote: > Hi Greg, > > On 23/8/23 11:08, Greg KH wrote: > > CAUTION: This email originated from outside of the organization. Do not > > click links or open attachments unless you can confirm the sender and know &g

Re: [RFC PATCH 1/2] random: emit reseed notifications for PRNGs

2023-08-23 Thread Greg KH
On Wed, Aug 23, 2023 at 11:01:05AM +0200, Babis Chalios wrote: > Sometimes, PRNGs need to reseed. For example, on a regular timer > interval, to ensure nothing consumes a random value for longer than e.g. > 5 minutes, or when VMs get cloned, to ensure seeds don't leak in to > clones. > > The

Re: [PATCH 2/2] vdpa: Enable strict validation for netlinks ops

2023-07-26 Thread Greg KH
On Wed, Jul 26, 2023 at 09:49:44PM +0300, Dragos Tatulea wrote: > The previous patch added the missing nla policies that were required for > validation to work. > > Now strict validation on netlink ops can be enabled. This patch does it. > > Signed-off-by: Dragos Tatulea > --- >

Re: [PATCH 1/3] virtio-crypto: fixup potential cpu stall when free unused bufs

2023-06-10 Thread Greg KH
On Sat, Jun 10, 2023 at 11:20:49AM +0800, Xianting Tian wrote: > > 在 2023/6/9 下午11:57, Michael S. Tsirkin 写道: > > On Fri, Jun 09, 2023 at 09:18:15PM +0800, Xianting Tian wrote: > > > From: Xianting Tian > > > > > > Cpu stall issue may happen if device is configured with multi queues > > > and

Re: [PATCH 1/3] virtio-crypto: fixup potential cpu stall when free unused bufs

2023-06-09 Thread Greg KH
On Fri, Jun 09, 2023 at 09:49:39PM +0800, Xianting Tian wrote: > > 在 2023/6/9 下午9:41, Greg KH 写道: > > On Fri, Jun 09, 2023 at 03:39:24PM +0200, Greg KH wrote: > > > On Fri, Jun 09, 2023 at 09:18:15PM +0800, Xianting Tian wrote: > > > > From: Xianting Tian >

Re: [PATCH 1/3] virtio-crypto: fixup potential cpu stall when free unused bufs

2023-06-09 Thread Greg KH
On Fri, Jun 09, 2023 at 03:39:24PM +0200, Greg KH wrote: > On Fri, Jun 09, 2023 at 09:18:15PM +0800, Xianting Tian wrote: > > From: Xianting Tian > > > > Cpu stall issue may happen if device is configured with multi queues > > and large queue depth, so fix it. >

Re: [PATCH 1/3] virtio-crypto: fixup potential cpu stall when free unused bufs

2023-06-09 Thread Greg KH
On Fri, Jun 09, 2023 at 09:18:15PM +0800, Xianting Tian wrote: > From: Xianting Tian > > Cpu stall issue may happen if device is configured with multi queues > and large queue depth, so fix it. > > Signed-off-by: Xianting Tian > --- > drivers/crypto/virtio/virtio_crypto_core.c | 1 + > 1 file

Re: [PATCH net-next v1] xsk: introduce xsk_dma_cbs

2023-04-23 Thread Greg KH
On Sun, Apr 23, 2023 at 02:58:36PM +0800, Xuan Zhuo wrote: > On Sun, 23 Apr 2023 08:45:20 +0200, Greg KH > wrote: > > On Sun, Apr 23, 2023 at 02:25:45PM +0800, Xuan Zhuo wrote: > > > The purpose of this patch is to allow driver pass the own dma callbacks > > > to xs

Re: [PATCH net-next v1] xsk: introduce xsk_dma_cbs

2023-04-23 Thread Greg KH
On Sun, Apr 23, 2023 at 02:25:45PM +0800, Xuan Zhuo wrote: > The purpose of this patch is to allow driver pass the own dma callbacks > to xsk. > > This is to cope with the scene of virtio-net. If virtio does not have > VIRTIO_F_ACCESS_PLATFORM, then virtio cannot use DMA API. In this case, > xsk

Re: [PATCH 0/2] net/af_packet: Fix kernel BUG in __skb_gso_segment

2023-01-04 Thread Greg KH
On Thu, Dec 22, 2022 at 10:35:43AM +0200, Tudor Ambarus wrote: > The series is intended for sta...@vger.kernel.org # 5.4+ > > Syzkaller reported the following bug on linux-5.{4, 10, 15}.y: > https://syzkaller.appspot.com/bug?id=ce5575575f074c33ff80d104f5baee26f22e95f5 > > The upstream commit

Re: kernel BUG in __skb_gso_segment

2022-12-21 Thread Greg KH
On Wed, Dec 21, 2022 at 09:42:59AM +0200, Tudor Ambarus wrote: > > > On 21.12.2022 09:37, Greg KH wrote: > > On Wed, Dec 21, 2022 at 09:28:16AM +0200, Tudor Ambarus wrote: > > > Hi, > > > > > > I added Greg KH to the thread, maybe he can shed s

Re: kernel BUG in __skb_gso_segment

2022-12-20 Thread Greg KH
On Wed, Dec 21, 2022 at 09:28:16AM +0200, Tudor Ambarus wrote: > Hi, > > I added Greg KH to the thread, maybe he can shed some light on whether > new support can be marked as fixes and backported to stable. The rules > on what kind of patches are accepted into the -stable tree don'

Re: [PATCH v2] vduse: prevent uninitialized memory accesses

2022-08-29 Thread Greg KH
On Mon, Aug 29, 2022 at 09:34:24AM +0200, Maxime Coquelin wrote: > If the VDUSE application provides a smaller config space > than the driver expects, the driver may use uninitialized > memory from the stack. > > This patch prevents it by initializing the buffer passed by > the driver to store

Re: [PATCH] VMCI: Update maintainers for VMCI

2022-07-28 Thread Greg KH
On Tue, Jul 26, 2022 at 09:35:54AM -0700, rajesh jalisatgi wrote: This message never made it to any public list as it was sent in HTML format. Please resend in a way we can properly access it. thanks, greg k-h ___ Virtualization mailing list

Re: [PATCH] VMCI: Update maintainers for VMCI

2022-07-26 Thread Greg KH
On Mon, Jul 25, 2022 at 06:29:25PM +, Vishnu Dasa wrote: > > > On Jul 25, 2022, at 11:05 AM, Greg KH wrote: > > > > On Mon, Jul 25, 2022 at 09:32:46AM -0700, vd...@vmware.com wrote: > >> From: Vishnu Dasa > >> > >> Remove Rajesh a

Re: [PATCH] VMCI: Update maintainers for VMCI

2022-07-25 Thread Greg KH
On Mon, Jul 25, 2022 at 09:32:46AM -0700, vd...@vmware.com wrote: > From: Vishnu Dasa > > Remove Rajesh as a maintainer for the VMCI driver. Why? > > Acked-by: Bryan Tan > Signed-off-by: Vishnu Dasa I need an ack from the person that is being removed here, for obvious reasons. Any

Re: [linux-next:master] BUILD REGRESSION 088b9c375534d905a4d337c78db3b3bfbb52c4a0

2022-07-07 Thread Greg KH
On Thu, Jul 07, 2022 at 02:56:34PM +0800, kernel test robot wrote: > tree/branch: > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > branch HEAD: 088b9c375534d905a4d337c78db3b3bfbb52c4a0 Add linux-next > specific files for 20220706 > > Error/Warning reports: > >

Re: [PATCH v2 2/3] vdpa: Add a device object for vdpa management device

2022-05-17 Thread Greg KH
On Tue, May 17, 2022 at 02:29:38PM +0800, Jason Wang wrote: > On Mon, May 16, 2022 at 7:54 PM Greg KH wrote: > > > > On Mon, May 16, 2022 at 06:34:36AM -0400, Michael S. Tsirkin wrote: > > > On Mon, May 16, 2022 at 06:31:18PM +0800, Yongji Xie wrote: > > >

Re: [PATCH v2 2/3] vdpa: Add a device object for vdpa management device

2022-05-16 Thread Greg KH
On Mon, May 16, 2022 at 06:34:36AM -0400, Michael S. Tsirkin wrote: > On Mon, May 16, 2022 at 06:31:18PM +0800, Yongji Xie wrote: > > On Mon, May 16, 2022 at 5:54 PM Michael S. Tsirkin wrote: > > > > > > On Mon, May 16, 2022 at 05:31:27PM +0800, Yongji Xie wrote: > > > > On Mon, May 16, 2022 at

Re: [PATCH v2 1/3] vduse: Pass management device pointer to vduse_dev_init_vdpa()

2022-05-16 Thread Greg KH
On Mon, May 16, 2022 at 02:03:40PM +0800, Xie Yongji wrote: > Pass management device pointer from vdpa_dev_add() to > vduse_dev_init_vdpa() rather than using the static > variable directly. > > No functional change. > > Signed-off-by: Xie Yongji > --- > drivers/vdpa/vdpa_user/vduse_dev.c | 9

Re: [PATCH v2 3/3] Docs/ABI/testing: Add VDUSE sysfs interface ABI document

2022-05-16 Thread Greg KH
On Mon, May 16, 2022 at 02:03:42PM +0800, Xie Yongji wrote: > This adds missing documentation for VDUSE sysfs interface ABI > under Documentation/ABI/testing. > > Signed-off-by: Xie Yongji > --- > Documentation/ABI/testing/sysfs-class-vduse | 33 + > MAINTAINERS

Re: [PATCH v2 2/3] vdpa: Add a device object for vdpa management device

2022-05-16 Thread Greg KH
On Mon, May 16, 2022 at 02:03:41PM +0800, Xie Yongji wrote: > Introduce a device object for vdpa management device to control > its lifecycle. And the device name will be used to match > VDPA_ATTR_MGMTDEV_DEV_NAME field of netlink message rather than > using parent device name. > > With this

Re: [PATCH 1/2] vduse: Remove empty vduse_mgmtdev_release()

2022-05-12 Thread Greg KH
On Thu, May 12, 2022 at 05:31:51PM +0800, Yongji Xie wrote: > On Thu, May 12, 2022 at 4:58 PM Greg KH wrote: > > > > On Thu, May 12, 2022 at 03:51:38PM +0800, Yongji Xie wrote: > > > On Thu, May 12, 2022 at 2:19 PM Greg KH > > > wrote: > > > > >

Re: [PATCH 1/2] vduse: Remove empty vduse_mgmtdev_release()

2022-05-12 Thread Greg KH
On Thu, May 12, 2022 at 03:51:38PM +0800, Yongji Xie wrote: > On Thu, May 12, 2022 at 2:19 PM Greg KH wrote: > > > > On Thu, May 12, 2022 at 01:59:00PM +0800, Yongji Xie wrote: > > > On Thu, May 12, 2022 at 1:23 PM Greg KH > > > wrote: > > > > >

Re: [PATCH 1/2] vduse: Remove empty vduse_mgmtdev_release()

2022-05-12 Thread Greg KH
On Thu, May 12, 2022 at 01:59:00PM +0800, Yongji Xie wrote: > On Thu, May 12, 2022 at 1:23 PM Greg KH wrote: > > > > On Thu, May 12, 2022 at 01:19:58PM +0800, Yongji Xie wrote: > > > On Wed, May 11, 2022 at 10:02 PM Greg KH > > > wrote: > > > > >

Re: [PATCH 1/2] vduse: Remove empty vduse_mgmtdev_release()

2022-05-11 Thread Greg KH
On Thu, May 12, 2022 at 01:19:58PM +0800, Yongji Xie wrote: > On Wed, May 11, 2022 at 10:02 PM Greg KH wrote: > > > > On Wed, May 11, 2022 at 09:55:22PM +0800, Xie Yongji wrote: > > > It's not recommended to provide an "empty" release function > > > for

Re: [PATCH 1/2] vduse: Remove empty vduse_mgmtdev_release()

2022-05-11 Thread Greg KH
On Wed, May 11, 2022 at 09:55:22PM +0800, Xie Yongji wrote: > It's not recommended to provide an "empty" release function > for the device object as Documentation/core-api/kobject.rst > mentioned. "it is a bug to have an empty release function" is more like it :) > So let's allocate the device

Re: [PATCH v2] vduse: Fix NULL pointer dereference on sysfs access

2022-04-26 Thread Greg KH
On Tue, Apr 26, 2022 at 10:02:02PM +0800, Yongji Xie wrote: > On Tue, Apr 26, 2022 at 9:34 PM Greg KH wrote: > > > > On Tue, Apr 26, 2022 at 09:17:23PM +0800, Yongji Xie wrote: > > > On Tue, Apr 26, 2022 at 8:44 PM Greg KH > > > wrote: > > > > >

Re: [PATCH v2] vduse: Fix NULL pointer dereference on sysfs access

2022-04-26 Thread Greg KH
On Tue, Apr 26, 2022 at 09:17:23PM +0800, Yongji Xie wrote: > On Tue, Apr 26, 2022 at 8:44 PM Greg KH wrote: > > > > On Tue, Apr 26, 2022 at 08:30:38PM +0800, Yongji Xie wrote: > > > On Tue, Apr 26, 2022 at 6:26 PM Greg KH > > > wrote: > > > > >

Re: [PATCH v2] vduse: Fix NULL pointer dereference on sysfs access

2022-04-26 Thread Greg KH
On Tue, Apr 26, 2022 at 08:30:38PM +0800, Yongji Xie wrote: > On Tue, Apr 26, 2022 at 6:26 PM Greg KH wrote: > > > > On Tue, Apr 26, 2022 at 05:41:15PM +0800, Yongji Xie wrote: > > > On Tue, Apr 26, 2022 at 4:07 PM Greg KH > > > wrote: > > > > >

Re: [PATCH v2] vduse: Fix NULL pointer dereference on sysfs access

2022-04-26 Thread Greg KH
On Tue, Apr 26, 2022 at 05:41:15PM +0800, Yongji Xie wrote: > On Tue, Apr 26, 2022 at 4:07 PM Greg KH wrote: > > > > On Tue, Apr 26, 2022 at 03:36:56PM +0800, Xie Yongji wrote: > > > The control device has no drvdata. So we will get a > > > NULL pointer d

Re: [PATCH v2] vduse: Fix NULL pointer dereference on sysfs access

2022-04-26 Thread Greg KH
On Tue, Apr 26, 2022 at 03:36:56PM +0800, Xie Yongji wrote: > The control device has no drvdata. So we will get a > NULL pointer dereference when accessing control > device's msg_timeout attribute via sysfs: > > [ 132.841881][ T3644] BUG: kernel NULL pointer dereference, address: >

Re: [PATCH] vduse: Fix NULL pointer dereference on sysfs access

2022-04-26 Thread Greg KH
On Tue, Apr 26, 2022 at 02:01:03PM +0800, Xie Yongji wrote: > The control device has no drvdata. So we will get a NULL > NULL pointer dereference when accessing control device's > msg_timeout via sysfs: > > [ 132.841881][ T3644] BUG: kernel NULL pointer dereference, address: > 00f8 >

Re: [PATCH RESEND] VMCI: Check exclusive_vectors when freeing interrupt 1

2022-03-18 Thread Greg KH
On Thu, Mar 17, 2022 at 10:58:43PM -0700, vd...@vmware.com wrote: > From: Vishnu Dasa > > free_irq() may be called to free an interrupt that was not > allocated. Add missing 'if' statement to check for > exclusive_vectors when freeing interrupt 1. > > Fixes: cc68f2177fcb ("VMCI: dma dg:

Re: [PATCH 1/1] vhost: Protect the virtqueue from being cleared whilst still in use

2022-03-14 Thread Greg KH
On Mon, Mar 14, 2022 at 08:43:02AM +, Lee Jones wrote: > vhost_vsock_handle_tx_kick() already holds the mutex during its call > to vhost_get_vq_desc(). All we have to do here is take the same lock > during virtqueue clean-up and we mitigate the reported issues. > > Also WARN() as a

Re: [PATCH] VMCI: Fix a couple of failure paths in vmci_guest_probe_device()

2022-03-10 Thread Greg KH
On Wed, Mar 09, 2022 at 10:24:56AM -0800, Vishnu Dasa wrote: > notification_bitmap may not be released when VMCI_CAPS_DMA_DATAGRAM > capability is missing from the device. Add missing > 'err_free_notification_bitmap' label and use it instead of > 'err_free_data_buffers' to avoid this. > >

Re: [PATCH 1/1] vhost: Protect the virtqueue from being cleared whilst still in use

2022-03-08 Thread Greg KH
On Tue, Mar 08, 2022 at 05:55:58AM -0500, Michael S. Tsirkin wrote: > On Tue, Mar 08, 2022 at 10:57:42AM +0100, Greg KH wrote: > > On Tue, Mar 08, 2022 at 09:15:27AM +, Lee Jones wrote: > > > On Tue, 08 Mar 2022, Greg KH wrote: > > > > > > > On Tue, Mar

Re: [PATCH 1/1] vhost: Protect the virtqueue from being cleared whilst still in use

2022-03-08 Thread Greg KH
On Tue, Mar 08, 2022 at 09:15:27AM +, Lee Jones wrote: > On Tue, 08 Mar 2022, Greg KH wrote: > > > On Tue, Mar 08, 2022 at 08:10:06AM +, Lee Jones wrote: > > > On Mon, 07 Mar 2022, Greg KH wrote: > > > > > > > On Mon, Mar 07,

Re: [PATCH 1/1] vhost: Protect the virtqueue from being cleared whilst still in use

2022-03-08 Thread Greg KH
On Tue, Mar 08, 2022 at 08:10:06AM +, Lee Jones wrote: > On Mon, 07 Mar 2022, Greg KH wrote: > > > On Mon, Mar 07, 2022 at 07:17:57PM +, Lee Jones wrote: > > > vhost_vsock_handle_tx_kick() already holds the mutex during its call > > > to vhost_get_vq_d

Re: [PATCH 1/1] vhost: Protect the virtqueue from being cleared whilst still in use

2022-03-07 Thread Greg KH
On Mon, Mar 07, 2022 at 07:17:57PM +, Lee Jones wrote: > vhost_vsock_handle_tx_kick() already holds the mutex during its call > to vhost_get_vq_desc(). All we have to do here is take the same lock > during virtqueue clean-up and we mitigate the reported issues. > > Also WARN() as a

Re: [PATCH v2 2/8] VMCI: dma dg: add MMIO access to registers

2022-02-04 Thread Greg KH
On Thu, Feb 03, 2022 at 05:12:31AM -0800, Jorgen Hansen wrote: > Detect the support for MMIO access through examination of the length > of the region requested in BAR1. If it is 256KB, the VMCI device > supports MMIO access to registers. > > If MMIO access is supported, map the area of the region

Re: [PATCH v2 4/8] VMCI: dma dg: set OS page size

2022-02-04 Thread Greg KH
On Thu, Feb 03, 2022 at 05:12:33AM -0800, Jorgen Hansen wrote: > Tell the device the page size used by the OS. > > Reviewed-by: Vishnu Dasa > Signed-off-by: Jorgen Hansen > --- > drivers/misc/vmw_vmci/vmci_guest.c | 9 + > include/linux/vmw_vmci_defs.h | 1 + > 2 files changed, 10

Re: [PATCH 4.9] virtio_pci: Support surprise removal of virtio pci device

2022-01-07 Thread Greg KH
On Fri, Jan 07, 2022 at 04:51:28PM +0800, Yang Wei wrote: > From: Parav Pandit > > commit 43bb40c5b92659966bdf4bfe584fde0a3575a049 upstream. > > When a virtio pci device undergo surprise removal (aka async removal in > PCIe spec), mark the device as broken so that any upper layer drivers can >

Re: [PATCH v3] virtio_blk: Add support for lifetime feature

2021-12-23 Thread Greg KH
[note, your original post had the to: line messed up, which caused any response to this to not work well in many email clients, this is a resend...] On Tue, Dec 07, 2021 at 10:55:17AM -0700, Enrico Granata wrote: > From: Enrico Granata > > The VirtIO TC has adopted a new feature in virtio-blk

Re: [PATCH v3 1/3] MAINTAINERS: Update maintainers for paravirt ops and VMware hypervisor interface

2021-11-11 Thread Greg KH
On Thu, Nov 11, 2021 at 11:40:02AM -0800, Srivatsa S. Bhat wrote: > On Thu, Nov 11, 2021 at 07:45:02PM +0100, Greg KH wrote: > > On Thu, Nov 11, 2021 at 07:39:16AM -0800, Srivatsa S. Bhat wrote: > > > On Thu, Nov 11, 2021 at 07:50:39AM +0100, Greg KH wrote: > > > >

Re: [PATCH v3 1/3] MAINTAINERS: Update maintainers for paravirt ops and VMware hypervisor interface

2021-11-11 Thread Greg KH
On Thu, Nov 11, 2021 at 07:39:16AM -0800, Srivatsa S. Bhat wrote: > On Thu, Nov 11, 2021 at 07:50:39AM +0100, Greg KH wrote: > > On Wed, Nov 10, 2021 at 12:08:16PM -0800, Srivatsa S. Bhat wrote: > > > From: Srivatsa S. Bhat (VMware) > > > > > > Deep ha

Re: [PATCH v3 1/3] MAINTAINERS: Update maintainers for paravirt ops and VMware hypervisor interface

2021-11-10 Thread Greg KH
On Wed, Nov 10, 2021 at 12:08:16PM -0800, Srivatsa S. Bhat wrote: > From: Srivatsa S. Bhat (VMware) > > Deep has decided to transfer maintainership of the VMware hypervisor > interface to Srivatsa, and the joint-maintainership of paravirt ops in > the Linux kernel to Srivatsa and Alexey. Update

Re: [PATCH v11 2/3] tty: hvc: pass DMA capable memory to put_chars()

2021-10-26 Thread Greg KH
On Tue, Oct 26, 2021 at 02:11:51PM +0800, Xianting Tian wrote: > > 在 2021/10/26 下午2:10, Greg KH 写道: > > On Tue, Oct 26, 2021 at 02:02:21PM +0800, Xianting Tian wrote: > > > 在 2021/10/26 下午1:10, Jiri Slaby 写道: > > > > On 15. 10. 21, 4:46, Xianting Tian wrote: >

Re: [PATCH v11 2/3] tty: hvc: pass DMA capable memory to put_chars()

2021-10-26 Thread Greg KH
On Tue, Oct 26, 2021 at 02:02:21PM +0800, Xianting Tian wrote: > 在 2021/10/26 下午1:10, Jiri Slaby 写道: > > On 15. 10. 21, 4:46, Xianting Tian wrote: > > > @@ -151,9 +142,11 @@ static uint32_t vtermnos[MAX_NR_HVC_CONSOLES] = > > >   static void hvc_console_print(struct console *co, const char *b, > >

Re: [PATCH v11 0/3] make hvc pass dma capable memory to its backend

2021-10-21 Thread Greg KH
On Fri, Oct 15, 2021 at 10:46:55AM +0800, Xianting Tian wrote: > Dear all, > > This patch series make hvc framework pass DMA capable memory to > put_chars() of hvc backend(eg, virtio-console), and revert commit > c4baad5029 ("virtio-console: avoid DMA from stack”) Thanks for sticking with this,

Re: [PATCH v11 2/3] tty: hvc: pass DMA capable memory to put_chars()

2021-10-20 Thread Greg KH
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I

Re: [PATCH 1/2] i2c: virtio: disable timeout handling

2021-10-19 Thread Greg KH
On Wed, Oct 20, 2021 at 12:20:13PM +0800, Jie Deng wrote: > > On 2021/10/20 2:14, Wolfram Sang wrote: > > > I think it is set to HZ currently, though I haven't tried big > > > transfers but I still get into some issues with Qemu based stuff. > > > Maybe we can bump it up to few seconds :) > > If

Re: [PATCH 1/2] i2c: virtio: disable timeout handling

2021-10-19 Thread Greg KH
On Tue, Oct 19, 2021 at 03:12:03PM +0530, Viresh Kumar wrote: > On 19-10-21, 11:36, Greg KH wrote: > > What is the "other side" here? Is it something that you trust or not? > > Other side can be a remote processor (for remoteproc over virtio or > something simil

Re: [PATCH 1/2] i2c: virtio: disable timeout handling

2021-10-19 Thread Greg KH
On Tue, Oct 19, 2021 at 01:39:13PM +0530, Viresh Kumar wrote: > +Greg. > > On 19-10-21, 09:46, Vincent Whitchurch wrote: > > If a timeout is hit, it can result is incorrect data on the I2C bus > > and/or memory corruptions in the guest since the device can still be > > operating on the buffers it

Re: [PATCH v5 12/16] PCI: Add pci_iomap_host_shared(), pci_iomap_host_shared_range()

2021-10-18 Thread Greg KH
On Mon, Oct 11, 2021 at 07:59:17AM -0400, Michael S. Tsirkin wrote: > On Sun, Oct 10, 2021 at 03:22:39PM -0700, Andi Kleen wrote: > > > > > To which Andi replied > > > One problem with removing the ioremap opt-in is that > > > it's still possible for drivers to get at devices without going

Re: [PATCH v5 12/16] PCI: Add pci_iomap_host_shared(), pci_iomap_host_shared_range()

2021-10-18 Thread Greg KH
On Tue, Oct 12, 2021 at 11:35:04AM -0700, Andi Kleen wrote: > > I'd rather see more concerted efforts focused/limited core changes > > rather than leaf driver changes until there is a clearer definition of > > hardened. > > A hardened driver is a driver that Ah, you do define this, thank you! >

Re: [PATCH v5 12/16] PCI: Add pci_iomap_host_shared(), pci_iomap_host_shared_range()

2021-10-18 Thread Greg KH
On Sun, Oct 10, 2021 at 03:11:23PM -0700, Andi Kleen wrote: > > On 10/9/2021 1:39 PM, Dan Williams wrote: > > On Sat, Oct 9, 2021 at 2:53 AM Michael S. Tsirkin wrote: > > > On Fri, Oct 08, 2021 at 05:37:07PM -0700, Kuppuswamy Sathyanarayanan > > > wrote: > > > > From: Andi Kleen > > > > > > >

Re: [PATCH v10 2/3] tty: hvc: pass DMA capable memory to put_chars()

2021-10-14 Thread Greg KH
On Thu, Oct 14, 2021 at 04:34:59PM +0800, Xianting Tian wrote: > > 在 2021/10/10 下午1:33, Greg KH 写道: > > On Sat, Oct 09, 2021 at 11:45:23PM +0800, Xianting Tian wrote: > > > 在 2021/10/9 下午7:58, Greg KH 写道: > > > > Did you look at the placement using pa

Re: [PATCH v10 2/3] tty: hvc: pass DMA capable memory to put_chars()

2021-10-09 Thread Greg KH
On Sat, Oct 09, 2021 at 11:45:23PM +0800, Xianting Tian wrote: > > 在 2021/10/9 下午7:58, Greg KH 写道: > > Did you look at the placement using pahole as to how this structure now > > looks? > > thanks for all your commnts. for this one, do you mean I need to remove the > b

Re: [PATCH v10 2/3] tty: hvc: pass DMA capable memory to put_chars()

2021-10-09 Thread Greg KH
On Sat, Oct 09, 2021 at 07:48:28PM +0800, Xianting Tian wrote: > --- a/drivers/tty/hvc/hvc_console.h > +++ b/drivers/tty/hvc/hvc_console.h > @@ -32,13 +32,21 @@ > */ > #define HVC_ALLOC_TTY_ADAPTERS 8 > > +/* > + * These sizes are most efficient for vio, because they are the > + *

Re: [PATCH v10 2/3] tty: hvc: pass DMA capable memory to put_chars()

2021-10-09 Thread Greg KH
On Sat, Oct 09, 2021 at 07:48:28PM +0800, Xianting Tian wrote: > As well known, hvc backend can register its opertions to hvc backend. > the operations contain put_chars(), get_chars() and so on. > > Some hvc backend may do dma in its operations. eg, put_chars() of > virtio-console. But in the

Re: virtio-net: kernel panic in virtio_net.c

2021-10-08 Thread Greg KH
On Sat, Oct 09, 2021 at 12:27:08AM +0800, Xuan Zhuo wrote: > On Fri, 8 Oct 2021 10:06:57 +0200, Greg KH wrote: > > On Fri, Oct 08, 2021 at 12:17:26AM +0800, Xuan Zhuo wrote: > > > On Thu, 7 Oct 2021 17:25:02 +0200, Greg KH > > > wrote: > > > > On Thu, Oct

Re: virtio-net: kernel panic in virtio_net.c

2021-10-08 Thread Greg KH
On Fri, Oct 08, 2021 at 12:17:26AM +0800, Xuan Zhuo wrote: > On Thu, 7 Oct 2021 17:25:02 +0200, Greg KH wrote: > > On Thu, Oct 07, 2021 at 11:06:12PM +0800, Xuan Zhuo wrote: > > > On Thu, 07 Oct 2021 14:04:22 +0200, Corentin Noël > > > wrote: > > > > I've

Re: virtio-net: kernel panic in virtio_net.c

2021-10-07 Thread Greg KH
On Thu, Oct 07, 2021 at 11:06:12PM +0800, Xuan Zhuo wrote: > On Thu, 07 Oct 2021 14:04:22 +0200, Corentin Noël > wrote: > > I've been experiencing crashes with 5.14-rc1 and above that do not > > occur with 5.13, > > I should have fixed this problem before. I don't know why, I just looked at >

Re: virtio-net: kernel panic in virtio_net.c

2021-10-07 Thread Greg KH
On Thu, Oct 07, 2021 at 04:02:10PM +0200, Corentin Noël wrote: > Le jeudi 07 octobre 2021 à 06:51 -0700, Eric Dumazet a écrit : > > On Thu, Oct 7, 2021 at 6:11 AM Michael S. Tsirkin > > wrote: > > > On Thu, Oct 07, 2021 at 02:04:22PM +0200, Corentin Noël wrote: > > > > I've been experiencing

Re: [PATCH v8 2/3] tty: hvc: pass DMA capable memory to put_chars()

2021-09-18 Thread Greg KH
On Sat, Sep 18, 2021 at 08:32:01PM +0800, Xianting Tian wrote: > hi > > Will you consider to continue the disscussion of this patch? thanks I do not see a newer version of this series. thanks, greg k-h ___ Virtualization mailing list

Re: [RESEND][PATCH] virtio_console: protect max_nr_ports to avoid invalid value

2021-08-27 Thread Greg KH
On Fri, Aug 20, 2021 at 03:52:19PM +0800, Xianting Tian wrote: > In theory untrusted remote host can pass a big or overflow value > of max_nr_ports to guest, it may cause guest system consumes > a lot of memory when create vqs and other impacts. How can you have a untrusted host? Can't they do a

Re: [PATCH v7 1/2] tty: hvc: pass DMA capable memory to put_chars()

2021-08-17 Thread Greg KH
On Tue, Aug 17, 2021 at 09:22:59PM +0800, Xianting Tian wrote: > We tested the patch, it worked normally. Who is "we"? > Signed-off-by: Xianting Tian Like I said before, I need another developer from your company to review and sign-off on this patch (and the other one), before I am willing to

Re: [PATCH v6 1/2] tty: hvc: pass DMA capable memory to put_chars()

2021-08-13 Thread Greg KH
On Thu, Aug 12, 2021 at 05:45:31PM +0800, Xianting Tian wrote: > As well known, hvc backend can register its opertions to hvc backend. > the opertions contain put_chars(), get_chars() and so on. > > Some hvc backend may do dma in its opertions. eg, put_chars() of > virtio-console. But in the code

Re: [PATCH v3 1/2] tty: hvc: pass DMA capable memory to put_chars()

2021-08-05 Thread Greg KH
On Thu, Aug 05, 2021 at 04:08:46PM +0800, Xianting Tian wrote: > > 在 2021/8/5 下午3:58, Jiri Slaby 写道: > > Hi, > > > > On 04. 08. 21, 4:54, Xianting Tian wrote: > > > @@ -933,6 +949,16 @@ struct hvc_struct *hvc_alloc(uint32_t vtermno, > > > int data, > > >   hp->outbuf_size = outbuf_size; > >

Re: [PATCH v10 16/17] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-07-29 Thread Greg KH
On Thu, Jul 29, 2021 at 03:35:02PM +0800, Xie Yongji wrote: > +/* > + * The basic configuration of a VDUSE device, which is used by > + * VDUSE_CREATE_DEV ioctl to create a VDUSE device. > + */ > +struct vduse_dev_config { Please document this structure using kernel doc so we know what all the

Re: [PATCH v14] i2c: virtio: add a virtio i2c frontend driver

2021-07-22 Thread Greg KH
On Thu, Jul 22, 2021 at 10:44:33AM +0530, Viresh Kumar wrote: > On 09-07-21, 10:25, Jie Deng wrote: > > Add an I2C bus driver for virtio para-virtualization. > > > > The controller can be emulated by the backend driver in > > any device model software by following the virtio protocol. > > > >

Re: [PATCH] MAINTAINERS: Update for VMCI driver

2021-07-21 Thread Greg KH
On Wed, Jul 21, 2021 at 09:26:15AM +, Jorgen Hansen wrote: > > > > On 21 Jul 2021, at 11:00, Greg KH wrote: > > > > On Wed, Jul 21, 2021 at 08:46:15AM +, Jorgen Hansen wrote: > >> > >> > >>> On 20 Jul 2021, at 12:39, Greg KH

Re: [PATCH] MAINTAINERS: Update for VMCI driver

2021-07-21 Thread Greg KH
On Wed, Jul 21, 2021 at 08:46:15AM +, Jorgen Hansen wrote: > > > > On 20 Jul 2021, at 12:39, Greg KH wrote: > > > > On Tue, Jul 20, 2021 at 03:29:01AM -0700, Jorgen Hansen wrote: > >> Add maintainer info for the VMware VMCI driver. > &

Re: [PATCH] MAINTAINERS: Update for VMCI driver

2021-07-20 Thread Greg KH
On Tue, Jul 20, 2021 at 06:04:15PM +, Vishnu Dasa wrote: > > On Jul 20, 2021, at 3:39 AM, Greg KH > mailto:gre...@linuxfoundation.org>> wrote: > > Also I would need an ack from Vishnu. > > Acked-by: Vishnu Dasa mailto:d...@vmware.com>> A maintainer

Re: [PATCH] MAINTAINERS: Update for VMCI driver

2021-07-20 Thread Greg KH
On Tue, Jul 20, 2021 at 03:29:01AM -0700, Jorgen Hansen wrote: > Add maintainer info for the VMware VMCI driver. > > Signed-off-by: Jorgen Hansen > --- > MAINTAINERS | 8 > 1 file changed, 8 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index a61f4f3..7e7c6fa 100644 > ---

Re: [PATCH v9 16/17] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-07-14 Thread Greg KH
On Wed, Jul 14, 2021 at 02:02:50PM +0800, Jason Wang wrote: > > 在 2021/7/14 下午1:54, Michael S. Tsirkin 写道: > > On Wed, Jul 14, 2021 at 01:45:39PM +0800, Jason Wang wrote: > > > > +static int vduse_dev_msg_sync(struct vduse_dev *dev, > > > > + struct vduse_dev_msg *msg)

Re: virtio-net: kernel panic in virtio_net.c

2021-06-09 Thread Greg KH
On Wed, Jun 09, 2021 at 03:51:20PM +0800, Xuan Zhuo wrote: > On Wed, 9 Jun 2021 08:24:20 +0200, Greg KH wrote: > > On Wed, Jun 09, 2021 at 02:08:17PM +0800, Xuan Zhuo wrote: > > > On Wed, 9 Jun 2021 06:50:10 +0200, Greg KH > > > wrote: > > > > On Wed, Jun

Re: virtio-net: kernel panic in virtio_net.c

2021-06-09 Thread Greg KH
On Wed, Jun 09, 2021 at 02:08:17PM +0800, Xuan Zhuo wrote: > On Wed, 9 Jun 2021 06:50:10 +0200, Greg KH wrote: > > On Wed, Jun 09, 2021 at 09:48:33AM +0800, Xuan Zhuo wrote: > > > > > With this patch and the latest net branch I no longer get crashes. > > > >

Re: virtio-net: kernel panic in virtio_net.c

2021-06-08 Thread Greg KH
On Wed, Jun 09, 2021 at 09:48:33AM +0800, Xuan Zhuo wrote: > > > With this patch and the latest net branch I no longer get crashes. > > > > Did this ever get properly submitted to the networking tree to get into > > 5.13-final? > > The patch has been submitted. > > [PATCH net] virtio-net:

Re: virtio-net: kernel panic in virtio_net.c

2021-06-08 Thread Greg KH
On Thu, Jun 03, 2021 at 10:57:52AM +0200, Corentin Noël wrote: > Le jeudi 03 juin 2021 à 10:44 +0800, Xuan Zhuo a écrit : > > On Wed, 02 Jun 2021 19:54:41 +0200, Corentin Noël < > > corentin.n...@collabora.com> wrote: > > > Sure, here is the decoded trace: > > > > > > [ 44.523231] skbuff:

Re: virtio-net: kernel panic in virtio_net.c

2021-06-01 Thread Greg KH
On Tue, Jun 01, 2021 at 06:06:50PM +0200, Corentin Noël wrote: > I've been experiencing crashes with 5.13 that do not occur with 5.12, > here is the crash trace: > > [ 47.713713] skbuff: skb_over_panic: text:b73a8354 len:3762 > put:3762 head:9e1e1e48e000 data:9e1e1e48e010

Re: Re: [PATCH v7 11/12] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-05-31 Thread Greg KH
On Mon, May 31, 2021 at 02:19:37PM +0800, Yongji Xie wrote: > Hi Greg, > > Thanks a lot for the review! > > On Mon, May 31, 2021 at 12:56 PM Greg KH wrote: > > > > On Mon, May 17, 2021 at 05:55:12PM +0800, Xie Yongji wrote: > > > +struct vduse_dev {

Re: [PATCH v7 11/12] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-05-30 Thread Greg KH
On Mon, May 17, 2021 at 05:55:12PM +0800, Xie Yongji wrote: > +struct vduse_dev { > + struct vduse_vdpa *vdev; > + struct device dev; > + struct cdev cdev; You now have 2 reference counted devices controling the lifespace of a single structure. A mess that is guaranteed to go wrong.

Re: [PATCH] treewide: Remove leading spaces in Kconfig files

2021-05-17 Thread Greg KH
On Mon, May 17, 2021 at 10:07:43AM +0200, Juerg Haefliger wrote: > On Mon, May 17, 2021 at 7:46 AM Greg KH wrote: > > > > On Sun, May 16, 2021 at 03:22:09PM +0200, Juerg Haefliger wrote: > > > There are a few occurences of leading spaces before tabs in a couple of > >

Re: [PATCH] treewide: Remove leading spaces in Kconfig files

2021-05-16 Thread Greg KH
On Sun, May 16, 2021 at 03:22:09PM +0200, Juerg Haefliger wrote: > There are a few occurences of leading spaces before tabs in a couple of > Kconfig files. Remove them by running the following command: > > $ find . -name 'Kconfig*' | xargs sed -r -i 's/^[ ]+\t/\t/' > > Signed-off-by: Juerg

Re: [PATCH 0/5] VDPA mlx5 fixes

2021-04-08 Thread Greg KH
On Thu, Apr 08, 2021 at 12:10:42PM +0300, Eli Cohen wrote: > Hi Michael, > > The following series contains fixes to mlx5 vdpa driver. Included first > is Siwei's fix to queried MTU was already reviewed a while ago and is > not in your tree. > > Patches 2 and 3 are required to allow mlx5_vdpa

Re: [PATCH for 5.10 v2 0/5] vdpa_sim: fix param validation in vdpasim_get_config()

2021-02-17 Thread Greg KH
On Tue, Feb 16, 2021 at 03:24:34PM +0100, Stefano Garzarella wrote: > v1: > https://lore.kernel.org/stable/20210211162519.215418-1-sgarz...@redhat.com/ > > v2: > - backport the upstream patch and related patches needed > > Commit 65b709586e22 ("vdpa_sim: add get_config callback in >

Re: [PATCH for 5.10] vdpa_sim: fix param validation in vdpasim_get_config()

2021-02-15 Thread Greg KH
On Mon, Feb 15, 2021 at 04:03:21PM +0100, Stefano Garzarella wrote: > On Mon, Feb 15, 2021 at 03:32:19PM +0100, Greg KH wrote: > > On Thu, Feb 11, 2021 at 05:25:19PM +0100, Stefano Garzarella wrote: > > > Commit 65b709586e222fa6ffd4166ac7fdb5d5dad113ee upstream. > &

Re: [PATCH for 5.10] vdpa_sim: fix param validation in vdpasim_get_config()

2021-02-15 Thread Greg KH
On Thu, Feb 11, 2021 at 05:25:19PM +0100, Stefano Garzarella wrote: > Commit 65b709586e222fa6ffd4166ac7fdb5d5dad113ee upstream. No, this really is not that commit, so please do not say it is. > Before this patch, if 'offset + len' was equal to > sizeof(struct virtio_net_config), the entire

Re: [PATCH v2 0/3] VMCI: Queue pair bug fixes

2021-01-26 Thread Greg KH
On Wed, Jan 20, 2021 at 08:32:04AM -0800, Jorgen Hansen wrote: > This series contains three bug fixes for the queue pair > implementation in the VMCI driver. > > v1 -> v2: > - format patches as a series > - use min_t instead of min to ensure size_t comparison > (issue pointed out by

Re: [PATCH v3] vhost_vdpa: fix the problem in vhost_vdpa_set_config_call

2021-01-11 Thread Greg KH
On Tue, Jan 12, 2021 at 01:36:29PM +0800, Cindy Lu wrote: > In vhost_vdpa_set_config_call, the cb.private should be vhost_vdpa. > this cb.private will finally use in vhost_vdpa_config_cb as > vhost_vdpa. Fix this issue. > > Fixes: 776f395004d82 ("vhost_vdpa: Support config interrupt in vdpa") >

Re: [PATCH v2] vhost_vdpa: fix the problem in vhost_vdpa_set_config_call

2021-01-11 Thread Greg KH
On Tue, Jan 12, 2021 at 01:32:27PM +0800, Cindy Lu wrote: > In vhost_vdpa_set_config_call, the cb.private should be vhost_vdpa. > this cb.private will finally use in vhost_vdpa_config_cb as > vhost_vdpa. Fix this issue. > > Signed-off-by: Cindy Lu > --- > drivers/vhost/vdpa.c | 2 +- > 1 file

Re: [PATCH] VMCI: Enforce queuepair max size for IOCTL_VMCI_QUEUEPAIR_ALLOC

2021-01-11 Thread Greg KH
On Mon, Jan 11, 2021 at 02:05:56PM +, Jorgen Hansen wrote: > On 11 Jan 2021, at 13:46, Greg KH wrote: > > > > On Mon, Jan 11, 2021 at 04:18:53AM -0800, Jorgen Hansen wrote: > >> When create the VMCI queue pair tracking data structures on the host > >> side

Re: [PATCH] VMCI: Enforce queuepair max size for IOCTL_VMCI_QUEUEPAIR_ALLOC

2021-01-11 Thread Greg KH
On Mon, Jan 11, 2021 at 04:18:53AM -0800, Jorgen Hansen wrote: > When create the VMCI queue pair tracking data structures on the host > side, the IOCTL for creating the VMCI queue pair didn't validate > the queue pair size parameters. This change adds checks for this. > > This avoids a memory

Re: [PATCH RESEND v2] virtio-input: add multi-touch support

2020-12-08 Thread Greg KH
On Tue, Dec 08, 2020 at 11:01:50PM +0200, Vasyl Vavrychuk wrote: > From: Mathias Crombez > > Without multi-touch slots allocated, ABS_MT_SLOT events will be lost by > input_handle_abs_event. > > Signed-off-by: Mathias Crombez > Signed-off-by: Vasyl Vavrychuk > Tested-by: Vasyl Vavrychuk >

Re: [PATCH AUTOSEL 5.9 22/33] vhost scsi: add lun parser helper

2020-11-30 Thread Greg KH
On Mon, Nov 30, 2020 at 02:52:11PM +0100, Paolo Bonzini wrote: > On 30/11/20 14:28, Greg KH wrote: > > > > Lines of code is not everything. If you think that this needs additional > > > > testing then that's fine and we can drop it, but not picking up a fix > >

Re: [PATCH AUTOSEL 5.9 22/33] vhost scsi: add lun parser helper

2020-11-30 Thread Greg KH
On Mon, Nov 30, 2020 at 09:33:46AM +0100, Paolo Bonzini wrote: > On 29/11/20 22:06, Sasha Levin wrote: > > On Sun, Nov 29, 2020 at 06:34:01PM +0100, Paolo Bonzini wrote: > > > On 29/11/20 05:13, Sasha Levin wrote: > > > > > Which doesn't seem to be suitable for stable either...  Patch 3/5 in > > >

Re: [RFC] treewide: cleanup unreachable breaks

2020-10-17 Thread Greg KH
On Sat, Oct 17, 2020 at 09:09:28AM -0700, t...@redhat.com wrote: > From: Tom Rix > > This is a upcoming change to clean up a new warning treewide. > I am wondering if the change could be one mega patch (see below) or > normal patch per file about 100 patches or somewhere half way by collecting >

  1   2   3   4   5   6   >