Re: [PATCH V1 vfio 0/9] Introduce a vfio driver over virtio devices

2023-10-22 Thread Michael S. Tsirkin
On Sun, Oct 22, 2023 at 11:20:31AM +0300, Yishai Hadas wrote: > On 17/10/2023 16:42, Yishai Hadas wrote: > > This series introduce a vfio driver over virtio devices to support the > > legacy interface functionality for VFs. > > > > Background, from the virtio spec [1]. > >

Re: [PATCH V1 vfio 0/9] Introduce a vfio driver over virtio devices

2023-10-22 Thread Yishai Hadas via Virtualization
On 17/10/2023 16:42, Yishai Hadas wrote: This series introduce a vfio driver over virtio devices to support the legacy interface functionality for VFs. Background, from the virtio spec [1]. In some systems, there is a need to

Re: [PATCH] virtio_ring: add an error code check in virtqueue_resize

2023-10-22 Thread Xuan Zhuo
On Fri, 20 Oct 2023 06:08:06 -0400, "Michael S. Tsirkin" wrote: > On Fri, Oct 20, 2023 at 05:50:22PM +0800, Xuan Zhuo wrote: > > On Fri, 20 Oct 2023 05:42:14 -0400, "Michael S. Tsirkin" > > wrote: > > > On Fri, Oct 20, 2023 at 05:36:41PM +0800, Xuan Zhuo wrote: > > > > On Fri, 20 Oct 2023

Re: [PATCH] virtio_ring: add an error code check in virtqueue_resize

2023-10-22 Thread Xuan Zhuo
On Mon, 23 Oct 2023 10:51:59 +0800, Su Hui wrote: > On 2023/10/23 10:26, Xuan Zhuo wrote: > Well, what are the cases where it can happen practically? > >>> Device error. Such as vp_active_vq() > >>> > >>> Thanks. > >> Hmm interesting. OK. But do callers know to recover? > > > > No. > > > >

Re: [PATCH v4 4/4] vduse: Add LSM hooks to check Virtio device type

2023-10-22 Thread Jason Wang
On Fri, Oct 20, 2023 at 11:58 PM Maxime Coquelin wrote: > > This patch introduces LSM hooks for devices creation, > destruction and opening operations, checking the > application is allowed to perform these operations for > the Virtio device type. > > Signed-off-by: Maxime Coquelin > --- Hi

Re: [PATCH net-next v1 16/19] virtio_net: xsk: rx: introduce receive_xsk() to recv xsk buffer

2023-10-22 Thread Xuan Zhuo
On Fri, 20 Oct 2023 14:57:06 +0800, Jason Wang wrote: > On Mon, Oct 16, 2023 at 8:01 PM Xuan Zhuo wrote: > > > > Implementing the logic of xsk rx. If this packet is not for XSK > > determined in XDP, then we need to copy once to generate a SKB. > > If it is for XSK, it is a zerocopy receive

Re: [PATCH v4 3/4] vduse: Temporarily disable control queue features

2023-10-22 Thread Jason Wang
On Fri, Oct 20, 2023 at 11:58 PM Maxime Coquelin wrote: > > Virtio-net driver control queue implementation is not safe > when used with VDUSE. If the VDUSE application does not > reply to control queue messages, it currently ends up > hanging the kernel thread sending this command. > > Some work

Re: [PATCH v4 0/7] vdpa: decouple reset of iotlb mapping from device reset

2023-10-22 Thread Jason Wang
Hi Si-Wei: On Sat, Oct 21, 2023 at 5:28 PM Si-Wei Liu wrote: > > In order to reduce needlessly high setup and teardown cost > of iotlb mapping during live migration, it's crucial to > decouple the vhost-vdpa iotlb abstraction from the virtio > device life cycle, i.e. iotlb mappings should be

[GIT PULL] virtio: last minute fixes

2023-10-22 Thread Michael S. Tsirkin
The following changes since commit 58720809f52779dc0f08e53e54b014209d13eebb: Linux 6.6-rc6 (2023-10-15 13:34:39 -0700) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for you to fetch changes up to

Re: [PATCH] virtio_ring: add an error code check in virtqueue_resize

2023-10-22 Thread Xuan Zhuo
On Mon, 23 Oct 2023 11:06:48 +0800, Su Hui wrote: > > On 2023/10/23 10:53, Xuan Zhuo wrote: > > On Mon, 23 Oct 2023 10:51:59 +0800, Su Hui wrote: > >> On 2023/10/23 10:26, Xuan Zhuo wrote: > >> Well, what are the cases where it can happen practically? > > Device error. Such as