balloon pages become movable within a guest.
Rafael Aquini (4):
mm: introduce compaction and migration for virtio ballooned pages
virtio_balloon: handle concurrent accesses to virtio_balloon struct
elements
virtio_balloon: introduce migration primitives to balloon pages
mm: add vm event
This patch introduces helper functions that teach compaction and migration bits
how to cope with pages which are part of a guest memory balloon, in order to
make them movable by memory compaction procedures.
Signed-off-by: Rafael Aquini aqu...@redhat.com
---
include/linux/mm.h | 17
This patch introduces access sychronization to critical elements of struct
virtio_balloon, in order to allow the thread concurrency compaction/migration
bits might ended up imposing to the balloon driver on several situations.
Signed-off-by: Rafael Aquini aqu...@redhat.com
---
drivers/virtio
This patch makes balloon pages movable at allocation time and introduces the
infrastructure needed to perform the balloon page migration operation.
Signed-off-by: Rafael Aquini aqu...@redhat.com
---
drivers/virtio/virtio_balloon.c | 96 ++-
include/linux
This patch is only for testing report purposes and shall be dropped in case of
the rest of this patchset getting accepted for merging.
Signed-off-by: Rafael Aquini aqu...@redhat.com
---
drivers/virtio/virtio_balloon.c |1 +
include/linux/vm_event_item.h |2 ++
mm/compaction.c
On Mon, Jun 25, 2012 at 07:31:38PM -0400, Konrad Rzeszutek Wilk wrote:
On Mon, Jun 25, 2012 at 7:25 PM, Rafael Aquini aqu...@redhat.com wrote:
This patch introduces helper functions that teach compaction and migration
bits
how to cope with pages which are part of a guest memory balloon
Mel,
First and foremost, thank you for taking the time to review these bits and
provide such valuable feedback.
On Tue, Jun 26, 2012 at 11:17:29AM +0100, Mel Gorman wrote:
+/* return 1 if page is part of a guest's memory balloon, 0 otherwise */
+static inline int PageBalloon(struct page
This patch introduces access sychronization to critical elements of struct
virtio_balloon, in order to allow the thread concurrency compaction/migration
bits might ended up imposing to the balloon driver on several situations.
Signed-off-by: Rafael Aquini aqu...@redhat.com
---
drivers/virtio
This patch introduces the helper functions as well as the necessary changes
to teach compaction and migration bits how to cope with pages which are
part of a guest memory balloon, in order to make them movable by memory
compaction procedures.
Signed-off-by: Rafael Aquini aqu...@redhat.com
balloon pages become movable within a guest.
Rafael Aquini (4):
mm: introduce compaction and migration for virtio ballooned pages
virtio_balloon: handle concurrent accesses to virtio_balloon struct
elements
virtio_balloon: introduce migration primitives to balloon pages
mm: add vm event
This patch makes balloon pages movable at allocation time and introduces the
infrastructure needed to perform the balloon page migration operation.
Signed-off-by: Rafael Aquini aqu...@redhat.com
---
drivers/virtio/virtio_balloon.c | 96 ++-
include/linux
This patch is only for testing report purposes and shall be dropped in case of
the rest of this patchset getting accepted for merging.
Signed-off-by: Rafael Aquini aqu...@redhat.com
---
drivers/virtio/virtio_balloon.c |1 +
include/linux/vm_event_item.h |2 ++
mm/compaction.c
On Fri, Jun 29, 2012 at 10:37:12AM +0900, Minchan Kim wrote:
Hi Rafael,
On 06/29/2012 06:49 AM, Rafael Aquini wrote:
This patchset follows the main idea discussed at 2012 LSFMMS section:
Ballooning for transparent huge pages -- http://lwn.net/Articles/490114/
Could you summarize
On Fri, Jun 29, 2012 at 02:32:11PM +0900, Minchan Kim wrote:
On 06/29/2012 06:49 AM, Rafael Aquini wrote:
This patch introduces the helper functions as well as the necessary changes
to teach compaction and migration bits how to cope with pages which are
part of a guest memory balloon
On Fri, Jun 29, 2012 at 04:31:57PM +0100, Mel Gorman wrote:
On Thu, Jun 28, 2012 at 06:49:39PM -0300, Rafael Aquini wrote:
This patch introduces the helper functions as well as the necessary changes
to teach compaction and migration bits how to cope with pages which are
part of a guest
On Fri, Jun 29, 2012 at 02:01:52PM +0930, Rusty Russell wrote:
On Thu, 28 Jun 2012 18:49:38 -0300, Rafael Aquini aqu...@redhat.com wrote:
This patchset follows the main idea discussed at 2012 LSFMMS section:
Ballooning for transparent huge pages -- http://lwn.net/Articles/490114
Howdy Minchan,
On Sat, Jun 30, 2012 at 07:03:33AM +0900, Minchan Kim wrote:
+static inline bool is_balloon_page(struct page *page)
+{
+return (page-mapping == balloon_mapping) ? true : false;
+}
What lock should it protect?
I'm afraid I didn't quite get
On Mon, Jul 02, 2012 at 10:25:58AM +0300, Michael S. Tsirkin wrote:
On Mon, Jul 02, 2012 at 10:35:47AM +0930, Rusty Russell wrote:
On Sun, 1 Jul 2012 12:20:51 +0300, Michael S. Tsirkin m...@redhat.com
wrote:
On Thu, Nov 03, 2011 at 06:12:53PM +1030, Rusty Russell wrote:
A virtio
On Tue, Jul 03, 2012 at 10:17:46AM +0930, Rusty Russell wrote:
On Mon, 2 Jul 2012 13:08:19 -0300, Rafael Aquini aqu...@redhat.com wrote:
As 'locking in balloon', may I assume the approach I took for the
compaction case
is OK and aligned to address these concerns of yours? If not, do
On Mon, Jul 02, 2012 at 08:36:02AM +0900, Minchan Kim wrote:
On 06/30/2012 10:34 AM, Rafael Aquini wrote:
void isolate_page_from_balloonlist(struct page* page)
{
page-mapping-a_ops-invalidatepage(page, 0);
}
if (is_balloon_page(page) (page_count(page) == 2
of ballooned pages and allow memory balloon pages become
movable within a guest, thus avoiding the aforementioned fragmentation issue.
Rafael Aquini (4):
mm: introduce compaction and migration for virtio ballooned pages
virtio_balloon: handle concurrent accesses to virtio_balloon struct
This patch introduces the helper functions as well as the necessary changes
to teach compaction and migration bits how to cope with pages which are
part of a guest memory balloon, in order to make them movable by memory
compaction procedures.
Signed-off-by: Rafael Aquini aqu...@redhat.com
This patch introduces access sychronization to critical elements of struct
virtio_balloon, in order to allow the thread concurrency compaction/migration
bits might ended up imposing to the balloon driver on several situations.
Signed-off-by: Rafael Aquini aqu...@redhat.com
---
drivers/virtio
This patch makes balloon pages movable at allocation time and introduces the
infrastructure needed to perform the balloon page migration operation.
Signed-off-by: Rafael Aquini aqu...@redhat.com
---
drivers/virtio/virtio_balloon.c | 96 ++-
include/linux
This patch is only for testing report purposes and shall be dropped in case of
the rest of this patchset getting accepted for merging.
Signed-off-by: Rafael Aquini aqu...@redhat.com
---
drivers/virtio/virtio_balloon.c |1 +
include/linux/vm_event_item.h |2 ++
mm/compaction.c
Howdy Rusty,
First and foremost, thank you very much for taking the time to go through this
proposal and provide me with such valuable feedback. I really appreciate that.
On Wed, Jul 04, 2012 at 04:08:23PM +0930, Rusty Russell wrote:
On Tue, 3 Jul 2012 20:48:50 -0300, Rafael Aquini aqu
This patch introduces the helper functions as well as the necessary changes
to teach compaction and migration bits how to cope with pages which are
part of a guest memory balloon, in order to make them movable by memory
compaction procedures.
Signed-off-by: Rafael Aquini aqu...@redhat.com
aware of ballooned pages and allow memory balloon pages become
movable within a guest, thus avoiding the aforementioned fragmentation issue
Rafael Aquini (3):
mm: introduce compaction and migration for virtio ballooned pages
virtio_balloon: introduce migration primitives to balloon pages
mm: add
pages list against
concurrent list handling operations;
Signed-off-by: Rafael Aquini aqu...@redhat.com
---
drivers/virtio/virtio_balloon.c | 145 ---
include/linux/virtio_balloon.h |4 ++
2 files changed, 141 insertions(+), 8
This patch is only for testing report purposes and shall be dropped in case of
the rest of this patchset getting accepted for merging.
Signed-off-by: Rafael Aquini aqu...@redhat.com
---
drivers/virtio/virtio_balloon.c |1 +
include/linux/vm_event_item.h |2 ++
mm/compaction.c
Howdy Andrew,
Thanks for taking the time to go through this work and provide me with such good
feedback.
On Wed, Jul 18, 2012 at 03:46:05PM -0700, Andrew Morton wrote:
On Tue, 17 Jul 2012 13:50:41 -0300
Rafael Aquini aqu...@redhat.com wrote:
This patch introduces the helper functions
Howdy Andrew,
Thanks for taking the time to go through this work and provide me with such good
feedback.
On Wed, Jul 18, 2012 at 03:49:08PM -0700, Andrew Morton wrote:
On Tue, 17 Jul 2012 13:50:42 -0300
Rafael Aquini aqu...@redhat.com wrote:
Besides making balloon pages movable
On Wed, Jul 18, 2012 at 04:12:39PM -0700, Andrew Morton wrote:
On Wed, 18 Jul 2012 20:07:07 -0300
Rafael Aquini aqu...@redhat.com wrote:
+}
+#else
+static inline bool is_balloon_page(struct page *page) { return
false; }
+static inline bool isolate_balloon_page
Howdy Minchan,
Once again, thanks for raising such valuable feedback over here.
On Wed, Jul 18, 2012 at 02:48:24PM +0900, Minchan Kim wrote:
+/* __isolate_lru_page() counterpart for a ballooned page */
+static bool isolate_balloon_page(struct page *page)
+{
+ if
On Mon, Jul 23, 2012 at 11:33:32AM +0900, Minchan Kim wrote:
Hi Rafael,
On Fri, Jul 20, 2012 at 04:48:59PM -0300, Rafael Aquini wrote:
Howdy Minchan,
Once again, thanks for raising such valuable feedback over here.
On Wed, Jul 18, 2012 at 02:48:24PM +0900, Minchan Kim wrote
On Mon, Jul 23, 2012 at 11:33:32AM +0900, Minchan Kim wrote:
Look at memory-hotplug, offline_page calls has_unmovable_pages, scan_lru_pages
and do_migrate_range which calls isolate_lru_page. They consider only LRU
pages
to migratable ones.
As promised, I looked into those bits. Yes, they
against
concurrent list handling operations;
Signed-off-by: Rafael Aquini aqu...@redhat.com
---
drivers/virtio/virtio_balloon.c | 138 +---
include/linux/virtio_balloon.h | 4 ++
2 files changed, 134 insertions(+), 8 deletions(-)
diff
.
This patch introduces the helper functions as well as the necessary changes
to teach compaction and migration bits how to cope with pages which are
part of a guest memory balloon, in order to make them movable by memory
compaction procedures.
Signed-off-by: Rafael Aquini aqu...@redhat.com
---
include/linux
aware of ballooned pages and allow memory balloon pages become
movable within a guest, thus avoiding the aforementioned fragmentation issue
Rafael Aquini (3):
mm: introduce compaction and migration for virtio ballooned pages
virtio_balloon: introduce migration primitives to balloon pages
mm: add
This patch is only for testing report purposes and shall be dropped in case of
the rest of this patchset getting accepted for merging.
Signed-off-by: Rafael Aquini aqu...@redhat.com
---
drivers/virtio/virtio_balloon.c | 1 +
include/linux/vm_event_item.h | 2 ++
mm/compaction.c
On Mon, Aug 06, 2012 at 02:38:23PM -0400, Rik van Riel wrote:
On 08/06/2012 09:56 AM, Rafael Aquini wrote:
@@ -846,6 +861,21 @@ static int unmap_and_move(new_page_t get_new_page,
unsigned long private,
goto out;
rc = __unmap_and_move(page, newpage, force
On Mon, Aug 06, 2012 at 03:06:49PM -0400, Rik van Riel wrote:
Just a plain rename would work.
Ok, I will rename it.
+static inline bool is_balloon_page(struct page *page)
+{
+return (page-mapping page-mapping == balloon_mapping);
+}
As an aside, since you are only comparing
.
This patch introduces the helper functions as well as the necessary changes
to teach compaction and migration bits how to cope with pages which are
part of a guest memory balloon, in order to make them movable by memory
compaction procedures.
Signed-off-by: Rafael Aquini aqu...@redhat.com
---
include/linux
This patch is only for testing report purposes and shall be dropped in case of
the rest of this patchset getting accepted for merging.
Signed-off-by: Rafael Aquini aqu...@redhat.com
---
drivers/virtio/virtio_balloon.c | 1 +
include/linux/vm_event_item.h | 2 ++
mm/compaction.c
aware of ballooned pages and allow memory balloon pages become
movable within a guest, thus avoiding the aforementioned fragmentation issue
Rafael Aquini (3):
mm: introduce compaction and migration for virtio ballooned pages
virtio_balloon: introduce migration primitives to balloon pages
mm: add
against
concurrent list handling operations;
Signed-off-by: Rafael Aquini aqu...@redhat.com
---
drivers/virtio/virtio_balloon.c | 138 +---
include/linux/virtio_balloon.h | 4 ++
2 files changed, 134 insertions(+), 8 deletions(-)
diff
On Thu, Aug 09, 2012 at 10:00:19AM +0100, Mel Gorman wrote:
On Wed, Aug 08, 2012 at 07:53:19PM -0300, Rafael Aquini wrote:
Memory fragmentation introduced by ballooning might reduce significantly
the number of 2MB contiguous memory blocks that can be used within a guest,
thus imposing
.
This patch introduces the helper functions as well as the necessary changes
to teach compaction and migration bits how to cope with pages which are
part of a guest memory balloon, in order to make them movable by memory
compaction procedures.
Signed-off-by: Rafael Aquini aqu...@redhat.com
---
include/linux
aware of ballooned pages and allow memory balloon pages become
movable within a guest, thus avoiding the aforementioned fragmentation issue
Rafael Aquini (4):
mm: introduce compaction and migration for virtio ballooned pages
virtio_balloon: introduce migration primitives to balloon pages
mm
against
concurrent list handling operations;
Signed-off-by: Rafael Aquini aqu...@redhat.com
---
drivers/virtio/virtio_balloon.c | 138 +---
include/linux/virtio_balloon.h | 4 ++
2 files changed, 134 insertions(+), 8 deletions(-)
diff
putback_movable_pages() to properly cope with cases where the isolated
pageset contains ballooned pages and LRU pages, thus fixing the mentioned
inelegant hack around putback_lru_pages().
Signed-off-by: Rafael Aquini aqu...@redhat.com
---
include/linux/migrate.h | 2 ++
mm/compaction.c
On Mon, Aug 13, 2012 at 11:26:19AM +0300, Michael S. Tsirkin wrote:
+static inline bool movable_balloon_page(struct page *page)
+{
+ return (page-mapping page-mapping == balloon_mapping);
I am guessing this needs smp_read_barrier_depends, and maybe
ACCESS_ONCE ...
I'm curious about
On Mon, Aug 13, 2012 at 11:41:23AM +0300, Michael S. Tsirkin wrote:
@@ -141,7 +151,10 @@ static void fill_balloon(struct virtio_balloon *vb,
size_t num)
set_page_pfns(vb-pfns + vb-num_pfns, page);
vb-num_pages += VIRTIO_BALLOON_PAGES_PER_PAGE;
On Tue, Aug 14, 2012 at 11:33:20AM +0300, Michael S. Tsirkin wrote:
On Tue, Aug 14, 2012 at 09:29:49AM +0930, Rusty Russell wrote:
On Mon, 13 Aug 2012 11:41:23 +0300, Michael S. Tsirkin m...@redhat.com
wrote:
On Fri, Aug 10, 2012 at 02:55:15PM -0300, Rafael Aquini wrote
On Tue, Aug 14, 2012 at 10:35:25PM +0300, Michael S. Tsirkin wrote:
+/* __isolate_lru_page() counterpart for a ballooned page */
+bool isolate_balloon_page(struct page *page)
+{
+ if (WARN_ON(!movable_balloon_page(page)))
Looks like this actually can happen if the page
On Tue, Aug 14, 2012 at 10:48:37PM +0300, Michael S. Tsirkin wrote:
E.g. kvm can emulate hyperv so it could in theory have hyperv balloon.
This is mm stuff it is best not to tie it to specific drivers.
But of course I agree this is not top priority, no need
to block submission on this,
On Tue, Aug 14, 2012 at 10:59:16PM +0300, Michael S. Tsirkin wrote:
What if there is more than one balloon device?
Is it possible to load this driver twice, or are you foreseeing a future
case
where this driver will be able to manage several distinct memory balloons
for
On Tue, Aug 14, 2012 at 11:24:01PM +0300, Michael S. Tsirkin wrote:
On Tue, Aug 14, 2012 at 05:08:31PM -0300, Rafael Aquini wrote:
On Tue, Aug 14, 2012 at 10:59:16PM +0300, Michael S. Tsirkin wrote:
What if there is more than one balloon device?
Is it possible to load
On Tue, Aug 14, 2012 at 11:49:06PM +0300, Michael S. Tsirkin wrote:
On Tue, Aug 14, 2012 at 05:29:50PM -0300, Rafael Aquini wrote:
On Tue, Aug 14, 2012 at 11:24:01PM +0300, Michael S. Tsirkin wrote:
On Tue, Aug 14, 2012 at 05:08:31PM -0300, Rafael Aquini wrote:
On Tue, Aug 14, 2012 at 10
On Tue, Aug 14, 2012 at 10:31:09PM +0300, Michael S. Tsirkin wrote:
now CPU1 executes the next instruction:
}
which would normally return to function's caller,
but it has been overwritten by CPU2 so we get corruption.
No?
At the point CPU2 is unloading the module,
aware of ballooned pages and allow memory balloon pages become
movable within a guest, thus avoiding the aforementioned fragmentation issue
Rafael Aquini (5):
mm: introduce a common interface for balloon pages mobility
mm: introduce compaction and migration for ballooned pages
virtio_balloon
.
This patch introduces a common interface to help a balloon driver on
making its page set movable to compaction, and thus allowing the system
to better leverage the compation efforts on memory defragmentation.
Signed-off-by: Rafael Aquini aqu...@redhat.com
---
include/linux/balloon_compaction.h | 113
against
concurrent list handling operations;
- virtio_baloon-pages list handling sync by RCU operations;
Signed-off-by: Rafael Aquini aqu...@redhat.com
---
drivers/virtio/virtio_balloon.c | 210 +---
1 file changed, 199 insertions(+), 11
.
This patch introduces the helper functions as well as the necessary changes
to teach compaction and migration bits how to cope with pages which are
part of a guest memory balloon, in order to make them movable by memory
compaction procedures.
Signed-off-by: Rafael Aquini aqu...@redhat.com
---
mm
putback_movable_pages() to properly cope with cases where the isolated
pageset contains ballooned pages and LRU pages, thus fixing the mentioned
inelegant hack around putback_lru_pages().
Signed-off-by: Rafael Aquini aqu...@redhat.com
---
include/linux/migrate.h | 2 ++
mm/compaction.c
This patch introduces a new set of vm event counters to keep track of
ballooned pages compaction activity.
Signed-off-by: Rafael Aquini aqu...@redhat.com
---
drivers/virtio/virtio_balloon.c | 2 ++
include/linux/vm_event_item.h | 8 +++-
mm/balloon_compaction.c | 6 --
mm
On Tue, Aug 21, 2012 at 06:41:42PM +0300, Michael S. Tsirkin wrote:
On Tue, Aug 21, 2012 at 05:16:06PM +0200, Peter Zijlstra wrote:
On Tue, 2012-08-21 at 16:52 +0300, Michael S. Tsirkin wrote:
+ rcu_read_lock();
+ mapping = rcu_dereference(page-mapping);
+
On Tue, Aug 21, 2012 at 04:52:23PM +0300, Michael S. Tsirkin wrote:
+ * address_space_operations utilized methods for ballooned pages:
+ * .migratepage- used to perform balloon's page migration (as is)
+ * .launder_page - used to isolate a page from balloon's page list
+ *
On Tue, Aug 21, 2012 at 09:24:32AM -0700, Paul E. McKenney wrote:
On Tue, Aug 21, 2012 at 05:20:11PM +0200, Peter Zijlstra wrote:
On Tue, 2012-08-21 at 09:47 -0300, Rafael Aquini wrote:
+ mapping = rcu_access_pointer(page-mapping);
+ if (mapping)
+ mapping
On Tue, Aug 21, 2012 at 10:13:30PM +0300, Michael S. Tsirkin wrote:
I believe rcu_dereference_protected() is what I want/need here, since this
code
is always called for pages which we hold locked (PG_locked bit).
It would only help if we locked the page while updating the mapping,
as
On Tue, Aug 21, 2012 at 10:16:12PM +0300, Michael S. Tsirkin wrote:
On Tue, Aug 21, 2012 at 02:55:03PM -0300, Rafael Aquini wrote:
On Tue, Aug 21, 2012 at 04:52:23PM +0300, Michael S. Tsirkin wrote:
+ * address_space_operations utilized methods for ballooned pages:
+ * .migratepage
On Tue, Aug 21, 2012 at 10:30:31PM +0300, Michael S. Tsirkin wrote:
On Tue, Aug 21, 2012 at 04:23:58PM -0300, Rafael Aquini wrote:
On Tue, Aug 21, 2012 at 10:13:30PM +0300, Michael S. Tsirkin wrote:
I believe rcu_dereference_protected() is what I want/need here, since
this code
On Wed, Aug 22, 2012 at 03:07:41AM +0300, Michael S. Tsirkin wrote:
On Tue, Aug 21, 2012 at 05:45:56PM -0300, Rafael Aquini wrote:
On Tue, Aug 21, 2012 at 10:30:31PM +0300, Michael S. Tsirkin wrote:
On Tue, Aug 21, 2012 at 04:23:58PM -0300, Rafael Aquini wrote:
On Tue, Aug 21, 2012 at 10
On Wed, Aug 22, 2012 at 12:33:17PM +0300, Michael S. Tsirkin wrote:
Hmm, so this will busy wait which is unelegant.
We need some event IMO.
No, it does not busy wait. leak_balloon() is mutual exclusive with migration
steps, so for the case we have one racing against the other, we really want
On Thu, Aug 23, 2012 at 01:01:07PM +0300, Michael S. Tsirkin wrote:
So, when remove_common() calls leak_balloon() looping on
vb-num_pages, that won't become a tight loop.
The scheme was apparently working before this series, and it will remain
working
after it.
It seems that before
On Thu, Aug 23, 2012 at 03:34:32PM +0300, Michael S. Tsirkin wrote:
So, nothing has changed here.
Yes, your patch does change things:
leak_balloon now might return without freeing any pages.
In that case we will not be making any progress, and just
spin, pinning CPU.
That's a transitory
On Thu, Aug 23, 2012 at 04:53:29PM +0300, Michael S. Tsirkin wrote:
On Thu, Aug 23, 2012 at 10:06:07AM -0300, Rafael Aquini wrote:
On Thu, Aug 23, 2012 at 03:34:32PM +0300, Michael S. Tsirkin wrote:
So, nothing has changed here.
Yes, your patch does change things:
leak_balloon now
On Thu, Aug 23, 2012 at 12:03:15PM -0400, Rik van Riel wrote:
Not longer - apparently forever unless user resend the leak command.
It's wrong - it should
1. not tell host if nothing was done
2. after migration finished leak and tell host
Agreed. If the balloon is told to leak N pages,
On Thu, Aug 23, 2012 at 07:25:05PM +0300, Michael S. Tsirkin wrote:
On Thu, Aug 23, 2012 at 04:53:28PM +0300, Michael S. Tsirkin wrote:
Basically it was very simple: we assumed page-lru was never
touched for an allocated page, so it's safe to use it for
internal book-keeping by the driver.
On Fri, Aug 24, 2012 at 02:36:16AM +0300, Michael S. Tsirkin wrote:
On Thu, Aug 23, 2012 at 02:28:45PM -0300, Rafael Aquini wrote:
On Thu, Aug 23, 2012 at 07:25:05PM +0300, Michael S. Tsirkin wrote:
On Thu, Aug 23, 2012 at 04:53:28PM +0300, Michael S. Tsirkin wrote:
Basically it was very
On Fri, Aug 24, 2012 at 02:36:16AM +0300, Michael S. Tsirkin wrote:
I would wake it each time after adding a page, then it
can stop waiting when it leaks enough.
But again, it's cleaner to just keep tracking all
pages, let mm hang on to them by keeping a reference.
Here is a rough idea on
On Thu, Aug 23, 2012 at 09:33:53PM -0300, Rafael Aquini wrote:
On Fri, Aug 24, 2012 at 02:36:16AM +0300, Michael S. Tsirkin wrote:
I would wake it each time after adding a page, then it
can stop waiting when it leaks enough.
But again, it's cleaner to just keep tracking all
pages, let mm
On Thu, Aug 23, 2012 at 09:38:48PM -0300, Rafael Aquini wrote:
On Thu, Aug 23, 2012 at 09:33:53PM -0300, Rafael Aquini wrote:
On Fri, Aug 24, 2012 at 02:36:16AM +0300, Michael S. Tsirkin wrote:
I would wake it each time after adding a page, then it
can stop waiting when it leaks enough
.
This patch introduces the helper functions as well as the necessary changes
to teach compaction and migration bits how to cope with pages which are
part of a guest memory balloon, in order to make them movable by memory
compaction procedures.
Signed-off-by: Rafael Aquini aqu...@redhat.com
---
mm
aware of ballooned pages and allow memory balloon pages become
movable within a guest, thus avoiding the aforementioned fragmentation issue
Rafael Aquini (5):
mm: introduce a common interface for balloon pages mobility
mm: introduce compaction and migration for ballooned pages
virtio_balloon
.
This patch introduces a common interface to help a balloon driver on
making its page set movable to compaction, and thus allowing the system
to better leverage the compation efforts on memory defragmentation.
Signed-off-by: Rafael Aquini aqu...@redhat.com
---
include/linux/balloon_compaction.h | 137
putback_movable_pages() to properly cope with cases where the isolated
pageset contains ballooned pages and LRU pages, thus fixing the mentioned
inelegant hack around putback_lru_pages().
Signed-off-by: Rafael Aquini aqu...@redhat.com
---
include/linux/migrate.h | 2 ++
mm/compaction.c
queue operations;
- pages_lock (spinlock): special protection to balloon's pages bookmarking
elements (list and atomic counters) against the
potential memory compaction concurrency;
Signed-off-by: Rafael Aquini aqu...@redhat.com
---
drivers
This patch introduces a new set of vm event counters to keep track of
ballooned pages compaction activity.
Signed-off-by: Rafael Aquini aqu...@redhat.com
---
drivers/virtio/virtio_balloon.c | 1 +
include/linux/vm_event_item.h | 8 +++-
mm/balloon_compaction.c | 2 ++
mm
On Sun, Aug 26, 2012 at 10:42:44AM +0300, Michael S. Tsirkin wrote:
Reading two atomics and doing math? Result can even be negative.
I did not look at use closely but it looks suspicious.
Doc on atomic_read says:
The read is atomic in that the return value is guaranteed to be one of the
On Sun, Aug 26, 2012 at 06:44:23PM +0300, Michael S. Tsirkin wrote:
I am simply asking how was this patchset tested.
It would be nice to have this info in commit log.
Since this is an optimization patch it is strange
to see one with no numbers at all.
For example, you probably run some
On Tue, Aug 28, 2012 at 06:54:10PM +0300, Michael S. Tsirkin wrote:
On Mon, Aug 27, 2012 at 04:47:13PM -0300, Rafael Aquini wrote:
On Sun, Aug 26, 2012 at 10:42:44AM +0300, Michael S. Tsirkin wrote:
Reading two atomics and doing math? Result can even be negative.
I did not look at use
1378 968
Compaction success 406 595
Compaction failures 972 373
Compaction pages moved 3104073 1790932
Compaction move failure 92713 41252
===END stress-highalloc
Rafael Aquini (5):
mm: introduce a common interface
.
This patch introduces a common interface to help a balloon driver on
making its page set movable to compaction, and thus allowing the system
to better leverage the compation efforts on memory defragmentation.
Signed-off-by: Rafael Aquini aqu...@redhat.com
---
include/linux/balloon_compaction.h | 147
.
This patch introduces the helper functions as well as the necessary changes
to teach compaction and migration bits how to cope with pages which are
part of a guest memory balloon, in order to make them movable by memory
compaction procedures.
Signed-off-by: Rafael Aquini aqu...@redhat.com
---
mm
putback_movable_pages() to properly cope with cases where the isolated
pageset contains ballooned pages and LRU pages, thus fixing the mentioned
inelegant hack around putback_lru_pages().
Signed-off-by: Rafael Aquini aqu...@redhat.com
---
include/linux/migrate.h | 2 ++
mm/compaction.c
bookmarking
elements (list and atomic counters) against the
potential memory compaction concurrency;
Signed-off-by: Rafael Aquini aqu...@redhat.com
---
drivers/virtio/virtio_balloon.c | 305 +---
1 file changed
This patch introduces a new set of vm event counters to keep track of
ballooned pages compaction activity.
Signed-off-by: Rafael Aquini aqu...@redhat.com
---
drivers/virtio/virtio_balloon.c | 1 +
include/linux/vm_event_item.h | 8 +++-
mm/balloon_compaction.c | 2 ++
mm
On Mon, Sep 17, 2012 at 03:15:52PM -0700, Andrew Morton wrote:
+ /* Number of balloon pages isolated from 'pages' list for compaction */
+ unsigned int num_isolated_pages;
Is it utterly inconceivable that this counter could exceed 4G, ever?
/* Number of balloon pages we've told
On Mon, Sep 17, 2012 at 03:15:43PM -0700, Andrew Morton wrote:
+/* return code to identify when a ballooned page has been migrated */
+#define BALLOON_MIGRATION_RETURN 0xba1100
I didn't really spend enough time to work out why this was done this
way, but I know a hack when I see one!
1 - 100 of 139 matches
Mail list logo
