Re: [waffle] [PATCH 1/3] waffle: add public func waffle_teardown()

2015-01-20 Thread Chad Versace
On 01/15/2015 07:21 AM, Emil Velikov wrote: It will be used to teardown the global state, make valgrind happy and catch (point out) a bug or two in the GL/EGL/etc implementations. See the man page for more details. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com ---

Re: [waffle] [PATCH 2/3] examples: make use of waffle_teardown

2015-01-20 Thread Chad Versace
On 01/15/2015 07:21 AM, Emil Velikov wrote: Using this we clear the global state thus the user can call waffle_init() multiple times, as things won't get clobbered. According to gl_basic we cleanup ~20K of leaks (still reachable) and catch a bug in the GL/dri2 loader :-) We catch a bug!

Re: [waffle] [PATCH 3/3] wflinfo: use waffle_teardown

2015-01-20 Thread Chad Versace
On 01/15/2015 07:21 AM, Emil Velikov wrote: Drop ~20k and ~10k of still reachable memory leaks, for the glx and x11_egl platforms respectively. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/utils/wflinfo.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-)

Re: [waffle] [PATCH 0/3] Add the waffle_teardown API

2015-01-20 Thread Chad Versace
On 01/15/2015 05:31 AM, Emil Velikov wrote: On 15 January 2015 at 15:21, Emil Velikov emil.l.veli...@gmail.com wrote: Hello all, As mentioned a while back, here is the function waffle_teardown. Its purpose is to cleanup the global state (the api_platform variable and the respective platform

Re: [waffle] [PATCH 01/17] include: Define macro WAFFLE_DEPRECATED_1_06

2015-01-20 Thread Chad Versace
On 01/15/2015 04:29 AM, Emil Velikov wrote: On 4 January 2015 at 22:02, Chad Versace chad.vers...@intel.com wrote: This macro annotates symbols as deprecated in Waffle 1.6. The compiler emits deprecation warnings only if the user enables the feature macro for the Waffle 1.6 API.

Re: [waffle] [PATCH v3 0/4] Initial NaCl patches v3

2015-01-20 Thread Chad Versace
On 01/04/2015 11:36 PM, Tapani Pälli wrote: Hello; Here is v3 of nacl support patches with many changes and fixes here and there! Thanks for Emil and Chad for review, I think it looks a lot cleaner now. In case you want to try on Chrome, I also put 'demo' of gl_basic here:

[waffle] [PATCH v2] waffle: make gl_basic to work with nacl

2015-01-20 Thread Tapani Pälli
v2: fixes in cmake (Emil Velikov, Chad Versace) Changed also nmf file content and generation, moved nacl example content to separate output path. Signed-off-by: Tapani Pälli tapani.pa...@intel.com --- .gitignore| 1 +

Re: [waffle] [PATCH v3 0/4] Initial NaCl patches v3

2015-01-20 Thread Tapani
On 01/20/2015 07:55 PM, Chad Versace wrote: On 01/04/2015 11:36 PM, Tapani Pälli wrote: Hello; Here is v3 of nacl support patches with many changes and fixes here and there! Thanks for Emil and Chad for review, I think it looks a lot cleaner now. In case you want to try on Chrome, I also put