Re: [waffle] [PATCH 6/6] nacl: Add an error when trying to use a robust access context.

[Chad Versace]

On 04/06/2016 09:59 PM, Tapani Pälli wrote:
> This looks correct to me;
> 
> Reviewed-by: Tapani Pälli 
> 
> Note that following patch is required to build waffle nacl support on any 
> recent nacl sdk versions:
> 
> https://lists.freedesktop.org/archives/waffle/2015-October/001266.html

Tapani, is your r-b for only patch 6/6 or the the complete series?
___
waffle mailing list
waffle@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/waffle

Re: [waffle] [PATCH 6/6] nacl: Add an error when trying to use a robust access context.

[Tapani Pälli]

This looks correct to me;

Reviewed-by: Tapani Pälli 

Note that following patch is required to build waffle nacl support on 
any recent nacl sdk versions:


https://lists.freedesktop.org/archives/waffle/2015-October/001266.html


On 04/06/2016 06:59 PM, Bas Nieuwenhuizen wrote:

Signed-off-by: Bas Nieuwenhuizen 
---
  src/waffle/nacl/nacl_config.c | 6 ++
  1 file changed, 6 insertions(+)

diff --git a/src/waffle/nacl/nacl_config.c b/src/waffle/nacl/nacl_config.c
index 9017775..668657b 100644
--- a/src/waffle/nacl/nacl_config.c
+++ b/src/waffle/nacl/nacl_config.c
@@ -63,6 +63,12 @@ nacl_config_choose(struct wcore_platform *wc_plat,
  goto error;
  }

+if (attrs->context_robust) {
+wcore_errorf(WAFFLE_ERROR_UNSUPPORTED_ON_PLATFORM,
+ "NaCl does not support robust contexts.");
+goto error;
+}
+
  unsigned attr = 0;

  // Max amount of attribs is hardcoded in nacl_config.h (64)


___
waffle mailing list
waffle@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/waffle