Re: [PATCH weston 02/10] desktop-shell: Fix coding style of add_popup_grab

2015-02-23 Thread Pekka Paalanen
On Fri, 13 Feb 2015 14:01:54 +0800 Jonas Ådahl jad...@gmail.com wrote: Signed-off-by: Jonas Ådahl jad...@gmail.com --- desktop-shell/shell.c | 37 - 1 file changed, 24 insertions(+), 13 deletions(-) Trivial, R-b me, pushed. c2b1011..01193ae master -

Re: [PATCH weston] configure.ac: make use of wayland-scanner.pc

2015-02-23 Thread sardemff7+wayland
On 2015-02-17 16:13, Emil Velikov wrote: Currently we use the wayland-scanner executable as found with AC_PATH_PROG, and then check the presence of wayland-scanner.pc Currently the latter is unused even if AC_PATH_PROG fails to find the binary. Rework things to use the pkg-config variable as a

Re: [PATCH libinput 00/15] tablet: support the remaining tools

2015-02-23 Thread Lyude
Hi! So, unfortunately as I said before I can't test most of these patches since I've only got the standard pen on my Intuos pro, none of the fact mice and whatnot. I did test what I could though and I found one bug: the button capabilities for the eraser on the Intuos Pro aren't reported properly.

Re: [PATCH weston 05/10] xdg-shell: Remove the flags from get_xdg_popup

2015-02-23 Thread Pekka Paalanen
On Fri, 13 Feb 2015 14:01:57 +0800 Jonas Ådahl jad...@gmail.com wrote: From: Jasper St. Pierre jstpie...@mecheye.net There haven't been any ideas for flags, so we don't need a useless, unused parameter hanging around. Any future ideas should be done with a new request entirely. ---

Re: [PATCH weston 01/10] desktop-shell: Simplify popup_end_grab popup_done sending loop

2015-02-23 Thread Pekka Paalanen
On Fri, 13 Feb 2015 14:01:53 +0800 Jonas Ådahl jad...@gmail.com wrote: Can just use wl_list_for_each_safe instead of dealing with pointers ourself. Signed-off-by: Jonas Ådahl jad...@gmail.com --- desktop-shell/shell.c | 36 +++- 1 file changed, 15

Re: [PATCH weston 04/10] xdg-shell: Remove the serial from popup_done

2015-02-23 Thread Pekka Paalanen
On Fri, 13 Feb 2015 14:01:56 +0800 Jonas Ådahl jad...@gmail.com wrote: From: Jasper St. Pierre jstpie...@mecheye.net It doesn't serve any purpose, as it's a serial that the client gave to the server when starting the popup, which the client already has. --- clients/window.c | 2 +-

Re: [PATCH weston 03/10] xdg-shell: Take a xdg_surface as the parent surface

2015-02-23 Thread Pekka Paalanen
On Fri, 13 Feb 2015 14:01:55 +0800 Jonas Ådahl jad...@gmail.com wrote: From: Jasper St. Pierre jstpie...@mecheye.net There is no other valid surface that we should be using here. --- clients/window.c | 14 +++--- desktop-shell/shell.c | 12 ++--

Re: [PATCH weston] configure.ac: make use of wayland-scanner.pc

2015-02-23 Thread Emil Velikov
On 23 February 2015 at 15:31, Emil Velikov emil.l.veli...@gmail.com wrote: On 23 February 2015 at 14:10, sardemff7+wayl...@sardemff7.net wrote: On 2015-02-17 16:13, Emil Velikov wrote: Currently we use the wayland-scanner executable as found with AC_PATH_PROG, and then check the presence of

Re: [PATCH weston] configure.ac: make use of wayland-scanner.pc

2015-02-23 Thread Emil Velikov
On 23 February 2015 at 14:10, sardemff7+wayl...@sardemff7.net wrote: On 2015-02-17 16:13, Emil Velikov wrote: Currently we use the wayland-scanner executable as found with AC_PATH_PROG, and then check the presence of wayland-scanner.pc Currently the latter is unused even if AC_PATH_PROG

[PATCH wayland] server: add helper functions for wl_global

2015-02-23 Thread Jonny Lamb
The intention here is to be able to find an existing wl_global using some search parameters and then get some information about it. --- src/wayland-server.c | 33 + src/wayland-server.h | 4 2 files changed, 37 insertions(+) diff --git a/src/wayland-server.c

Re: [PATCH wayland] server: add helper functions for wl_global

2015-02-23 Thread Daniel Stone
Hi, On 23 February 2015 at 16:36, Jonny Lamb jonny.l...@collabora.co.uk wrote: Il 23/02/2015 17:28, Derek Foreman ha scritto: On 23/02/15 10:02 AM, Jonny Lamb wrote: The intention here is to be able to find an existing wl_global using some search parameters and then get some information about

Re: [PATCH wayland] server: add helper functions for wl_global

2015-02-23 Thread Derek Foreman
On 23/02/15 10:02 AM, Jonny Lamb wrote: The intention here is to be able to find an existing wl_global using some search parameters and then get some information about it. I'm not sure I see a need for this, but if there is need there should also be documentation. :) ---

Re: [PATCH wayland] server: add helper functions for wl_global

2015-02-23 Thread Jonny Lamb
Il 23/02/2015 17:28, Derek Foreman ha scritto: On 23/02/15 10:02 AM, Jonny Lamb wrote: The intention here is to be able to find an existing wl_global using some search parameters and then get some information about it. I'm not sure I see a need for this, but if there is need there should also

Re: [PATCH weston] configure.ac: make use of wayland-scanner.pc

2015-02-23 Thread Emil Velikov
On 23 February 2015 at 19:20, Bill Spitzak spit...@gmail.com wrote: On 02/22/2015 11:52 PM, Pekka Paalanen wrote: I'll give Bill and Daniels a chance to comment, but meanwhile: Reviewed-by: Bryce Harrington br...@osg.samsung.com My only concern is that trying to build Wayland from scratch

Re: libinput: the road to 1.0

2015-02-23 Thread Peter Hutterer
On Mon, Feb 23, 2015 at 10:50:48AM +0100, Michal Suchanek wrote: Hello, I heard there is attempt to collect a database of mouse speeds (DPI) so all mice behave the same. yep, look at the hwdb/70-mouse.hwdb file in the systemd repo. it's fairly easy to add to it. What is the semantic of

Re: [PATCH libinput 10/11] touchpad: Refactor tp_get_*_touches_delta

2015-02-23 Thread Hans de Goede
Hi, On 23-02-15 04:02, Peter Hutterer wrote: On Wed, Feb 18, 2015 at 01:26:53PM +0100, Hans de Goede wrote: The two tp_get_*_touches_delta functions are almost identical, refactor them into one function. Signed-off-by: Hans de Goede hdego...@redhat.com --- ACK to the basics, but I'd like to

Re: [PATCH libinput 11/11] touchpad: Add support for swipe gestures

2015-02-23 Thread Hans de Goede
Hi, On 23-02-15 04:25, Peter Hutterer wrote: On Wed, Feb 18, 2015 at 01:26:54PM +0100, Hans de Goede wrote: Add support for swipe gestures. Signed-off-by: Hans de Goede hdego...@redhat.com unless noted otherwise, series Reviewed-by: Peter Hutterer peter.hutte...@who-t.net Thanks for the

Re: [PATCH libinput 07/11] touchpad: Gesture support preparation

2015-02-23 Thread Hans de Goede
Hi, On 23-02-15 03:56, Peter Hutterer wrote: On Wed, Feb 18, 2015 at 01:26:50PM +0100, Hans de Goede wrote: Handle everything which is not handeld by the tap, (soft)button or edge-scroll typo: handled Fixed. code/statemachines in a unified way. Everything is treated as a X-finger

Re: libinput: the road to 1.0

2015-02-23 Thread Michal Suchanek
Hello, I heard there is attempt to collect a database of mouse speeds (DPI) so all mice behave the same. What is the semantic of speed for trackballs? Technically the DPI of scanning the ball movement can be determined and is often part of the specification but the perceived speed will likely

The 1.7.0 version of Wayland and Weston was released on February 14th, 2014. ?

2015-02-23 Thread scsijon
According to http://wayland.freedesktop.org/releases.html A typo or did someone get lucky? :-) ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

[PATCH libinput 03/26] test: fix double comparison macros

2015-02-23 Thread Peter Hutterer
args needs to be within () to ensure correct calculation Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/litest.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/test/litest.h b/test/litest.h index 4553c87..dd1ad9a 100644 --- a/test/litest.h +++

[PATCH libinput 20/26] tablet: support airbrush wheel as slider

2015-02-23 Thread Peter Hutterer
The little wheel isn't a full wheel, it has a ~90 degree rotation angle with a range of 1024 values. To avoid confusion with wheel elsewhere in the API name it slider. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-tablet.c | 9 -- src/evdev-tablet.h | 6

[PATCH libinput 26/26] tablet: add libinput_event_tablet_get_axis_delta_discrete()

2015-02-23 Thread Peter Hutterer
Equivalent to the pointer axis function - it gets the mouse wheel clicks from the tablet mouse. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-tablet.c | 5 - src/libinput-private.h | 3 ++- src/libinput.c | 32 +++-

[PATCH libinput 21/26] tablet: support artpen rotation

2015-02-23 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-tablet.c | 35 +++- src/evdev-tablet.h | 6 src/libinput.h | 3 +- test/tablet.c | 95 ++ 4 files changed, 130 insertions(+), 9 deletions(-)

[PATCH libinput 10/26] Keep the tablet APIs in a separate symbol version block

2015-02-23 Thread Peter Hutterer
I keep having to move them around after merging from master and often I'm late with it too. It's a lot easier to just have to update the dependency in a single line, and causes less conflicts too. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/libinput.sym | 9 ++--- 1 file

[PATCH libinput 18/26] tablet: rely on libwacom to give us the right tablet axes

2015-02-23 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-tablet.c | 50 +- 1 file changed, 33 insertions(+), 17 deletions(-) diff --git a/src/evdev-tablet.c b/src/evdev-tablet.c index 2b90e08..52742cf 100644 --- a/src/evdev-tablet.c +++

[PATCH libinput 09/26] tablet: add libinput_tool_get_tool_id()

2015-02-23 Thread Peter Hutterer
The tool ID on wacom tablets is what really defines the tool, so one can differ between say an Intuos Grip Pen, Art Pen or Classic Pen. They're all BTN_TOOL_PEN in the kernel driver. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-tablet.c | 8

[PATCH libinput 16/26] tablet: add support for libinput_tool_has_button

2015-02-23 Thread Peter Hutterer
libwacom can tell us how many buttons we have per stylus, so we map those into BTN_STYLUS and BTN_STYLUS2. BTN_TOUCH is set on all styli. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-tablet.c | 73 ++

[PATCH libinput 01/26] test: fix two tablet tests

2015-02-23 Thread Peter Hutterer
The serial test was broken, it succeeded even if we never got an event. The second test was fine, but complicated. Make it use some of the newer litest features. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/tablet.c | 42 -- 1 file

Re: [PATCH wayland] server: add helper functions for wl_global

2015-02-23 Thread Bryce Harrington
On Mon, Feb 23, 2015 at 11:30:57AM -0800, Bill Spitzak wrote: Which of the 4 arguments do you use for your use case? Because this can only return the first match I suspect some of the NULL tests are pretty useless, because you have to specify arguments that you know will return the one and

Re: [PATCH weston] configure.ac: make use of wayland-scanner.pc

2015-02-23 Thread Bryce Harrington
On Mon, Feb 23, 2015 at 03:10:35PM +0100, sardemff7+wayl...@sardemff7.net wrote: On 2015-02-17 16:13, Emil Velikov wrote: Currently we use the wayland-scanner executable as found with AC_PATH_PROG, and then check the presence of wayland-scanner.pc Currently the latter is unused even if

Re: [PATCH libinput 00/15] tablet: support the remaining tools

2015-02-23 Thread Peter Hutterer
On Mon, Feb 23, 2015 at 09:30:24AM -0500, Lyude wrote: Hi! So, unfortunately as I said before I can't test most of these patches since I've only got the standard pen on my Intuos pro, none of the fact mice and whatnot. I did test what I could though and I found one bug: the button capabilities