Re: [PATCH weston] libweston-desktop: fix the size of unmaximized xdg surfaces

2017-07-27 15:22 GMT+02:00 Quentin Glidic <sardemff7+wayl...@sardemff7.net>: > On 7/27/17 3:01 PM, Giulio Camuffo wrote: >> >> When unmaximizing a surface the configure event should send 0,0 as the >> requested size, so that the client can use the size that it had be

[PATCH weston] libweston-desktop: fix the size of unmaximized xdg surfaces

When unmaximizing a surface the configure event should send 0,0 as the requested size, so that the client can use the size that it had before maximizing --- libweston-desktop/xdg-shell-v6.c | 31 ++- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git

Re: [PATCH weston v3 2/2] compositor: allow to control the vt switching

2017-02-07 16:12 GMT+01:00 Pekka Paalanen <ppaala...@gmail.com>: > On Mon, 5 Dec 2016 14:50:37 +0100 > Giulio Camuffo <giuliocamu...@gmail.com> wrote: > >> A compositor may want to control the vt switching, for example to >> ensure to have a lock screen befo

[PATCH wayland v3 1/3] server: add a safer signal type and port wl_display to it

wl_list_for_each_safe, which is used by wl_signal_emit is not really safe. If a signal has two listeners, and the first one removes and re-inits the second one, it would enter an infinite loop, which was hit in weston on resource destruction, which emits a signal. This commit adds a new version of

[PATCH wayland v3 2/3] server: use the new wl_priv_signal in wl_client

--- src/wayland-server.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/wayland-server.c b/src/wayland-server.c index 98d1205..86fa025 100644 --- a/src/wayland-server.c +++ b/src/wayland-server.c @@ -78,10 +78,10 @@ struct wl_client { uint32_t

[PATCH wayland v2] server: use a safer signal type for the wl_resource destruction signals

of wl_signal, called wl_priv_signal, which is private in wayland-server.c and which does not have this problem. The old wl_signal cannot be improved without breaking backwards compatibility. Signed-off-by: Giulio Camuffo <giulio.camu...@kdab.com> --- v2: make sure we don't use the new signa

Re: [PATCH v2 2/2] xdg-shell: Fold several client-side decoration requests into a generic request

2016-12-30 1:59 GMT+01:00 Adam Goode : > On Mon, Dec 19, 2016 at 10:15 PM, Jonas Ådahl wrote: >> >> On Mon, Dec 19, 2016 at 12:55:24PM -0500, Adam Goode wrote: >> > Compositors currently receive "move", "resize", and "show_window_menu" >> > requests from

Re: [PATCH wayland v2] wayland-server: abort instead of posting events with wrong client objects

2016-12-08 20:36 GMT+01:00 Derek Foreman : > Check that all the objects in an event belong to the same client as > the resource posting it. This prevents a compositor from accidentally > mixing client objects and posting an event that causes a client to > kill itself. > >

Re: [PATCH weston v4] libweston-desktop: fix stale ping when a wl_shell_surface is destroyed

2016-12-08 16:46 GMT+01:00 Quentin Glidic <sardemff7+wayl...@sardemff7.net>: > On 08/12/2016 16:20, Giulio Camuffo wrote: >> >> When sending a ping event to a surface using the wl_shell interface, >> if that surface is destroyed before we receive the pong we wil

[PATCH weston v4] libweston-desktop: fix stale ping when a wl_shell_surface is destroyed

and reset the ping state. Signed-off-by: Giulio Camuffo <giuliocamu...@gmail.com> --- v3: store the ping serial in the surface instead of the client wrapper v4: removed leftover change libweston-desktop/wl-shell.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff

[PATCH weston v3] libweston-desktop: fix stale ping when a wl_shell_surface is destroyed

and reset the ping state. Signed-off-by: Giulio Camuffo <giuliocamu...@gmail.com> --- v3: store the ping serial in the surface instead of the client wrapper libweston-desktop/wl-shell.c | 22 +- libweston-desktop/xwayland.c | 3 ++- 2 files changed, 23 insertions(+), 2 del

[PATCH weston v2] libweston-desktop: don't crash when getting the pid for X clients

X client's don't have a wl_client associated with their weston_desktop_client, so make sure to not use it. Signed-off-by: Giulio Camuffo <giuliocamu...@gmail.com> --- v2: use -1 as the pid unset value, and initialize the pid to 0 for xwayland surfaces. This means the branch where

[PATCH weston] libweston-desktop: don't crash when getting the pid for X clients

X client's don't have a wl_client associated with their weston_desktop_client_create, so check that it is valid. Signed-off-by: Giulio Camuffo <giuliocamu...@gmail.com> --- libweston-desktop/surface.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libweston-d

[PATCH wayland] server: use a safer signal type for the wl_resource destruction signals

wl_list_for_each_safe, which is used by wl_signal_emit is not really safe. If a signal has two listeners, and the first one removes and re-inits the second one, it would enter an infinite loop, which was hit in weston on resource destruction, which emits a signal. This commit adds a new version of

Re: [PATCH weston v3] libweston: Position layers in an absolute way

king). > With this patch, modules can safely add their own layer at the expected > position in the stack, with runtime persistence. Hi, sorry for the long wait. I've just a nitpick below, but anyway i think it's good now: Reviewed-by: Giulio Camuffo <giuliocamu...@gmail.com> > + &g

[PATCH weston v3 1/2] launcher: don't try to switch to weston's vt

Signed-off-by: Giulio Camuffo <giuliocamu...@gmail.com> Reviewed-by: Pekka Paalanen <pekka.paala...@collabora.co.uk> --- v3: changed the summary to say "weston's vt" instead of "current vt" libweston/launcher-direct.c| 12 libwest

[PATCH weston v3 2/2] compositor: allow to control the vt switching

weston_compositor_set_vt_switcher() function, so that it can delay the switching to later, by calling weston_compositor_activate_vt(). Signed-off-by: Giulio Camuffo <giuliocamu...@gmail.com> --- v3: removed leftover include, fix wrong name in documentation Makefile.am | 2 +- libweston/compositor.c

Re: [PATCH weston v2 2/2] compositor: allow to control the vt switching

2016-11-25 15:10 GMT+01:00 Pekka Paalanen <ppaala...@gmail.com>: > On Wed, 29 Jun 2016 11:57:12 +0200 > Giulio Camuffo <giuliocamu...@gmail.com> wrote: > >> A compositor may want to control the vt switching, for example to >> ensure to have a lock screen befo

Re: [PATCH weston v2 1/2] launcher: don't try to switch to the current vt

2016-11-25 15:10 GMT+01:00 Pekka Paalanen <ppaala...@gmail.com>: > On Wed, 29 Jun 2016 11:57:11 +0200 > Giulio Camuffo <giuliocamu...@gmail.com> wrote: > >> Signed-off-by: Giulio Camuffo <giuliocamu...@gmail.com> >> --- >> >> v2: this was split

[PATCH weston] drm: don't put too big surfaces in the cursor plane

When using output scaling a client surface's wicth and height can be smaller than the cursor plane's size, even if its buffer is actually bigger. So check the buffer size rather than the surface size. --- libweston/compositor-drm.c | 17 + 1 file changed, 9 insertions(+), 8

Re: Weston

2016-11-11 11:18 GMT+01:00 Andrea Giammarchi : > Thanks for your answer. > >> you should be starting weston, not weston-launch, when you have a proper >> logind. weston-launch is for users who do not have logind service. > > I think weston-launch does more than just

Re: [weston v2] gl-renderer: conditionally call query_buffer while gl_renderer_attach

Hi, Reviewed-by: Giulio Camuffo <giuliocamu...@gmail.com> 2016-11-03 11:15 GMT+01:00 Vincent Abriou <vincent.abr...@st.com>: > While gl_renderer_attach, query_buffer should be call only if the > query_buffer function exists ie when has_bind_display is true. > > v2

Re: [PATCH weston v2] xwayland: Fix crash when run with no input device

Hi, Looks good to me, Reviewed-by: Giulio Camuffo <giuliocamu...@gmail.com> 2016-11-01 20:14 GMT+01:00 Tom Hochstein <tom.hochst...@nxp.com>: > Starting an xterm with no input device led to a crash > because weston_wm_pick_seat() was returning garbage and > weston_wm_select

Re: [RFC wayland] tests: Test wl_message_count_arrays

2016-11-01 18:49 GMT+01:00 Yong Bakos <j...@humanoriented.com>: > On Nov 1, 2016, at 10:35 AM, Giulio Camuffo <giuliocamu...@gmail.com> wrote: >> >> Hi, >> >> I think i would put more messages in the array, just two seems like >> it's not re

Re: [weston] gl-renderer: conditionally call query_buffer while gl_renderer_attach

Hi, 2016-10-07 17:08 GMT+02:00 Vincent Abriou : > While gl_renderer_attach, query_buffer should be call only if the > query_buffer function exists. > > Signed-off-by: Vincent Abriou > --- > libweston/gl-renderer.c | 3 ++- > 1 file changed, 2

Re: [PATCH 1/1] libweston: fix building issue when EGL support is not enabled

be skipped except EGL_PLATFORM_xxx_KHR that must be still defined to > allow compositor-xx.c to build. Makes sense. Ifdeffing away the egl code in the backends would be uglier imho, so Reviewed-by: Giulio Camuffo <giuliocamu...@gmail.com> Cheers, Giulio > > Signed-off-by: Vinc

Re: [RFC wayland] tests: Test wl_message_count_arrays

Hi, I think i would put more messages in the array, just two seems like it's not really testing much. Besides that it looks good. Cheers, Giulio 2016-10-27 17:58 GMT+02:00 Yong Bakos : > From: Yong Bakos > > message-test.c did not cover

Re: [PATCH weston] xwayland: Fix crash when run with no input device

Hi, 2016-11-01 2:38 GMT+01:00 Tom Hochstein : > Starting an xterm with no input device led to a crash > because weston_wm_pick_seat() was returning garbage and > weston_wm_selection_init() was trying to use the garbage. > > Signed-off-by: Tom Hochstein

Re: SHM buffer pool and file offset

Hi, 2016-10-13 19:27 GMT+02:00 Richard Röjfors : > Hi all, > > I have a situation where I use shared memory buffers and think it would > be very handy to be able to pass on the file offset to a create_pool call. > Right now the implementation takes for granted that it

[PATCH weston v2] libweston-desktop: destroy wl_shell_surface after the wl_surface is destroyed

The wl_shell_surface spec says that it is destroyed automatically by the server when the wl_surface is destroyed, and indeed it does not have a destroy request. So, do that. --- v2: remove the destroy listener when the wl_shell_surface is destroyed libweston-desktop/wl-shell.c | 21

[PATCH weston] libweston-desktop: fix sending the configure event with wl_shell

--- libweston-desktop/wl-shell.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libweston-desktop/wl-shell.c b/libweston-desktop/wl-shell.c index 20fe494..49f0f82 100644 --- a/libweston-desktop/wl-shell.c +++ b/libweston-desktop/wl-shell.c @@ -75,6 +75,7 @@

Re: [PATCH weston] libweston-desktop: listen for the wl_surface resource destruction

As per the discussion on IRC, i've sent a new one actually destroying the weston_desktop_surface. So, ignore this one. Cheers, Giulio 2016-09-28 11:13 GMT+02:00 Giulio Camuffo <giuliocamu...@gmail.com>: > Weston's desktop shell increments the ref_count on the surfaces so th

[PATCH weston] libweston-desktop: destroy wl_shell_surface after the wl_surface is destroyed

The wl_shell_surface spec says that it is destroyed automatically by the server when the wl_surface is destroyed, and indeed it does not have a destroy request. So, do that. --- libweston-desktop/wl-shell.c | 19 +++ 1 file changed, 19 insertions(+) diff --git

Re: [PATCH weston] libweston-desktop: fix stale ping when a wl_shell_surface is destroyed

ital, when using weston this additional patch is needed to fix it: https://patchwork.freedesktop.org/patch/112521/ Cheers, Giulio > > Thanks > On Monday, September 26, 2016 12:37:54 PM EDT Giulio Camuffo wrote: >> When sending a ping event to a surface using the wl_shell interf

[PATCH weston] libweston-desktop: listen for the wl_surface resource destruction

Weston's desktop shell increments the ref_count on the surfaces so that when the wl_resource of the wl_surface is destroyed the weston_surface keeps living. In that case, the weston_desktop_surface keeps living too but the shell resource doesn't. In the xdg_shell case it is destroyed by the client

[PATCH weston] libweston-desktop: fix stale ping when a wl_shell_surface is destroyed

When sending a ping event to a surface using the wl_shell interface, if that surface is destroyed before we receive the pong we will never receive it, even if the client is actually responsive, since the interface does not exist anymore. So when the surface if destroyed pretend it's a pong and

[PATCH weston] libweston-desktop: fix stale ping when a surface is destroyed

When sending a ping event to a surface using the wl_shell interface, if that surface is destroyed before we receive the pong we will never receive it, even if the client is actually responsive, since the interface does not exist anymore. So when the surface if destroyed pretend it's a pong and

Re: [PATCH] server: Fix crash when accessing client which is already freed

Hi, could you write how to trigger the crash, also in the commit message maybe? Besides that, i have a comment inline below. 2016-09-21 9:08 GMT+02:00 Hyunkook Khang : > While processing pending data, client could be destroyed in the middle of > the process. (e.g. by

Re: Micro optimizations welcome?

2016-09-18 4:03 GMT+03:00 Yong Bakos : > On Sep 17, 2016, at 5:42 PM, Ursache Vladimir wrote: >> >> Hi, >> On amd64 struct wl_display from wayland-client.c can shrink in size >> from 320 bytes to 304 if two fields (last_error and id) are >> rearranged.

Re: [PATCH wayland] server: allow removing any wl_listener from a signal when emitted

Hi, Thanks for the great wrap-up! > > > A proposal > > I believe we could have a private and safe variant of wl_signal used > internally for all these. We would still use struct wl_listener as is, > and be completely ABI compatible. > > wl_signal would be left as is. If someone needs a

Re: [PATCH weston] libweston-desktop/xwayland: Do not over-destroy the view

2016-09-01 2:27 GMT+03:00 Quentin Glidic : > On 30/08/2016 02:26, Bryce Harrington wrote: >> >> On Thu, Aug 18, 2016 at 04:45:30PM +0200, Quentin Glidic wrote: >>> >>> From: Quentin Glidic >>> >>> With this weston_view_destroy() call,

Re: [PATCH weston 2/2] libweston-desktop: fix unsetting fullscreen/maximize with wl_shell

2016-09-06 7:04 GMT+03:00 Jonas Ådahl <jad...@gmail.com>: > On Sun, Sep 04, 2016 at 06:50:47PM +0300, Giulio Camuffo wrote: >> --- >> libweston-desktop/wl-shell.c | 11 +++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/libweston-desktop/wl

[PATCH wayland] server: allow removing any wl_listener from a signal when emitted

wl_list_for_each_safe, which was used by wl_signal_emit is not really safe. If a signal has two listeners, and the first one removes and re-inits the second one, it would enter an infinite loop. This commit adds a wl_list_iterate_safe() function which is used by wl_signal_emit() and adds a test

[PATCH weston 2/2] libweston-desktop: fix unsetting fullscreen/maximize with wl_shell

--- libweston-desktop/wl-shell.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/libweston-desktop/wl-shell.c b/libweston-desktop/wl-shell.c index 74ce473..7172449 100644 --- a/libweston-desktop/wl-shell.c +++ b/libweston-desktop/wl-shell.c @@ -151,6 +151,17 @@

[PATCH weston 1/2] compositor: set the opaque region for some views with transform

If the transform on a view is only a translation we can trivially set the opaque region for it so to optimize the rendering. --- libweston/compositor.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libweston/compositor.c b/libweston/compositor.c index 47907bb..8c3872d 100644 ---

Re: [PATCH weston 1/2] input: Update keyboard serial on press and release

2016-09-02 10:27 GMT+02:00 Olivier Fourdan : > Hi, > > - Original Message - >> 2016-09-01 11:52 GMT+02:00 Olivier Fourdan : >> > Hi >> > >> >> > + keyboard->grab_serial = >> >> > wl_display_get_serial(compositor->wl_display); >> >> > if

Re: [PATCH weston 1/2] input: Update keyboard serial on press and release

2016-09-01 11:52 GMT+02:00 Olivier Fourdan : > Hi > >> > + keyboard->grab_serial = wl_display_get_serial(compositor->wl_display); >> > if (state == WL_KEYBOARD_KEY_STATE_PRESSED) { >> > - keyboard->grab_serial = >> > -

Re: [PATCH] Introduce keyboard grabbing protocol

2016-08-30 15:22 GMT+02:00 Jonas Ådahl <jad...@gmail.com>: > On Tue, Aug 30, 2016 at 02:12:29PM +0200, Giulio Camuffo wrote: >> 2016-08-30 13:58 GMT+02:00 Olivier Fourdan <ofour...@redhat.com>: >> > Hi Giulio, >> > >> >> i have a couple of comment

Re: [PATCH] Introduce keyboard grabbing protocol

2016-08-30 13:58 GMT+02:00 Olivier Fourdan : > Hi Giulio, > >> i have a couple of comments below > > Thanks a lot for your quick reply! > >> 2016-08-30 11:54 GMT+02:00 Olivier Fourdan : >> > [...] >> >> I can understand the Xwayland use, but not the VM

Re: [PATCH] Introduce keyboard grabbing protocol

Hi, i have a couple of comments below 2016-08-30 11:54 GMT+02:00 Olivier Fourdan : > This patch introduces a new protocol for grabbing a keyboard. > > Signed-off-by: Olivier Fourdan > --- > Makefile.am| 1 + >

Re: [PATCH wayland 1/2] util: Document wl_list methods

Il 26/ago/2016 16:28, "Yong Bakos" <j...@humanoriented.com> ha scritto: > > On Aug 26, 2016, at 2:12 AM, Giulio Camuffo <giuliocamu...@gmail.com> wrote: > > > > Hi, > > > > > >> > >> +/** > >> + * Removes an elem

Re: [PATCH wayland 1/2] util: Document wl_list methods

Hi, > > +/** > + * Removes an element from the list. > + * > + * \param elm element to remove from the list > + */ I think this should mention that elm is left in an invalid state, and the user should call wl_list_init on it before using it again. Cheers, Giulio > void >

Re: [PATCH wayland-web] Mention GammaRay in the tools page

2016-08-17 23:23 GMT+02:00 : > On 08/17, Jonas Ådahl wrote: >> Is half a megabyte really a big deal for wayland-web? I find it more >> reasonable to just provide the full resolution image instead of relying >> on the URL to the external image never changing. > > I think

Re: [PATCH wayland-web] Mention GammaRay in the tools page

2016-08-17 10:48 GMT+02:00 Pekka Paalanen <ppaala...@gmail.com>: > On Wed, 17 Aug 2016 10:33:19 +0200 > Giulio Camuffo <giuliocamu...@gmail.com> wrote: > >> --- >> extras.html | 13 + >> gammaray.png | Bin 0 -> 563838 bytes >> 2

Re: [PATCH weston v3 6/6] Add API to install protocol loggers on the server wl_display

2016-08-12 10:25 GMT+02:00 Pekka Paalanen <ppaala...@gmail.com>: > On Thu, 11 Aug 2016 17:06:02 +0200 > Giulio Camuffo <giuliocamu...@gmail.com> wrote: > >> 2016-08-11 16:39 GMT+02:00 Pekka Paalanen <ppaala...@gmail.com>: >> > On Tue, 9 Aug 2016 12:4

Re: [PATCH wayland v5] Add API to install protocol loggers on the server wl_display

Ah sorry, i forgot to add Yong's R-b. 2016-08-12 9:33 GMT+02:00 Giulio Camuffo <giuliocamu...@gmail.com>: > The new wl_display_add_protocol_logger allows to set a function as > a logger, which will get called when a new request is received or an > event is sent. > This

[PATCH wayland v5] Add API to install protocol loggers on the server wl_display

. A test is added for the new functionality. Signed-off-by: Giulio Camuffo <giulio.camu...@kdab.com> Reviewed-by: Jonas Ådahl <jad...@gmail.com> --- v5: fixed documentation Makefile.am | 5 +- src/wayland-server-core.h| 24 +++ src/wayland-server.c

Re: [PATCH wayland v4 3/3] Add API to install protocol loggers on the server wl_display

2016-08-12 3:33 GMT+02:00 Jonas Ådahl <jad...@gmail.com>: > On Thu, Aug 11, 2016 at 05:23:11PM +0200, Giulio Camuffo wrote: >> The new wl_display_add_protocol_logger allows to set a function as >> a logger, which will get called when a new request is received o

[PATCH wayland v4 3/3] Add API to install protocol loggers on the server wl_display

. A test is added for the new functionality. Signed-off-by: Giulio Camuffo <giulio.camu...@kdab.com> --- v4: - set a timeout of 1s for the test - don't init the logger's list link - remove unneeded forward declaration Makefile.am | 5 +- src/wayland-server-core.h

[PATCH wayland v4 2/3] Add API to retrieve and iterate over the resources list of a client

To complement on the new resource created signal, this allows to iterate over the existing resources of a client. Signed-off-by: Giulio Camuffo <giulio.camu...@kdab.com> Reviewed-by: Jonas Ådahl <jad...@gmail.com> --- v4: - really stop when the iterator says so src/wayland-privat

[PATCH wayland v4 1/3] Add a resource creation signal

the wl_client as the context. Signed-off-by: Giulio Camuffo <giulio.camu...@kdab.com> Reviewed-by: Jonas Ådahl <jad...@gmail.com> --- v4: - added a test - allow removing the listeners after the client was destroyed src/wayland-server-core.h | 4 ++ src/wayl

Re: [PATCH weston v3 6/6] Add API to install protocol loggers on the server wl_display

2016-08-11 16:39 GMT+02:00 Pekka Paalanen <ppaala...@gmail.com>: > On Tue, 9 Aug 2016 12:46:56 +0200 > Giulio Camuffo <giuliocamu...@gmail.com> wrote: > >> The new wl_display_add_protocol_logger allows to set a function as >> a logger, which will get call

Re: [PATCH weston v3 5/6] Add API to retrieve and iterate over the resources list of a client

2016-08-11 16:34 GMT+02:00 Pekka Paalanen <ppaala...@gmail.com>: > On Tue, 9 Aug 2016 12:46:55 +0200 > Giulio Camuffo <giuliocamu...@gmail.com> wrote: > >> To complement on the new resource created signal, this allows to >> iterate over the existing resour

Re: [PATCH weston v3 4/6] Add a resource creation signal

Hi 2016-08-11 14:34 GMT+02:00 Pekka Paalanen : > > Hi Giulio, > > what is in this patch looks good, but I think there could be more. > > There is no test that would excercise > wl_client_add_resource_created_signal(). Right, i'll add it. > > wl_client destruction assumes

Re: [PATCH weston v3 6/6] Add API to install protocol loggers on the server wl_display

Hi, 2016-08-10 18:28 GMT+02:00 Yong Bakos <j...@humanoriented.com>: > Hi Giulio, > >> On Aug 9, 2016, at 3:46 AM, Giulio Camuffo <giuliocamu...@gmail.com> wrote: >> >> The new wl_display_add_protocol_logger allows to set a function as >> a logger

Re: [PATCH weston v3 2/6] Add API to retrieve the interface name of a wl_resource

2016-08-10 0:48 GMT+02:00 Yong Bakos <j...@humanoriented.com>: > Hi Giulio, > I missed these Wayland patches due to the weston subject > line, so forgive me for the late feedback. Suggestion inline > below. Oh indeed, sorry about that. > >> On Aug 9, 2016, at 3:46 AM,

[PATCH weston v3 4/6] Add a resource creation signal

the wl_client as the context. Signed-off-by: Giulio Camuffo <giulio.camu...@kdab.com> Reviewed-by: Jonas Ådahl <jad...@gmail.com> --- src/wayland-server-core.h | 4 src/wayland-server.c | 32 2 files changed, 36 insertions(+) diff --git a/src/wa

[PATCH weston v3 6/6] Add API to install protocol loggers on the server wl_display

. A test is added for the new functionality. Signed-off-by: Giulio Camuffo <giulio.camu...@kdab.com> --- v3: - added missing test file - renamed wl_protocol_logger_direction to wl_protocol_logger_type - renamed closure_log to log_closure - renamed wl_display_remove_protocol_

[PATCH weston v3 5/6] Add API to retrieve and iterate over the resources list of a client

To complement on the new resource created signal, this allows to iterate over the existing resources of a client. Signed-off-by: Giulio Camuffo <giulio.camu...@kdab.com> Reviewed-by: Jonas Ådahl <jad...@gmail.com> --- v3: - add a new wl_iterator_enum to be used instead of t

[PATCH weston v3 3/6] Add API to get the list of connected clients

This patch chooses the wl_list_for_each-style of iterating over the clients, instead of using an iterator function, because i think it is easier to use. Signed-off-by: Giulio Camuffo <giulio.camu...@kdab.com> Reviewed-by: Jonas Ådahl <jad...@gmail.com> --- v3: check that the client

[PATCH weston v3 1/6] server: add listener API for new clients

e Park <nic...@nicesj.com> Signed-off-by: Giulio Camuffo <giulio.camu...@kdab.com> Reviewed-by: Jonas Ådahl <jad...@gmail.com> --- v3: added missing copyright line to the test Makefile.am | 5 +- src/wayland-server-core.h | 4

[PATCH weston v3 2/6] Add API to retrieve the interface name of a wl_resource

Signed-off-by: Giulio Camuffo <giulio.camu...@kdab.com> Reviewed-by: Jonas Ådahl <jad...@gmail.com> --- src/wayland-server-core.h | 2 ++ src/wayland-server.c | 12 2 files changed, 14 insertions(+) diff --git a/src/wayland-server-core.h b/src/wayland-server-

Re: [PATCH weston v2 5/6] Add API to retrieve and iterate over the resources list of a client

2016-08-09 10:17 GMT+02:00 Jonas Ådahl <jad...@gmail.com>: > On Tue, Jul 05, 2016 at 09:51:10AM +0200, Giulio Camuffo wrote: >> To complement on the new resource created signal, this allows to >> iterate over the existing resources of a client. >> >> Signed-of

Re: [PATCH 1/3 v3] wayland-server: Add API to control globals visibility

2016-08-08 11:07 GMT+02:00 Olivier Fourdan <ofour...@redhat.com>: > Hi Giulio, > > On 8 August 2016 at 10:53, Giulio Camuffo <giuliocamu...@gmail.com> wrote: >> Hi, >> >> this looks like a nice way to implement restricted interfaces... i >> just wonde

Re: [PATCH weston v2 1/8] gl-renderer: Silence maybe-uninitialized warning

Hi, Reviewed-by: Giulio Camuffo <giuliocamu...@gmail.com> 2016-07-10 11:00 GMT+02:00 Quentin Glidic <sardemff7+wayl...@sardemff7.net>: > From: Quentin Glidic <sardemff7+...@sardemff7.net> > > libweston/gl-renderer.c: In function 'compress_bands': > libweston/gl-rend

Re: [PATCH weston v2 2/8] shared/image: Silence maybe-uninitialized warning

Hi, Reviewed-by: Giulio Camuffo <giuliocamu...@gmail.com> 2016-07-10 11:00 GMT+02:00 Quentin Glidic <sardemff7+wayl...@sardemff7.net>: > From: Quentin Glidic <sardemff7+...@sardemff7.net> > > shared/image-loader.c: In function 'load_image': > shared/image-loader.

Re: [PATCH weston v2 4/8] libweston: Silence tautological-compare warning

Hi, Reviewed-by: Giulio Camuffo <giuliocamu...@gmail.com> 2016-07-10 11:00 GMT+02:00 Quentin Glidic <sardemff7+wayl...@sardemff7.net>: > From: Quentin Glidic <sardemff7+...@sardemff7.net> > > libweston/compositor.c:5023:14: warning: comparison of unsigned enum >

Re: [PATCH weston v2 5/8] libweston/launcher-weston-launch: Silence unused-function warning

Hi, Reviewed-by: Giulio Camuffo <giuliocamu...@gmail.com> 2016-07-10 11:00 GMT+02:00 Quentin Glidic <sardemff7+wayl...@sardemff7.net>: > From: Quentin Glidic <sardemff7+...@sardemff7.net> > > libweston/launcher-weston-launch.c:58:1: warning: unused function > 'is_

Re: [PATCH weston v2 6/8] share/cairo-util: Use wl_pointer_button_state enum directly

Hi, Reviewed-by: Giulio Camuffo <giuliocamu...@gmail.com> 2016-07-10 11:00 GMT+02:00 Quentin Glidic <sardemff7+wayl...@sardemff7.net>: > From: Quentin Glidic <sardemff7+...@sardemff7.net> > > This silences two warnings: > > clients/window.c:2450:20: warning: imp

Re: [PATCH weston v2] desktop-shell: Send fewer pings

Hi, looks good. Reviewed-by: Giulio Camuffo <giuliocamu...@gmail.com> 2016-07-08 20:20 GMT+02:00 Derek Foreman <der...@osg.samsung.com>: > Currently we can end up sending pings to popups every screen redraw and every > pointer move when they're focused. Instead let's send a

Re: [PATCH 4/5] client: "_id" versions of constructors, alternative to proxy_wrapper

Hi, What's the point of this now that we have the proxy wrapper approach? Cheers, Giulio 2016-05-17 8:18 GMT+02:00 : > From: Bill Spitzak > > Scanner produces a wl_xyz_new() for each object, and for each constructor > request it produces an "_id"

Re: [PATCH wayland] cursor: Remove "weston" from anonymous shm filenames

Hi, Reviewed-by: Giulio Camuffo <giuliocamu...@gmail.com> 2016-07-27 21:02 GMT+02:00 Yong Bakos <j...@humanoriented.com>: > On Jul 27, 2016, at 9:06 AM, Derek Foreman <der...@osg.samsung.com> wrote: >> >> This mildly confused me during some debugging, so I

Re: Re: Wayland application start failed

Hi, your qtwayland version and qtbase version don't match. Run your application with QT_DEBUG_PLUGINS=1 and look at the output for more details. Cheers, Giulio 2016-08-08 3:22 GMT+02:00 Anthenony : > The error still existed. > Is there any other way? > > > > At 2016-08-05

Re: [PATCH 1/3 v3] wayland-server: Add API to control globals visibility

Hi, this looks like a nice way to implement restricted interfaces... i just wonder, would we need to revoke allowed interfaces? How would this approach allow that? Also, this still doesn't prevent a client from binding an interface if it knows the name and id. Do we care? 2016-08-08 10:10

Re: [PATCH weston 2/3] modules: Drop module_init as a shared init function

2016-07-04 15:58 GMT+02:00 Quentin Glidic : > From: Quentin Glidic > > Use different functions so we cannot load a libweston module in weston > or the other way around. > > Also properly namespace backend_init and use a different name

Re: [PATCH weston 1/3] weston: Add a specific option to load XWayland

Hi, This looks good to me but i wonder, since it's a behavior change, it should be mentioned in the changelog. I think we should start using a [Changelog] tag or something in the commit message to make fishing them out of the git history easier. With that, Reviewed-by: Giulio Camuffo <giulioc

Re: [PATCH weston v2] libweston: Position layers in an absolute way

2016-07-09 20:45 GMT+02:00 Quentin Glidic : > From: Quentin Glidic > > Currently, layers’ order depends on the module loading order and it does > not survive runtime modifications (like shell locking/unlocking). > With this patch,

[PATCH weston v2 2/6] Add API to retrieve the interface name of a wl_resource

Signed-off-by: Giulio Camuffo <giulio.camu...@kdab.com> --- v2: - return the interface name instead of the interface struct src/wayland-server-core.h | 2 ++ src/wayland-server.c | 12 2 files changed, 14 insertions(+) diff --git a/src/wayland-server-core.h b/src/w

[PATCH weston v2 1/6] server: add listener API for new clients

e Park <nic...@nicesj.com> Signed-off-by: Giulio Camuffo <giulio.camu...@kdab.com> Reviewed-by: Pekka Paalanen <pekka.paala...@collabora.co.uk> --- v2: - added a test - some more documentation Makefile.am | 5 ++- src/wayland-server-core.h

[PATCH weston v2 6/6] Add API to install protocol loggers on the server wl_display

. A test is added for the new functionality. Signed-off-by: Giulio Camuffo <giulio.camu...@kdab.com> --- v2: - return wl_protocol_logger* when adding a logger, and use that to remove it - add a test - rename the enum to _REQUEST and _EVENT Makefile.am | 3 ++ src/wayland-

[PATCH weston v2 4/6] Add a resource creation signal

the wl_client as the context. Signed-off-by: Giulio Camuffo <giulio.camu...@kdab.com> --- v2: expand a bit the documentation and commit message src/wayland-server-core.h | 4 src/wayland-server.c | 32 2 files changed, 36 insertions(+) diff --git

[PATCH weston v2 3/6] Add API to get the list of connected clients

This patch chooses the wl_list_for_each-style of iterating over the clients, instead of using an iterator function, because i think it is easier to use. Signed-off-by: Giulio Camuffo <giulio.camu...@kdab.com> --- v2: expand a bit the documentation and the commit message src/wayland-

Re: [PATCH wayland 3/5] Add API to get the list of connected clients

2016-06-17 13:51 GMT+02:00 Pekka Paalanen <ppaala...@gmail.com>: > On Mon, 7 Mar 2016 18:31:33 +0100 > Giulio Camuffo <giuliocamu...@gmail.com> wrote: > >> --- >> src/wayland-server-core.h | 14 + &

Re: [PATCH wayland 5/5] Add API to retrieve and iterate over the resources list of a client

2016-06-17 14:07 GMT+02:00 Pekka Paalanen <ppaala...@gmail.com>: > On Mon, 7 Mar 2016 18:31:35 +0100 > Giulio Camuffo <giuliocamu...@gmail.com> wrote: > >> To complement on the new resource created signal, this allows to >> iterate over the existing resources of

[PATCH weston v2 2/2] xwayland: make the plugin usable by libweston compositors

in the compositor side, and to deal with signal handling. A new function is added in compositor.c to load and init the xwayland.so plugin. Also make sure to re-arm the SIGUSR1 when the X server quits. Signed-off-by: Giulio Camuffo <giuliocamu...@gmail.com> --- v2: - use strstr instead of strcmp to

[PATCH weston v2 1/2] compositor: add plugin-registry

n core to explicitly support each case. This patch fixes that. The tests all pass. Signed-off-by: Pekka Paalanen <pekka.paala...@collabora.co.uk> Signed-off-by: Giulio Camuffo <giuliocamu...@gmail.com> --- Makefile.am | 8 +++ libweston/compositor.c | 6 ++ libw

Re: [PATCH weston 2/2] xwayland: make the plugin usable by libweston compositors

= xwayland; >> + wxw->process.cleanup = xserver_cleanup; >> + if (api->listen(xwayland, wxw, spawn_xserver) < 0) >> + return -1; >> + >> + loop = wl_display_get_event_loop(comp->wl_display); >> + wxw->sigusr1_source = wl

Re: [PATCH weston v2] compositor: allow to control the vt switching

2016-06-23 9:37 GMT+02:00 Daniel Stone <dan...@fooishbar.org>: > Hi Guilio, > > On 5 June 2016 at 03:48, Giulio Camuffo <giuliocamu...@gmail.com> wrote: >> @@ -97,8 +97,17 @@ switch_vt_binding(struct weston_keyboard *keyboard, >> uint32

Re: [PATCH weston 12/12] compositor: Switch to new surface/view mapped checks

2016-06-28 14:30 GMT+02:00 Pekka Paalanen : > On Thu, 23 Jun 2016 11:59:40 +0200 > Armin Krezović wrote: > >> This patch makes use of new flags which were introduced >> by previous patches to check if a surface/view is mapped >> >> Signed-off-by:

Re: [PATCH weston 08/11] compositor: Untangle mapedness from outputs

2016-06-18 19:15 GMT+02:00 Armin Krezović : > Currently, weston assumes a surface/view is mapped if > it has an output assigned. In a zero outputs scenario, > this isn't really desirable. > > This patch introduces a new flag to weston_surface and > weston_view, which has

  1   2   3   4   5   6   7   >