Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 75a3eb3a5fe3dce1867d880faf785137963b234a
https://github.com/WebKit/WebKit/commit/75a3eb3a5fe3dce1867d880faf785137963b234a
Author: Amanda Falke <afa...@igalia.com>
Date: 2023-08-10 (Thu, 10 Aug 2023)
Changed paths:
M Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp
M Tools/TestWebKitAPI/glib/TestExpectations.json
Log Message:
-----------
[GTK][WPE] Address bots for TestWebsiteData/cache flakiness
https://bugs.webkit.org/show_bug.cgi?id=259991
Reviewed by Michael Catanzaro.
This is a test that succeeds locally but fails intermittently in bots per
history below, and in `wk-bot-digest` over time.
In 2018 in `webkit.org/b/188113`, we determined that this test was flaky
in GTK, and in 2019 in that bug we also thought possibly that the 1-second wait
was not long enough in this test, and perhaps we should increase the wait
to 2s. In 2022, we determined in that bug that test had been consistently
passing in GTK/WPE for a long time "Sometimes fails consistently, but due
to regressions." We then removed the `"all"` pass/fail flakes in that commit
`246255@main` in January 2022. Since that time the bots tend to look like
this, despite succeeding locally for GTK|WPE:
```
/path/to/wk-bot-digest-results/last-3000 $ ag /webkit/WebKitWebsiteData/cache |
sort | grep PASS | wc -l
2066
/path/to/wk-bot-digest-results/last-3000 $ ag /webkit/WebKitWebsiteData/cache |
sort | grep FAIL | wc -l
75
```
In March 2022 a few months ago we re-added the failing/flaky expectation
for GTK in `webkit.org/b/254002`, so this test's failing/flaky expectations
have been continually added and removed over time.
Per comment in b/188113, adding a slightly higher wait for bots.
Removing failing expectations.
* Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
(testWebsiteDataCache):
* Tools/TestWebKitAPI/glib/TestExpectations.json:
Canonical link: https://commits.webkit.org/266790@main
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
