Re: [webkit-dev] Should we consider switching to git over svn?

2007-10-09 Thread Lars Knoll
On Tuesday 09 October 2007, Timothy Hatcher wrote: I think Git is rather slow on Windows I hear. Yes, it's quite a bit slower than on Unix systems. But there has been quite a bit of work happening lately on the windows port speeding it up substantially. It's now pretty usable for us (Qt

Re: [webkit-dev] Should we consider switching to git over svn?

2007-10-09 Thread Alexey Proskuryakov
On 10/9/07 8:29 AM, Oliver Hunt [EMAIL PROTECTED] wrote: Unfortunately, git is still not as user friendly as svn, and has a relatively steep learning curve (largely due to it using some similar commands to svn for completely different purposes :-/ ) My understanding is that tool support for

Re: [webkit-dev] Should we consider switching to git over svn?

2007-10-09 Thread Mike Hommey
On Mon, Oct 08, 2007 at 10:40:27PM -0700, Oliver Hunt [EMAIL PROTECTED] wrote: ... and only follows the trunk, AFAICS. Whether you switch to git or not, I'd like at least the feature-branch to be available in a git-svn bridge. Git has it's own svn bridge, if you add I was talking about

Re: [webkit-dev] Should we consider switching to git over svn?

2007-10-09 Thread Brady Eidson
On Oct 8, 2007, at 11:30 PM, Oliver Hunt wrote: The average user uses update-webkit + some manual work, svn-create- patch, svn-apply-patch Behind the scenes these do, svn up, svn diff + some magic, patch + magic Yup Under git they would be git fetch git rebase origin/master +

Re: [webkit-dev] Should we consider switching to git over svn?

2007-10-09 Thread Mark Rowe
On 09/10/2007, at 17:31, Mike Hommey wrote: On Mon, Oct 08, 2007 at 10:40:27PM -0700, Oliver Hunt [EMAIL PROTECTED] wrote: ... and only follows the trunk, AFAICS. Whether you switch to git or not, I'd like at least the feature-branch to be available in a git- svn bridge. Git has it's

Re: [webkit-dev] Should we consider switching to git over svn?

2007-10-09 Thread Lars Knoll
I'll just add my 2 cents here. I'm very much in favor of switching over to git at some point. There are many reasons for that, but I'll try to highlight the main ones that come to my mind (in addition to the ones Oliver mentioned already): * local repository and working offline: I often have

Re: [webkit-dev] Bus error while building WebKit on Mac

2007-10-09 Thread Song Yuan
I was planning to update Xcode anyway, so I did it. I installed the latest release as you recommended and now my Xcode is 2.4.1, Gcc is powerpc-apple-darwin8-gcc-4.0.1 (GCC) 4.0.1 (Apple Computer, Inc. build 5367). After doing all this, WebKit was successfully built and run within Safari with no

Re: [webkit-dev] Should we consider switching to git over svn?

2007-10-09 Thread Adam Roben
On Oct 9, 2007, at 6:40 AM, David D. Kilzer wrote: The biggest issue I see from using a git development model is that the WebKit project would need its own Linus to integrate changes from branches/clones into the main tree, unless using git is simply another means-to-an- end for

Re: [webkit-dev] for review: RefPtr document

2007-10-09 Thread Brady Eidson
I seem to recall reviewing it at the time, but I just went over it once more. I see no technical inaccuracies, I think it's written at a great level for introducing people unfamiliar with the concept to our RefPtr infrastructure, and I don't want to get into arguing tiny ways I would

RE: [webkit-dev] Should we consider switching to git over svn?

2007-10-09 Thread Chris Brichford
If switching webkit to git makes it easier to import webkit code into perforce ( and export changes from perforce ), then that alone would justify the change from my team's point of view. Chris Brichford Adobe AIR Team -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL

[webkit-dev] McAfee VirusScan considers the following files as (Trojan) in window

2007-10-09 Thread Jerry K
Deleted \WebKit\LayoutTests\fast\encoding\utf-32-big-endian-nobom.xml Exploit-ObscuredHtml (Trojan) Deleted \WebKit\LayoutTests\fast\encoding\.svn\text-base\utf-32-big-endian-nobom.xml.svn-base Exploit-ObscuredHtml (Trojan) Moved (Clean failed)

Re: [webkit-dev] for review: RefPtr document

2007-10-09 Thread Geoffrey Garen
Having this document as a reference will be great! History Many objects in WebKit are reference counted. The pattern used is that classes have member functionsref and deref that increment and decrement the reference count. Each call to ref has to be matched by a call to deref. When the

[webkit-dev] Webkit Building failed on Windows

2007-10-09 Thread James tu
Hello guys, I tried to build the webkit on windows but failed. Here are the steps I followed 1. Install Visual C++ 2005 Express 2. Install Microsoft Visual C++ Express 2005 Service Pack 1 3 .Install the Windows Platform SD. Add the path following the installation guide 4. Install

Re: [webkit-dev] could someone try building with my patch to gtk and qt?

2007-10-09 Thread Alice Liu
Alice Liu wrote: Hello, I'm making a change to WebKit that will change the return type of FrameLoaderClient::createFrame() from Frame* to PassRefPtrFrame. In my patch I also included the necessary changes to gtk and qt frame loader classes to remain compatible with my change. In an effort

[webkit-dev] Re: Should we consider switching to git over svn?

2007-10-09 Thread Alp Toker
Thumbs up on this one. git certainly has the potential to make WebKit development more accessible and transparent. It might be worth talking with other large projects that have migrated from CVS or SVN (like xorg, freedesktop.org, wine) to see if they have any useful commit history

Re: [webkit-dev] Build question on Window (Safari version)

2007-10-09 Thread Jerry K
Hi Adam, I did this -- debug flag or have run `set-webkit-configuration --debug` and it fixed my problem. Thanks Jerry Adam Roben wrote: On Oct 9, 2007, at 9:26 AM, Jerry K wrote: Hi Adam, Here is what I found. I built webkit debug and release version. The webkit.dll release

Re: [webkit-dev] Build question on QT window version

2007-10-09 Thread Jerry K
Hi George, I tried your patch, but I saw other compiling error. +#if PLATFORM(QT) defined(Q_WS_WIN32) +#define localtime_r(x, y) localtime_s(y, x) +#endif \qt\WebKit\WebCore\loader\FTPDirectoryDocument.cpp:237: error: `localtime_s' undeclared (first use this function) I also

Re: [webkit-dev] Re: Should we consider switching to git over svn?

2007-10-09 Thread Mike Hommey
On Wed, Oct 10, 2007 at 03:15:52AM +0100, Alp Toker wrote: Thumbs up on this one. git certainly has the potential to make WebKit development more accessible and transparent. It might be worth talking with other large projects that have migrated from CVS or SVN (like xorg, freedesktop.org,