Re: [webkit-dev] HTML5 tokenizer enabled

2010-06-16 Thread Eric Seidel
See https://docs.google.com/document/edit?id=1as5xYjyMSCph4960iz0-Kb7hZKf_L6f2vts57NMcVBIhl=en# for a description of expected differences. On Wed, Jun 16, 2010 at 2:18 AM, Adam Barth aba...@webkit.org wrote: As of early this morning, we've enabled the HTML5 tokenizer on trunk. I expect we've

Re: [webkit-dev] HTML5 tokenizer enabled

2010-06-16 Thread Adam Barth
Yeah, the main issue is that we didn't have access to all the platforms (e.g., Qt, Gtk, Tiger) so we needed help from the bots. Adam On Wed, Jun 16, 2010 at 9:57 AM, Cameron Zwarich cwzwar...@uwaterloo.ca wrote: Was anything preventing you from running these tests before you turned it on?

Re: [webkit-dev] increase the number of tests before bailing?

2010-06-16 Thread Geoffrey Garen
Hi Ojan. I wonder if it would help to distinguish --exit-after-n-failures from --exit-after-n-crashes. I think that crashing tests are the biggest problem, since they can cause a bot to lag behind quite a bit. Geoff On Jun 16, 2010, at 1:57 PM, Ojan Vafai wrote: Currently,

Re: [webkit-dev] increase the number of tests before bailing?

2010-06-16 Thread Eric Seidel
We could add a separate option to DumpRenderTree to disable ReportCrash (sign up for all the crashing signals and simply exit(2) or similar). That would be useful in many instances besides the bots. Yes, --exit-after-N-failures was designed to prevent crashers from eating the bots. On Wed, Jun

Re: [webkit-dev] increase the number of tests before bailing?

2010-06-16 Thread Eric Seidel
We could also look into BreakPad (Chromium's solution) for the bots. That doesn't seem to hang for 5 minutes a crash like ReportCrash does. But maybe that's related to how Chromium builds (symbol-wise) more than ReportCrash. On Wed, Jun 16, 2010 at 2:04 PM, Eric Seidel e...@webkit.org wrote: We

Re: [webkit-dev] Why so many text nodes in the DOM? (especially ones with just whitespace)

2010-06-16 Thread David Hyatt
Whitespace nodes most commonly occur between elements, so they can't be coalesced. dave On Jun 14, 2010, at 7:00 PM, Matt 'Murph' Finnicum wrote: Why are there so many Text nodes in the DOM? I had a look at the initial DOM tree from rendering slashdot, and there are 1959 Text nodes. Of

Re: [webkit-dev] increase the number of tests before bailing?

2010-06-16 Thread Maciej Stachowiak
On Jun 16, 2010, at 2:04 PM, Eric Seidel wrote: We could add a separate option to DumpRenderTree to disable ReportCrash (sign up for all the crashing signals and simply exit(2) or similar). That would be useful in many instances besides the bots. Yes, --exit-after-N-failures was designed

Re: [webkit-dev] increase the number of tests before bailing?

2010-06-16 Thread Eric Seidel
I think --exit-after-N-failures is actually very useful as-is. I think peopel just use it for different things. For teh commit-queue --exit-after-N-failures is great for keeping it quick. Perhaps people want to use the bots more like try-bots and have --exit-after-N-failures higher. I think

[webkit-dev] A proposal for Platform Mechanisms

2010-06-16 Thread Anders Carlsson
Hi everyone, We've now reached the point in WebKit2 development where we need to be able to override some global calls in WebCore so that we can funnel them through to another process, in a similar way to what Chromium does. We also need to be able to override the calls at run-time, so that we

Re: [webkit-dev] A proposal for Platform Mechanisms

2010-06-16 Thread Kenneth Christiansen
Hi there Anders, I think this sounds pretty fine at least from a Qt perspective; and it will also easily enable us to let some of our platforms override the implementation using a plugin system. We already have such a system in place (PlatformPlugin) so that platforms can re-implement the

Re: [webkit-dev] beforeinput and input events for contenteditable/designMode

2010-06-16 Thread Ojan Vafai
This discussion stalled on whatwg a bit. Sending an update in the hopes that we can start getting code reviewed and checked in here. In the discussion on whatwg, there weren't any vendors that opposed adding beforeInput/input, but there also wasn't outright support. There was hesitance from Boris

Re: [webkit-dev] A proposal for Platform Mechanisms

2010-06-16 Thread Darin Adler
Sounds reasonable to me. We already follow pointers and use virtual functions for all these things, so I don’t see them adding a lot of overhead. Would these Mechanism classes replace all the current Client classes? Would the mechanism objects be obtained once and cached globally? How is the

Re: [webkit-dev] A proposal for Platform Mechanisms

2010-06-16 Thread Simon Fraser
On Jun 16, 2010, at 5:30 PM, Anders Carlsson wrote: Hi everyone, We've now reached the point in WebKit2 development where we need to be able to override some global calls in WebCore so that we can funnel them through to another process, in a similar way to what Chromium does. We also need

Re: [webkit-dev] A proposal for Platform Mechanisms

2010-06-16 Thread Anders Carlsson
On Jun 16, 2010, at 5:55 PM, Darin Adler wrote: Sounds reasonable to me. We already follow pointers and use virtual functions for all these things, so I don’t see them adding a lot of overhead. Would these Mechanism classes replace all the current Client classes? Like Kenneth said, these

Re: [webkit-dev] A proposal for Platform Mechanisms

2010-06-16 Thread Darin Fisher
Hi, this is of course a very interesting topic! Some comments: 1- Why do you see the need for these interfaces to be virtual? Will there be multiple implementations? Some possible answers that come to mind: a) Yes, there could be a proxy implementation used to marshal calls to the real