Re: [webkit-dev] Some new coding style rules

2010-08-05 Thread Sam Weinig
On Wed, Aug 4, 2010 at 1:29 AM, Nikolas Zimmermann zimmerm...@physik.rwth-aachen.de wrote: namespace WebCore { ... } // namespace WebCore 2. ENABLE(FOO) #endif comments #if ENABLE(FOO) .. #endif // ENABLE(FOO) I like these two forms of comments. -Sam

Re: [webkit-dev] Fwd: webkit editing rewrite?

2010-08-05 Thread Maciej Stachowiak
On Aug 4, 2010, at 6:12 PM, Ojan Vafai wrote: On Tue, Aug 3, 2010 at 5:07 PM, Geoffrey Garen gga...@apple.com wrote: -Ensures that the APIs we expose to the web are at least good enough for our own editing code I don't think this necessarily follows. Not everything exposed to the

Re: [webkit-dev] Fwd: webkit editing rewrite?

2010-08-05 Thread Adam Barth
On Thu, Aug 5, 2010 at 1:59 AM, Maciej Stachowiak m...@apple.com wrote: On Aug 4, 2010 4:30:01 PM PDT, Darin Adler da...@apple.com wrote: On Aug 4, 2010, at 3:48 PM, Ryosuke Niwa wrote: I think the kind of crashes Ojan is talking about are ones caused by DOM mutation events. snip It’s

Re: [webkit-dev] Some new coding style rules

2010-08-05 Thread Tor Arne Vestbø
On 04.08.10 20.04, Adam Roben wrote: On Aug 4, 2010, at 7:15 AM, Jeremy Orlow wrote: 2. ENABLE(FOO) #endif comments #if ENABLE(FOO) .. #endif // ENABLE(FOO) Shall we remove the comment, or require it explicitely in the style rules? I find these comments especially helpful when there are

Re: [webkit-dev] HTML5 tree builder enabled

2010-08-05 Thread Jeremy Orlow
Impressive! Thanks Eric+Adam for all the work on this! You guys are quite a team. J On Thu, Aug 5, 2010 at 9:10 AM, Adam Barth aba...@webkit.org wrote: The HTML5 tree builder is enabled as of http://trac.webkit.org/changeset/64712. Check out our awesome SVG-in-HTML demo (in a post r64712

Re: [webkit-dev] Some new coding style rules

2010-08-05 Thread David Kilzer
On Wed, August 4, 2010 at 11:56:53 PM, Sam Weinig wrote: On Wed, Aug 4, 2010 at 1:29 AM, Nikolas Zimmermann zimmerm...@physik.rwth-aachen.de wrote: namespace WebCore { ... } // namespace WebCore 2. ENABLE(FOO) #endif comments #if ENABLE(FOO) .. #endif // ENABLE(FOO) I like these

[webkit-dev] New wiki page for Visual Studio debugging tips

2010-08-05 Thread Adam Roben
While working on WebKit2 I've had to become a bit more savvy in my Visual Studio usage. I started a wiki page to record useful tips I've learned. You can find it here: https://trac.webkit.org/wiki/Debugging%20With%20Visual%20Studio. I hope others will find it useful, too. Please add your own