Re: [webkit-dev] Use of Frame by ResourceHandle

2010-09-12 Thread Adam Barth
On Sat, Sep 11, 2010 at 10:52 PM, Darin Fisher da...@chromium.org wrote: On Sat, Sep 11, 2010 at 10:42 PM, Adam Barth aba...@webkit.org wrote: On Sat, Sep 11, 2010 at 10:02 PM, Darin Fisher da...@chromium.org wrote: I don't understand.  WebWorkers use ThreadableLoader, which routes the

Re: [webkit-dev] Use of Frame by ResourceHandle

2010-09-12 Thread Darin Fisher
On Sat, Sep 11, 2010 at 11:07 PM, Adam Barth aba...@webkit.org wrote: On Sat, Sep 11, 2010 at 10:52 PM, Darin Fisher da...@chromium.org wrote: On Sat, Sep 11, 2010 at 10:42 PM, Adam Barth aba...@webkit.org wrote: On Sat, Sep 11, 2010 at 10:02 PM, Darin Fisher da...@chromium.org wrote: I

Re: [webkit-dev] Use of Frame by ResourceHandle

2010-09-12 Thread Maciej Stachowiak
I like Adam's thinking on this. ResourceHandle depending on Frame, even indirectly, is something of a layering violation. It makes more sense to factor out the bits that it does need, a la NetworkContext. Using client methods to make an association externally seems ok too, but poses more risk

Re: [webkit-dev] Why is ResourceHandle.cpp in WebKit/chromium/src

2010-09-12 Thread Maciej Stachowiak
On Sep 11, 2010, at 9:42 PM, Darin Fisher wrote: On Sat, Sep 11, 2010 at 2:49 AM, Adam Barth aba...@webkit.org wrote: If we like pattern (3), maybe we should replace PlatformBridge with (3)? Yes, perhaps we should do that. In concert with that, it would be good to create a

Re: [webkit-dev] Use of Frame by ResourceHandle

2010-09-12 Thread Adam Barth
On Sat, Sep 11, 2010 at 11:28 PM, Darin Fisher da...@chromium.org wrote: On Sat, Sep 11, 2010 at 11:07 PM, Adam Barth aba...@webkit.org wrote: On Sat, Sep 11, 2010 at 10:52 PM, Darin Fisher da...@chromium.org wrote: For example, you cannot load any network requests in Chromium unless you

Re: [webkit-dev] Use of Frame by ResourceHandle

2010-09-12 Thread David Levin
On Sat, Sep 11, 2010 at 11:07 PM, Adam Barth aba...@webkit.org wrote: On Sat, Sep 11, 2010 at 10:52 PM, Darin Fisher da...@chromium.org wrote: On Sat, Sep 11, 2010 at 10:42 PM, Adam Barth aba...@webkit.org wrote: On Sat, Sep 11, 2010 at 10:02 PM, Darin Fisher da...@chromium.org wrote: I

Re: [webkit-dev] Use of Frame by ResourceHandle

2010-09-12 Thread Adam Barth
On Sun, Sep 12, 2010 at 12:33 PM, David Levin le...@chromium.org wrote: On Sat, Sep 11, 2010 at 11:07 PM, Adam Barth aba...@webkit.org wrote: Having fake versions of objects add complexity to all the code that expects to talk to real versions of those objects.  For example, SVG-in-img creates

Re: [webkit-dev] Use of Frame by ResourceHandle

2010-09-12 Thread David Levin
On Sun, Sep 12, 2010 at 12:37 PM, Adam Barth aba...@webkit.org wrote: On Sun, Sep 12, 2010 at 12:33 PM, David Levin le...@chromium.org wrote: On Sat, Sep 11, 2010 at 11:07 PM, Adam Barth aba...@webkit.org wrote: Having fake versions of objects add complexity to all the code that expects to

Re: [webkit-dev] Use of Frame by ResourceHandle

2010-09-12 Thread Adam Barth
On Sat, Sep 11, 2010 at 11:28 PM, Darin Fisher da...@chromium.org wrote: On Sat, Sep 11, 2010 at 11:07 PM, Adam Barth aba...@webkit.org wrote: On Sat, Sep 11, 2010 at 10:52 PM, Darin Fisher da...@chromium.org wrote: There are are lots of ways to get a Frameless document.  For example,

Re: [webkit-dev] Use of Frame by ResourceHandle

2010-09-12 Thread Adam Barth
On Sun, Sep 12, 2010 at 12:43 PM, David Levin le...@chromium.org wrote: On Sun, Sep 12, 2010 at 12:37 PM, Adam Barth aba...@webkit.org wrote: On Sun, Sep 12, 2010 at 12:33 PM, David Levin le...@chromium.org wrote: On Sat, Sep 11, 2010 at 11:07 PM, Adam Barth aba...@webkit.org wrote: Having