Re: [webkit-dev] Bools are strictly worse than enums

2010-12-06 Thread Darin Adler
On Dec 4, 2010, at 3:01 PM, Maciej Stachowiak wrote: Passing a true or false literal (at least in cases where it's not the sole argument) is a likely indicator of unclear style, as opposed to taking a boolean argument. Agreed. In fact, even putting a boolean literal in a named variable

[webkit-dev] Stability problems involving Javascript GC

2010-12-06 Thread Chris Backas
Hello all, I'm trying to write a Cocoa application with embedded WebViews that navigates through a web application, eventually arriving at a page with a Java applet. I query some values from the Java applet via Javascript, and then at some point I close up and free the WebView. The problem

Re: [webkit-dev] Stability problems involving Javascript GC

2010-12-06 Thread Geoffrey Garen
Hi Chris. (function () { var app = document.getElementById(\RemoteApplication\); var ReturnMe = Number(app.getListenPort()); app = null; return ReturnMe; })() FYI, from a GC perspective, there's no need to set app to

Re: [webkit-dev] Stability problems involving Javascript GC

2010-12-06 Thread Chris Backas
Hi Geoff, On Dec 6, 2010, at 2:24 PM, Geoffrey Garen wrote: Hi Chris. (function () { var app = document.getElementById(\RemoteApplication\); var ReturnMe = Number(app.getListenPort()); app = null; return ReturnMe; })()

Re: [webkit-dev] Bools are strictly worse than enums

2010-12-06 Thread Chris Marrin
On Dec 6, 2010, at 10:15 AM, Darin Adler wrote: On Dec 4, 2010, at 3:01 PM, Maciej Stachowiak wrote: Passing a true or false literal (at least in cases where it's not the sole argument) is a likely indicator of unclear style, as opposed to taking a boolean argument. Agreed. In

[webkit-dev] Rebaselining render tree dumps

2010-12-06 Thread David Hyatt
RenderTreeAsTetxt has a large number of hacks in it that have been put in over time to keep the dumps from changing too dramatically. Some of these include: (1) Table cells dump incorrect dimensions and positions. (2) Text nodes dump an incorrect bounding box position. (3) RenderInlines don't

Re: [webkit-dev] Rebaselining render tree dumps

2010-12-06 Thread Dirk Pranke
I think this is a great idea. I have one suggestion and one potentially large, derailing comment :) Suggestion: in theory, fixing the render tree output shouldn't change the pixel output. So, I would suggest that as many ports as possible should be running (up-to-date) pixel tests when do have

Re: [webkit-dev] Rebaselining render tree dumps

2010-12-06 Thread David Hyatt
On Dec 6, 2010, at 3:20 PM, Dirk Pranke wrote: I think this is a great idea. I have one suggestion and one potentially large, derailing comment :) Suggestion: in theory, fixing the render tree output shouldn't change the pixel output. So, I would suggest that as many ports as possible

Re: [webkit-dev] Rebaselining render tree dumps

2010-12-06 Thread Dan Bernstein
On Dec 6, 2010, at 12:30 PM, David Hyatt wrote: RenderTreeAsTetxt has a large number of hacks in it that have been put in over time to keep the dumps from changing too dramatically. Some of these include: (1) Table cells dump incorrect dimensions and positions. (2) Text nodes dump an

Re: [webkit-dev] Rebaselining render tree dumps

2010-12-06 Thread David Hyatt
On Dec 6, 2010, at 4:12 PM, Dan Bernstein wrote: (6) There’s something called RenderBody ;-) LOL yeah. I forgot about that one. dave (hy...@apple.com) ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] Rebaselining render tree dumps

2010-12-06 Thread Mihai Parparita
On Mon, Dec 6, 2010 at 12:30 PM, David Hyatt hy...@apple.com wrote: What do people think of this idea?  How can we make sure that a rebaselining like this goes smoothly? I think this is a great idea. As far as how to do this, prompted by the Leopard - Snow Leopard switch (which is causing