Re: [webkit-dev] (no subject)

2012-02-28 Thread Andy Wingo
Hi Dirk, On Mon, 2012-02-27 at 17:56 -0800, Dirk Pranke wrote: 1) Do you use -g foo to upload a single change? Yes, it's pretty much the only way I use it. If so, would you be annoyed if I changed that syntax to a different argument That would be fine. , or eliminated it completely (so

Re: [webkit-dev] Moving WTF out of JavaScriptCore

2012-02-28 Thread Osztrogonac Csaba
Hi, I uploaded the necessary buildfix for Qt to the bugzilla: https://bugs.webkit.org/show_bug.cgi?id=79783 . Please be careful with moving JavaScriptCore/wtf to WTF, because we need zillion trivial fixes for case sensitive file systems. (~4000 files!!!) I made it locally to be able prepare

Re: [webkit-dev] The Care and Feeding of WebCore Modules

2012-02-28 Thread Darin Fisher
Nice. Is there a plan for modularizing Settings? On Feb 28, 2012 12:30 AM, Adam Barth aba...@webkit.org wrote: I wrote up a short wiki page explaining how the modules system works and how to use it when building new features: https://trac.webkit.org/wiki/Modules We've been making good

Re: [webkit-dev] webkit

2012-02-28 Thread David Kilzer
This account has been unsubscribed. Dave On Feb 25, 2012, at 6:57 PM, Eric Seidel wrote: Please ban this spammer. On Sat, Feb 25, 2012 at 1:27 PM, Tyler Cumberton tylercw...@gmail.com wrote: I have a question : webkit site -- -Tyler. ___

Re: [webkit-dev] The Care and Feeding of WebCore Modules

2012-02-28 Thread Adam Barth
We haven't done anything about Settings yet, but Setting is also kind of growing out of control. My initial read is that we should try to autogenerate Settings (and maybe some/all of the Settings-related boilerplate in the WebKit layer) from an in file. Adam On Tue, Feb 28, 2012 at 7:40 AM,

[webkit-dev] RDF related stuff in WebKit.

2012-02-28 Thread Alexis Menard
Hi, I stumble across the RDF work in W3C. I was wondering if that make sense for WebKit. What WebKit could do with the semantic data extracted from the document? Feeding some underlaying indexing application? Or to help some application embedding WebKit but interested in extracting the data

Re: [webkit-dev] The Care and Feeding of WebCore Modules

2012-02-28 Thread Darin Fisher
Good idea! -Darin On Tue, Feb 28, 2012 at 8:46 AM, Adam Barth aba...@webkit.org wrote: We haven't done anything about Settings yet, but Setting is also kind of growing out of control. My initial read is that we should try to autogenerate Settings (and maybe some/all of the Settings-related

Re: [webkit-dev] RDF related stuff in WebKit.

2012-02-28 Thread Maciej Stachowiak
I think many of us in the WebKit community are skeptical of the value of implementing RDFa on the client side, at least for now. The proposed API is rather complicated, the processing rules are quite complicated, and it's not clear there is demand for authors. HTML Microdata is a similar

Re: [webkit-dev] The Care and Feeding of WebCore Modules

2012-02-28 Thread Adam Barth
Yeah. I haven't studied the Settings issue carefully yet. If you look at patches that add a new setting, they need to add a ridiculous amount of boilerplate code, especially if they want to test the setting. Reducing this overhead seems valuable (whether by autogeneration or other means),

Re: [webkit-dev] (no subject)

2012-02-28 Thread Ojan Vafai
On Mon, Feb 27, 2012 at 5:56 PM, Dirk Pranke dpra...@chromium.org wrote: Hi all, If you don't use webkit-patch and Git, you can stop reading now. Otherwise ... Currently, webkit-patch -g has some special logic for figuring out what to diff against for Git checkouts. Specifically,

Re: [webkit-dev] The Care and Feeding of WebCore Modules

2012-02-28 Thread Darin Fisher
The main issue isn't that the settings are large and unwieldy. I thought the point of the modularization effort was to enable partitioning of features. That means eliminating files that enumerate each feature. That said, we might still have classes that need to mention all features, so to

Re: [webkit-dev] The Care and Feeding of WebCore Modules

2012-02-28 Thread Maciej Stachowiak
One thing that would be helpful to add is an explanation of what types of subsystems should be turned into Modules and what types should not. Also advantages and disadvantages of turning a particular piece of code into a Module. I think part of the confusion/controversy around these changes

Re: [webkit-dev] The Care and Feeding of WebCore Modules

2012-02-28 Thread Darin Fisher
On Tue, Feb 28, 2012 at 11:11 AM, Alexey Proskuryakov a...@webkit.org wrote: Having read the wiki page, I'm even more unhappy with the approach that has been taken than I used to be. In fact, it is harmful even to the goals of the refactoring. If a single #ifdefed line in DOMWindow.idl is a

Re: [webkit-dev] The Care and Feeding of WebCore Modules

2012-02-28 Thread Alexey Proskuryakov
28.02.2012, в 11:25, Darin Fisher написал(а): Is this something the build system could help address? Perhaps a by-product of the build is or could be a single file that contains everything that will be exposed on WorkerContext / DOMWindow? Some of these concerns could be alleviated with

Re: [webkit-dev] The Care and Feeding of WebCore Modules

2012-02-28 Thread Adam Barth
On Tue, Feb 28, 2012 at 11:24 AM, Maciej Stachowiak m...@apple.com wrote: One thing that would be helpful to add is an explanation of what types of subsystems should be turned into Modules and what types should not. Also advantages and disadvantages of turning a particular piece of code into

Re: [webkit-dev] The Care and Feeding of WebCore Modules

2012-02-28 Thread Adam Barth
On Tue, Feb 28, 2012 at 11:52 AM, Maciej Stachowiak m...@apple.com wrote: But it seems like what is actually happening is wholesale rapid application of this pattern to all of WebCore, including even things that aren't in the Modules directory. So it's starting to seem more like a major

Re: [webkit-dev] The Care and Feeding of WebCore Modules

2012-02-28 Thread Adam Barth
2012/2/28 Alexey Proskuryakov a...@webkit.org: - separation of concerns seems incorrect (not all code with WebSocket in the name is WebSocket code is the concern of engineers who solely focus on WebSocket). Do you have a concrete example of this sort of code? It's easier to talk concretely

Re: [webkit-dev] The Care and Feeding of WebCore Modules

2012-02-28 Thread Adam Barth
On Tue, Feb 28, 2012 at 11:52 AM, Maciej Stachowiak m...@apple.com wrote: From the initial mail about modules, I got the (perhaps mistaken) impression that it would be used only for selected features that had very loose coupling and were perhaps not even of interest to every port. That seemed

Re: [webkit-dev] The Care and Feeding of WebCore Modules

2012-02-28 Thread Adam Barth
On Tue, Feb 28, 2012 at 1:59 PM, Maciej Stachowiak m...@apple.com wrote: On Feb 28, 2012, at 12:20 PM, Adam Barth wrote: On Tue, Feb 28, 2012 at 11:52 AM, Maciej Stachowiak m...@apple.com wrote: But it seems like what is actually happening is wholesale rapid application of this pattern to all

Re: [webkit-dev] Moving WTF out of JavaScriptCore

2012-02-28 Thread Eric Seidel
I'm going to push off the move, probably until next week. Thank you for the Qt patch! I'll post a patch for Mark and we can discuss further from there. -eric On Tue, Feb 28, 2012 at 7:38 AM, Osztrogonac Csaba o...@inf.u-szeged.hu wrote: Hi, I uploaded the necessary buildfix for Qt to the

Re: [webkit-dev] Moving WTF out of JavaScriptCore

2012-02-28 Thread Mark Rowe
On 2012-02-28, at 07:38, Osztrogonac Csaba o...@inf.u-szeged.hu wrote: Hi, I uploaded the necessary buildfix for Qt to the bugzilla: https://bugs.webkit.org/show_bug.cgi?id=79783 . Please be careful with moving JavaScriptCore/wtf to WTF, because we need zillion trivial fixes for case

Re: [webkit-dev] Moving WTF out of JavaScriptCore

2012-02-28 Thread Eric Seidel
My current plan is to have a WTF/wtf directory to avoid this exact issue. :) And to avoid the annoyance of 131 files in the root WTF directory. I'm open to other suggestions if folks have them. -eric On Tue, Feb 28, 2012 at 3:59 PM, Mark Rowe mr...@apple.com wrote: On 2012-02-28, at 07:38,

Re: [webkit-dev] Moving WTF out of JavaScriptCore

2012-02-28 Thread Geoffrey Garen
My current plan is to have a WTF/wtf directory to avoid this exact issue. :) WTF/wtf makes the think, WTF? -- which is a fun mental onomatopoeia, but probably not a great design. Just plain Source/wtf looks better to me. And to avoid the annoyance of 131 files in the root WTF directory. I'd

[webkit-dev] CSS properties vs. their JS bindings on the style object

2012-02-28 Thread Tom Zakrajsek
While investigating https://bugs.webkit.org/show_bug.cgi?id=77427, Dave and I have been trekking through the bindings code. Multiword CSS property names are hyphen-delimited and lower-case, while the equivalent JS binding names are camel-case. In the implementation, our binding code is

Re: [webkit-dev] CSS properties vs. their JS bindings on the style object

2012-02-28 Thread Simon Fraser
On Feb 28, 2012, at 5:00 PM, Tom Zakrajsek wrote: While investigating https://bugs.webkit.org/show_bug.cgi?id=77427, Dave and I have been trekking through the bindings code. Multiword CSS property names are hyphen-delimited and lower-case, while the equivalent JS binding names are

Re: [webkit-dev] CSS properties vs. their JS bindings on the style object

2012-02-28 Thread Eric Seidel
It would have to be WebKit-only content, correct? On Tue, Feb 28, 2012 at 5:04 PM, Simon Fraser simon.fra...@apple.comwrote: On Feb 28, 2012, at 5:00 PM, Tom Zakrajsek wrote: While investigating https://bugs.webkit.org/show_bug.cgi?id=77427, Dave and I have been trekking through the bindings

Re: [webkit-dev] Moving WTF out of JavaScriptCore

2012-02-28 Thread Eric Seidel
I'm fine with Source/wtf. Very easy to implement. On Tue, Feb 28, 2012 at 4:59 PM, Geoffrey Garen gga...@apple.com wrote: My current plan is to have a WTF/wtf directory to avoid this exact issue. :) WTF/wtf makes the think, WTF? -- which is a fun mental onomatopoeia, but probably not a

Re: [webkit-dev] Moving WTF out of JavaScriptCore

2012-02-28 Thread Mark Rowe
On 2012-02-28, at 17:11, Eric Seidel e...@webkit.org wrote: I'm fine with Source/wtf. Very easy to implement. I think this has the potential to cause problems. It would lead to adding the Source directory to the header search path for some build systems, which would cause all sorts of

Re: [webkit-dev] CSS properties vs. their JS bindings on the style object

2012-02-28 Thread Simon Fraser
Yes, of which there is plenty. Simon On Feb 28, 2012, at 5:10 PM, Eric Seidel wrote: It would have to be WebKit-only content, correct? On Tue, Feb 28, 2012 at 5:04 PM, Simon Fraser simon.fra...@apple.com wrote: On Feb 28, 2012, at 5:00 PM, Tom Zakrajsek wrote: While investigating

Re: [webkit-dev] The Care and Feeding of WebCore Modules

2012-02-28 Thread Adam Barth
On Tue, Feb 28, 2012 at 4:43 PM, Kentaro Hara hara...@chromium.org wrote: First of all, I am sorry we have done things too aggressively without a community consensus. I'll stop committing patches until reaching a consensus, and am happy to revert some patches that have already committed. As

Re: [webkit-dev] The Care and Feeding of WebCore Modules

2012-02-28 Thread Kentaro Hara
So my answer to Maciej's second question: 2) To what extent should Module-like techniques be applied to non-Modules? is that let us stop applying Module-like techniques to non-Modules, until the modularization techniques mature well and the advantages of applying it become obvious. If there

Re: [webkit-dev] CSS properties vs. their JS bindings on the style object

2012-02-28 Thread tomz
Yeah, but how many people really use this Trident thing ;) Seriously, I'm not sure how to proceed on this. It does seem to be outside the spec. Humorously, even Microsoft's has references that imply that the script binding is named differently from the CSS attribute.

Re: [webkit-dev] CSS properties vs. their JS bindings on the style object

2012-02-28 Thread tomz
Sorry, I posted the wrong Microsoft link. Here's the one I meant ... http://msdn.microsoft.com/en-us/library/ie/ms537842%28v=vs.85%29.aspx --Tom Yeah, but how many people really use this Trident thing ;) Seriously, I'm not sure how to proceed on this. It does seem to be outside the spec.