Re: [webkit-dev] Changing Github repository to mirror git.webkit.org (was Github vs. git.webkit.org)

2013-01-17 Thread Dominik Röttsches
On 01/16/2013 10:07 PM, Eric Seidel wrote: Do we know if there is a way to re-write our existing forks w/o pulling the whole repo down, just to push it back up again? If you make the new github mirror fork a remote for your existing git.webkit.org clone and push from there you would only need

Re: [webkit-dev] Proposal to remove list-item special counter

2013-01-17 Thread L. David Baron
On Wednesday 2013-01-16 18:25 -0800, Darin Adler wrote: On Jan 16, 2013, at 5:46 PM, Elliott Sprehn espr...@chromium.org wrote: I've scoured the web and can't find any reference to anyone using it, mention of it's usage on any pages and no other browser supports it. How much more common

Re: [webkit-dev] request of canconfirm-bit

2013-01-17 Thread 徐征
Thank you. Darin I will add comments on the bug. BR, Zheng (2013/01/17 11:40), Darin Adler wrote: On Jan 16, 2013, at 2:54 PM, 徐征 xz91...@yahoo.co.jp wrote: So, how can I get assign for this issue(and make the status to ASSIGNED)? You don’t need to. You can add comments and post a patch

[webkit-dev] EWS commenting about ancient patches

2013-01-17 Thread Alexey Proskuryakov
On several occasions over the last few days, I noticed EWS commenting in bugs that didn't have any recent activity, e.g. https://bugs.webkit.org/show_bug.cgi?id=87527. Is EWS picking ancient patches, or is it posting comments to wrong bugs? - WBR, Alexey Proskuryakov

Re: [webkit-dev] EWS commenting about ancient patches

2013-01-17 Thread Osztrogonac Csaba
Hi, EWS picks up all patches with r? flag. Mac WK2 EWS is a brand new EWS bot, that's why it tested ancient patches and commented their bugs. It finished processing ancient patches, so it won't be problem in the future. br, Ossy Alexey Proskuryakov írta: On several occasions over the last few

[webkit-dev] Can't upload patch

2013-01-17 Thread Raymond Toy
I'm trying to upload a patch and webkit-patch upload appears to do everything except actually add the patch to the bug. I first ran webkit-patch upload and it correctly created the bug ( https://bugs.webkit.org/show_bug.cgi?id=106955) for me, but didn't upload the patch. When I run webkit-patch

Re: [webkit-dev] Can't upload patch

2013-01-17 Thread Adam Barth
Have you tried uploading the patch manually by running svn-create-patch and using the attachments UI in bugs.webkit.org? One possibility is that your patch is too big for bugs.webkit.org to handle. You mention that it contains a number of binary files, which might be the cause of the problem.

Re: [webkit-dev] Can't upload patch

2013-01-17 Thread Raymond Toy
Hmm. I have a git checkout of webkit so svn-create-patch doesn't want to work. Yeah, the patch is probably too big. The particular patch could be broken up into 3-4 separate smaller patches. Perhaps that will work. On Thu, Jan 17, 2013 at 9:52 AM, Adam Barth aba...@webkit.org wrote: Have

Re: [webkit-dev] Can't upload patch

2013-01-17 Thread Eric Seidel
Sorry. webkit-patch upload does not have very good error handling: https://bugs.webkit.org/show_bug.cgi?id=72863 On Thu, Jan 17, 2013 at 10:49 AM, Raymond Toy r...@google.com wrote: Hmm. I have a git checkout of webkit so svn-create-patch doesn't want to work. Yeah, the patch is probably

Re: [webkit-dev] EWS commenting about ancient patches

2013-01-17 Thread Ryosuke Niwa
Sorry, that's my fault. I added Mac-WK2 EWS to the EWS queue much earlier than we added bots. So we ended up having 1000+ backlogs of patches. As Ossy points out, Mac WK2 EWS bots have caught up with patches so this shouldn't be a problem in the future. - R. Niwa On Thu, Jan 17, 2013 at 8:40 AM,

Re: [webkit-dev] EWS commenting about ancient patches

2013-01-17 Thread Eric Seidel
I believe the queue was actually cleared when they were brought online. As Ossy notes, this is expected behavior. Every time the feeder queue boots up (which is every 2 hours), it sends *all* patches marked for review to queues.webkit.org. queues.webkit.org makes sure that each individual EWS

Re: [webkit-dev] EWS commenting about ancient patches

2013-01-17 Thread Adam Barth
Maybe we shouldn't bother feeding the bots patches that are over a certain age (perhaps a week)? Adam On Thu, Jan 17, 2013 at 11:50 AM, Eric Seidel e...@webkit.org wrote: I believe the queue was actually cleared when they were brought online. As Ossy notes, this is expected behavior. Every

Re: [webkit-dev] EWS commenting about ancient patches

2013-01-17 Thread Eric Seidel
That seems totally reasonable, and simple to implement: https://bugs.webkit.org/show_bug.cgi?id=107152 On Thu, Jan 17, 2013 at 11:55 AM, Adam Barth aba...@webkit.org wrote: Maybe we shouldn't bother feeding the bots patches that are over a certain age (perhaps a week)? Adam On Thu, Jan 17,

Re: [webkit-dev] Can't upload patch

2013-01-17 Thread jpetso
Note that "git show" produces a valid different file, extra commit message notwithstanding. (The commit message is part of the header and will be ignored when used with diff and related tools.)If you have your commit, plus the ChangeLog changes mer ged into the same commit, you can just pipe the

Re: [webkit-dev] Can't upload patch

2013-01-17 Thread jpetso
... valid *diff* file. Damn you autocorrect! From: jpe...@gmx.atSent: Thursday, January 17, 2013 3:42 PMTo: Raymond ToyCc: webkit-d e...@lists.webkit.orgSubject: Re: [webkit-dev] Can't upload patchNote that "git show" produces a valid different file, extra commit message notwithstanding. (The

Re: [webkit-dev] Changing Github repository to mirror git.webkit.org (was Github vs. git.webkit.org)

2013-01-17 Thread Eric Seidel
Yes, but I'm more interested in rebasing my existing github branches. :) But you're right, I could probably run Tools/Scripts/sync-master-with-upstream from my existing git.webkit.org checkout and not have to download anything. I'd still have a bunch of github branches which I can't easily

Re: [webkit-dev] Can't upload patch

2013-01-17 Thread Konrad Piascik
Instead of piping the output of git show, I'd use git format-patch -1 This will generate a patch file for the topmost commit of your current branch. Cheers, Konrad From: webkit-dev-boun...@lists.webkit.org [webkit-dev-boun...@lists.webkit.org] on behalf

Re: [webkit-dev] Changing Github repository to mirror git.webkit.org (was Github vs. git.webkit.org)

2013-01-17 Thread Pablo Flouret
Maybe git rebase --onto would help, if only a bit? http://git-scm.com/book/en/Git-Branching-Rebasing#More-Interesting-Rebases /pf On Thu, 17 Jan 2013 13:13:44 -0800, Eric Seidel esei...@google.com wrote: Yes, but I'm more interested in rebasing my existing github branches. :) But you're

Re: [webkit-dev] Can't upload patch

2013-01-17 Thread Raymond Toy
On Thu, Jan 17, 2013 at 1:17 PM, Konrad Piascik kpias...@rim.com wrote: Instead of piping the output of git show, I'd use git format-patch -1 This will generate a patch file for the topmost commit of your current branch. Thanks! That does the trick. I wasn't sure if the patches for the

Re: [webkit-dev] Can't upload patch

2013-01-17 Thread Konrad Piascik
You could have kept your commits separate and generated a patch for each. The parameter for format-patch is the number of commits for which to generate patches. -Konrad Sent from my BlackBerry smartphone. From: Raymond Toy Sent: Thursday, January 17, 2013 6:00 PM To: Konrad Piascik Cc:

[webkit-dev] Feature configurations

2013-01-17 Thread laszlo gombos
Hi, I wanted to give a heads up that I'm planning to land a patch that moves the ENABLE feature macros out from Platform.h into its own file - see https://bugs.webkit.org/show_bug.cgi?id=105735. After the patch lands I will update our wiki with the changes at

Re: [webkit-dev] Is the New XMLParser dead?

2013-01-17 Thread Ryosuke Niwa
Hi, It has been 11 months since Eric initially raised the concern. Can we go ahead and remove the parser now? - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Is the New XMLParser dead?

2013-01-17 Thread Adam Barth
Maciej has asked that we keep it around until the end of February: https://bugs.webkit.org/show_bug.cgi?id=100710 Adam On Thu, Jan 17, 2013 at 4:10 PM, Ryosuke Niwa rn...@webkit.org wrote: Hi, It has been 11 months since Eric initially raised the concern. Can we go ahead and remove the

Re: [webkit-dev] Adding main element to WebCore

2013-01-17 Thread James Craig
IMO, the following represents enough evidence to land the patch as soon as the last layout test failure is resolved. https://bugs.webkit.org/show_bug.cgi?id=103172 1. Sam Ruby, as Chair declared this passing the HTML WG vote, With no objections and ample support, this resolution passes.

Re: [webkit-dev] Adding main element to WebCore

2013-01-17 Thread Maciej Stachowiak
Does anyone still object in light of these updates, particularly Mozilla's support for the feature? Regards, Maciej On Jan 17, 2013, at 5:20 PM, James Craig jcr...@apple.com wrote: IMO, the following represents enough evidence to land the patch as soon as the last layout test failure is

Re: [webkit-dev] Is the New XMLParser dead?

2013-01-17 Thread Maciej Stachowiak
I think it's fine to shoot it in the head now. We do still want to come back to it eventually, but it's now apparent that we won't in the next 1.5 months. - Maciej On Jan 17, 2013, at 4:15 PM, Adam Barth aba...@webkit.org wrote: Maciej has asked that we keep it around until the end of

Re: [webkit-dev] Adding main element to WebCore

2013-01-17 Thread Ryosuke Niwa
Thanks for the follow up. Mozilla's commitment makes a strong case for supporting it in WebKit as well. - R. Niwa On Thu, Jan 17, 2013 at 5:20 PM, James Craig jcr...@apple.com wrote: IMO, the following represents enough evidence to land the patch as soon as the last layout test failure is

[webkit-dev] We've added Mac WK2 EWS (runs tests!)

2013-01-17 Thread Ryosuke Niwa
Hello WebKittens, Lucas and I have enabled Mac WK2 EWS bots that run layout tests using WebKitTestRunner (WebKit2) on Mountain Lion. You should see the mac-wk2 bubble in your bugzilla entries now. If anyone has any interest in looking at the queues, you can find them here: EWS Queues