Re: [webkit-dev] Offline Assembler build step always computes hashes even when nothing changes

> On Sep 16, 2018, at 5:59 PM, Filip Pizlo wrote: > > Which offline assembler build step are you referring to? The one that is the “Offline Assembler” target in Xcode, which runs this command: ruby JavaScriptCore/offlineasm/asm.rb JavaScriptCore/llint/LowLevelInterpreter.asm

Re: [webkit-dev] Offline Assembler build step always computes hashes even when nothing changes

> On Sep 16, 2018, at 4:03 PM, Darin Adler wrote: > > I noticed that the “Offline Assembler” build step was taking between 5 and 30 > seconds every time I build. Really stands out in incremental builds. I > realized that this step does not do any dependency analysis. Every time, it > builds

Re: [webkit-dev] Offline Assembler build step always computes hashes even when nothing changes

Darin, I can take a look at this. Filed > “Offline assembler always computes hashes even when nothing changes" - Michael > On Sep 16, 2018, at 4:03 PM, Darin Adler >

[webkit-dev] Offline Assembler build step always computes hashes even when nothing changes

I noticed that the “Offline Assembler” build step was taking between 5 and 30 seconds every time I build. Really stands out in incremental builds. I realized that this step does not do any dependency analysis. Every time, it builds a hash of the input to see if it needs to recompute the

Re: [webkit-dev] node-jsc: A node.js port to the JavaScriptCore engine and iOS

Hi Koby, This sounds awesome. A good list of people to CC on the bug for reviews are: sbar...@apple.com,fpi...@apple.com,keith_mil...@apple.com,mark@apple.com,msab...@apple.com,yusukesuz...@slowstart.org - Saam > On Sep 16, 2018, at 11:44 AM, Filip Pizlo wrote: > > > >> On Sep 16,

Re: [webkit-dev] node-jsc: A node.js port to the JavaScriptCore engine and iOS

> On Sep 16, 2018, at 2:09 AM, Koby Boyango wrote: > > Thanks for taking the time to look into the project :) > > Filip - I would love to. Should I create one bug for all of the patches, or a > bug for each patch? > Also, there is an existing bug that I've reported a while ago, but worked

Re: [webkit-dev] node-jsc: A node.js port to the JavaScriptCore engine and iOS

Thanks for taking the time to look into the project :) Filip - I would love to. Should I create one bug for all of the patches, or a bug for each patch? Also, there is an existing bug that I've reported a while ago, but worked around it for now: https://bugs.webkit.org/show_bug.cgi?id=184232. It