Re: [webkit-dev] New web-facing canvas feature: opaque attribute

2013-03-14 Thread Dana Jansens
On Thu, Mar 14, 2013 at 3:46 PM, Dean Jackson d...@apple.com wrote: I'm not sure I like this proposal. Why is canvas special? Why doesn't img get an opaque attribute (or flag)? Why not every element? There is ongoing work to infer opaqueness in every other kind of element when possible. See

Re: [webkit-dev] window.internals abuse

2013-03-13 Thread Dana Jansens
On Wed, Mar 13, 2013 at 12:42 PM, Simon Fraser simon.fra...@apple.comwrote: https://bugs.webkit.org/show_bug.cgi?id=80046 (landed in http://trac.webkit.org/changeset/114081) added internals. setBackgroundBlurOnNode(). I consider this to be abuse of the Internals object. As shown by the

Re: [webkit-dev] window.internals abuse

2013-03-13 Thread Dana Jansens
On Wed, Mar 13, 2013 at 1:21 PM, Simon Fraser simon.fra...@apple.comwrote: On Mar 13, 2013, at 10:15 AM, Dana Jansens dan...@chromium.org wrote: On Wed, Mar 13, 2013 at 12:42 PM, Simon Fraser simon.fra...@apple.comwrote: https://bugs.webkit.org/show_bug.cgi?id=80046 (landed in http

Re: [webkit-dev] window.internals abuse

2013-03-13 Thread Dana Jansens
On Wed, Mar 13, 2013 at 1:25 PM, Ryosuke Niwa rn...@webkit.org wrote: On Wed, Mar 13, 2013 at 10:22 AM, Dana Jansens dan...@chromium.orgwrote: On Wed, Mar 13, 2013 at 1:21 PM, Simon Fraser simon.fra...@apple.comwrote: On Mar 13, 2013, at 10:15 AM, Dana Jansens dan...@chromium.org wrote

Re: [webkit-dev] css: rotateY(90) with perspective()

2013-02-12 Thread Dana Jansens
+shawnsingh On Tue, Feb 12, 2013 at 9:22 AM, Marcin Szamotulski msza...@gmail.comwrote: Dear WebKit-Dev, I found an interesting difference between implementation of css 3d transforms in Gecko (FireFox) and Chromium (WebKit). In Gecko, the following css rule: tranform: perspective(500px)

Re: [webkit-dev] Int/FloatPoint and Int/FloatSize

2013-01-04 Thread Dana Jansens
On Fri, Jan 4, 2013 at 12:15 AM, Simon Fraser simon.fra...@apple.comwrote: On Jan 3, 2013, at 7:43 PM, Steve Block wrote: Thanks all for the detailed replies. I wasn't aware of the distinction made between points and vectors for the purposes transforms. However, if I understand things

Re: [webkit-dev] Possible device scale factor emulation approaches?

2012-12-05 Thread Dana Jansens
On Wed, Dec 5, 2012 at 8:28 PM, Adam Barth aba...@webkit.org wrote: On Wed, Dec 5, 2012 at 7:16 AM, Alexander Pavlov apav...@chromium.org wrote: I'm working on emulating the device scale factor with Web Inspector. My goal is to let web developers see their pages on normal (device pixel ratio ==

Re: [webkit-dev] Some stderr output missing when using run-webkit-tests

2012-10-29 Thread Dana Jansens
On Mon, Oct 29, 2012 at 6:59 PM, Dirk Pranke dpra...@chromium.org wrote: If that's the case, it's a bug, and new to me. The output was present on the results page, but it would only include the first, maybe, 60 lines or so. - Dana -- Dirk On Mon, Oct 29, 2012 at 3:42 PM, Terry Anderson

[webkit-dev] Hashing pairs in WTF

2012-09-07 Thread Dana Jansens
Hello WebKittens, I noticed the other day that our hashing method in wtf/HashFunctions.h for hashing of pairs can be improved. We have a hash method (WTF::intHash) for a single integer that takes 32 bits as input and produces a key of 32 bits. This works well enough for hashing an integer, as it

Re: [webkit-dev] Comments in the code (Was Please include function-level comments in change log entries)

2012-07-13 Thread Dana Jansens
On Fri, Jul 13, 2012 at 1:56 PM, Ryosuke Niwa rn...@webkit.org wrote: On Fri, Jul 13, 2012 at 5:57 AM, Stephen Chenney schen...@chromium.orgwrote: I don't doubt there are poor comments, both outdated and useless. That's a reviewing failure. You have simply highlighted the fact that any

Re: [webkit-dev] Web APIs and class name collisions

2012-07-12 Thread Dana Jansens
On Thu, Jul 12, 2012 at 1:25 PM, Ryosuke Niwa rn...@webkit.org wrote: I'd vote for CSSRegion or CSSOMRegion for the class you're adding but I'll also suggest we rename the existing Region class now that the term region has a specific semantic in CSS. Maybe LayoutRegion or ScreenRegion?

Re: [webkit-dev] Please include function-level comments in change log entries

2012-07-06 Thread Dana Jansens
On Fri, Jul 6, 2012 at 1:05 PM, Dan Bernstein m...@apple.com wrote: It appears that lately most WebCore change log entires don’t include any comments on individual functions. An overall description of the change at the top of the change log entry is valuable, but it is no substitute for

Re: [webkit-dev] Settings::devicePixelRatio and Settings::defaultDeviceScaleFactor

2012-05-31 Thread Dana Jansens
I agree, having this in Settings seems to imply that the browser's physical device remains the same for its entire lifetime which is not true. - Dana On Thu, May 31, 2012 at 6:52 PM, James Robinson jam...@google.com wrote: (top-posting to fit in) Doesn't the same argument apply to

Re: [webkit-dev] Device and page scaling

2012-05-29 Thread Dana Jansens
On Tue, May 29, 2012 at 9:54 PM, Adam Barth aba...@webkit.org wrote: There's a lot of confusion in the code base about how page and device scaling works. Different ports are using Page::deviceScaleFactor for incompatible purposes. On Mac, Page::deviceScaleFactor represents the actual

Re: [webkit-dev] Git/SVN is slow

2012-03-17 Thread Dana Jansens
On Fri, Mar 16, 2012 at 12:54 PM, William Siegrist wsiegr...@apple.comwrote: On Mar 16, 2012, at 9:26 AM, Ryosuke Niwa rn...@webkit.org wrote: As I stated on this thread, I was getting reasonable download speed from svn and others at home (Comcast business in SF). You may want to compare my

Re: [webkit-dev] Moving to Git?

2012-03-08 Thread Dana Jansens
On Thu, Mar 8, 2012 at 12:35 PM, Alexis Menard alexis.men...@openbossa.orgwrote: On Thu, Mar 8, 2012 at 2:32 PM, Konrad Piascik kpias...@rim.com wrote: It is possible to keep linear history with git. This just requires you to fast forward and rebase before pushing. But can you enforce in