On Feb 15, 2010, at 11:23 PM, haithem rahmani wrote:
the m17n seems providing the same features as the icu library.
There is some overlap, but I’m not sure it includes all the ICU features used
by WebKit.
Folks who don’t want to use ICU have already made ports that use WinCE platform
This is a question for webkit-help, not webkit-dev. The webkit-dev mailing list
is for discussion of development of WebKit, not for use of WebKit.
See http://webkit.org/contact.html for this.
I can’t resist answering this one, though. Next time I will not answer this
kind of question on this
Does anyone know why this test is failing? It’s failing on my computer as well
as on the bot?
-- Darin
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
You mention some refactoring.
But the thing you mention here with the biggest significance is creating a
WebKit-internal clipboard to augment the platform-specific clipboard mechanisms
that work between processes and between WebKit and non-WebKit within a process.
I think that’s OK, but it
This is a question for the webkit-help mailing list or a Qt-specific one, not
webkit-dev. The webkit-dev mailing list is for discussion of WebKit
development, not building or using it.
See http://webkit.org/contact.html.
-- Darin
___
webkit-dev
On Feb 4, 2010, at 12:01 PM, Sam Weinig wrote:
I would be in favor of fixing the existing uses by using explicit std::isinf.
Me too.
-- Darin
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
On Feb 4, 2010, at 1:09 PM, Eric Seidel wrote:
explicit namespaces may not play well with:
http://trac.webkit.org/browser/trunk/JavaScriptCore/wtf/MathExtras.h
I think it’s a good point, and we should make sure MathExtras.h continues to
help smooth over platform differences in such functions.
There’s something wrong with your grep. For example, this style is seen in
RenderLineBoxList::paint.
-- Darin
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
On Jan 23, 2010, at 8:18 AM, Christopher White wrote:
What are the general thoughts whether a binary serialization is possible
retaining all needed information for rendering?
My general thought is that it is not practical.
-- Darin
___
On Jan 22, 2010, at 7:16 AM, Christopher White wrote:
Is it possible to save the DOM resulting from the parsing of HTML / CSS into
a file and then read it back instead of re-parsing the HTML (similar to Java
object serialization).
WebKit has a feature called web archives that does something
On Jan 22, 2010, at 9:12 AM, Adam Treat wrote:
Correct me if I'm wrong, but he said without re-parsing. The WebArchive
definitely needs to be reparsed, right?
You’re right. I was wrong.
I guess the idea boils down to inventing a new serialization for HTML besides
HTML and XHTML, a binary
On Jan 22, 2010, at 7:08 AM, Yong Li wrote:
So how about adding a macro UNREACHABLE_RETURN(valueToReturn)?
I like that idea.
I don’t think it’s only the RVCT compiler that has this issue. I seem to recall
something similar with the Visual Studio compiler. Obviously in any compiler
that knows
On Jan 21, 2010, at 11:22 AM, Alex Milowski wrote:
So, when I try this with the trunk I get an error on the console:
2010-01-21 11:17:24.288 Safari[20905:80f] *** -[WebRenderNode
initWithWebFrameView:]: unrecognized selector sent to instance
0x1f930270
and nothing happens.
This was
Hi folks.
We’ve never formalized this, but I believe that patches tagged with a
particular platform name such as
[Qt] Add new API for fluffy bunnies
should be limited to one particular platform’s code. If the patch changes more
than a trivial bit of platform-independent code, even if the
On Jan 20, 2010, at 2:19 PM, Yong Li wrote:
As everyone may know, current webkit style (at least for most source code)
for a switch statement is like this:
switch (var) {
case valueFirst:
...
break;
...
case valueLast:
...
break;
default:
ASSERT_NOT_REACHED()
}
That’s
On Jan 19, 2010, at 5:34 AM, Konstantin wrote:
I'm a web developer and don't know C at all.
I'm going to use WebKit JavaScriptCore in one of the projects, but I'm not
sure about the possibility of this solution.
There is a webpage with tons of JavaScript code in it, the page is processed
Just out of curiosity, I used the --slowest option to see which tests were
slowest in a debug build. On my fairly-fast Mac Pro the tests took 14 minutes
overall (849.76s), and these were the ten slowest tests:
9.57 secs: editing/selection/move-left-right.html
7.64 secs:
On Jan 13, 2010, at 6:25 PM, Yong Li wrote:
Sorry for my English. does should be will.
I think your question is unclear. The WebKit project will not “ban” use of a
global new/delete operator.
-- Darin
___
webkit-dev mailing list
My main feedback on this plan would be to land and review the work in pieces
that are as small as possible.
For example, factoring out the database bits into a separate database manager
class should be done in an initial first pass that does not make other changes.
I’m also not sure I like
On Jan 14, 2010, at 2:35 PM, Eric Uhrhane wrote:
I think it would have been hard to break this chunk any smaller.
Any time you have a chunk and you’re wondering how it could be broken up
smaller, please feel free to ask that question after cc'ing me on a bug. Maciej
and I, in particular, have
Someone is porting WebKit to Qualcomm’s BREW. And there are many patches for
that port; now a significant fraction of the unreviewed WebKit patches. Who’s
going to review these? Is this a one-time code drop or is there an intent to
maintain this port ongoing? Does the test suite work on the
On Jan 13, 2010, at 9:22 AM, Jason Rukman wrote:
Do I load the history first, or initialize the icon database first since they
seem to have an interdependency that I don’t see how to resolve.
I believe the correct sequence is to call delayDatabaseCleanup first, then
initialize the icon
That’s not a question about development of WebKit. The place to ask is the
webkit-help mailing list http://webkit.org/contact.html.
-- Darin
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
On Jan 8, 2010, at 8:15 AM, Osztrogonac Csaba wrote:
I don't think it is a good idea to land different, platform dependent
expected files with false data.
This is where I think the difference comes in. I don’t think these different
expected files are accurately characterized as “false data”.
On Jan 7, 2010, at 10:13 AM, Afonso Costa wrote:
Anyway, I've created a patch removing the zoomOrNot argument, but I
don't know if I need to create a bugzilla entry for it or just put it in
a place where someone can review it.
A bugzilla entry for it is the best place for someone to review
On Jan 7, 2010, at 10:19 AM, Dimitri Glazkov wrote:
Are we planning to run pixel tests on the build bots?
If we can get them green, we should. It’s a lot of work. We need a volunteer to
do that work. We’ve tried before.
-- Darin
___
webkit-dev
On Jan 6, 2010, at 10:46 AM, Chris Fleizach wrote:
I see a lot of code that calls the same function a number of times in the
same scope.
Is it better to store that result in a local variable, or is it better to
repeatedly call a method...
in this example, node() is called two times
On Jan 6, 2010, at 3:16 PM, Alex Milowski wrote:
Can I override the default calculation of the baseline somehow?
By overriding the baselinePosition function, perhaps.
-- Darin
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
On Jan 6, 2010, at 3:13 PM, Afonso Costa wrote:
Is there any thing wrong or not?
I think the zoomOrNot argument and if statement are both unnecessary now that
bug 30034 is fixed, but the test is otherwise OK.
-- Darin
___
webkit-dev mailing
WebKit contributors have developed a feature called “isolated worlds” to handle
requirements like this.
But I don’t know where we are in the implementation of that feature. Perhaps
one of the people working on isolated worlds could comment on its current
status.
-- Darin
On Jan 4, 2010, at 3:33 PM, Darin Fisher wrote:
I noticed recently that the style bot started complaining about header files
ending with #endif instead of #endif // Foo_h. I was surprised by this
since the style guide does not require it.
I personally see little value in this sort of
On Dec 25, 2009, at 9:39 AM, TAMURA, Kent wrote:
I made a master bug of HTML5, like HTML5 Forms already has.
[Bug 32934] Master bug of HTML5 features
https://bugs.webkit.org/show_bug.cgi?id=32934
Good to get this organized.
But I think you generalized the topic a bit. I think that “HTML5
On Dec 23, 2009, at 1:19 PM, William Edney wrote:
From following the thread earlier, it didn't seem like anyone would have a
major objection to using UTF-8 instead of UTF-16 for localStorage on Webkit.
Maciej did have an objection to doing this in a simplistic way (always using
UTF-8). He
This question is for webkit-help, not webkit-dev. Please see the descriptions
of the lists on http://webkit.org/contact.html.
-- Darin
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
On Dec 21, 2009, at 6:14 PM, Dirk Pranke wrote:
Given all that, Darin, what were you suggesting when you said Let's fix
that?
Lets add a feature so something in the tests tree can indicate a Chromium
Windows result should be the base result, rather than the platform/win one. We
can debate
On Dec 22, 2009, at 4:27 PM, Dirk Pranke wrote:
In the completely generic case, I hope we are not checking in incorrect
results.
We do intentionally check in incorrect results, fairly often. For example,
we’ve checked in whole test suites and then generated expected results without
studying
On Dec 22, 2009, at 10:04 PM, allstars.chh wrote:
so i am wondering where i can get some information about my question here? or
android group?
As you say, Android changes to WebKit have not been entirely merged, so I
suggest that given that you discuss the bugs you have found with the
On Dec 21, 2009, at 1:50 PM, Peter Kasting wrote:
the framework doesn't seem to have a way of distinguishing Safari/Win from
Chromium/Win
Lets fix that.
-- Darin
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
This question is for webkit-help, not webkit-dev. Please see
http://webkit.org/contact.html for an explanation of which topics go on which
list.
-- Darin
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
My preference is:
1) I prefer functions that return booleans over more complex things like
strcmp-style return values. The name of the function ends up being much clearer
in an if statement. Hence, I would like to see a simple cover with a better
name when checking for equality rather than
On Dec 9, 2009, at 4:41 AM, Eddy Bruël wrote:
However, when I trace my plugin, I notice that NPN_IdentifierIsString()
always returns true, even if I do an array access. It looks like the array
index gets converted to a string before it is passed to any of my callbacks.
This doesn't seem
On Dec 9, 2009, at 10:57 AM, Adam Treat wrote:
Ok, well FWIW I disagree that the current rule makes things hard to read and
I do not like the idea of changing it. I object on the same grounds as the
other recent styling change proposals as well as substantively that it makes
anything
On Dec 9, 2009, at 11:25 AM, Adam Treat wrote:
That speaks negatively to the real world value of the rule IMHO.
A lot of the code predates the rule, so I wouldn’t judge the effectiveness of
the rule too harshly.
-- Darin
___
webkit-dev mailing
On Dec 9, 2009, at 1:02 PM, Maciej Stachowiak wrote:
That's my thinking on the matter, perhaps others have other opinions.
Perhaps no surprise to the rest of you, but I agree with every word Maciej said.
-- Darin
___
webkit-dev mailing list
On Dec 7, 2009, at 6:28 AM, Alexander Vassilev wrote:
With qtwebkit 4.5.x I had no problems doing so, no cross-site scripting
blocking by webkit, everything just worked (i did security control by
myself). With qt 4.6 however, I get an empty responseText of the
XMLHttpRequest object.
I
On Dec 7, 2009, at 3:33 PM, Nate Chapin wrote:
I was thinking of renaming it to SpaceSplitString, or AtomicStringList (it's
previous name), but I'm not hung up on any particular name.
Renaming seems OK. Of the two I definitely prefer SpaceSplitString. Generally I
think we should only use
On Dec 7, 2009, at 8:42 PM, Chris Jerdonek wrote:
The existing guidelines single out the case of nested namespaces and
says they should appear further down when the parent exists. For
example, instead of this--
using namespace WebCore::HTMLNames;
namespace WebCore {
do this--
On Dec 1, 2009, at 6:07 PM, Nikolas Zimmermann wrote:
I'd like to enable SVG FIlters support by default. This is the last remaining
piece before we can officially claim SVG 1.0/1.1 support, in our SVG DOM
implementation (through SVG requiredFeatures/requiredExtensions
functionality).
I suggest using VectorUChar instead of String in TextResourceDecoder’s
interface and implementation.
-- Darin
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
On Dec 2, 2009, at 11:28 PM, Brent Fulgham wrote:
I notice that the IWebFrame interface provides a stub for this through the
IWebDocumentText interface, which I was happily connecting to when I realized
that it dead-ends in a notImplemented call.
Is this just something no one has
On Nov 28, 2009, at 12:09 AM, pattin.shieh wrote:
Look at this:void Page::setMainFrame(PassRefPtrFrame mainFrame). Why use
PassRefPtr?
Because the only call to Page::setMainFrame is inside the Frame constructor,
there is no performance benefit to taking a PassRefPtr.
But it’s arguably a
On Dec 2, 2009, at 9:49 AM, Darin Fisher wrote:
This would probably be a performance win since it would reduce the amount of
disk i/o.
(Note, it doesn't mean that 5 million characters could be stored since a
UTF-8 character might be multi-byte.)
Currently the database can store invalid
On Dec 2, 2009, at 10:48 AM, Jeremy Orlow wrote:
How can you construct invalid UTF-16 sequences?
http://unicode.org/faq/utf_bom.html#utf16-7
-- Darin
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
You have sent your mail to the wrong mailing list. The right one is
webkit-help. See this page for details:
http://webkit.org/contact.html
After read http://www.w3.org/TR/CSS21/visuren.html#display-prop for me the
plugin must be instantiated
What you describe seems to be a bug where
On Nov 30, 2009, at 11:38 AM, Mario Bensi wrote:
Are you an idea to fix this or a pointer to help me ?
I don’t know what you are doing, so not sure what kind of help you need. Please
ask on webkit-help, though, lets end the discussion on the WebKit development
mailing list.
-- Darin
On Nov 18, 2009, at 8:55 PM, pundarik rajkhowa wrote:
I have a doubt regarding the content of webkit render tree dump. In this
dump, do we only print the HTML node information(body, div etc) or we print
the style information also(font-weight, text-decoration etc). From what I
have seen, it
This question is for webkit-help, not webkit-dev. See
http://webkit.org/contact.html for the purposes of the lists.
-- Darin
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
On Nov 18, 2009, at 12:40 AM, Gavin Barraclough wrote:
From http://lists.webkit.org/:
ListDescription
webkit-help [no description available]
Hmmm, yes, there would seem to be some scope to make that a little more
descriptive! ;-)
On Nov 18, 2009, at 10:03 AM, Alexey Proskuryakov wrote:
I actually prefer no comment after the namespace ending brace. If I have any
concerns about namespaces not being properly closed, I won't believe the
comment anyway, and will check by double-clicking on the closing brace to
select
On Oct 7, 2009, at 4:51 AM, kevin631012 wrote:
I installed Webkit on ubuntu 9.04 , then I run some plugins code in folder
WebKitExamplePlugins seems to be not working . those samples code are
developed on Mac , problems is I all develop my code on Linux . I am not
familiar with Mac .
On Nov 16, 2009, at 7:54 PM, Chris Jerdonek wrote:
First, it seems like the original motive was to avoid pointlessly indenting
nearly the whole file:
https://lists.webkit.org/pipermail/webkit-dev/2009-September/010002.html
So, I was wondering if we can clarify the rule to apply only to
On Nov 15, 2009, at 9:57 PM, Chris Jerdonek wrote:
In particular, the following file uses using namespace WTF::Unicode five
times, but within the bodies of various template definitions:
http://trac.webkit.org/browser/trunk/WebCore/platform/text/BidiResolver.h
(see line 304, for example)
On Nov 13, 2009, at 11:45 AM, Yong Li wrote:
There're 2 ways to fix this:
1. let StringImpl::create(UString...) create new copy if UString::data() is
not aligned to 4 bytes.
2. remove dependencies on 4-byte aligment of String::characters(), probably
just with #ifdef...
Which one
On Nov 11, 2009, at 6:56 PM, Chris Jerdonek wrote:
What is the current thinking on all of the using WTF::... statements at the
end of many header files in JSC? For example, what was the original reason
behind including those, and is there any chance that they will be taken out
at a later
Sorry, I should have been clearer the first time around. This
absolutely is a misuse of this list. The list is for discussion of
development of WebKit. It’s not to be used for reporting bugs. You can
file a bug report with this information and continue the discussion
there.
-- Darin
On Nov 10, 2009, at 7:41 PM, Chris Jerdonek wrote:
Hi, I have a question about the last of the WebKit Coding Style Guidelines:
http://webkit.org/coding/coding-style.html
It's the second of these two:
1. Any using namespace statements for a nested namespace whose parent
namespace is
On Nov 10, 2009, at 2:29 PM, Rick Gigger wrote:
I have noticed that Safari and Firefox seem to use different strategies for
caching static files. It seems that when I have the expiration headers set
properly that Firefox does not request them at all until they are expired but
Safari
On Nov 2, 2009, at 11:19 PM, Chris Evans wrote:
Whilst mining a large list of URLs, I came across some sites that render
incorrectly in WebKit but fine in IE.
It turns out there exist some sites which declare themselves standards
complaint in their HTML via their DTD. These sites then
On Nov 8, 2009, at 12:21 AM, Chris Jerdonek wrote:
I have a question regarding JSC's WTFNoncopyable::Noncopyable class and
argument-dependent lookup (ADL). It seems like an old decision may have been
unintentionally undone in changeset 46933.
I’m surprised that nothing depended on the
On Nov 6, 2009, at 10:49 AM, tonikitoo (Antonio Gomes) wrote:
Hi guys, I have a question about DRT and its current support to handling
error pages.
For a layout test I am working for a bug fix (see bug 30573), it would be
great if the DumpRenderTree supports a way to handle error pages.
WebKit doesn’t have any code for this. RSS-feed-related features are
part of individual WebKit-based browsers, not WebKit itself.
-- Darin
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
On Nov 2, 2009, at 1:56 PM, Yong Li wrote:
Why there are #if 0 here? First, I'm told #if 0 is not webkit style.
This code predates that rule.
Second, the disabled code seems useful.
Someone who wants to get the DOMAttrModified event working in WebKit
might start by enabling that code,
On Nov 1, 2009, at 4:23 PM, Karthick Jayaraman wrote:
I am not able to pin down the portions in the source code that add
attributes to the HTML element. I set breakpoint to the
Element::setAttribute functions, but I dont see the parser calling it.
I’m not sure this query belongs in the
On Oct 27, 2009, at 10:55 AM, Jens Alfke wrote:
Looking at how refcounting is implemented in WebCore, I was
surprised to find that there are a lot of functions/methods that
take PassRefPtrs as parameters instead of regular pointers to
those objects. I can't see any benefit to this, and it
On Oct 29, 2009, at 12:57 PM, Drew Wilson wrote:
HTMLCollection() keeps a reference to the object, so you can't
safely pass in just a raw pointer.
Good point, but strictly speaking that’s not true.
It’s always safe to pass a raw pointer. The PassRefPtr type for the
argument is solely
Has there been any discussion of or feedback about the web timing
proposal?
Would WebKit’s implementation of this be the first one?
Is someone planning on building a benchmark that uses this new feature
to evaluate browser speed?
-- Darin
On Oct 29, 2009, at 2:30 PM, Jens Alfke wrote:
Is there any reason this couldn't be optimized to use a HashMap
Memory consumption is much greater.
or at least binary search?
Would make lookups faster but parsing slower.
(I thought the answer might be that the order of attributes is
On Oct 29, 2009, at 2:32 PM, Darin Adler wrote:
On Oct 29, 2009, at 2:30 PM, Jens Alfke wrote:
Is there any reason this couldn't be optimized to use a HashMap
Memory consumption is much greater.
or at least binary search?
Would make lookups faster but parsing slower.
I forgot
On Oct 29, 2009, at 7:17 AM, zheng shiju wrote:
I have port qt4.5 and webkit to an embedded linux board, and I edit
qt and webkit source codes,
and I develop a TV look-feel application and based on the edit qt4.5
and webkit , it is commercial.
so ,I must let my application following LGPL?
On Oct 12, 2009, at 9:30 AM, mab2001 wrote:
It seems that with WebKit, the contents of the noscript tag cannot
be accessed through the DOM. FF and IE (haven't tested other
browsers) allow access through the textContent property but in
Safari and Chrome this just comes back blank.
I think
On Oct 23, 2009, at 6:27 AM, Alexander Cohen wrote:
I've been looking into having WebCore support another scripting
language other than Javascript. By going through the code, it seems
pretty doable. Then i got to inline scripts on event handlers and
that's where it became a bit more
On Oct 22, 2009, at 7:01 AM, Buakaw San wrote:
This tip should be on the build wiki page.
Sounds good. Did you know that because it’s a wiki page, anyone can
edit it? That includes you. Would you be willing to add it?
-- Darin
___
On Oct 21, 2009, at 2:17 AM, Shinichiro Hamaji wrote:
However, there are some cases in which people forgot to add test
files.
Thanks for tackling this!
- fast/dynamic/8952-reduction
author: darin
trac: http://trac.webkit.org/changeset/15459
comment: now the png file is in platform/mac
In
On Oct 20, 2009, at 1:25 PM, Michelangelo De Simone wrote:
I need to understand whether or not I am supposed to provide a
blind implementation for every available port in the trunk, even
if this means a potential port specific break.
Yes, that’s what I usually do.
-- Darin
On Oct 20, 2009, at 10:15 AM, Mark Mentovai wrote:
Would these libraries with private extern symbols be unsuitable for
Apple's WebKit build?
Probably not. But even though this is easy it could be a long time
until someone gets the free time to make and test this simple change.
I was
On Oct 18, 2009, at 4:14 PM, Erik Arvidsson wrote:
I wrote a simple tool that allows me to quickly look up the WebKit
build number based on an SVN revision number.
http://webkit-util.appspot.com/rev/
http://webkit-util.appspot.com/rev/45980
I wrote this mainly so I could figure out what
On Oct 14, 2009, at 2:44 PM, tali garsiel wrote:
The CSS parser products are CSSStyleSheets objects which contain
CSS rule lists - right?.
Yes.
If I understand correctly the render style gets created in the
process of creating the render tree.
The flow is:
Node::attach()
On Oct 13, 2009, at 10:50 AM, Adam Barth wrote:
* MainResourceLoader. MainResourceLoader inherits from
ResourceLoader and receive callbacks from the network stack. It's
primary task is to take callbacks from the network stack and route
them to the appropriate higher-level APIs. Currently,
On Oct 13, 2009, at 2:10 PM, Adam Barth wrote:
The word policy is very overloaded here. For example, the third-
party cookie blocking logic used to speak about policy URLs.
I may have overused the term “policy” in my mail. I think that
generally speaking, the things that ought to be called
On Oct 9, 2009, at 1:55 AM, Jickae Davis wrote:
Well, I checked the WebView.h, and didn't find the estimatedProgress
method
http://trac.webkit.org/browser/trunk/WebKit/mac/WebView/WebView.h
76 extern NSString *WebViewProgressStartedNotification;
77 extern NSString
On Oct 5, 2009, at 12:23 PM, Eric Seidel wrote:
I would like us to consider disabling the requestee field for the
review flag.
Yes, I think we should do it.
-- Darin
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
On Oct 1, 2009, at 11:58 AM, Eric Seidel wrote:
I think more you're identifying that there is a test hierarchy
problem here. Chromium really wants to base its tests off of some
base win implementation, and then win-apple, win-chromium,
win-cairo results could derive from that, similar to
Some leak checkers are based on all objects being deleted at shutdown.
Those won’t work with WebKit. It doesn’t delete all objects at shutdown.
Other leak checkers are based on finding unreachable objects. Those
work well with WebKit.
-- Darin
It seems that the commit queue clears the review flag on each patch as
it lands it. I can see how this could be useful for the cases of one
bug with a lot of patches, but for the usual case of one bug one
patch, it seems non-helpful. I find it confusing to look back at such
bugs and see
On Sep 11, 2009, at 2:57 AM, TAMURA, Kent wrote:
What's the encoding of ChangeLog files?
UTF-8.
Originally they were ASCII but we started allowing UTF-8 as a courtesy
for people whose names required non-ASCII characters. We try to avoid
using non-ASCII characters in change log entries,
On Sep 11, 2009, at 10:59 AM, Eric Seidel wrote:
However you'll still get an email about commit-queue being canceled
when it removes commit-queue+.
I’m not currently getting mail about changes to the status of commit-
queue flags from the webkit-reviews mailing list, so I don’t think I
On Sep 10, 2009, at 9:04 AM, Kent Hansen wrote:
JavaScriptCore uses some compile-time defines to decide which flags
to pass to vm_map() and mmap(), depending on the Mac OS version.
Now, if WebKit is built and run on the same version, that's
obviously fine, but we've found that if we build
On Sep 8, 2009, at 8:00 AM, Avi Drissman wrote:
I thought WebCore had moved away from using Cocoa for scrolling.
No, it has not.
-- Darin
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
On Sep 3, 2009, at 1:03 PM, Gavin Barraclough wrote:
I believe the C spec requires that files end in a newline, though I
couldn't comment on the C++ spec. Possibly redundant to list this
as WebKit style issue, if required by the language?
This is possibly not relevant to the discussion,
Looks good to me.
On Sep 3, 2009, at 8:43 AM, David Levin wrote:
There should only be a single space before end of line comments. An
exception is if one is lining up several end of line comments.
I don’t think we should have this exception.
Things manually lined up in source code generally
701 - 800 of 1086 matches
Mail list logo
