Re: [webkit-dev] use binary webkit

2011-10-23 Thread Eric Seidel
This is the wrong list for this question. webkit-help is a better choice for these topics. There is no free-to-distribute version of WebKit for windows to my knowledge. Apple's windows version (the DLLs from the nightly) requires non-redistributable libraries from Apple. Making it il-suited

Re: [webkit-dev] NRWT Migration Update

2011-10-21 Thread Eric Seidel
to switch is Apple's Windows. (I likely won't be able to takle that one myself.) Thanks again for your patience in this process. -eric On Thu, Oct 20, 2011 at 9:54 PM, Eric Seidel e...@webkit.org wrote: After further testing tonight, I was able to reproduce the exact set of 81 WebKit 2

Re: [webkit-dev] NRWT Migration Update

2011-10-21 Thread Eric Seidel
, Eric Seidel e...@webkit.org wrote: After a long hiatus, I'm back working on NRWT. As of this evening all of the blocking issues to switching the WK2 bot are resolved: https://bugs.webkit.org/show_bug.cgi?id=56729 Just waiting for the WK2 bot to have some smaller number of failures, then I'll

Re: [webkit-dev] [chromium] make build for chromium/mac (build twice as fast!) clang for chromium/linux

2011-10-21 Thread Eric Seidel
On Fri, Oct 21, 2011 at 1:37 PM, Nico Weber tha...@chromium.org wrote: build-webkit will then use make instead of xcodebuild, and new-run-webkit-tests will use the make-produced binary. On my machine, this reduced full build times from 17 minutes to 12 minutes (50% of the original gcc

Re: [webkit-dev] NRWT Migration Update

2011-10-20 Thread Eric Seidel
After further testing tonight, I was able to reproduce the exact set of 81 WebKit 2 failures with both NRWT and ORWT this evening. I'm going to move the bots to NRWT shortly. -eric On Wed, Oct 19, 2011 at 9:59 PM, Eric Seidel e...@webkit.org wrote: After a long hiatus, I'm back working on NRWT

[webkit-dev] NRWT Migration Update

2011-10-19 Thread Eric Seidel
After a long hiatus, I'm back working on NRWT. As of this evening all of the blocking issues to switching the WK2 bot are resolved: https://bugs.webkit.org/show_bug.cgi?id=56729 Just waiting for the WK2 bot to have some smaller number of failures, then I'll pull the trigger. After WK2 is

Re: [webkit-dev] Style bot failing and spewing failure into each bug

2011-10-17 Thread Eric Seidel
Adam is sitting on a committee today, but can boot the bot as soon as he's out. -eric On Mon, Oct 17, 2011 at 4:01 PM, Ryosuke Niwa rn...@webkit.org wrote: I think abarth or eseidel need to kick the bot. - Ryosuke On Mon, Oct 17, 2011 at 3:51 PM, Darin Adler da...@apple.com wrote: Hi

Re: [webkit-dev] layout tests cannot set Generic RGB Color Profile on headless MacPro?

2011-10-07 Thread Eric Seidel
At least as of Snow Leopard, it was impossible to run the layout tests, without a login-session/security context. You would need to be physically logged into the machine, and then run the tests from VNC/Remote Desktop for them to work. In snow leopard SSHing to a machine (without being

Re: [webkit-dev] Please use platform prefixes in bug titles

2011-10-05 Thread Eric Seidel
That sounds very related to which features are enabled on which ports. A per-directory map is probably easier to produce of course. We have no good way to get any of this information out of our myriad build and branch strategies employed by the numerous ports. :) I too am in favor of [port]

Re: [webkit-dev] Change to style guideline: should use type instead of type* for out arguments

2011-10-04 Thread Eric Seidel
Interesting. I thought historical policy was universally against the word get in function names. I guess you're suggesting that get should only be applied to function names which have an out-argument? -eric On Tue, Oct 4, 2011 at 6:00 PM, Darin Adler da...@apple.com wrote: On Oct 4, 2011, at

Re: [webkit-dev] Facing problem in running html-parser.html

2011-09-30 Thread Eric Seidel
Every file:// url has a unique security origin in Chrome. So the test only works in Safari. Try using Tools/Scripts/run-safari. -eric On Fri, Sep 30, 2011 at 1:13 AM, Monil Parmar monil.par...@gmail.com wrote: Hi, Iam trying to run the parser performance test on webkit through

Re: [webkit-dev] It's time to remove the Haiku port

2011-09-25 Thread Eric Seidel
On Sun, Sep 25, 2011 at 9:12 AM, Ryosuke Niwa rn...@webkit.org wrote: On Sun, Sep 25, 2011 at 2:30 AM, Adam Barth aba...@webkit.org wrote: Yeah, I'm not sure where we should draw the line, but this case seems pretty clearly in the unmaintained camp, as was the old Android port.  Maybe a good

Re: [webkit-dev] Starting implementation on W3C Filter Effects

2011-09-22 Thread Eric Seidel
I was actually considering removing ENABLE(FILTERS) since it seemed to be on everywhere. It would probably be better for us to remove it first and this feature to exist under its own define (if it even needs a define?). If you'll want folks to be able to turn this off w/o affecting their

Re: [webkit-dev] Starting implementation on W3C Filter Effects

2011-09-22 Thread Eric Seidel
On Thu, Sep 22, 2011 at 11:44 AM, Dean Jackson d...@apple.com wrote: On 23/09/2011, at 4:38 AM, Eric Seidel wrote: I was actually considering removing ENABLE(FILTERS) since it seemed to be on everywhere. Sorry to bring bad news, but Apple currently turns off ENABLE(FILTERS) on desktop

Re: [webkit-dev] Starting implementation on W3C Filter Effects

2011-09-22 Thread Eric Seidel
Interesting. It is unfortunate that we currently have no easy way to tell which ports are shipping with which defines enabled. I didn't think to check the settings on the branch. Thank you for the clarification. -eric On Thu, Sep 22, 2011 at 1:06 PM, Darin Adler da...@apple.com wrote: The

Re: [webkit-dev] Do you compile with ENABLE_SVG diabled?

2011-09-13 Thread Eric Seidel
: [webkit-dev] Do you compile with ENABLE_SVG diabled? When doing ports to various embedded systems we often disable SVG to reduce the size of the resulting library.  It would be nice to retain the top level ENABLE_SVG define for this purpose. Thanks, Dan On 09/09/2011 05:42 PM, Eric Seidel

Re: [webkit-dev] Do you compile with ENABLE_SVG diabled?

2011-09-13 Thread Eric Seidel
Folks can track the general task of feature removal at: https://bugs.webkit.org/show_bug.cgi?id=68012 I will link all the Remove ENABLE_* bugs to that one. -eric On Tue, Sep 13, 2011 at 11:20 AM, Eric Seidel e...@webkit.org wrote: Hearing no objections to removing any of the sub-defines, I

Re: [webkit-dev] Do you maintain OS(WINCE)?

2011-09-13 Thread Eric Seidel
I also noticed that WINCE looks abandoned in my work on bug 68018 this morning. -eric On Tue, Sep 13, 2011 at 12:00 PM, Antonio Gomes toniki...@gmail.com wrote: I believe it was maintained by Torch Mobile, and, according to George Staikos, it is not part of the plans any more (Torch was

Re: [webkit-dev] Do you maintain OS(WINCE)?

2011-09-13 Thread Eric Seidel
On Tue, Sep 13, 2011 at 2:38 PM, Patrick Gansterer par...@paroga.com wrote: How do we measure an active port??? I maintain a buildbot for WinCe and usually fix problems with the port within hours. Unfortunately I don't get paid to work on WebKit the whole day and so I can't make such big

Re: [webkit-dev] run-bindings-tests

2011-09-09 Thread Eric Seidel
On Thu, Sep 8, 2011 at 12:44 PM, Darin Adler da...@apple.com wrote: On Sep 8, 2011, at 12:29 PM, Eric Seidel wrote: I'm happy to write a run-all-tests script which runs all known tests that platform can handle. :) I think run-webkit-tests should be this. We can come up with a new name

[webkit-dev] Do you compile with ENABLE_SVG diabled?

2011-09-09 Thread Eric Seidel
I am interested in removing the ENABLE_SVG define, and all associated sub-defines ENABLE_SVG_ANIMATION ENABLE_SVG_AS_IMAGE ENABLE_SVG_FONTS ENABLE_SVG_FOREIGN_OBJECT ENABLE_SVG_USE SVG is part of HTML5, and all major ports compile and ship with SVG enabled (and have for years). Please let me

Re: [webkit-dev] make-script-test-wrappers not being maintained

2011-09-08 Thread Eric Seidel
We could also teach DumpRenderTree to lie about what / is, so we could include the scripts like this: script href=/fast/js/resources/js-test-pre.js On Thu, Sep 8, 2011 at 1:14 AM, Adam Barth aba...@webkit.org wrote: On Thu, Sep 8, 2011 at 12:41 AM, Maciej Stachowiak m...@apple.com wrote: Do

Re: [webkit-dev] make-script-test-wrappers not being maintained

2011-09-08 Thread Eric Seidel
It seems the sucessfullyParsed question could also be answered by some intelligent onerror handler added to the right script tag. On Thu, Sep 8, 2011 at 10:16 AM, Ryosuke Niwa rn...@webkit.org wrote: Yeah, if the script is located at LayoutTests/resources/js-test.js for example, all I need to

[webkit-dev] run-bindings-tests

2011-09-08 Thread Eric Seidel
FYI: As many of you already know, the build.webkit.org bots run run-bindings-tests on (almost) all platforms. They've been running (mostly w/o incident) on the bots since 6/20: http://trac.webkit.org/changeset/89267 These just make sure that our generated bindings look sane, by comparing the

Re: [webkit-dev] run-bindings-tests

2011-09-08 Thread Eric Seidel
, was at one point at least one happy customer of this script: https://bugs.webkit.org/show_bug.cgi?id=62880#c5 -eric On Thu, Sep 8, 2011 at 11:49 AM, Alexey Proskuryakov a...@webkit.org wrote: 08.09.2011, в 11:32, Eric Seidel написал(а): FYI:  As many of you already know, the build.webkit.org

Re: [webkit-dev] run-bindings-tests

2011-09-08 Thread Eric Seidel
If the objection against run-bindings-tests is that they're not part of some larger test script which developers can run locally, it's very easy to add a wrapper script which runs all known testing harnesses. The test tests which currently run on the bots include: run-webkit-tests (minutes)

[webkit-dev] Code Search for webkit.org

2011-09-08 Thread Eric Seidel
I'm curious how other developers search the WebKit code? I use http://codesearch.google.com/#search/q=package:webkit from time to time. If others do too, we should make it a redirect from cs.webkit.org (like we do for cia.webkit.org). Or maybe folks have better code search solutions? grep -r?

Re: [webkit-dev] WebKit and Android

2011-08-22 Thread Eric Seidel
Exciting times! Is there a Master bug that those of us interested in following along at home can CC ourselves on? Looking forward to seeing a real Android port in WebKit! -eric On Mon, Aug 22, 2011 at 12:25 PM, Andrei Popescu andr...@google.com wrote: Hello WebKit! We would like to give an

Re: [webkit-dev] Chromium Mac moving to Skia

2011-08-16 Thread Eric Seidel
I suggest you pain the bikeshed MAC_CG instead of MACCG. The brains our children's children will thank me. -eric On Tue, Aug 16, 2011 at 11:31 AM, Adam Barth aba...@webkit.org wrote: Hi WebKit, In an effort to make the Chromium port more consistent across platforms, we're moving the

[webkit-dev] Snow Leopard Leaks Bot out of Disk Space

2011-08-08 Thread Eric Seidel
http://build.webkit.org/builders/SnowLeopard%20Intel%20Leaks/builds/18482/steps/layout-test/logs/stdio 2011-08-08 16:03:36,710 67413 manager.py:1403 ERROR worker/0 raised OSError('[Errno 28] No space left on device: '/var/folders/dR/dRbf9KVoHs0rNZjRONbHTU+++TI/-Tmp-/DumpRenderTree-CL_oFh''):

Re: [webkit-dev] Snow Leopard Leaks Bot out of Disk Space

2011-08-08 Thread Eric Seidel
you for your help. -eric On Mon, Aug 8, 2011 at 6:09 PM, Mark Rowe mr...@apple.com wrote: On 2011-08-08, at 17:16, Eric Seidel wrote: http://build.webkit.org/builders/SnowLeopard%20Intel%20Leaks/builds/18482/steps/layout-test/logs/stdio 2011-08-08 16:03:36,710 67413 manager.py:1403 ERROR

Re: [webkit-dev] LayoutTests results fallback graph

2011-07-13 Thread Eric Seidel
I believe what Adam means by this (it wasn't immediately clear to me), is that we have 1500 redundant result files with duplicate git hashes to some other file. This could be calculated by the deduplicate_results.py script by removing any of the current fallback logic and just look at raw

Re: [webkit-dev] msys support/WinCE support

2011-07-12 Thread Eric Seidel
Thank you. Will do. On Mon, Jul 11, 2011 at 11:10 PM, Patrick Gansterer par...@paroga.com wrote: On Mon, 11 Jul 2011 21:30:44 -0700, Brent Fulgham bfulg...@gmail.com wrote: Is the WinCE port still active? I don't know about your other questions, but Patrick Gansterer (paroga) maintains the

[webkit-dev] msys support/WinCE support

2011-07-11 Thread Eric Seidel
There is code in old-run-webkit-tests attempting to support msys configurations. (Which appears to be used by the WinCE port?) Is this an active configuration? Or can we remove msys support when transitioning to new-run-webkit-tests. Is the WinCE port still active? -eric

[webkit-dev] PSA: Removing support for Apache 1.3 in WebKit

2011-07-11 Thread Eric Seidel
As part of fixing https://bugs.webkit.org/show_bug.cgi?id=64086 I found that only the CYGWIN port still uses Apache 1.3. However, it has its own special httpd.conf file to do so. Now that Tiger is removed (and all known linux ports have moved to Apache 2), LayoutTests/httpd/conf/http.conf no

Re: [webkit-dev] Switching to new-run-webkit-tests

2011-07-07 Thread Eric Seidel
. :) In other news, Qt, Gtk, Leopard and Snow Leopard all seem to be using NRWT successfully. We've had very few reports of trouble over the last 24 hours. I'm working on the last few details for WebKit2 and plan to enable NRWT on the WebKit2 bots tomorrow. -eric On Wed, Jul 6, 2011 at 2:10 AM, Eric Seidel

Re: [webkit-dev] Best practices for failing a flaky tests (was Re: Switching to new-run-webkit-tests)

2011-07-07 Thread Eric Seidel
I do not know the history as to why Chromium removed support for test_expectations cascading. Ideally we would have fewer test expectations, not more in the future. :) On Thu, Jul 7, 2011 at 3:16 AM, Balazs Kelemen kbal...@webkit.org wrote: On 07/06/2011 07:24 PM, Eric Seidel wrote: On Wed

Re: [webkit-dev] Switching to new-run-webkit-tests

2011-07-06 Thread Eric Seidel
the bots are running in very very slow mode (about as fast as ORWT was). We'll turn on parallel testing with new-run-webkit-tests once we've transitioned all ports. On Tue, Jul 5, 2011 at 10:53 PM, Eric Seidel e...@webkit.org wrote: Update: Snow Leopard - Successful transition. Leopard - Had to roll

Re: [webkit-dev] Switching to new-run-webkit-tests

2011-07-06 Thread Eric Seidel
at 2:20 AM, Xan xan.lo...@gmail.com wrote: On Wed, Jul 6, 2011 at 11:10 AM, Eric Seidel e...@webkit.org wrote: Update: Leopard Release, Gtk and Qt have been successfully transitioned. What do we exactly consider successfully transitioned? The GTK+ bots were still failing, so I reverted

Re: [webkit-dev] Switching to new-run-webkit-tests

2011-07-06 Thread Eric Seidel
Xan and I found the issue regarding the timeouts, and Xan is trying NRWT again on the machine: https://bugs.webkit.org/show_bug.cgi?id=63983 On Wed, Jul 6, 2011 at 2:20 AM, Xan xan.lo...@gmail.com wrote: On Wed, Jul 6, 2011 at 11:10 AM, Eric Seidel e...@webkit.org wrote: Update: Leopard

Re: [webkit-dev] Using Skipped vs. test_expectations.txt, WAS Switching to new-run-webkit-tests

2011-07-06 Thread Eric Seidel
We've intentionally left that decision up to the ports. Mac has a stop-gap test_expectations.txt file, which depending on the result of this discussion will likely be expanded, or removed: http://trac.webkit.org/browser/trunk/LayoutTests/platform/mac/test_expectations.txt That exists solely to

Re: [webkit-dev] Using Skipped vs. test_expectations.txt, WAS Switching to new-run-webkit-tests

2011-07-06 Thread Eric Seidel
Nm, Adam Barth already split the thread in a nicer name too. Folks can reply there. :) On Wed, Jul 6, 2011 at 9:12 AM, Eric Seidel e...@webkit.org wrote: We've intentionally left that decision up to the ports. Mac has a stop-gap test_expectations.txt file, which depending on the result

Re: [webkit-dev] Best practices for failing a flaky tests (was Re: Switching to new-run-webkit-tests)

2011-07-06 Thread Eric Seidel
On Wed, Jul 6, 2011 at 10:18 AM, Xan Lopez x...@gnome.org wrote: On Wed, Jul 6, 2011 at 6:29 PM, Eric Seidel e...@webkit.org wrote: NRWT uses both!  It will read in all the port's Skipped files, covert them to SKIP text_expectations, and add them to your test_expectations file. http

[webkit-dev] Is there special setup needed to run the WebKit2 tests?

2011-07-06 Thread Eric Seidel
old-run-webkit-tests -2 --debug produces: 107 test cases (1%) had incorrect layout 1 test case (1%) crashed 8 test cases (1%) Web process crashed 24 test cases (1%) had stderr output new-run-webkit-tests -2 --debug (which is what I'm trying to make work better) produces: Regressions: Unexpected

Re: [webkit-dev] Switching to new-run-webkit-tests

2011-07-05 Thread Eric Seidel
as possible. Thanks for your patience. Adam On Mon, Jun 27, 2011 at 4:26 PM, Xan Lopez x...@gnome.org wrote: On Tue, Jun 28, 2011 at 1:17 AM, Eric Seidel e...@webkit.org wrote: There appear to be 6 remaining blocking issues: https://bugs.webkit.org/showdependencytree.cgi?id=34984hide_resolved=1

Re: [webkit-dev] Switching to new-run-webkit-tests

2011-07-05 Thread Eric Seidel
patience in this process. Please let me know if you see any issues you think we may have missed. We're still watching the bots and fixing issues as they appear. -eric On Tue, Jul 5, 2011 at 4:03 PM, Eric Seidel e...@webkit.org wrote: We've turned NRWT back on for the WebKit1 Snow Leopard bots

Re: [webkit-dev] Does NRWT let you indicate that a test should fail with a particular failure diff?

2011-07-01 Thread Eric Seidel
I like the idea of -failing. But what happens when you have both -failing and -expected in the same directory? Are either accepted? (in which case it's like a file-system version of test-expetations flaky lists) On Fri, Jul 1, 2011 at 12:49 PM, Ojan Vafai o...@chromium.org wrote: I proposed a

Re: [webkit-dev] Does NRWT let you indicate that a test should fail with a particular failure diff?

2011-07-01 Thread Eric Seidel
could chose not to use -failure files if it didn't want to. -- Dirk On Fri, Jul 1, 2011 at 12:56 PM, Eric Seidel e...@webkit.org wrote: I like the idea of -failing.  But what happens when you have both -failing and -expected in the same directory?  Are either accepted? (in which case

Re: [webkit-dev] Writing a new XML parser with no external libraries

2011-06-28 Thread Eric Seidel
Correct. We convert from UTF16 to UTF8 (for libxml2) and then back to UTF16. There has been at least one libxml-related security fix to WebCore in recent memory. We have various hacks in the libxml2 parser due to libxml2 being designed to be a library used by applications, and not used by a

Re: [webkit-dev] Writing a new XML parser with no external libraries

2011-06-28 Thread Eric Seidel
That was done, long ago. You can find the old patches in our svn history. :) On Tue, Jun 28, 2011 at 6:44 PM, Wyatt Carss wca...@google.com wrote: If that were all, would it be possible to patch libxml2 to use UTF-16? That might be less of an undertaking than writing a new xml library, but

[webkit-dev] Switching to new-run-webkit-tests

2011-06-27 Thread Eric Seidel
Looking at the master bug, it looks like we're close to switching the project to new-run-webkit-tests: https://bugs.webkit.org/show_bug.cgi?id=34984 There appear to be 6 remaining blocking issues: https://bugs.webkit.org/showdependencytree.cgi?id=34984hide_resolved=1 We would like to hear from

Re: [webkit-dev] Switching away from integers for layout

2011-06-23 Thread Eric Seidel
I know you made some consideration of fixed point vs. float point in your investigation. I suspect that decision is orthogonal to work of plumbing more precise types through the engine... but I am still curious to know if there was a decision if fixed point or float point might be the eventual

Re: [webkit-dev] Extra review requirement for web-facing API? (Was: Re: Spellcheck API for WebKit)

2011-06-22 Thread Eric Seidel
I think it's better for our reviewers to review only things they're comfortable with. We could also teach bots (like the style-bot) to complain when seeing new API. I'd rather not add another layer of process. -eric On Wed, Jun 22, 2011 at 11:31 AM, Ryosuke Niwa rn...@webkit.org wrote: On

Re: [webkit-dev] How to integrate HbbTV with WebKit

2011-06-20 Thread Eric Seidel
Please do not cross-post. A cursory internet search shows HbbTV has little to do with WebKit. What spec covers HbbTV? What other browsers implement such? Your mail does not seem appropriate for this list. -eric On Sun, Jun 19, 2011 at 10:26 PM, Vicky Tux sssein...@gmail.com wrote: Hi, We

Re: [webkit-dev] DOM tree vs. Render tree

2011-06-20 Thread Eric Seidel
I'm not sure this will help you Song, but here is a talk I gave a couple years back which talks some about the DOM vs. Rendering tree separation: http://www.youtube.com/watch?v=RVnARGhhs9w Best of luck in your exploration. -eric On Thu, Jun 16, 2011 at 4:34 PM, Darin Adler da...@apple.com

Re: [webkit-dev] 194 bugs in pending-commit

2011-06-20 Thread Eric Seidel
In general it's pretty safe to cq+ a patch, especially an old one. Since the cq + EWS tests patches better than just about any committer ever does manually. :) We built infrastructure to have the sherriff-bot auto-rollout patches which caused any tree redness. If folks want, we could turn that

Re: [webkit-dev] review flags (was bugs in pending-commit)

2011-06-19 Thread Eric Seidel
On Sun, Jun 19, 2011 at 11:31 AM, Darin Adler da...@apple.com wrote: On Jun 18, 2011, at 9:01 PM, Antonio Gomes wrote: I actually do not like the way the review flags are cleared today only in order to make the tools and pending-xxx pages happier. IMO the review flags give much about the

Re: [webkit-dev] review flags (was bugs in pending-commit)

2011-06-19 Thread Eric Seidel
it also be helpful when sheriff bot rolls out a patch to attach the rolled out patch with a nice description like ROLLOUT(rX) to the bug? On Sun, Jun 19, 2011 at 8:36 PM, Eric Seidel e...@webkit.org wrote: On Sun, Jun 19, 2011 at 11:31 AM, Darin Adler da...@apple.com wrote: On Jun 18, 2011

Re: [webkit-dev] 105 bugs in pending-commit

2011-06-18 Thread Eric Seidel
I'm running clean-pending-commit and clean-review-queue now. Adam and I will make sure to set up a bot to run both next week. -eric On Sat, Jun 18, 2011 at 1:03 PM, Darin Adler da...@apple.com wrote: On Jun 17, 2011, at 10:56 PM, Adam Barth wrote: There are a 194 open bugs with an R+ patches

Re: [webkit-dev] Are roll-outs getting a little out of hand?

2011-06-18 Thread Eric Seidel
On Sat, Jun 18, 2011 at 1:15 PM, Darin Adler da...@apple.com wrote: On Jun 18, 2011, at 12:58 PM, Oliver Hunt wrote: On Jun 18, 2011, at 12:24 PM, Darin Adler wrote: http://trac.webkit.org/changeset/89190 Looks like Ossy did look at this one; it was not a Qt issue at all, broken on all

Re: [webkit-dev] 105 bugs in pending-commit

2011-06-18 Thread Eric Seidel
). -eric On Sat, Jun 18, 2011 at 1:12 PM, Eric Seidel e...@webkit.org wrote: I'm running clean-pending-commit and clean-review-queue now.  Adam and I will make sure to set up a bot to run both next week. -eric On Sat, Jun 18, 2011 at 1:03 PM, Darin Adler da...@apple.com wrote: On Jun 17, 2011

Re: [webkit-dev] 194 bugs in pending-commit

2011-06-18 Thread Eric Seidel
webkit-patch upload clears all flags when obsoleting a patch. We could make it not clear r- if you like. I know of no way to construct a query like http://webkit.org/pending-commit in our current bugzilla without clearing r+ on obsolete patches/closed bugs. We clear flags (specifically r+) to

Re: [webkit-dev] Adding ENABLE_BATTERY_STATUS to WebCore

2011-06-17 Thread Eric Seidel
My 2¢: I'm confused by who the client of this API would be. It seems that web sites don't really need to know my battery state. But web applications that are on mobile phone (like WebOS, or Apple's original vision for iPhone apps) would want battery state information, but would want *more*

Re: [webkit-dev] Adding ENABLE_BATTERY_STATUS to WebCore

2011-06-17 Thread Eric Seidel
at a lower frequency.  Crazy idea: Maybe an advertising network could be nice and not show animated ads to such users? ;-) -Darin On Fri, Jun 17, 2011 at 10:47 AM, Eric Seidel e...@webkit.org wrote: My 2¢: I'm confused by who the client of this API would be. It seems that web sites don't

Re: [webkit-dev] Feeling stuck on preparing next patches for CSSRegions/CSSExclusions

2011-06-17 Thread Eric Seidel
You should also feel welcome to land test suites which entirely/mostly fail, and then later land the code changes which make them pass. We used this method with great success for the HTML parser re-write. This can be useful in cases where your individual tests have larger coverage than any

Re: [webkit-dev] bugs.webkit.org UI housekeeping

2011-06-13 Thread Eric Seidel
Speaking of the review patch link. I really want a way to CC people from there... I don't think that's easy to do, since it uses the details view to actually do the submit, but it would be nice to have. :) On Mon, Jun 13, 2011 at 1:19 PM, Adam Barth aba...@webkit.org wrote: On Mon, Jun 13,

Re: [webkit-dev] bugs.webkit.org UI housekeeping

2011-06-12 Thread Eric Seidel
I would go so far as to suggest removing both Diff and Formatted Diff. I guess I'm more excited about removing Formatted Diff than I am Diff, since Diff actually has some built in bugzilla crazy features (like diffing between attachments!?!) but Formatted Dfif is just a lame version of Review

Re: [webkit-dev] DumpRenderTree for the EFL port :)

2011-06-10 Thread Eric Seidel
This is *so* importnat to the long-term health of your port. Congrats! I'm happy to review what I can and will look through them now. -eric On Fri, Jun 10, 2011 at 12:02 PM, Leandro Pereira lean...@profusion.mobi wrote: Hey, At last, the EFL port of WebKit got a DumpRenderTree

Re: [webkit-dev] DumpRenderTree for the EFL port :)

2011-06-10 Thread Eric Seidel
, mostly due to the lack of smart pointers. I'm ready to r+ the patches re-posted with some modern c++ usage. I'm also OK with someone else approving them if EFL style requires this ancient-C (and bad memory-management) look. -eric On Fri, Jun 10, 2011 at 12:10 PM, Eric Seidel e...@webkit.org

Re: [webkit-dev] Parallel CSS styling

2011-06-08 Thread Eric Seidel
Re-sending w/o the attached file. On Wed, Jun 8, 2011 at 3:31 PM, Eric Seidel e...@webkit.org wrote: I used Safari's built-in Page Load Test mechanism to test the page. I created a flickr.pltsuite and placed it in /Applications/Safari.app/Contents/Resources/flickr.pltsuite with the contents

Re: [webkit-dev] Parallel CSS styling

2011-06-08 Thread Eric Seidel
interested in making things faster! Again, best of luck with your efforts. At this time WebKit does not believe that parallel CSS styling would yield any noticeable performance increase on standard page loads. -eric On Wed, Jun 8, 2011 at 3:31 PM, Eric Seidel e...@webkit.org wrote: I used Safari's

Re: [webkit-dev] Parallel CSS styling

2011-06-07 Thread Eric Seidel
You noted it spends 66% of its CSS time in StyleForElement. What about total page load time? Then again 6450ms spent in CSS sounds like a lot of time regardless. Answering what % of total page load time we're spending in CSS (or StyleForElement) is important. Loading

Re: [webkit-dev] CSS optional property names

2011-06-06 Thread Eric Seidel
I think our .in files get pre-processed. So you can use normal c++ preprocessor definitions. #if defined(ENABLE_CSS_REGIONS) ENABLE_CSS_REGIONS But I could be remembering wrong... On Mon, Jun 6, 2011 at 4:25 AM, Alexandru Chiculita ach...@adobe.com wrote: Hi, Until we have working CSS

Re: [webkit-dev] WebKit port to my own system?!

2011-06-06 Thread Eric Seidel
No, there is no stock or template port of webkit. Chromium might be the closest thing to such with it's PlatformBridge abstraction (since webkit runs inside a restricted sandbox in chromium and can't talk always directly to the OS). But you're better off starting with whatever port is closest to

Re: [webkit-dev] WebKit port to my own system?!

2011-06-06 Thread Eric Seidel
...@uwindsor.ca From: Eric Seidel e...@webkit.org To: Soheil Servati Beiragh sserv...@yahoo.com Cc: webkit-dev@lists.webkit.org webkit-dev@lists.webkit.org Sent: Monday, June 6, 2011 2:21 PM Subject: Re: [webkit-dev] WebKit port to my own system

Re: [webkit-dev] Parallel CSS styling

2011-06-06 Thread Eric Seidel
Do you have statistics on how much total time rendering flickr.com is in CSS/Style code at all? I believe it to be very low. -eric On Mon, Jun 6, 2011 at 1:16 PM, Kulanthaivel Palanichamy kulanthai...@codeaurora.org wrote: Hi All, At Qualcomm Innovation Center we have been working on a

[webkit-dev] Proposal: Avoiding fastMalloc(0) in WebKit

2011-06-06 Thread Eric Seidel
I have posted a patch to (optionally) ASSERT whenever fastMalloc is called with 0 size: https://bugs.webkit.org/show_bug.cgi?id=55097 After fixing https://bugs.webkit.org/show_bug.cgi?id=55091 for a large performance win in the HTML parser (by avoiding a single fastMalloc(0) call) I now believe

Re: [webkit-dev] Cross-platform fonts for Layout Tests

2011-06-06 Thread Eric Seidel
: Actually, even the same Ahem font will be rendered differently on different platform, depending on the font drawing library, the anti-aliasing algorithm, subpixel, tiny float-point calculation diff on different arch. On Thu, Jun 2, 2011 at 3:30 AM, Eric Seidel e...@webkit.org wrote: I know

Re: [webkit-dev] Pages from the wiki vanished from google search results

2011-06-05 Thread Eric Seidel
Bill would have access to any logs there may be. On Sun, Jun 5, 2011 at 7:20 PM, Matt Falkenhagen fal...@chromium.org wrote: Since a couple of days ago (when?), our trac/wiki is not appearing as relevant on google search results anymore. I guess google blacklisted the site because of some

[webkit-dev] Cross-platform fonts for Layout Tests

2011-06-01 Thread Eric Seidel
I know that Ahem is safe to use across multiple platforms (the font metrics will be the same). Do we know if there are any other fonts for which this is true? I'd like to make the style-bot yell at people when they use pixel tests with non-safe fonts. Right now that list would only include

Re: [webkit-dev] Pages from the wiki vanished from google search results

2011-05-31 Thread Eric Seidel
Someone could check: https://www.google.com/webmasters I no longer have access (but I could go through the process of getting access if needed). -eric On Tue, May 31, 2011 at 1:37 PM, Ademar Reis ademar.r...@openbossa.orgwrote: Hi there. Since a couple of days ago (when?), our trac/wiki is

Re: [webkit-dev] Font Name

2011-05-29 Thread Eric Seidel
There are a couple steps missing, but this hits most of the important points. I think one could turn such into a blog post with diagrams if so desired. -eric On Sat, May 21, 2011 at 5:55 PM, Mustafizur Rahaman mustaf.h...@gmail.comwrote: Hi, When you are drawing some text, you create a

Re: [webkit-dev] EWS guts about to change

2011-05-28 Thread Eric Seidel
Related: We swapped out the guts of Tools/EWSTools/start-queue.sh a few weeks back. If you run an EWS bot and haven't restarted it manually in a while, now would be a good time to. start-queue.sh makes the EWS robust against python changes, but when we change start-queue.sh bots require manual

Re: [webkit-dev] Adding CSS Regions and Exclusions to WebKit

2011-05-26 Thread Eric Seidel
I appreciate that you've followed the master-bug idiom which is so common in bugs.webkit.org these days! I also would *strongly* encourage you to post your changes in as small of patches as possible. Integrating features which have been developed outside webkit.org is always difficult, but doing

[webkit-dev] Cherry-Pick Bug Comments

2011-05-26 Thread Eric Seidel
I get a lot of these: Revision r86028 cherry-picked into qtwebkit-2.2 with commit 7e1bab1 http://gitorious.org/webkit/qtwebkit/commit/7e1bab1 as bug mail. Probably because I'm CC'd on a zillion bugs (and actually read my bug mail). This is probably the pot calling the kettle black, since I

Re: [webkit-dev] Cherry-Pick Bug Comments

2011-05-26 Thread Eric Seidel
...@chromium.org wrote: On Thu, May 26, 2011 at 3:54 PM, Eric Seidel e...@webkit.org wrote: I get a lot of these: Revision r86028 cherry-picked into qtwebkit-2.2 with commit 7e1bab1 http://gitorious.org/webkit/qtwebkit/commit/7e1bab1 as bug mail. Probably because I'm CC'd on a zillion bugs

Re: [webkit-dev] Verifying changes to build.webkit.org-config/master.cfg locally

2011-05-23 Thread Eric Seidel
If someone does that, seems we should turn it into a script in Tools/Scripts for easy testing of buildbot! :) On Mon, May 23, 2011 at 10:58 AM, Adam Roben aro...@apple.com wrote: On May 20, 2011, at 8:22 PM, Dmitry Lomov wrote: I am trying to make run-api-tests run at build time. I wonder

[webkit-dev] Mac-EWS is down until further notice

2011-05-23 Thread Eric Seidel
***Mac-EWS machines down until further notice.*** I'm sorry for the unexpected outage. I may be able to bring them up as soon as next week. If someone else would like to try running a mac-ews, the instructions remain the same as always: 1) Tools/Scripts/webkit-patch mac-ews 2) There is no

Re: [webkit-dev] New Feature Flag Proposal: INPUT_COLOR

2011-05-23 Thread Eric Seidel
Exciting times! On May 23, 2011 8:57 PM, Keishi Hattori kei...@webkit.org wrote: Hi webkit-dev, I just wanted to notify everyone that I will be adding a new feature flag, INPUT_COLOR. http://webkit.org/b/61273 This flag will enable input type=color I need this flag because the color picker

Re: [webkit-dev] Question on Inline element

2011-05-18 Thread Eric Seidel
the image the text, as a result the paragraph area counts for the image area. So, ther root cause of the problem is when for float image, positionNewFloatOnLine() is called, it has to appropriately set the paragraph framerect. Thanks. On Tue, May 17, 2011 at 11:48 PM, Eric Seidel e

Re: [webkit-dev] Question on Inline element

2011-05-17 Thread Eric Seidel
would imagine. Thanks, Rahaman On Fri, May 13, 2011 at 11:25 PM, Eric Seidel e...@webkit.org wrote: On Thu, May 12, 2011 at 10:52 PM, Mustafizur Rahaman mustaf.h...@gmail.com wrote: So my question is - Can a paragraph element contain an image element= the html spec does

Re: [webkit-dev] Question on Inline element

2011-05-13 Thread Eric Seidel
On Thu, May 12, 2011 at 10:52 PM, Mustafizur Rahaman mustaf.h...@gmail.comwrote: So my question is - Can a paragraph element contain an image element= the html spec does not say NO. Yes. There are two specs at play here. HTML and CSS. Ignore anything prior to HTML5 as it was

Re: [webkit-dev] New feature announcement – Video conferencing and peer-to-peer communication

2011-05-13 Thread Eric Seidel
That sounds like about 8 features. Seems we should think about this in smaller chunks... On the surface peer to peer video conferencing does not seem like something appropriate to add to WebCore/WebKit. Just like an API for reading my email is out of scope for the project. (But certainly lots

[webkit-dev] Please announce your features

2011-05-09 Thread Eric Seidel
Per discussion at the WebKit contributors meeting, we have added new guidelines for adding features to WebKit. http://www.webkit.org/coding/adding-features.html Basically, we expect folks adding features to announce them on webkit-dev. We've had 4 announcements already following these new

[webkit-dev] EWS Bots are Sick

2011-05-04 Thread Eric Seidel
App Engine went down this afternoon. The bots (commit-queue, sherriff-bot, ewses, etc.) haven't really recovered yet. Adam and I will work to bring them all back up tomorrow. -eric ___ webkit-dev mailing list webkit-dev@lists.webkit.org

[webkit-dev] Tiger

2011-05-03 Thread Eric Seidel
It looks like Tiger support in WebKit is slowly being removed. There no longer is a libWebKitSystemInterfaceTiger.a in the project, nor is there a Tiger buildbot or tiger expectations. Can we go ahead and kill all the ifdefs too? Or is it too early to call Tiger dead? -eric

Re: [webkit-dev] Tiger

2011-05-03 Thread Eric Seidel
I was referring mostly to build-webkit ifs, assuming that the #ifdefs in the cpp code were still around as well. But it's possible those already got removed. :) -eric On Tue, May 3, 2011 at 11:07 AM, Mark Rowe mr...@apple.com wrote: On 2011-05-03, at 10:58, Eric Seidel wrote: It looks like

Re: [webkit-dev] new-run-webkit-tests new results.html format

2011-05-03 Thread Eric Seidel
Is that a good example? It doesn't remind me much of the ORWT output. The disclosure triangles don't seem to do anything for hte failures on that page. On Tue, May 3, 2011 at 2:05 PM, Ojan Vafai o...@chromium.org wrote: On Tue, May 3, 2011 at 1:44 PM, Adam Roben aro...@apple.com wrote: On

Re: [webkit-dev] new-run-webkit-tests new results.html format

2011-05-03 Thread Eric Seidel
: Here is a link to the NRWT bot running the Mac Leopard Release build: http://build.webkit.org/results/Leopard%20Intel%20Release%20(NRWT)/r85644%20(142)/results.html -- Dirk On Tue, May 3, 2011 at 2:14 PM, Eric Seidel e...@webkit.org wrote: Is that a good example?  It doesn't remind me much

Re: [webkit-dev] new-run-webkit-tests new results.html format

2011-05-03 Thread Eric Seidel
If we have + buttons for all the failures, might as well have them for the http logs too. :p On Tue, May 3, 2011 at 2:23 PM, Eric Seidel e...@webkit.org wrote: IIRC the showing wdiff when there is no wdiff bug has since been fixed? (but that bot just hasn't updated?) what's the failure type

<    1   2   3   4   5   6   7   8   9   >