[webkit-dev] Removing webkit-tools-completion.sh

. Thanks for your thoughts, Jonathan Bedard WebKit Continuous Integration ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] Sam Sneddon is now a WebKit Reviewer

Hello folks, I am happy to announce that Sam Sneddon is now a WebKit Reviewer! Sam is an expert in Web Platform Tests and our tooling to run layout tests, along with Python in general. Jonathan Bedard ___ webkit-dev mailing list webkit-dev

Re: [webkit-dev] WebKit Tree Closure

This tree closure has been canceled. ‘main’ will remain open for commits for the duration of 2/23 and 2/24. Thank you for your patience! Jonathan Bedard WebKit Continuous Integration > What: WebKit tree closure > When: 8pm PT 2/23/2024 until 12pm PT 2/24/2024 > > Impact > Af

Re: [webkit-dev] Approving / Rejects PRs on GitHub when not a reviewer?

> Hi, > > Back in the Bugzilla days, only reviewers were allowed to r+ or r- patches. > Non-reviewers were - of course - encouraged to do informal reviews but they > would do so by leaving comments. They would never r+ / r-. > > Since we?ve moved to Github, it seems we have become a lot more

[webkit-dev] New `request-merge-queue` label

Hey folks, There was a request to add an equivalent to Bugzilla's “cq?” in GitHub. This morning, I added the `request-merge-queue` label, https://github.com/WebKit/WebKit/labels?q=request-merge-queue. Since GitHub lets you filter PRs on labels

Re: [webkit-dev] webkit-dev Digest, Vol 208, Issue 5

> On Sep 29, 2022, at 4:28 PM, Ryosuke Niwa wrote: > > > >> On Sep 29, 2022, at 11:48 AM, Jonathan Bedard via webkit-dev >> mailto:webkit-dev@lists.webkit.org>> wrote: >> >> >>>> On Sep 20, 2022, at 1:52 PM, Brent Fulgham >>>

Re: [webkit-dev] webkit-dev Digest, Vol 208, Issue 5

>> On Sep 20, 2022, at 1:52 PM, Brent Fulgham wrote: >> >>> On Sep 20, 2022, at 1:16 AM, Ryosuke Niwa via webkit-dev >>> wrote: >>> On Sep 19, 2022, at 2:28 PM, Brandon Stewart via webkit-dev mailto:webkit-dev@lists.webkit.org>> wrote: Documentation is an important part

Re: [webkit-dev] WebKit is now on GitHub

t 2:01 PM, Michael Catanzaro wrote: > > On Thu, Jun 23 2022 at 10:29:55 AM -0700, Jonathan Bedard via webkit-dev > wrote: >> Let me know if there is any fallout, > > As far as I know, WebKitGTK and WPE WebKit stable branches have not yet been > migrated and are now

[webkit-dev] WebKit is now on GitHub

will remain accessible in a read-only state so we can audit any content we intend to migrate to GitHub. Let me know if there is any fallout, Jonathan Bedard WebKit Continuous Integration ___ webkit-dev mailing list webkit-dev@lists.webkit.org https

[webkit-dev] 7 Days Until Retiring Subversion

king-out-WebKit <https://github.com/WebKit/WebKit/wiki/Contributing#checking-out-WebKit> for starting fresh. We intend to keep our defunct remotes available for a few weeks to ease the transitions, but starting Thursday, these 3 remotes will not be receiving new commits. Please reach ou

Re: [webkit-dev] Proposal: Mandatory Commit and Merge Queue

top of chaos, and there is no way to > know if things are improving or getting worse, and no way to hold ourselves > accountable for improvement. > > Thanks, > Geoff > >> >> Jonathan >> >>> >>> Thanks, >>> Geoff >>>

Re: [webkit-dev] Add CODEOWNERS to WebKit

p. > > I believe that while there are stale watchlists entries, newer additions are > valid. > > - Alexey > >> 2 июня 2022 г., в 2:19 PM, Jonathan Bedard via webkit-dev >> mailto:webkit-dev@lists.webkit.org>> >> написал(а): >> >

Re: [webkit-dev] Proposal: Mandatory Commit and Merge Queue

long and contentious discussion. The motivating change is that the GitHub transition makes this proposal possible, from a technical perspective, in a way it is not while the project is still backed by Subversion. Jonathan > > Thanks, > Geoff > > >> On Jun 2, 2022, at 2:35 PM, J

[webkit-dev] Proposal: Mandatory Commit and Merge Queue

trying known flakey or failing tests - Another MergeQueue bot - Xcode workspace builds to speed up incremental builds Jonathan Bedard WebKit Continuous Integration ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/m

Re: [webkit-dev] Add CODEOWNERS to WebKit

t; >> On Jun 2, 2022, at 1:12 PM, Jonathan Bedard via webkit-dev >> wrote: >> >> Hey folks, >> >> Yusuke is interested in adding the CODEOWNERS file to the WebKit project >> (see https://github.com/WebKit/WebKit/pull/1137 >> <https://github.com/WebK

[webkit-dev] Add CODEOWNERS to WebKit

Hey folks, Yusuke is interested in adding the CODEOWNERS file to the WebKit project (see https://github.com/WebKit/WebKit/pull/1137 ). There have been some objections to this, the two ones I’m aware of: - WebKit doesn’t assign “ownership” to pieces

[webkit-dev] ChangeLogs are Deprecated

As outlined in my email yesterday, Commit-Queue and Merge-Queue both now reject any changes that include ChangeLogs. I will be waiting a few days before actually deleting all of the ChangeLog files so that contributors with patches that still contain ChangeLogs can apply those patches without

[webkit-dev] ChangeLog Deprecation in WebKit

Starting tomorrow, Tuesday May 17th, WebKit will no longer be using ChangeLogs and will instead require commit messages in new commits. These were the norm when we started the project, but now they are unusual, antiquated, and get in the way of common git tooling. This means that we need a

Re: [webkit-dev] Proposal: Immediate Deprecation of ChangeLogs

changes in the unsafe queue and some bots are busy with Merge-Queue and Commit-Queue requests, so there is only a single available bot serving the unsafe queue. Jonathan > On May 11, 2022, at 4:31 PM, Chris Dumez wrote: > > >> On May 11, 2022, at 11:56 AM, Jonathan Bedard via webkit

Re: [webkit-dev] Proposal: Immediate Deprecation of ChangeLogs

Trying to embed previous replies is going to get messy, will be referencing those replies but not embedding them. Unsafe-Merge-Queue should be very fast, I haven’t seen anything take longer than 10 minutes from label application to landing or rejection. The average case is 3-4 minutes. We’re

Re: [webkit-dev] Proposal: Immediate Deprecation of ChangeLogs

looking… to propose immediate migration > without that data. > > Thanks, > Geoff > >> On May 10, 2022, at 1:32 PM, Jonathan Bedard via webkit-dev >> wrote: >> >> A few weeks ago, I started a discussion about deprecating ChangeLogs. In >> that time,

[webkit-dev] Proposal: Immediate Deprecation of ChangeLogs

A few weeks ago, I started a discussion about deprecating ChangeLogs. In that time, we’ve had more folks using the pull-request workflow and more folks using newer versions of `git` which break automatic ChangeLog rebasing. I propose that on Monday, May 16th, we implement the following policy

Re: [webkit-dev] webkit-patch land behavior change

ote: > > > > On 26/04/2022 21:58, Jonathan Bedard via webkit-dev wrote: >> As we move closer to transitioning away from Subversion, I’ve change >> ‘webkit-patch land’ to use commit-queue instead of directly committing a >> local change from a contributor’s machine >>

[webkit-dev] webkit-patch land behavior change

Hey folks, As we move closer to transitioning away from Subversion, I’ve change ‘webkit-patch land’ to use commit-queue instead of directly committing a local change from a contributor’s machine (https://github.com/WebKit/WebKit/pull/392). ‘git-webkit land-unsafe’ will allow contributors to

Re: [webkit-dev] ChangeLog Deprecation Plan

> It seems to me that you can write a script that just applies a patch while > ignoring changes to each change log file, then separately prepend each > change log entry. I don't see why such a script would behave differently > for reverting multiple commits or rebasing a feature onto a branch. In

Re: [webkit-dev] ChangeLog Deprecation Plan

> Message: 2 > Date: Mon, 18 Apr 2022 10:33:03 -0700 > From: Ryosuke Niwa > To: Jonathan Bedard > Cc: WebKit Development > Subject: Re: [webkit-dev] ChangeLog Deprecation Plans > Message-ID: > > Content-Type: text/plain; charset="utf-8" > &g

[webkit-dev] ChangeLog Deprecation Plans

in a text editor Looking forward to the discussion, Jonathan Bedard WebKit Continuous Integration___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] WebKit and GitHub Update

workflow from the same checkout. Jonathan Bedard WebKit Continuous Integration ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] GitHub Labels

Hey folks, We’re in the final stage of bringing up support for GitHub pull-requests. To support this effort, we’re starting to add labels to our project. We intend to use labels as a replacement for commit-queue flags and Product/Component/Version fields in bugzilla. Before our tools are too

[webkit-dev] Removing Python 2 in WebKit

Hey folks, The macOS 12.3 seed remove Python 2. Most of WebKit’s tools are already Python 3 compatible, and in the last few weeks, we changed a number of buildbot invocation and shebangs so that workflows critical to the project are Python 3 by default. There are still a number of scripts

[webkit-dev] Recommended GitHub Settings

Hey folks, We’ve had some contributors reach out to us about notifications they are starting to receive because of our development of GitHub pull-requests. Given the size of the WebKit project, we have a few recommendations of how to configure your notification settings. On

[webkit-dev] GitHub Usernames in contributors.json

Hello WebKittens, As I continue to bring up GitHub infrastructure, it’s coming time to start representing various permissions of the WebKit project in GitHub. In order to represent these permissions, we need a record of active contributor’s GitHub usernames. We’re doing this in

Re: [webkit-dev] Identifiers in Log and Blame

ut I really don't use command line tools to > see my blame. What I need is this getting applied to a online tools like trac > and GitHub. > > On Tue, Aug 17, 2021 at 10:57 AM Jonathan Bedard via webkit-dev > mailto:webkit-dev@lists.webkit.org>> wrote: > Hi folks, >

[webkit-dev] Identifiers in Log and Blame

9. ... git-webkit blame is a wrapper around git blame or svn blame (again, depending on your checkout) and also annotates the output of these commands with identifiers: 230258@main (Keith Rollin2020-10-08 19:10:32 + 1) MODULES = Source Tools 184786@main (Jonathan Bedard 2017-02-02

[webkit-dev] Fixed merged commits in GitHub Mirror

Morning folks, Last Friday, git-svn failed us and merged two commits together (this was the cause of the incorrect commits.webkit.org links folks saw over the last few days). I’ve fixed it, but that fix involves force-pushing, if you have a GitHub checkout, you

[webkit-dev] Identifier Conversion Tooling

Hello contributors, As we move forward with the transition to GitHub, we are starting to adopt identifiers in tooling and infrastructure. This is going to take a few weeks, but you will start seeing links based on identifiers more frequently.

[webkit-dev] Scripts default to Python 3

Hello contributors, Now that trunk no longer supports Mojave, it’s time to change our Python shebangs to Python 3 in our scripts. https://bugs.webkit.org/show_bug.cgi?id=221411 is the umbrella bug that covers this change. We aren’t ready to

Re: [webkit-dev] Replacing PHP with Python in Layout Tests

>> Hello Contributors, >> >> To help reduce the number of dependencies WebKit?s tools have, I would >> like to replace our PHP tests (and resources used by tests) with Python 3 >> CGI scripts. I?ve already attempted to convert a few dozen PHP tests and >> resources to demonstrate that this is

[webkit-dev] Replacing PHP with Python in Layout Tests

Hello Contributors, To help reduce the number of dependencies WebKit’s tools have, I would like to replace our PHP tests (and resources used by tests) with Python 3 CGI scripts. I’ve already attempted to convert a few dozen PHP tests and resources to demonstrate that this is both possible and

[webkit-dev] Official GitHub Mirror Automatically Syncing

Hey folks, Just wanted to let everyone know that our GitHub mirror, https://github.com/WebKit/WebKit , is being automatically updated on SVN commits to trunk, just like the git.webkit.org repositories. Using the GitHub repository for

Re: [webkit-dev] GitHub Account and Commit Attribution

ecause someone could just grab the commit log and find the email), but that setting your email to private will not prevent commits from being attributed to you. Jonathan > On Dec 17, 2020, at 1:02 PM, Darin Adler wrote: > >> On Dec 17, 2020, at 8:47 AM, Jonathan Bedard via web

[webkit-dev] GitHub Account and Commit Attribution

Hey folks, Something we’ve just learned about commit attribution and GitHub is that adding an email to your GitHub account may not attribute commits that were pushed to a repository before you added the email. There were a few issues with history as it stands now, and I will be pushing up the

Re: [webkit-dev] GitHub Clone Published

anging again in the next few days. Jonathan > On Dec 14, 2020, at 9:28 AM, Jonathan Bedard wrote: > > Hello contributors, > > This morning, I just finished pushing main with re-written history to > https://github.com/WebKit/WebKit <https://github.com/WebKit/WebKit&

[webkit-dev] GitHub Clone Published

WebKit <https://github.com/WebKit/WebKit> as the future canonical home of the WebKit project, and will be publishing instructions on how to rebase forks of the old https://github.com/WebKit/WebKit-http <https://github.com/WebKit/WebKit-http> repository. Jonathan Bedard

[webkit-dev] Bugzilla Accounts and contributors.json

Hello contributors, As of r270538, commit-queue will only respect committer and reviewer permissions on the first email in contributor.json. The motivation for this is that many contributors have old email addresses that they no longer control (usually because of certain email services being

Re: [webkit-dev] Commit Authorship on GitHub

> On Dec 1, 2020, at 1:55 PM, Yusuke Suzuki wrote: > > Hi Jonathan! > >> On Dec 1, 2020, at 8:22 AM, Jonathan Bedard via webkit-dev >> mailto:webkit-dev@lists.webkit.org>> wrote: >> >> Hello contributors, >> >> I am in the process

[webkit-dev] Commit Authorship on GitHub

Hello contributors, I am in the process of modifying one of our Git mirrors of the repository for permanent use. As part of that modification, I am repairing authorship of historical commits based on contributors.json. This effort includes our branches and resolving commits attributed to

Re: [webkit-dev] Github mirror is not updating

Not at first, but at the moment, yes, it is intentional. We are working on migrating WebKit to a more permanent and complete Git repository, which involves editing history. Because of this, we didn’t want to further the confusion we already have with two different sets of git hashes. The new

Re: [webkit-dev] Embedding Identifiers in Commit Messages

Forgot to update this thread: taking a different approach, will be tracked by the same bug. Will answer inline. > On Nov 11, 2020, at 7:56 AM, Michael Catanzaro wrote: > > On Wed, Nov 4, 2020 at 11:51 am, Jonathan Bedard wrote: >> We don´t have post commit hooks in SVN

Re: [webkit-dev] Embedding Identifiers in Commit Messages

> > We appreciate everyone’s feedback on transitioning away from Subversion to > > Git, I’ll be releasing an expected timeline of up-coming changes in the > > next week before the contributors meeting. > > > > In the mean time, we’re preparing on adding identifiers to new commit > > messages,

Re: [webkit-dev] Embedding Identifiers in Commit Messages

>> On Mon, Nov 2, 2020 at 2:04 PM Jonathan Bedard > <https://lists.webkit.org/mailman/listinfo/webkit-dev>> wrote: >> >>> We appreciate everyone’s feedback on transitioning away from Subversion to >>> Git, I’ll be releasing >>> an expected ti

[webkit-dev] Embedding Identifiers in Commit Messages

Hello WebKit contributors, We appreciate everyone’s feedback on transitioning away from Subversion to Git, I’ll be releasing an expected timeline of up-coming changes in the next week before the contributors meeting. In the mean time, we’re preparing on adding identifiers

Re: [webkit-dev] WebKit Transition to Git (Merge Workflows)

To point something out with the squash merge vs rebase merge policies, we will definitely be enforcing squash merges at least initially because rebase merges require some extra EWS and commit-queue infrastructure. Recall that WebKit does regression testing for every commit, even if these

Re: [webkit-dev] WebKit Transition to Git

Seems like most large projects are using some sort of bot or action to solve this problem: https://github.com/isaacs/github/issues/581 . Jonathan > On Oct 6, 2020, at 11:07 AM, Michael Catanzaro wrote: > > On Wed, Oct 7, 2020 at 2:22 am, Tetsuharu

Re: [webkit-dev] WebKit Transition to Git [Identifiers and Merge Commits]

>> Monotonic Commit Identifiers >> Of great interest to Apple?s engineers has been retaining some kind >> of ordered tag we can use to refer to commits to make defending CI >> and bisection easier. We?ve developed a scheme for this that assigns >> commits an ordered identifier per-branch,

Re: [webkit-dev] WebKit Transition to Git

> On Oct 2, 2020, at 5:05 PM, Michael Catanzaro wrote: > > On Fri, Oct 2, 2020 at 09:43, Jonathan Bedard wrote: >> The biggest blocker we are aware of is managing security bugs, since the >> security advisory system used by GitHub is essentially the opposite of how &g

Re: [webkit-dev] WebKit Transition to Git

weird on the default branch since we often use tags to mark branch points. This means that commits on the default branch would reset their count every time we branched. Jonathan > On Oct 4, 2020, at 2:41 PM, Konstantin Tokarev wrote: > > > > 02.10.2020, 19:46, "Jonathan Be

Re: [webkit-dev] WebKit Transition to Git

re still figuring out, personal experience like what you’re providing here is super valuable! > > > -- > Tetsuharu OHZEKI > tetsuharu.ohz...@gmail.com > > > > > On Sat, Oct 3, 2020 at 1:43 AM Jonathan Bedard wrote: >> >> Hello WebKit Contributor

[webkit-dev] WebKit Transition to Git

t part of this transition, and we are interested in soliciting feedback from our contributors on what the WebKit project’s integration with GitHub Issues should look like. Look forward to hearing from all of you, Jonathan Bedard WebKit Operations___ webk

[webkit-dev] Big Sur EWS and Apple Silicon

are sufficiently different from existing configurations that we wanted to provide this build configuration to WebKit developers through EWS. The ‘mac-AS’ (standing for Mac, Apple Silicon) is the bubble corresponding to this new configuration. Thank you all for your contributions, Jonathan Bedard

Re: [webkit-dev] Moving to Python 3

I would agree that if we move to Python 3, we need a script which installs Python 3 in an impossible to mess-up way on Mojave and High Sierra. I don’t think the clang comparison is fair here. Python 2 is officially deprecated in 2020, we can’t expect security updates to the language or any

Re: [webkit-dev] Moving to Python 3

> On Jul 12, 2019, at 1:07 PM, Keith Rollin wrote: > >> On Jul 12, 2019, at 13:37, Tim Horton wrote: >> >> See "Migrating to the common subset of Python 2 and 3” — you define >> different iteritems() helpers in the two cases. Seems pretty reasonable to >> me. > > I did something like this

Re: [webkit-dev] Moving to Python 3

> On Jul 12, 2019, at 12:49 PM, Michael Catanzaro wrote: > > On Fri, Jul 12, 2019 at 2:18 PM, Jonathan Bedard wrote: >> The trouble I foresee us encountering with any scheme which attempts a >> conversion which retains both Python 2.7 and Python 3 compatibi

Re: [webkit-dev] Moving to Python 3

e. Jonathan > > On Fri, Jul 12, 2019 at 3:38 PM Tim Horton <mailto:timothy_hor...@apple.com>> wrote: > > >> On Jul 12, 2019, at 12:18 PM, Jonathan Bedard > <mailto:jbed...@apple.com>> wrote: >> >> Hello WebKit developers, >> >> Now that

[webkit-dev] Moving to Python 3

Hello WebKit developers, Now that the Catalina developer seeds are available, it is official that the new Mac developer tools come with Python 3. As a result, we need to continue the ongoing discussion about migrating our Python 2.7 scripts to Python 3. I propose that, over the next 9 months,

Re: [webkit-dev] Requesting feedback about EWS comments on Bugzilla bugs

n automatic mechanism that gathers the failures, records them in >> a database, and then — with sufficient data — makes determinations about the >> flakiness or other status of the test. It could then mark the test as flaky >> or raise it as an issue to some responsible (and responsive

Re: [webkit-dev] Proposal for Device-Specific Layout Tests

> On Dec 12, 2018, at 11:28 PM, Maciej Stachowiak wrote: > > > >> On Dec 12, 2018, at 2:20 PM, Jonathan Bedard > <mailto:jbed...@apple.com>> wrote: >> >>> >>> On Dec 12, 2018, at 11:16 AM, Maciej Stachowiak >> <mailto:m...@appl

Re: [webkit-dev] Proposal for Device-Specific Layout Tests

> On Dec 12, 2018, at 11:16 AM, Maciej Stachowiak wrote: > > > >> On Dec 12, 2018, at 10:07 AM, Jonathan Bedard > <mailto:jbed...@apple.com>> wrote: >> >> Ryosuke and I discussed this on Monday, and in passing, Ryosuke mentioned

Re: [webkit-dev] Proposal for Device-Specific Layout Tests

>> >> >> On Tue, Dec 4, 2018 at 12:55 PM Jonathan Bedard > <mailto:jbed...@apple.com>> wrote: >> These directories would be along-side tests. >> >> I don't like that platform-specific results are under LayoutTests/platform >> and device-spe

Re: [webkit-dev] Proposal for Device-Specific Layout Tests

> On Dec 4, 2018, at 4:43 PM, Ryosuke Niwa wrote: > > > On Tue, Dec 4, 2018 at 12:55 PM Jonathan Bedard <mailto:jbed...@apple.com>> wrote: > These directories would be along-side tests. > > I don't like that platform-specific results are under LayoutTests/p

Re: [webkit-dev] Proposal for Device-Specific Layout Tests

- R. Niwa > > > On Mon, Dec 3, 2018 at 4:05 PM Jonathan Bedard <mailto:jbed...@apple.com>> wrote: > Hello everyone, > > I have a proposal to make writing layout tests for specific types of devices > more straight-forward. > > Currently, we name director

[webkit-dev] Proposal for Device-Specific Layout Tests

Hello everyone, I have a proposal to make writing layout tests for specific types of devices more straight-forward. Currently, we name directories with the beginning of a device name, such as ‘iphone7’ or ‘ipad’ and hope that those directory names match the name of a device type in the

Re: [webkit-dev] iOS EWS broken?

I inspected all of our bots this morning, none of them are chronically in a bad state: >. Also, we are getting results for your patch

[webkit-dev] Changing Order of Precedence for Mac TestExpectations

Hi everyone, Today, we changed the order of precedence for Mac TestExpectations (r219507). Previously, the precedence for El Capitan would look like this: platform/mac-wk2 platform/wk2 platform/mac-elcapitan platform/mac-sierra generic Where an expectation or expected result in

[webkit-dev] Moving iOS-Simulator Test Expectations

Hello WebKit developers, Tomorrow morning at 8:00 am PDT, all 'ios-simiulator*' test expectation folder will be moved to ones named ‘ios.’ The ios-simulator folders will remain, but should be reserved for platform specifics which are unique to iOS Simulator and not shared with iOS devices.