[webkit-dev] Removing webkit-tools-completion.sh

I’m working on unwinding Subversion support in WebKit. There is an old script, webkit-tools-completion.sh, which references various old scripts (namely, webkit-patch). Is anyone using this script or should we remove it? Pull-request in question is https://github.com/WebKit/WebKit/pull/28536.

[webkit-dev] Sam Sneddon is now a WebKit Reviewer

Hello folks, I am happy to announce that Sam Sneddon is now a WebKit Reviewer! Sam is an expert in Web Platform Tests and our tooling to run layout tests, along with Python in general. Jonathan Bedard ___ webkit-dev mailing list

Re: [webkit-dev] WebKit Tree Closure

This tree closure has been canceled. ‘main’ will remain open for commits for the duration of 2/23 and 2/24. Thank you for your patience! Jonathan Bedard WebKit Continuous Integration > What: WebKit tree closure > When: 8pm PT 2/23/2024 until 12pm PT 2/24/2024 > > Impact > Affected services: >

Re: [webkit-dev] Approving / Rejects PRs on GitHub when not a reviewer?

> Hi, > > Back in the Bugzilla days, only reviewers were allowed to r+ or r- patches. > Non-reviewers were - of course - encouraged to do informal reviews but they > would do so by leaving comments. They would never r+ / r-. > > Since we?ve moved to Github, it seems we have become a lot more

[webkit-dev] New `request-merge-queue` label

Hey folks, There was a request to add an equivalent to Bugzilla's “cq?” in GitHub. This morning, I added the `request-merge-queue` label, https://github.com/WebKit/WebKit/labels?q=request-merge-queue. Since GitHub lets you filter PRs on labels

Re: [webkit-dev] webkit-dev Digest, Vol 208, Issue 5

> On Sep 29, 2022, at 4:28 PM, Ryosuke Niwa wrote: > > > >> On Sep 29, 2022, at 11:48 AM, Jonathan Bedard via webkit-dev >> mailto:webkit-dev@lists.webkit.org>> wrote: >> >> >>>> On Sep 20, 2022, at 1:52 PM, Brent Fulgham >>>

Re: [webkit-dev] webkit-dev Digest, Vol 208, Issue 5

>> On Sep 20, 2022, at 1:52 PM, Brent Fulgham wrote: >> >>> On Sep 20, 2022, at 1:16 AM, Ryosuke Niwa via webkit-dev >>> wrote: >>> On Sep 19, 2022, at 2:28 PM, Brandon Stewart via webkit-dev mailto:webkit-dev@lists.webkit.org>> wrote: Documentation is an important part

Re: [webkit-dev] WebKit is now on GitHub

t 2:01 PM, Michael Catanzaro wrote: > > On Thu, Jun 23 2022 at 10:29:55 AM -0700, Jonathan Bedard via webkit-dev > wrote: >> Let me know if there is any fallout, > > As far as I know, WebKitGTK and WPE WebKit stable branches have not yet been > migrated and are now

[webkit-dev] WebKit is now on GitHub

r295779 is the last commit to WebKit’s Subversion repository. https://github.com/WebKit/WebKit is now the canonical home of the WebKit project! All commits must now go through Commit-Queue, Merge-Queue or Unsafe-Merge-Queue. For the next few weeks, svn.webkit.org and trac.webkit.org will

[webkit-dev] 7 Days Until Retiring Subversion

Hey folks, The time has come! On Thursday, June 23rd, we are planning on stopping all commits to the Subversion repository hosted on https://svn.webkit.org , all future commits will at that point be made on https://github.com/WebKit/WebKit

Re: [webkit-dev] Proposal: Mandatory Commit and Merge Queue

top of chaos, and there is no way to > know if things are improving or getting worse, and no way to hold ourselves > accountable for improvement. > > Thanks, > Geoff > >> >> Jonathan >> >>> >>> Thanks, >>> Geoff >>>

Re: [webkit-dev] Add CODEOWNERS to WebKit

p. > > I believe that while there are stale watchlists entries, newer additions are > valid. > > - Alexey > >> 2 июня 2022 г., в 2:19 PM, Jonathan Bedard via webkit-dev >> mailto:webkit-dev@lists.webkit.org>> >> написал(а): >> >

Re: [webkit-dev] Proposal: Mandatory Commit and Merge Queue

long and contentious discussion. The motivating change is that the GitHub transition makes this proposal possible, from a technical perspective, in a way it is not while the project is still backed by Subversion. Jonathan > > Thanks, > Geoff > > >> On Jun 2, 2022, at 2:35 PM, J

[webkit-dev] Proposal: Mandatory Commit and Merge Queue

As we move to GitHub, I would like to propose we strengthen our protections on `main` by making MergeQueue and CommitQueue mandatory. This would mean that with a few exceptions, all changes would need to be built and run layout tests before they are landed. To spell out what the exceptions I

Re: [webkit-dev] Add CODEOWNERS to WebKit

t; >> On Jun 2, 2022, at 1:12 PM, Jonathan Bedard via webkit-dev >> wrote: >> >> Hey folks, >> >> Yusuke is interested in adding the CODEOWNERS file to the WebKit project >> (see https://github.com/WebKit/WebKit/pull/1137 >> <https://github.com/WebK

[webkit-dev] Add CODEOWNERS to WebKit

Hey folks, Yusuke is interested in adding the CODEOWNERS file to the WebKit project (see https://github.com/WebKit/WebKit/pull/1137 ). There have been some objections to this, the two ones I’m aware of: - WebKit doesn’t assign “ownership” to pieces

[webkit-dev] ChangeLogs are Deprecated

As outlined in my email yesterday, Commit-Queue and Merge-Queue both now reject any changes that include ChangeLogs. I will be waiting a few days before actually deleting all of the ChangeLog files so that contributors with patches that still contain ChangeLogs can apply those patches without

[webkit-dev] ChangeLog Deprecation in WebKit

Starting tomorrow, Tuesday May 17th, WebKit will no longer be using ChangeLogs and will instead require commit messages in new commits. These were the norm when we started the project, but now they are unusual, antiquated, and get in the way of common git tooling. This means that we need a

Re: [webkit-dev] Proposal: Immediate Deprecation of ChangeLogs

changes in the unsafe queue and some bots are busy with Merge-Queue and Commit-Queue requests, so there is only a single available bot serving the unsafe queue. Jonathan > On May 11, 2022, at 4:31 PM, Chris Dumez wrote: > > >> On May 11, 2022, at 11:56 AM, Jonathan Bedard via webkit

Re: [webkit-dev] Proposal: Immediate Deprecation of ChangeLogs

Trying to embed previous replies is going to get messy, will be referencing those replies but not embedding them. Unsafe-Merge-Queue should be very fast, I haven’t seen anything take longer than 10 minutes from label application to landing or rejection. The average case is 3-4 minutes. We’re

Re: [webkit-dev] Proposal: Immediate Deprecation of ChangeLogs

looking… to propose immediate migration > without that data. > > Thanks, > Geoff > >> On May 10, 2022, at 1:32 PM, Jonathan Bedard via webkit-dev >> wrote: >> >> A few weeks ago, I started a discussion about deprecating ChangeLogs. In >> that time,

[webkit-dev] Proposal: Immediate Deprecation of ChangeLogs

A few weeks ago, I started a discussion about deprecating ChangeLogs. In that time, we’ve had more folks using the pull-request workflow and more folks using newer versions of `git` which break automatic ChangeLog rebasing. I propose that on Monday, May 16th, we implement the following policy

Re: [webkit-dev] webkit-patch land behavior change

ote: > > > > On 26/04/2022 21:58, Jonathan Bedard via webkit-dev wrote: >> As we move closer to transitioning away from Subversion, I’ve change >> ‘webkit-patch land’ to use commit-queue instead of directly committing a >> local change from a contributor’s machine >>

[webkit-dev] webkit-patch land behavior change

Hey folks, As we move closer to transitioning away from Subversion, I’ve change ‘webkit-patch land’ to use commit-queue instead of directly committing a local change from a contributor’s machine (https://github.com/WebKit/WebKit/pull/392). ‘git-webkit land-unsafe’ will allow contributors to

Re: [webkit-dev] ChangeLog Deprecation Plan

> It seems to me that you can write a script that just applies a patch while > ignoring changes to each change log file, then separately prepend each > change log entry. I don't see why such a script would behave differently > for reverting multiple commits or rebasing a feature onto a branch. In

Re: [webkit-dev] ChangeLog Deprecation Plan

t; On Mon, Apr 18, 2022 at 8:30 AM Jonathan Bedard via webkit-dev < > webkit-dev@lists.webkit.org> wrote: > >> As we migrate WebKit from Subversion to git, I would like to migrate the >> project away from ChangeLogs. The reason for this is that ChangeLogs make >> some of t

[webkit-dev] ChangeLog Deprecation Plans

As we migrate WebKit from Subversion to git, I would like to migrate the project away from ChangeLogs. The reason for this is that ChangeLogs make some of the features of git hard to use, namely, cherry-picking commits between branches requires conflict resolution every time. Rotating

[webkit-dev] WebKit and GitHub Update

It is now the time to start widespread testing of pure git checkouts for WebKit. Commit queue has been reimplemented for GitHub, so you don't need a Subversion or git-svn checkout for changes to trunk/main that aren’t modifying SVN properties. Over the past few months, we’ve been working on

[webkit-dev] GitHub Labels

Hey folks, We’re in the final stage of bringing up support for GitHub pull-requests. To support this effort, we’re starting to add labels to our project. We intend to use labels as a replacement for commit-queue flags and Product/Component/Version fields in bugzilla. Before our tools are too

[webkit-dev] Removing Python 2 in WebKit

Hey folks, The macOS 12.3 seed remove Python 2. Most of WebKit’s tools are already Python 3 compatible, and in the last few weeks, we changed a number of buildbot invocation and shebangs so that workflows critical to the project are Python 3 by default. There are still a number of scripts

[webkit-dev] Recommended GitHub Settings

Hey folks, We’ve had some contributors reach out to us about notifications they are starting to receive because of our development of GitHub pull-requests. Given the size of the WebKit project, we have a few recommendations of how to configure your notification settings. On

[webkit-dev] GitHub Usernames in contributors.json

Hello WebKittens, As I continue to bring up GitHub infrastructure, it’s coming time to start representing various permissions of the WebKit project in GitHub. In order to represent these permissions, we need a record of active contributor’s GitHub usernames. We’re doing this in

Re: [webkit-dev] Identifiers in Log and Blame

ut I really don't use command line tools to > see my blame. What I need is this getting applied to a online tools like trac > and GitHub. > > On Tue, Aug 17, 2021 at 10:57 AM Jonathan Bedard via webkit-dev > mailto:webkit-dev@lists.webkit.org>> wrote: > Hi folks, >

[webkit-dev] Identifiers in Log and Blame

Hi folks, As we move towards using Git as our version control system, more services and scripts will be using identifiers instead of revisions or hashes. Already, build.webkit.org , results.webkit.org and ews-build.webkit.org

[webkit-dev] Fixed merged commits in GitHub Mirror

Morning folks, Last Friday, git-svn failed us and merged two commits together (this was the cause of the incorrect commits.webkit.org links folks saw over the last few days). I’ve fixed it, but that fix involves force-pushing, if you have a GitHub checkout, you

[webkit-dev] Identifier Conversion Tooling

Hello contributors, As we move forward with the transition to GitHub, we are starting to adopt identifiers in tooling and infrastructure. This is going to take a few weeks, but you will start seeing links based on identifiers more frequently.

[webkit-dev] Scripts default to Python 3

Hello contributors, Now that trunk no longer supports Mojave, it’s time to change our Python shebangs to Python 3 in our scripts. https://bugs.webkit.org/show_bug.cgi?id=221411 is the umbrella bug that covers this change. We aren’t ready to

Re: [webkit-dev] Replacing PHP with Python in Layout Tests

>> Hello Contributors, >> >> To help reduce the number of dependencies WebKit?s tools have, I would >> like to replace our PHP tests (and resources used by tests) with Python 3 >> CGI scripts. I?ve already attempted to convert a few dozen PHP tests and >> resources to demonstrate that this is

[webkit-dev] Replacing PHP with Python in Layout Tests

Hello Contributors, To help reduce the number of dependencies WebKit’s tools have, I would like to replace our PHP tests (and resources used by tests) with Python 3 CGI scripts. I’ve already attempted to convert a few dozen PHP tests and resources to demonstrate that this is both possible and

[webkit-dev] Official GitHub Mirror Automatically Syncing

Hey folks, Just wanted to let everyone know that our GitHub mirror, https://github.com/WebKit/WebKit , is being automatically updated on SVN commits to trunk, just like the git.webkit.org repositories. Using the GitHub repository for

Re: [webkit-dev] GitHub Account and Commit Attribution

ecause someone could just grab the commit log and find the email), but that setting your email to private will not prevent commits from being attributed to you. Jonathan > On Dec 17, 2020, at 1:02 PM, Darin Adler wrote: > >> On Dec 17, 2020, at 8:47 AM, Jonathan Bedard via web

[webkit-dev] GitHub Account and Commit Attribution

Hey folks, Something we’ve just learned about commit attribution and GitHub is that adding an email to your GitHub account may not attribute commits that were pushed to a repository before you added the email. There were a few issues with history as it stands now, and I will be pushing up the

Re: [webkit-dev] GitHub Clone Published

To provide a short update: Thanks to Fuji Hironori who pointed out a class of contributors which were not properly imported. Re-writing history again to correct these cases. This does mean that the history on https://github.com/WebKit/Webkit will be changing

[webkit-dev] GitHub Clone Published

Hello contributors, This morning, I just finished pushing main with re-written history to https://github.com/WebKit/WebKit . Nothing is yet relying on this new repository yet, so we still have an opportunity to change things. In particular, I’m interested in

[webkit-dev] Bugzilla Accounts and contributors.json

Hello contributors, As of r270538, commit-queue will only respect committer and reviewer permissions on the first email in contributor.json. The motivation for this is that many contributors have old email addresses that they no longer control (usually because of certain email services being

Re: [webkit-dev] Commit Authorship on GitHub

> On Dec 1, 2020, at 1:55 PM, Yusuke Suzuki wrote: > > Hi Jonathan! > >> On Dec 1, 2020, at 8:22 AM, Jonathan Bedard via webkit-dev >> mailto:webkit-dev@lists.webkit.org>> wrote: >> >> Hello contributors, >> >> I am in the process

[webkit-dev] Commit Authorship on GitHub

Hello contributors, I am in the process of modifying one of our Git mirrors of the repository for permanent use. As part of that modification, I am repairing authorship of historical commits based on contributors.json. This effort includes our branches and resolving commits attributed to

Re: [webkit-dev] Github mirror is not updating

Not at first, but at the moment, yes, it is intentional. We are working on migrating WebKit to a more permanent and complete Git repository, which involves editing history. Because of this, we didn’t want to further the confusion we already have with two different sets of git hashes. The new