Re: [webkit-dev] Issue reports, merge requests, etc. (was: WebKit Transition to Git)

2020-10-02 Thread Ryosuke Niwa
I feel like I should write longer replies but here we go. On Fri, Oct 2, 2020 at 12:53 PM Michael Catanzaro wrote: > > On Fri, Oct 2, 2020 at 11:51 am, Ryosuke Niwa wrote: > > Since Igalia has a lot > > more experience working with other open source projects, do you have &g

Re: [webkit-dev] WebKit Transition to Git

2020-10-02 Thread Ryosuke Niwa
On Fri, Oct 2, 2020 at 5:06 PM Michael Catanzaro wrote: > > On Fri, Oct 2, 2020 at 13:48, Ken Russell wrote: > > Github's code review UI has a couple of feature gaps in my opinion. > > It's difficult to look at earlier versions of the pull request, in > > particular to verify that issues found

Re: [webkit-dev] WebKit Transition to Git

2020-10-02 Thread Ryosuke Niwa
On Fri, Oct 2, 2020 at 11:00 AM Michael Catanzaro wrote: > > On Fri, Oct 2, 2020 at 6:36 pm, Philippe Normand > wrote: > > Would you also consider preventing merge commits in order to keep a > > clean mainline branch? > > Big +1 to blocking merge commits. Merge commits in a huge project like >

Re: [webkit-dev] Request for position on isInputPending

2020-09-29 Thread Ryosuke Niwa
On Tue, Sep 29, 2020 at 1:44 PM Andrew Comminos wrote: > Thanks for the response Ryosuke, comments inline. > > On 9/23/20 12:37 AM, Ryosuke Niwa wrote: > > As we have discussed in other avenues, we're skeptical that this API is > > needed given native apps on iOS and macOS d

Re: [webkit-dev] Implementing MathML stylistic attributes in WebKit

2020-09-28 Thread Ryosuke Niwa
On Fri, Sep 25, 2020 at 12:47 AM Frédéric Wang wrote: > On 02/09/2019 16:11, Frédéric Wang wrote: > > Hello, > > Currently MathML attributes mathvariant, displaystyle and scriptlevel [1] > [2] are implemented in WebKit using custom "style resolution" and > "one-glyph rendering" inside the MathML

Re: [webkit-dev] Feedback on Blink's text fragment directive proposal

2020-09-24 Thread Ryosuke Niwa
On Thu, Sep 24, 2020 at 8:19 AM David Bokan wrote: > Can you clarify what question you’re looking to have answered? Are you >> asking for a new standards position in light of the replies below? >> > > There are two specific points: > > - As I understand it, HTML requires multi-vendor interest

Re: [webkit-dev] Smart Pointer Analysis Tool for WebKit

2020-09-23 Thread Ryosuke Niwa
On Wed, Sep 23, 2020 at 10:32 AM Darin Adler wrote: > On Sep 16, 2020, at 11:32 PM, Ryosuke Niwa wrote: > >1. Every data member to a ref counted object must use either Ref, >RefPtr, or WeakPtr. webkit.NoUncountedMemberChecker > > <https://github.com/llvm/llv

Re: [webkit-dev] Smart Pointer Analysis Tool for WebKit

2020-09-23 Thread Ryosuke Niwa
On Thu, Sep 17, 2020 at 2:51 AM Emilio Cobos Álvarez wrote: > Interesting. This looks fairly similar to some of the checkers we use in > mozilla-central, fwiw. > > One interesting difference is that we opted for explicitly annotating > the functions that can run script (think

Re: [webkit-dev] Smart Pointer Analysis Tool for WebKit

2020-09-23 Thread Ryosuke Niwa
On Thu, Sep 17, 2020 at 2:11 AM Konstantin Tokarev wrote: > > Sounds great! A few questions: > * Do I understand correctly that analyzer is a part of upstream clang and > can work on any platform? > Yes. * Does it require WebKit trunk or can work with older branches? It should work with

Re: [webkit-dev] Request for position on isInputPending

2020-09-23 Thread Ryosuke Niwa
On Fri, Sep 18, 2020 at 11:56 AM Andrew Comminos wrote: > We're looking to gather a position from WebKit folks on isInputPending, > an API to query for the presence of pending input events. It allows > sites to reduce event latency by yielding during longer computational > tasks, without

Re: [webkit-dev] Feedback on Blink's text fragment directive proposal

2020-09-23 Thread Ryosuke Niwa
On Fri, Sep 18, 2020 at 7:35 AM David Bokan wrote: > Friendly ping to get an answer here. > > Do my answers above address those points or is there anything else I can > clarify? > > Thanks, > David > > On Mon, Aug 31, 2020 at 1:42 PM David Bokan wrote: > >> [sending (again, sorry) from correct

[webkit-dev] Smart Pointer Analysis Tool for WebKit

2020-09-17 Thread Ryosuke Niwa
Hi all, I’ve been working with Geoff (ggaren) and Jan Korous from Apple's compiler team to create a static analyzer which detects dangerous use of ref counted objects, and we’re looking for folks who are interested in trying out this tool and helping us refine the tool. Please let me know if

Re: [webkit-dev] PSA: Bit fields won't be packed on Windows if you mix types

2020-09-04 Thread Ryosuke Niwa
On Thu, Sep 3, 2020 at 11:15 PM Fujii Hironori wrote: > > On Fri, Sep 4, 2020 at 2:56 PM Ryosuke Niwa wrote: > >> On Thu, Sep 3, 2020 at 10:11 PM Fujii Hironori >> wrote: >> >>> >>> On Fri, Sep 4, 2020 at 1:31 PM Ryosuke Niwa wrote: >>&

Re: [webkit-dev] PSA: Bit fields won't be packed on Windows if you mix types

2020-09-03 Thread Ryosuke Niwa
On Thu, Sep 3, 2020 at 10:11 PM Fujii Hironori wrote: > > On Fri, Sep 4, 2020 at 1:31 PM Ryosuke Niwa wrote: > >> Consecutive bit fields must use the same type. >> > > RenderLayer is mixing bool and unsigned in the consecutive bit fields. > They should use

Re: [webkit-dev] PSA: Bit fields won't be packed on Windows if you mix types

2020-09-03 Thread Ryosuke Niwa
; } struct C { uint32_t foo : 30; uint8_t bar : 2; } - R. Niwa On Thu, Mar 29, 2012 at 1:21 AM Ryosuke Niwa wrote: > Hi, > > Unlike gcc and clang, MSVC pads each consecutive member variables of the > same type in bitfields. e.g. if you have: > struct AB { > unsigned m_

Re: [webkit-dev] Request for position on hasDroppedEntry in PerformanceObserverCallback

2020-08-31 Thread Ryosuke Niwa
This seems fine to me. On Mon, Aug 31, 2020 at 9:09 AM Nicolás Peña wrote: > > Hi, > > We'd like to request an official position on a very small addition to > PerformanceTimeline specification. We've added a hasDroppedEntry parameter to > PerformanceObserverCallback, which is in >

Re: [webkit-dev] Request for position on Cookie Store API

2020-08-27 Thread Ryosuke Niwa
Hi, On Thu, Aug 27, 2020 at 12:02 PM Ayu Ishii wrote: > > We would like to ask for WebKit's official position on the Cookie Store API. > Cookie Store API aims to improve the complexity and performance issues of > cookies today by providing an asynchronous alternative to document.cookie and >

Re: [webkit-dev] Requesting a position on Document Policy

2020-08-25 Thread Ryosuke Niwa
Sorry for the late reply. We're going to review this feature. - R. Niwa On Tue, Jul 28, 2020 at 7:02 AM Ian Clelland wrote: > > Hi WebKit! > > I'm building out the infrastructure in Blink for Document Policy, and would > like to ship at least part of it in Chrome for developers to take

Re: [webkit-dev] Request for Position on Native File System API

2020-08-25 Thread Ryosuke Niwa
On Mon, Aug 17, 2020 at 10:38 AM Marijn Kruisselbrink wrote: > > We would like to get an official position from webkit for the Native File > System API (spec, explainer), a API that enables developers to build powerful > web apps that interact with files on the user’s local device. It builds on

Re: [webkit-dev] Status of custom paint?

2020-08-25 Thread Ryosuke Niwa
Our intern worked on the feature but I don't think anyone is actively maintaining or developing the feature at the moment. I don't think it's accurate to say it's mostly implemented. We got the basics working but there is quite a bit of work left to get to a feature complete / shippable state. -

Re: [webkit-dev] Request for position on the Origin-Isolation header

2020-08-20 Thread Ryosuke Niwa
Hi, On Thu, Aug 20, 2020 at 8:51 AM Domenic Denicola wrote: > > Hello webkit-dev, > > I've been working on a new header called Origin-Isolation, which is a way of > allowing origins to opt-out of using document.domain and cross-origin > sharing of WebAssembly.Module, and thus allowing the

Re: [webkit-dev] Request for position on content-visibility

2020-08-14 Thread Ryosuke Niwa
Hi, Sorry for the late reply. We're still reviewing this. - R. Niwa On Tue, May 26, 2020 at 12:00 PM Vladimir Levin wrote: > > Hi, > > I'm asking for WebKit's position on CSS property content-visibility (spec > draft: https://drafts.csswg.org/css-contain-2/#content-visibility). > > We're

Re: [webkit-dev] debug-test-runner: Timed out waiting for notifyDone to be called

2020-08-13 Thread Ryosuke Niwa
On Thu, Aug 13, 2020 at 9:42 AM Benjamin King wrote: > > Hi, > > I’m trying to run a LayoutTest case in the debugger using `debug-test-runner` > and it fails by timing out, see below. However, if I run `run-webkit-test` it > works. I read the WebKit wiki on debugging and searched google to no

Re: [webkit-dev] Request for feedback on CompressionStream and DecompressionStream

2020-08-12 Thread Ryosuke Niwa
Hi all, This is a very belated reply but what's being proposed seems reasonable to us (Apple's WebKit team). We would like to know more about use cases, and how they might be deployed in real websites / use cases but we don't see any major issues with it. - R. Niwa On Wed, Nov 27, 2019 at 11:18

Re: [webkit-dev] Position on emerging standard: Declarative Shadow DOM

2020-08-10 Thread Ryosuke Niwa
Hi, Sorry for the late reply. I've been on a medical leave. I just commented on https://github.com/whatwg/dom/issues/831 - R. Niwa On Tue, Aug 4, 2020 at 4:26 PM Mason Freed wrote: > > Hello WebKit folks, > > I just wanted to quickly ping this thread to see if there was any interest in >

Re: [webkit-dev] Request for position on Schemeful Same-Site

2020-08-10 Thread Ryosuke Niwa
Sorry for the late reply. We're going to review this. - R. Niwa On Thu, May 28, 2020 at 11:25 AM Steven Bingler wrote: > > Hello WebKit-dev, > > I'm seeking WebKit's position on Schemeful Same-Site. I've provided the > explainer [1], spec [2], TAG review [3], and Blink's I2P [4] which contains

Re: [webkit-dev] Request for position on Event Timing

2020-08-08 Thread Ryosuke Niwa
On Fri, Aug 7, 2020 at 2:09 PM Rob Buis wrote: > > I was not aware of Long Tasks API. However it seems to have a slightly > different focus (task vs. input events). Also I am mostly interested in > First Input Delay, and it was decided some time ago to not put it in > Long Tasks API (see >

Re: [webkit-dev] Request for Webkit position for Imperative Shadow DOM Distribution API

2020-08-06 Thread Ryosuke Niwa
ly > improve ergonomics for web developers. Let's do it in the next version of > the Imperative slot API. > Cool. - R. Niwa On Sat, Aug 1, 2020 at 12:09 AM Ryosuke Niwa wrote: > >> Hi Yu, >> >> I've reviewed your PRs and they look okay. We still prefer having the &g

Re: [webkit-dev] Request for position on Event Timing

2020-08-06 Thread Ryosuke Niwa
I'm generally concerned about the proliferation of all these X timing API. It's hard to review the aspect of "first input timing" because its definition is imprecise: https://github.com/WICG/event-timing/issues/91 On Thu, Aug 6, 2020 at 11:07 AM Simon Fraser wrote: > Our feedback is that this

Re: [webkit-dev] Request for Webkit position for Imperative Shadow DOM Distribution API

2020-08-01 Thread Ryosuke Niwa
Hi Yu, I've reviewed your PRs and they look okay. We still prefer having the ability to assign an arbitrary descendant node of a shadow root to be assigned to a slot since there are a number of user cases we care about that could be addressed with such a capability but what's currently being

Re: [webkit-dev] Introducing a minimum ICU version for WebKit

2020-04-03 Thread Ryosuke Niwa
On Fri, Apr 3, 2020 at 4:25 PM Kirsling, Ross wrote: > Hi everybody, > > > > Just sending out an email blast for visibility regarding > https://bugs.webkit.org/show_bug.cgi?id=209694. > > > > This patch: > >- Upgrades the Mac ICU headers under Source/WTF/icu from ICU 55 to ICU >62,

Re: [webkit-dev] Content-DPR: Image resolution optimization at CDN/transport layer

2020-03-11 Thread Ryosuke Niwa
On Wed, Mar 4, 2020 at 10:53 PM Noam Rosenthal wrote: > > > On Thu, Mar 5, 2020 at 4:24 AM Maciej Stachowiak wrote: >> >>> >> There has been a lot of work done on the spec front since the comments >> above, and I think we're ready for a re-review the state. >> * The next pull request:

Re: [webkit-dev] Terminology: Could we change 'roll out' to 'roll back'?

2020-03-06 Thread Ryosuke Niwa
On Fri, Mar 6, 2020 at 6:15 PM Kirsling, Ross wrote: > > Late on Friday seems like a good time for a terminological debate (), so I’d > like to propose we revisit one of the strangest items of WebKit-specific > terminology: the phrase ‘roll out’. > > In our industry, the typical meaning of the

Re: [webkit-dev] WebKit position on Paint Timing / (first paint, first contentful paint)

2020-03-03 Thread Ryosuke Niwa
On Tue, Mar 3, 2020 at 12:31 AM Noam Rosenthal wrote: > > On Tue, Mar 3, 2020 at 10:18 AM Ryosuke Niwa wrote: > >> Sorry for the delay. I had other other things to take care of first. >> >> Based on the discussion we had (between Maciej, Simon, Alan, and I), we &

Re: [webkit-dev] WebKit position on Paint Timing / (first paint, first contentful paint)

2020-03-03 Thread Ryosuke Niwa
Sorry for the delay. I had other other things to take care of first. Based on the discussion we had (between Maciej, Simon, Alan, and I), we should take the following items into account for WebKit's first meaningful paint heuristics: - Background image - SVG images - "Contentful" canvas

Re: [webkit-dev] Proposal for an "intent to" process for web-exposed features

2020-02-26 Thread Ryosuke Niwa
Thanks for starting this discussion. On Wed, Feb 26, 2020 at 10:33 PM Frédéric Wang wrote: > > The idea of an "intent to" process has been raised several times in the > past (e.g. in our 2020 goals [1]) and some people already use it > informally, but it does not seem that we have any agreement

Re: [webkit-dev] WebKit position on Paint Timing / (first paint, first contentful paint)

2020-02-26 Thread Ryosuke Niwa
On Wed, Feb 26, 2020 at 9:00 PM Maciej Stachowiak wrote: > > > On Feb 26, 2020, at 2:25 PM, Ryosuke Niwa wrote: > > > On Wed, Feb 26, 2020 at 11:29 AM Maciej Stachowiak wrote: > >> >> >> On Feb 26, 2020, at 10:51 AM, Noam Rosenthal >> wrote: >&

Re: [webkit-dev] WebKit position on Paint Timing / (first paint, first contentful paint)

2020-02-26 Thread Ryosuke Niwa
On Wed, Feb 26, 2020 at 10:54 AM Noam Rosenthal wrote: > (resending from correct address) > On Wed, Feb 26, 2020 at 8:08 PM Maciej Stachowiak wrote: > >> >> Some quick comments: >> > >> the definition of First Contentful Paint here in the spec: < >>

Re: [webkit-dev] WebKit position on Paint Timing / (first paint, first contentful paint)

2020-02-26 Thread Ryosuke Niwa
On Wed, Feb 26, 2020 at 11:29 AM Maciej Stachowiak wrote: > > > On Feb 26, 2020, at 10:51 AM, Noam Rosenthal > wrote: > > > > On Wed, Feb 26, 2020 at 8:08 PM Maciej Stachowiak wrote: > >> >> Some quick comments: >> > >> the definition of First Contentful Paint here in the spec: < >>

Re: [webkit-dev] Request for position on Badging API

2020-02-20 Thread Ryosuke Niwa
On Wed, Feb 19, 2020 at 4:32 PM Matt Giuca wrote: > > On Thu, 20 Feb 2020 at 11:18, Ryosuke Niwa wrote: > >> >> On Wed, Feb 19, 2020 at 3:29 PM Matt Giuca wrote: >> >>> On Wed, 19 Feb 2020 at 18:14, Ryosuke Niwa wrote: >>> >>>&g

Re: [webkit-dev] WebKit position on Wake Lock API

2020-02-19 Thread Ryosuke Niwa
On Tue, Feb 18, 2020 at 5:23 AM Thomas Steiner wrote: > On Sat 21. Dec 2019 at 02:18 Ryosuke Niwa wrote: > >> We'll be discussing this internally at Apple but since we're heading into >> the holiday shutdown, we probably won't be able to get back to you until >

Re: [webkit-dev] Request for position on Badging API

2020-02-18 Thread Ryosuke Niwa
rvice worker runs, you can do > that (but as has been discussed at length: > https://github.com/WICG/badging/issues/28, you *can't* currently set a > badge without a notification from a push message). > > On Mon, 17 Feb 2020 at 03:49, Ryosuke Niwa wrote: > >> For the rec

Re: [webkit-dev] Clearing old reviews from the queue

2020-02-16 Thread Ryosuke Niwa
Sounds reasonable to me although I’d suggest older than 1 year instead of 6 months since I don’t think 6 months is long enough to render a patch completely obsolete in many cases. - R. Niwa On Sun, Feb 16, 2020 at 07:53 Dean Jackson wrote: > Does anyone oppose clearing all review requests that

Re: [webkit-dev] Request for position on Badging API

2020-02-16 Thread Ryosuke Niwa
For the record, we have two concerns raised internally at Apple: * The integration of this API with push service worker would require running scripts in order to update the badge. This will pose a serious power consumption issue. * We don’t want every website to start using this API to increase

Re: [webkit-dev] WebKit position on Web NFC

2020-01-22 Thread Ryosuke Niwa
other non-Web platform where ordinary users can (or are advised to) only use well known trusted applications or visit well known trusted websites just like how native apps work today. - R. Niwa On Wed, Jan 22, 2020 at 8:15 AM Ryosuke Niwa wrote: > >> I'm not sure what specifics you're looki

Re: [webkit-dev] WebKit position on Web NFC

2020-01-22 Thread Ryosuke Niwa
I'm not sure what specifics you're looking for but the issue is that we don't believe permission prompt is sufficient mitigation. Ordinary people don't understand the full security & privacy implications of granting NFC access when asked. - R. Niwa On Wed, Jan 22, 2020 at 12:04 AM François

Re: [webkit-dev] WebKit position on Wake Lock API

2019-12-20 Thread Ryosuke Niwa
gt; https://groups.google.com/a/chromium.org/forum/m/#!msg/blink-dev/nrDKOvVl_I4/yNYZOwJ1EQAJ > > On Wed 11. Dec 2019 at 22:08 Ryosuke Niwa wrote: > >> >> On Wed, Dec 11, 2019 at 11:42 AM Maciej Stachowiak wrote: >> >>> >>> Is there a Blink Intent thread curren

Re: [webkit-dev] WebKit position on Wake Lock API

2019-12-11 Thread Ryosuke Niwa
On Wed, Dec 11, 2019 at 11:42 AM Maciej Stachowiak wrote: > > Is there a Blink Intent thread currently running on this or about to > start? And do you happen to know if there is a Mozilla standards-positions > issue on this? (We like to take into consideration whet the other browser > engines

Re: [webkit-dev] EWS Comments on Bugzilla (Was: EWS now parses error logs in case of build failure)

2019-12-03 Thread Ryosuke Niwa
il/webkit-dev/2019-December/030980.html > > Thanks > Aakash > > On Nov 5, 2019, at 12:04 PM, Alexey Proskuryakov wrote: > > > > 4 нояб. 2019 г., в 1:37 PM, Ryosuke Niwa написал(а): > > > On Mon, Nov 4, 2019 at 9:40 AM Alexey Proskuryakov wrote: > >>

Re: [webkit-dev] Handling flaky layout-test failures in EWS

2019-12-03 Thread Ryosuke Niwa
On Tue, Dec 3, 2019 at 9:29 AM Alexey Proskuryakov wrote: > > Yes, I think that this makes more sense than retrying. > > What is the current behavior when a patch introduces substantial > flakiness? E.g. this scenario: > > - First test run produces 5 failures. > - Second test run produces 5

Re: [webkit-dev] Removing WebSQL support

2019-11-22 Thread Ryosuke Niwa
paywalls.) > > > On Nov 22, 2019, at 12:35 AM, Ryosuke Niwa wrote: > > > > Hi all, > > > > It looks like we've successfully shipped iOS 13 and Safari 13 with > WebSQL disabled. I think it's time to remove the WebSQL supp

[webkit-dev] Removing WebSQL support

2019-11-22 Thread Ryosuke Niwa
Hi all, It looks like we've successfully shipped iOS 13 and Safari 13 with WebSQL disabled. I think it's time to remove the WebSQL support from WebKit entirely. - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] WPT at the WebKit Contributors Meeting

2019-11-13 Thread Ryosuke Niwa
Hi Stephen, Thanks for coming to the contributor's meeting and making a representation. We enjoyed your presentation & we had a really productive discussion. The WebKit team at Apple is putting a lot of effort into improving our WPT pass rate going forward as Maciej presented so we're looking

Re: [webkit-dev] Supporting for finding ref tests

2019-11-08 Thread Ryosuke Niwa
On Fri, Nov 8, 2019 at 2:15 PM Simon Fraser wrote: > > > On Nov 8, 2019, at 2:07 PM, Ryosuke Niwa wrote: > > > > On Fri, Nov 8, 2019 at 2:01 PM Simon Fraser wrote: > >> > >> I'd like to land a patch to support finding test references via >> rel=&q

Re: [webkit-dev] Supporting for finding ref tests

2019-11-08 Thread Ryosuke Niwa
On Fri, Nov 8, 2019 at 2:01 PM Simon Fraser wrote: > > I'd like to land a patch to support finding test references via rel="match/mismatch">: > https://bugs.webkit.org/show_bug.cgi?id=203784 > > There has been some discussion about this in the past: >

Re: [webkit-dev] [Styling] Space between [] and () in C++ lambdas

2019-11-08 Thread Ryosuke Niwa
There has been no more votes either way so no space wins. Here's a patch to codify it in our code style guidelines: https://bugs.webkit.org/show_bug.cgi?id=204021 - R. Niwa On Sat, Nov 2, 2019 at 8:26 PM Ryosuke Niwa wrote: > On Sat, Nov 2, 2019 at 10:16 AM Caitlin Potter wr

Re: [webkit-dev] [Styling] () for a lambda without arguments (Was Space between [] and () in C++ lambdas)

2019-11-08 Thread Ryosuke Niwa
quired by the C++ grammar, so we can’t say to always omit (). > We could say to always have it, to only have it when necessary, or have no > code style guideline. I think we should always have spaces before and > after, though. > > On Nov 3, 2019, at 3:27 AM, Ryosuke Niwa wrote: > &

[webkit-dev] iOS EWS behind by 3 days??

2019-11-04 Thread Ryosuke Niwa
Hi all, Does anyone know what's happening with iOS EWS? They're ~3 days behind now: https://ews-build.webkit.org/#/builders/24 - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] EWS Comments on Bugzilla (Was: EWS now parses error logs in case of build failure)

2019-11-04 Thread Ryosuke Niwa
On Mon, Nov 4, 2019 at 9:40 AM Alexey Proskuryakov wrote: > > Can you elaborate on that, how exactly is e-mailing on first failure > useful to reviewers? > > Getting rid of Bugzilla comments was one of the goals of EWS rewrite, > based on engineering feedback about noise in bugs and in e-mail,

Re: [webkit-dev] [Styling] () for a lambda without arguments (Was Space between [] and () in C++ lambdas)

2019-11-02 Thread Ryosuke Niwa
On Sat, Nov 2, 2019 at 8:25 PM Ryosuke Niwa wrote: > > On Sat, Nov 2, 2019 at 7:54 PM Chris Dumez wrote: > >> >> >> On Nov 2, 2019, at 7:38 PM, Ryosuke Niwa wrote: >> >>  >> >> On Sat, Nov 2, 2019 at 1:23 AM Antti Koivisto wrote: >> &

Re: [webkit-dev] [Styling] () for a lambda without arguments (Was Space between [] and () in C++ lambdas)

2019-11-02 Thread Ryosuke Niwa
On Sat, Nov 2, 2019 at 1:23 AM Antti Koivisto wrote: > > On Sat, Nov 2, 2019 at 1:38 AM Ryosuke Niwa wrote: > >> On Fri, Nov 1, 2019 at 11:53 AM Michael Catanzaro >> wrote: >> >>> On Fri, Nov 1, 2019 at 11:19 am, Ryosuke Niwa wrote: >>> > Nam

[webkit-dev] [Styling] () for a lambda without arguments (Was Space between [] and () in C++ lambdas)

2019-11-01 Thread Ryosuke Niwa
On Fri, Nov 1, 2019 at 11:53 AM Michael Catanzaro wrote: > On Fri, Nov 1, 2019 at 11:19 am, Ryosuke Niwa wrote: > > Namely, some people write a lambda as: > > auto x = [] () { } > > > > with a space between [] and () while others would write it as: > > &g

Re: [webkit-dev] [Styling] Space between [] and () in C++ lambdas

2019-11-01 Thread Ryosuke Niwa
On Fri, Nov 1, 2019 at 11:19 AM Ryosuke Niwa wrote: > Hi all, > > There seems to be inconsistency in our coding style with regards to > spacing in lambdas. > > Namely, some people write a lambda as: > auto x = [] () { } > > with a space between [] and () while others

[webkit-dev] [Styling] Space between [] and () in C++ lambdas

2019-11-01 Thread Ryosuke Niwa
Hi all, There seems to be inconsistency in our coding style with regards to spacing in lambdas. Namely, some people write a lambda as: auto x = [] () { } with a space between [] and () while others would write it as: auto x = []() { } without a space between the two. I'd like to require

Re: [webkit-dev] EWS now parses error logs in case of build failure

2019-10-29 Thread Ryosuke Niwa
These enhancements are great. There is one feature of the old EWS that I really miss, which is that I used to get emails when some EWS failed. With new EWS, I have to keep checking back the bugzilla to see if any of them have failed periodically. Can we add a feature to opt into such an email

Re: [webkit-dev] Can the WebKit logo be used for WebKit ports? (like WebKitGTK)

2019-10-11 Thread Ryosuke Niwa
On Fri, Oct 11, 2019 at 9:38 AM Konstantin Tokarev wrote: > > 10.10.2019, 23:10, "Ryosuke Niwa" : > > People often associate the term "WebKit" with Apple's WebKit port in > practice. The risk here is really about people not understanding the nuance > o

Re: [webkit-dev] Implementing OffscreenCanvas

2019-10-11 Thread Ryosuke Niwa
On Fri, Oct 11, 2019 at 2:09 AM Chris Lord wrote: > > On 2019-10-10 23:15, Ryosuke Niwa wrote: > > On Thu, Oct 10, 2019 at 2:07 PM Myles C. Maxfield > > wrote: > > > >>> On Oct 10, 2019, at 12:57 PM, Ryosuke Niwa > >>> wrote: > >>>

Re: [webkit-dev] Can the WebKit logo be used for WebKit ports? (like WebKitGTK)

2019-10-10 Thread Ryosuke Niwa
On Thu, Oct 10, 2019 at 9:03 AM Carlos Alberto Lopez Perez < clo...@igalia.com> wrote: > On 09/10/2019 21:53, Maciej Stachowiak wrote: > > In terms of legalities: > > > > The WebKit logo (as well as the term WebKit) is trademarked by Apple, > but there are acceptable use guidelines in the Terms

Re: [webkit-dev] Implementing OffscreenCanvas

2019-10-10 Thread Ryosuke Niwa
Hi Chris, I'm excited that you're working on OffscreenCanvas because I think it would be a valuable feature, and I'm confident we can come up with a strategy to limit its privacy & security risk as we see fit. However, many of your patches seem to ignore the fact most of WebCore objects aren't

Re: [webkit-dev] virtual destructor annotations in subclasses

2019-10-08 Thread Ryosuke Niwa
On Tue, Oct 8, 2019 at 4:24 PM Yury Semikhatsky wrote: > > This question came up in a code review where I annotated subclass's > destructor with 'override': > > class SuperClass { > public: > virtual ~SuperClass() {} > }; > > class Subclass : public SuperClass { > public: > ~Subclass()

[webkit-dev] Implementing requestIdleCallback

2019-10-07 Thread Ryosuke Niwa
Hi all, I'm starting the effort to implement requestIdleCallback [1] in WebKit in https://bugs.webkit.org/show_bug.cgi?id=164193. It's an API for executing scripts when the browser is idle. It's supported by both Gecko & Blink as well as the old Edge engine. Because we don't plan on implementing

Re: [webkit-dev] Can the WebKit logo be used for WebKit ports? (like WebKitGTK)

2019-10-02 Thread Ryosuke Niwa
I don't know the rules regarding the logo use but it might be a bit misleading to use WebKit logo without any qualification for GTK+ port on wpt.fyi. I'd imagine people who visiting wpt.fyi may not realize how different GTK+ and Apple's WebKit ports are in terms of set of features being enabled,

Re: [webkit-dev] Planned EWS improvements

2019-09-26 Thread Ryosuke Niwa
On Fri, Sep 27, 2019 at 7:57 AM Saam Barati wrote: > Hi Aakash, > > Thanks for doing this work. > > On Sep 26, 2019, at 11:27 AM, Aakash Jain wrote: > > Hi Everyone, > > I have been making number of improvements to EWS. I also have various > planned improvements to EWS. I wanted to reach out to

Re: [webkit-dev] Implementing MathML stylistic attributes in WebKit

2019-09-02 Thread Ryosuke Niwa
On Mon, Sep 2, 2019 at 7:11 AM Frédéric Wang wrote: > > Currently MathML attributes mathvariant, displaystyle and scriptlevel [1] > [2] are implemented in WebKit using custom "style resolution" and > "one-glyph rendering" inside the MathML layout code [3] [4] [5]. These > features involve text

[webkit-dev] Disabling keygen element by default

2019-08-16 Thread Ryosuke Niwa
Hi all, HTML keygen element had been removed from Chrome since 2017, and Firefox recently removed it in Firefox 69: https://bugzilla.mozilla.org/show_bug.cgi?id=1315460 I've put a patch up to disable keygen element by default on https://bugs.webkit.org/show_bug.cgi?id=200850. - R. Niwa

Re: [webkit-dev] Moving to Python 3

2019-07-13 Thread Ryosuke Niwa
On Sat, Jul 13, 2019 at 4:14 PM Michael Catanzaro wrote: > On Sat, Jul 13, 2019 at 6:02 PM, Maciej Stachowiak > wrote: > > This is exactly what virtualenvs can do. And this is how we should do > > it IMO, even for systems that natively have some version of Python 3. > > I guess that's fine for

Re: [webkit-dev] Moving to Python 3

2019-07-13 Thread Ryosuke Niwa
es, as long as it doesn’t replace or break existing Python2.7 and/or other python scripts in the system. > On Jul 12, 2019, at 7:34 PM, Ryosuke Niwa wrote: > >  > > > On Fri, Jul 12, 2019 at 7:03 PM Michael Catanzaro > wrote: > >> On Fri, Jul 12, 2019 at 5:22 P

Re: [webkit-dev] Moving to Python 3

2019-07-12 Thread Ryosuke Niwa
On Fri, Jul 12, 2019 at 7:03 PM Michael Catanzaro wrote: > On Fri, Jul 12, 2019 at 5:22 PM, Ryosuke Niwa wrote: > > I frequently do WebKit development in older versions of macOS to > > diagnose old OS specific regressions, and having to install Python 3 > > each time I ins

Re: [webkit-dev] Moving to Python 3

2019-07-12 Thread Ryosuke Niwa
On Fri, Jul 12, 2019 at 1:04 PM Jonathan Bedard wrote: > > > On Jul 12, 2019, at 12:49 PM, Michael Catanzaro > wrote: > > > > On Fri, Jul 12, 2019 at 2:18 PM, Jonathan Bedard > wrote: > >> The trouble I foresee us encountering with any scheme which attempts a > conversion which retains both

Re: [webkit-dev] What is the status of Network Error Logging and Reporting API?

2019-06-10 Thread Ryosuke Niwa
On Sat, Jun 8, 2019 at 5:37 PM Konstantin Tokarev wrote: > > 04.06.2019, 02:41, "Ryosuke Niwa" : > > I assume you want to use this feature. What are your use cases? > > Actually, I was just rambling through web-platform-tests and discovered > thing I

Re: [webkit-dev] Remove SVGTests.hasExtension?

2019-06-07 Thread Ryosuke Niwa
s://www.fxsitecompat.com/en-CA/docs/2015/several-properties-will-be-removed-from-svgsvgelement/ > > I didn't check Edge, but Microsoft is migrating to Chromium so that's not > going to be there in future versions. > > On 07/06/2019 20:40, Ryosuke Niwa wrote: > > Does Edge

Re: [webkit-dev] Remove SVGTests.hasExtension?

2019-06-07 Thread Ryosuke Niwa
Does Edge support it? When did Firefox remove this feature? On Fri, Jun 7, 2019 at 1:55 AM Frédéric Wang wrote: > Hi, > > 4 years ago, the SVG WG resolved to remove SVGTests.hasExtension due to lack > of use and being a poor API. > It was removed from Chromium at that time and has been removed

Re: [webkit-dev] What is the status of Network Error Logging and Reporting API?

2019-06-03 Thread Ryosuke Niwa
I assume you want to use this feature. What are your use cases? On Sun, Jun 2, 2019 at 6:16 PM Konstantin Tokarev wrote: > They are missing from features.json > > https://w3c.github.io/network-error-logging/ > https://www.w3.org/TR/reporting/ > > -- > Regards, > Konstantin > >

[webkit-dev] Waiting for an event in layout test...

2019-05-31 Thread Ryosuke Niwa
I’m gonna give you a game changing function: function listenForEventOnce(target, name, timeout) { return new Promise((resolve, reject) => { const timer = timeout ? setTimeout(reject, timeout) : null; target.addEventListener(name, () => { if (timer)

Re: [webkit-dev] Introducing brand new EWS

2019-04-11 Thread Ryosuke Niwa
, 2019 at 12:17 PM Aakash Jain wrote: > Hi Ryosuke, > > Sorry for the delay. I will soon be adding the feature to display patch's > position in queue in https://bugs.webkit.org/show_bug.cgi?id=196607. > Would that address your concern? > > Thanks > Aakash > > On Apr

Re: [webkit-dev] Introducing brand new EWS

2019-04-04 Thread Ryosuke Niwa
The new bubbles seem to be working well, and having API tests running in EWS is great! Can we add the waterfall view to https://ews-build.webkit.org/#/builders so that we can see where our patches are in the queue? - R. Niwa On Thu, Apr 4, 2019 at 6:59 PM Aakash Jain wrote: > Introducing

Re: [webkit-dev] MathML Refresh Heads up

2019-03-21 Thread Ryosuke Niwa
On Thu, Mar 21, 2019 at 9:42 AM Frédéric Wang wrote: > On 20/03/2019 20:45, Ryosuke Niwa wrote: > > I agree on the goal but disagree on the suggestion. At minimum, we should > decide each case separately and try to collect some data before. > >> We can continue to agree to d

Re: [webkit-dev] MathML Refresh Heads up

2019-03-20 Thread Ryosuke Niwa
On Wed, Mar 20, 2019 at 10:42 AM Ryosuke Niwa wrote: > > On Wed, Mar 20, 2019 at 5:57 AM Frédéric Wang wrote: > >> On 16/03/2019 00:04, Ryosuke Niwa wrote: >> >> On Fri, Mar 15, 2019 at 3:33 PM Frédéric Wang wrote: >> >>> Hi Ryosuke and Myles, >>

Re: [webkit-dev] MathML Refresh Heads up

2019-03-20 Thread Ryosuke Niwa
On Wed, Mar 20, 2019 at 5:57 AM Frédéric Wang wrote: > On 16/03/2019 00:04, Ryosuke Niwa wrote: > > On Fri, Mar 15, 2019 at 3:33 PM Frédéric Wang wrote: > >> Hi Ryosuke and Myles, >> >> Thank you for your reply. First, the exact thing about what will be in >&g

Re: [webkit-dev] MathML Refresh Heads up

2019-03-15 Thread Ryosuke Niwa
On Fri, Mar 15, 2019 at 3:33 PM Frédéric Wang wrote: > Hi Ryosuke and Myles, > > Thank you for your reply. First, the exact thing about what will be in > MathML Core is still open, people are welcome to join and participate to > the MathML CG [1] or comment on the GitHub tracker [2]. > > Our

Re: [webkit-dev] MathML Refresh Heads up

2019-03-15 Thread Ryosuke Niwa
On Fri, Mar 15, 2019 at 3:08 AM Frédéric Wang wrote: > Hello WebKit developers, > > As some of you may know, Igalia is working on MathML support in Chromium > this year [1]. As part of that effort we joined a new MathML Refresh > Community Group [2] and one goal is to focus on a core spec for

Re: [webkit-dev] Reminder regarding formatting uint64_t

2019-03-15 Thread Ryosuke Niwa
pageID); // wrong > >> LOG("%" PRIu64, pageID); // correct > >> > >> This is good to keep in mind for any sized integer types, but uint64_t > >> in particular since this is what causes problems for us in practice. > > > > > > >

Re: [webkit-dev] PSA: WebCore::Quirks should define the logic to determine if a particular site specific quirk is needed or not

2019-03-12 Thread Ryosuke Niwa
On Tue, Mar 12, 2019 at 7:57 PM Michael Catanzaro wrote: > On Tue, Mar 12, 2019 at 9:42 PM, Ryosuke Niwa wrote: > > On that note, I'd appreciate if someone who maintains PlayStation / > > Windows ports could cleanup standardsUserAgentForURL to use > > WebsitePolicies in

[webkit-dev] PSA: WebCore::Quirks should define the logic to determine if a particular site specific quirk is needed or not

2019-03-12 Thread Ryosuke Niwa
Hi all, I've consolidated all site specific quirks in WebCore and WebKit into WebCore::Quirks: https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/page/Quirks.cpp Going forward, any logic to determine whether a given site specific quirk is needed or not in a given document should be

Re: [webkit-dev] Reminder regarding formatting uint64_t

2019-02-27 Thread Ryosuke Niwa
We should probably stop using these formatting strings in favor of makeString by making *LOG* functions to use makeString behind the scene. See https://trac.webkit.org/changeset/242014 for example. - R. Niwa On Wed, Feb 27, 2019 at 2:36 PM Michael Catanzaro wrote: > Hi, > > For the past

Re: [webkit-dev] Encoding and decoding ProcessID

2019-02-24 Thread Ryosuke Niwa
On Sun, Feb 24, 2019 at 9:55 AM Adrien Destugues wrote: > We are finally starting to look into moving the Haiku port to WebKit2. > > We have hit one little problem I'm not sure how to solve. Our pid_t on > 32bit Haiku is declared as a signed long integer (this is for legacy > reasons and not

Re: [webkit-dev] Code Style: Opinion on returning void

2019-02-21 Thread Ryosuke Niwa
On Thu, Feb 21, 2019 at 9:31 AM Darin Adler wrote: > I tried not to weigh in on this, but my view on the materials we should > use to build the bike shed must be shared! > > Generally it seems neat to be able to make the code slightly more tight > and terse by merging the function call and the

Re: [webkit-dev] For your consideration: Naming scheme for fooIfExists/ensureFoo

2019-02-21 Thread Ryosuke Niwa
For those who joined webkit-dev after June 2013, see https://lists.webkit.org/pipermail/webkit-dev/2013-June/thread.html#25056 On Thu, Feb 21, 2019 at 7:54 PM Ryosuke Niwa wrote: > I guess we never remembered to update our style guideline back in 2013. > > I've uploaded a pa

Re: [webkit-dev] For your consideration: Naming scheme for fooIfExists/ensureFoo

2019-02-21 Thread Ryosuke Niwa
I guess we never remembered to update our style guideline back in 2013. I've uploaded a patch to do this: https://bugs.webkit.org/show_bug.cgi?id=194930 - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] Moving to Git

2019-02-20 Thread Ryosuke Niwa
On Wed, Feb 20, 2019 at 10:02 AM Philippe Normand wrote: > On Wed, 2019-02-20 at 09:40 -0800, Ryosuke Niwa wrote: > > > > On Wed, Feb 20, 2019 at 8:28 AM Bug Tracker < > > bug.tracking.acco...@protonmail.com> wrote: > > > I was curious about the statu

<    1   2   3   4   5   6   7   8   9   10   >