On Wed, Aug 8, 2012 at 11:43 AM, Alexey Proskuryakov a...@webkit.org wrote:
I can see some downsides to emptying the cache before each test:
- we won't be getting any test coverage for cache behavior when it hits
non-trivial size;
We should have a separate test for that as Eric pointed
,
Ryosuke Niwa
Software Engineer
Google Inc.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev
Committers, changes, and reviewers mailing lists are inappropriate for
these questions.
See
http://dvcs.w3.org/hg/editing/raw-file/tip/editing.html#canonical-space-sequences
However, no browser implements the spec exactly so if you're planning on
submitting some patches, basing your patch based
Excellent! Thanks for the follow up. I'm so glad we reached out to the
standards group first.
- Ryosuke
On Aug 7, 2012 2:31 PM, Edward O'Connor eocon...@apple.com wrote:
Hi,
After reviewing the original specification for 'user-select: all' [1], I
think the behavior we had in mind for
If you wanted to contribute to WebKit, file bugs on bugs.webkit.org and
submit patches there.
Also see http://www.webkit.org/coding/contributing.html
On Mon, Aug 6, 2012 at 1:09 PM, Alex Christensen
alex.christen...@flexsim.com wrote:
I got webkit to compile for Windows x64, and it runs
webkit-patch apply-from-bug bug number or webkit-patch apply-attachment
attachment id will do.
On Sun, Aug 5, 2012 at 9:57 PM, talking1...@gmail.com wrote:
Hi
I want to apply an patch to my git code, but i don't know how to download
and apply it.
Any help explaining this would be much
If you can't run webkit-patch, then you can do:
patch -p0 path to locally saved patch
On Sun, Aug 5, 2012 at 10:08 PM, 石梦军 talking1...@126.com wrote:
But in the windows platform, how to execute the webkit-patch.
Thanks.
--
BGs/Felix Shi
At 2012-08-06 12:59:54,Ryosuke Niwa rn
Shi
At 2012-08-06 13:12:01,Ryosuke Niwa rn...@webkit.org wrote:
If you can't run webkit-patch, then you can do:
patch -p0 path to locally saved patch
On Sun, Aug 5, 2012 at 10:08 PM, 石梦军 talking1...@126.com wrote:
But in the windows platform, how to execute the webkit-patch.
Thanks
or tests on your local machine that still use
window.layoutTestController, you must update your patches and tests to use
window.testRunner instead.
I thank you all for your time and your cooperation.
Best regards,
Ryosuke Niwa
Software Engineer
Google Inc
On Thu, Aug 2, 2012 at 9:43 PM, Bruno Abinader brunoabina...@gmail.comwrote:
On Thu, Aug 2, 2012 at 6:10 PM, Ryosuke Niwa rn...@webkit.org wrote:
Does the spec require to return new values in the computed style of
text-decoration property without authors specifying new text-decoration
-text-decorations-in-effect usage.
On Tue, Jul 31, 2012 at 10:40 PM, Ryosuke Niwa rn...@webkit.org wrote:
Please make sure the new text decoration values don't break editing (rich
text editing execCommand). In particular, we probably need to update
ApplyStyleCommand/EditingStyle to handle
Do we pass tests W3C submitted by Opera Mozilla?
- Ryosuke
On Mon, Jul 30, 2012 at 11:35 PM, Arko Saha ngh...@motorola.com wrote:
I am planning to enable MICRODATA feature by default in WebKit.
Microdata master bug: https://bugs.webkit.org/show_bug.cgi?id=68609
Microdata spec:
On Mon, Jul 30, 2012 at 11:51 PM, Arko Saha ngh...@motorola.com wrote:
I have tested the test :
http://w3c-test.org/html/tests/submission/Opera/microdata/001.html
255 Pass
82 Fail
Most of the failed cases are specific to their implementation and for
others, I need to check.
What do you
Hi,
I've fixed a bunch of bugs in perf-o-matic; in particular, I've determined
the culprit of the performance issue of perf-o-matic and fixed it.
Dashboard, custom graphs, etc... should load almost instantly now.
Best,
Ryosuke Niwa
Software Engineer
Google Inc
For those of you who didn't see the original announcement of perf-o-matic,
it's located at:
webkit-perf.appspot.com.
- Ryosuke
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev
On Tue, Jul 31, 2012 at 12:55 AM, Arko Saha ngh...@motorola.com wrote:
For an example :
test(function () {
assert_equals( makeEl('div',{itemtype:' '}).itemType[0],
window.undefined );
}, 'itemType[index] must be undefined for out-of-range index');
makeEl method creates an element div
. in our own performance tests.
Note that Firefox and Chrome have already shipped with a prefixed version
and Microsoft is going to ship it in IE10.
Best,
Ryosuke Niwa
Software Engineer
Google Inc.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http
On Tue, Jul 31, 2012 at 6:29 PM, Dirk Pranke dpra...@chromium.org wrote:
I'm finally getting around to cleaning up the byzantine mass of
options in new-run-webkit-tests that controls what gets printed to
stderr and stdout during a test run.
The patch is posted in
On Tue, Jul 31, 2012 at 6:59 PM, Dirk Pranke dpra...@chromium.org wrote:
On Tue, Jul 31, 2012 at 6:36 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Tue, Jul 31, 2012 at 6:29 PM, Dirk Pranke dpra...@chromium.org
wrote:
I'm finally getting around to cleaning up the byzantine mass of
options
:
On Tue, Jul 31, 2012 at 7:02 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Tue, Jul 31, 2012 at 6:59 PM, Dirk Pranke dpra...@chromium.org
wrote:
On Tue, Jul 31, 2012 at 6:36 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Tue, Jul 31, 2012 at 6:29 PM, Dirk Pranke dpra...@chromium.org
wrote
Please make sure the new text decoration values don't break editing (rich
text editing execCommand). In particular, we probably need to update
ApplyStyleCommand/EditingStyle to handle -webkit-text-decoration*.
On Tue, Jul 31, 2012 at 7:35 PM, Bruno Abinader brunoabina...@gmail.comwrote:
Hi all
to reproduce it and I am not seeing
much in the logs.
-Bill
On Jul 29, 2012, at 3:04 PM, Ryosuke Niwa rn...@webkit.org wrote:
Now I'm getting errors like the one below:
Traceback (most recent call last):
File /usr/lib/python2.6/site-packages/trac/web/api.py, line 441, in
send_error
data
Now I'm getting errors like the one below:
Traceback (most recent call last):
File /usr/lib/python2.6/site-packages/trac/web/api.py, line 441,
in send_error
data, 'text/html')
File /usr/lib/python2.6/site-packages/trac/web/chrome.py, line
828, in render_template
message =
flot
graphs summarizing the results.
Sample results page:
https://bug-92575-attachments.webkit.org/attachment.cgi?id=155123.
Best,
Ryosuke Niwa
Software Engineer
Google Inc.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org
-issued Mac* due to
some network setting issues (DRT simply ignores proxy setting you set
regardless of whether you're on the corporate network or not).
- Ryosuke
On Mon, Apr 16, 2012 at 1:42 AM, Ryosuke Niwa rn...@webkit.org wrote:
*Summary*
I propose to add a new page load time performance test
This is somewhat tangential but once we've solved this problem, can we
expose the data via testRunner or internals object so that we may use it in
our performance tests? It'll be very valuable to be able to monitor changes
in these metrics.
- Ryosuke
On Mon, Jul 23, 2012 at 3:32 PM, Alice Cheng alice_ch...@apple.com wrote:
We intend to work on an experimental implementation of a new
-webkit-user-select value that we are calling atomic. This value causes
the element to which it is applied to behave atomically for selection
purposes; either
On Mon, Jul 23, 2012 at 5:05 PM, Brendan Eich bren...@mozilla.org wrote:
Alice Cheng wrote:
Could you elaborate more on the difference? Maybe the difference is small
enough that it makes sense to reuse all. e.g. Mozilla might be willing to
change their behavior for all.
Mozilla is not
failures — won't be caught.
The current policy specifically says the committer is responsible for
making sure his or her patch builds passes tests:
http://www.webkit.org/coding/contributing.html
So please make sure your patch at least builds if you're landing a patch
via commit queue.
Best,
Ryosuke
On Thu, Jul 19, 2012 at 12:39 AM, Hajime Morrita morr...@chromium.orgwrote:
It is possible for a change to break chromium-linux, chromium-win or
chromium-mac,
that means developers needs to have Linux, Mac and Windows machines to
ensure
the successful build since there is no EWS for these
On Thu, Jul 19, 2012 at 11:15 AM, Brady Eidson beid...@apple.com wrote:
On Jul 19, 2012, at 11:01 AM, Oliver Buchtala
oliver.bucht...@googlemail.com wrote:
On 19.07.2012 19:53, Andreas Kling wrote:
On Tue, Jul 10, 2012 at 4:52 PM, Brady Eidson beid...@apple.com wrote:
On Jul 10, 2012,
If it weren't too much trouble, it might be nice to show some kind of
under maintenance page in the future so that we know for sure it's due to
the migration instead of migration-related outage.
- Ryosuke
On Thu, Jul 19, 2012 at 6:36 PM, William Siegrist wsiegr...@apple.comwrote:
See my
On Fri, Jul 13, 2012 at 4:16 AM, Jochen Eisinger joc...@chromium.orgwrote:
I wanted to share some updates about content_shell (a multi-processed
version of chromium's test shell): meanwhile, it is possible to generate
pixel results.
Out of 31431 tests that are executed on chromium-linux,
On Fri, Jul 13, 2012 at 5:57 AM, Stephen Chenney schen...@chromium.orgwrote:
I don't doubt there are poor comments, both outdated and useless. That's
a reviewing failure. You have simply highlighted the fact that any standard
for comments requires reviewer attention. Hence cost of maintaining
On Fri, Jul 13, 2012 at 11:03 AM, Dana Jansens dan...@chromium.org wrote:
On Fri, Jul 13, 2012 at 1:56 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Fri, Jul 13, 2012 at 5:57 AM, Stephen Chenney
schen...@chromium.orgwrote:
I don't doubt there are poor comments, both outdated and useless
On Fri, Jul 13, 2012 at 11:13 AM, Alec Flett alecfl...@chromium.org wrote:
On Fri, Jul 13, 2012 at 10:56 AM, Ryosuke Niwa rn...@webkit.org wrote:
On Fri, Jul 13, 2012 at 5:57 AM, Stephen Chenney
schen...@chromium.orgwrote:
I don't doubt there are poor comments, both outdated and useless
I'd vote for CSSRegion or CSSOMRegion for the class you're adding but I'll
also suggest we rename the existing Region class now that the term region
has a specific semantic in CSS. Maybe LayoutRegion or ScreenRegion?
- Ryosuke
On Jul 12, 2012 10:13 AM, Eric Seidel e...@webkit.org wrote:
I would
On Thu, Jul 12, 2012 at 10:43 AM, Stephen Chenney schen...@chromium.orgwrote:
As several people have shown, it is quite easy to come up with a formula
that shows the cost of maintaining comments is much lower than the cost of
living without.
I object to that conclusion. I've never seen any
On Thu, Jul 12, 2012 at 1:47 PM, Stephen Chenney schen...@chromium.orgwrote:
On Thu, Jul 12, 2012 at 3:44 PM, Dirk Pranke dpra...@chromium.org wrote:
On Thu, Jul 12, 2012 at 10:53 AM, Ryosuke Niwa rn...@webkit.org wrote:
On Thu, Jul 12, 2012 at 10:43 AM, Stephen Chenney
schen
On Thu, Jul 12, 2012 at 2:03 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Thu, Jul 12, 2012 at 1:47 PM, Stephen Chenney schen...@chromium.orgwrote:
On Thu, Jul 12, 2012 at 3:44 PM, Dirk Pranke dpra...@chromium.orgwrote:
On Thu, Jul 12, 2012 at 10:53 AM, Ryosuke Niwa rn...@webkit.org wrote
On Wed, Jul 11, 2012 at 6:54 AM, John Mellor joh...@chromium.org wrote:
On Fri, Jul 6, 2012 at 11:49 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Jul 6, 2012 3:16 PM, Per Bothner per.both...@oracle.com wrote:
On 07/06/2012 02:02 PM, Ryosuke Niwa wrote:
On Fri, Jul 6, 2012 at 12:54 PM, Per
On Jul 11, 2012 8:43 AM, John Mellor joh...@chromium.org wrote:
On Wed, Jul 11, 2012 at 4:21 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Wed, Jul 11, 2012 at 6:54 AM, John Mellor joh...@chromium.org wrote:
Even obvious (to some) concepts like InlineBox have subtleties, for
example not all
On Wed, Jul 11, 2012 at 9:30 AM, Yaar Schnitman y...@chromium.org wrote:
[(dev time of maintaining comments) + (risk of outdated comments causing
bugs X dev time of fixing resulting bugs)] (dev time gained by more
contributors each being more knowledgable)
No?
How did you reach such a
On Wed, Jul 11, 2012 at 10:44 AM, Adam Klein ad...@chromium.org wrote:
On Wed, Jul 11, 2012 at 9:51 AM, Ryosuke Niwa rn...@webkit.org wrote:
On Wed, Jul 11, 2012 at 9:30 AM, Yaar Schnitman y...@chromium.org
wrote:
[(dev time of maintaining comments) + (risk of outdated comments causing
On Fri, Jul 6, 2012 at 11:34 AM, Per Bothner per.both...@oracle.com wrote:
On 07/06/2012 10:05 AM, Dan Bernstein wrote:
It appears that lately most WebCore change log entires don’t include any
comments on individual functions. An overall description of the change at
the top of the change log
On Fri, Jul 6, 2012 at 11:42 AM, Dana Jansens dan...@chromium.org wrote:
On Fri, Jul 6, 2012 at 1:05 PM, Dan Bernstein m...@apple.com wrote:
It appears that lately most WebCore change log entires don’t include any
comments on individual functions. An overall description of the change at
the
On Fri, Jul 6, 2012 at 1:35 PM, Joe Mason jma...@rim.com wrote:
As has been noted in a recent thread, WebKit strives to make the code
clear and understandable rather than have embedded comments that can become
obsolete. One common practice that I find quite opaque is for classes to
have
As Eric pointed out, this is completely off the topic of the thread now. So
moving to a new thread.
On Fri, Jul 6, 2012 at 12:54 PM, Per Bothner per.both...@oracle.com wrote:
On 07/06/2012 11:41 AM, Ryosuke Niwa wrote:
Indeed, we try to avoid adding comments as much as possible since
On Fri, Jul 6, 2012 at 1:51 PM, Per Bothner per.both...@oracle.com wrote:
Documenting what a function/method does is sometimes useful,
but what is really important is documenting what (an instance of)
a class *is* and (preferably) how it relates to other objects.
For some classes, yes.
On
On Fri, Jul 6, 2012 at 2:26 PM, Joe Mason jma...@rim.com wrote:
From: Filip Pizlo [fpi...@apple.com]
Sent: Friday, July 06, 2012 4:52 PM
To: Joe Mason
Cc: WebKit Development [webkit-dev@lists.webkit.org]
Subject: Re: [webkit-dev] Pointers and self-documenting code
It's not at all
On Jul 6, 2012 2:36 PM, Per Bothner per.both...@oracle.com wrote:
On 07/06/2012 02:18 PM, Ryosuke Niwa wrote:
I've found that our culture of not adding comments have given me a
pressure to think really hard to come up with better class names rather
than going with vague names with explanatory
On Jul 6, 2012 3:16 PM, Per Bothner per.both...@oracle.com wrote:
On 07/06/2012 02:02 PM, Ryosuke Niwa wrote:
Heavens forbid that someone who actually understands the code should
have
to update the comments once in a while. Better to keep it
inscrutable
so newbies spend all
On Jul 6, 2012 3:04 PM, Filip Pizlo fpi...@apple.com wrote:
It is indeed a problem of incentives.
Nobody has the incentive to maintain a class comment when making changes,
since comments are not checked by the compiler.
Therefore, it's much better to not write comments, and instead find
On Jul 6, 2012 4:09 PM, Benjamin Poulain benja...@webkit.org wrote:
On Fri, Jul 6, 2012 at 3:49 PM, Ryosuke Niwa rn...@webkit.org wrote:
It DOES. Even today, I find many comments (even FIXMEs) that are
out-of-date. Say you add a some comment to a function A because of some
odd
behavior
On Jul 6, 2012 4:29 PM, Maciej Stachowiak m...@apple.com wrote:
On Jul 6, 2012, at 2:18 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Fri, Jul 6, 2012 at 1:51 PM, Per Bothner per.both...@oracle.com
wrote:
Documenting what a function/method does is sometimes useful,
but what is really
On Jul 6, 2012 4:34 PM, Maciej Stachowiak m...@apple.com wrote:
On Jul 6, 2012, at 2:37 PM, Per Bothner per.both...@oracle.com wrote:
On 07/06/2012 02:02 PM, Maciej Stachowiak wrote:
[... reasonable stuff I fully agree with - but one question ...]
Documenting ownership and lifetime
On Fri, Jul 6, 2012 at 4:54 PM, Per Bothner per.both...@oracle.com wrote:
On 07/06/2012 03:49 PM, Ryosuke Niwa wrote:
If nothing else
it's a useful sanity check: If something changes enough that you need to
change a comment, that suggests it's a good thing to take the time to
think through
On Fri, Jul 6, 2012 at 7:59 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Fri, Jul 6, 2012 at 4:54 PM, Per Bothner per.both...@oracle.comwrote:
On 07/06/2012 03:49 PM, Ryosuke Niwa wrote:
If nothing else
it's a useful sanity check: If something changes enough that you need to
change
All webkit.org have gotten so much faster after the upgrade. I think this
has improved my productivity to a whole new level.
Thanks a lot for making this improvement.
- Ryosuke
On Thu, Jun 28, 2012 at 5:30 PM, William Siegrist wsiegr...@apple.comwrote:
Buildbot is back up. The IP address
On Tue, Jun 26, 2012 at 10:05 PM, Darin Adler da...@apple.com wrote:
Some of the email to the WebKit lists is now showing up in 10 point size
rather than the default size for my mail reader. I’m having a hard time
reading the small text and I have to do various tricks to make these mails
for
letting us know of this problem.
On Tue, Jun 26, 2012 at 10:19 PM, Darin Adler da...@apple.com wrote:
On Jun 26, 2012, at 10:12 PM, Ryosuke Niwa wrote:
Could you send me a copy (markup and possibly a screenshot) of emails
you see this problem and ones you don't see this problem?
Sure
/g
then revert all new line changes. While sed adds a new line at the end of
each file when one is missing, this causes documents in quirks mode to
render differently and thus the modified tests to fail.
Upload the patch and cc me.
Best,
Ryosuke Niwa
Software Engineer
Google Inc
FYI, all conversion bugs *depend on*
https://bugs.webkit.org/show_bug.cgi?id=88210
- Ryosuke
On Mon, Jun 18, 2012 at 11:48 PM, Ryosuke Niwa rn...@webkit.org wrote:
Hello WebKittens,
I've exposed layoutTestController as testRunner in
http://trac.webkit.org/changeset/119946. Moving forward
On Tue, Jun 19, 2012 at 2:28 PM, Osztrogonac Csaba o...@inf.u-szeged.huwrote:
The idea is good, we should catching build errors as soon as possible. But
why don't
you make the Apple's part of build-webkit to build
DRT/WTR/ImageDiff/testbrowser/**...
too? I checked the bot logs and it seems
On Fri, Jun 15, 2012 at 3:18 AM, Navanshu Mahor mahor1...@gmail.com wrote:
Hello all,
I am actually novice in webkit but i want to learn *make webkit (on
webkit.org) compliant with new HTML5 Tags Features.
*Could anyone guide me through the steps to start with ?
Kindly suggest if i
On Fri, Jun 15, 2012 at 9:30 AM, Darin Adler da...@apple.com wrote:
On Jun 15, 2012, at 12:12 AM, Roland Steiner wrote:
I made the original name change, because I honestly was entirely confused
about the meaning of selfOnlyRef (it's done by Node on Document, so what
is self? Why is it
On Fri, Jun 15, 2012 at 9:49 AM, Darin Adler da...@apple.com wrote:
On Jun 15, 2012, at 9:47 AM, Ryosuke Niwa wrote:
// Nodes belonging to this document hold guard references -
// these are enough to keep the document from being destroyed, but
// not enough to keep it from removing its
Before unprefixing it, can we make sure we also pass Mozilla's tests and
vice versa? Mutation events was a huge mess partially because browsers
didn't interoperate. I'd like to make sure this API interoperates well from
day 1.
- Ryosuke
On Fri, Jun 15, 2012 at 10:31 AM, Adam Klein
:48 AM, Ryosuke Niwa rn...@webkit.org wrote:
Before unprefixing it, can we make sure we also pass Mozilla's tests and
vice versa? Mutation events was a huge mess partially because browsers
didn't interoperate. I'd like to make sure this API interoperates well
from
day 1.
- Ryosuke
On Fri, Jun 15, 2012 at 12:14 PM, Maciej Stachowiak m...@apple.com wrote:
I am not sure how to get the key points across without being accurate or
misleading. A version that I think explains the complete design without
saying anything false or misleading:
On Fri, Jun 15, 2012 at 12:40 PM, Maciej Stachowiak m...@apple.com wrote:
On Jun 15, 2012, at 12:22 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Fri, Jun 15, 2012 at 12:14 PM, Maciej Stachowiak m...@apple.com wrote:
I am not sure how to get the key points across without being accurate
On Fri, Jun 15, 2012 at 4:24 PM, Tony Payne tpa...@chromium.org wrote:
I would like to change chromium's ImageDiff to reflect the magnitude of
pixel changes. Currently, if the pixel has any difference, the entire pixel
is marked as 100% red. I'd like to change it so that miniscule difference
Here are some examples of old and new format:
BUGCR24182 SLOW MAC DEBUG : fast/css/large-list-of-rules-crash.html = PASS
BUGCR24182 SLOW LINUX MAC DEBUG :
fast/dom/Window/window-postmessage-clone-really-deep-array.html = PASS
BUGCR24182 SLOW MAC DEBUG :
Oops, some really bad typos.
On Thu, Jun 14, 2012 at 3:10 AM, Ryosuke Niwa rn...@webkit.org wrote:
Beginning of line (current proposal with expectations):
End of line with expectations (current proposal)
WONTFIX SKIP : media/media-captions.html = TIMEOUT
BUGWK43459 WONTFIX : http/tests
On Thu, Jun 14, 2012 at 1:44 PM, Peter Kasting pkast...@chromium.orgwrote:
On Thu, Jun 14, 2012 at 1:39 PM, Elliot Poger epo...@chromium.org wrote:
Can someone please remind me why IMAGE+TEXT even exists?
Wouldn't it be simpler to just mark a test as follows?
- IMAGE : allow image
Done in http://trac.webkit.org/changeset/120371
- Ryosuke
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
On Thu, Jun 14, 2012 at 4:34 PM, Adam Barth aba...@webkit.org wrote:
On Thu, Jun 14, 2012 at 4:22 PM, Maciej Stachowiak m...@apple.com wrote:
On Jun 14, 2012, at 1:47 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Thu, Jun 14, 2012 at 1:44 PM, Peter Kasting pkast...@chromium.org
wrote
On Wed, Jun 13, 2012 at 4:12 PM, Benjamin Poulain benja...@webkit.orgwrote:
On Wed, Jun 13, 2012 at 3:53 PM, Dirk Pranke dpra...@chromium.org wrote:
webkit.org/12345 WIN MAC DEBUG \
animations/stop-animation-on-suspend.html \ CRASH TEXT PASS
My bikeshedding:
-In my opinion, the backslash
On Wed, Jun 13, 2012 at 4:32 PM, Dirk Pranke dpra...@chromium.org wrote:
On Wed, Jun 13, 2012 at 4:26 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Wed, Jun 13, 2012 at 4:12 PM, Benjamin Poulain benja...@webkit.org
wrote:
On Wed, Jun 13, 2012 at 3:53 PM, Dirk Pranke dpra...@chromium.org
On Wed, Jun 13, 2012 at 4:55 PM, Tom Zakrajsek t...@codeaurora.org wrote:
As long as we're considering TitleCase for the keywords, could we use it
to keep all of them as single words?
WontFix, SkipCrash, SkipTimeout
For skipped tests, it doesn't make sense to have crash, timeout, etc...
On Mon, Jun 11, 2012 at 11:37 PM, Dirk Pranke dpra...@chromium.org wrote:
On Thu, Jun 7, 2012 at 4:47 PM, Dirk Pranke dpra...@chromium.org wrote:
I believe most if not all of the ports have started using either
TestExpectations files or a combination of TestExpectations files
(except for
On Mon, Jun 11, 2012 at 11:58 PM, Dirk Pranke dpra...@chromium.org wrote:
On Mon, Jun 11, 2012 at 11:45 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Mon, Jun 11, 2012 at 11:37 PM, Dirk Pranke dpra...@chromium.org
wrote:
On Thu, Jun 7, 2012 at 4:47 PM, Dirk Pranke dpra...@chromium.org
On Tue, Jun 12, 2012 at 9:50 AM, Darin Adler da...@apple.com wrote:
- Each time we change the tests we need to make sure we haven’t broken new
tests on various platforms and that we’ve updated the skipped or test
expectations files properly.
- When rearranging tests that share the test shell
On Tue, Jun 12, 2012 at 10:54 AM, Darin Adler da...@apple.com wrote:
On Jun 12, 2012, at 10:17 AM, Ryosuke Niwa wrote:
The last time we had this discussion, the consensus appeared to be
renaming it to RegressionTests.
I still like that name.
Are you suggesting that we have LayoutTests
and
WebKit's own tests. Can we put the imported W3C tests in imported-w3c
directory as proposed earlier?
Best,
Ryosuke Niwa
Software Engineer
Google Inc.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit
On Mon, Jun 11, 2012 at 2:21 PM, Jacob Goldstein jac...@adobe.com wrote:
Can we just create an imported-w3c folder at the same level as LayoutTests?
You mean at trunk? I don't think that makes sense, and our testing
infrastructure doesn't support that.
- Ryosuke
On Mon, Jun 11, 2012 at 2:25 PM, Jacob Goldstein jac...@adobe.com wrote:
On 6/11/12 2:24 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Mon, Jun 11, 2012 at 2:21 PM, Jacob Goldstein jac...@adobe.comwrote:
Can we just create an imported-w3c folder at the same level as
LayoutTests?
You mean
On Mon, Jun 11, 2012 at 2:33 PM, Dirk Pranke dpra...@chromium.org wrote:
Technically, it does (at least NRWT does), but I wouldn't recommend
it. NRWT is designed to allow tests to live in multiple repos, but it
seems like all of the tests in the webkit repo should be under a
single top-level
On Mon, Jun 11, 2012 at 7:33 PM, Mike Lawther mikelawt...@chromium.orgwrote:
I did so because I not all my tests are 'text only' tests, but I still
wanted them all together. My understanding was that the 'fast' directory
was intended for 'text only' tests only.
That's not the case. The
On Sat, Jun 9, 2012 at 12:27 PM, Ojan Vafai o...@chromium.org wrote:
Can you just expand out FAIL to it's equivalent longform? FAIL == TEXT
IMAGE IMAGE+TEXT. I don't see a need to block the infrastructure change on
this as the semantics are exactly the same. You can just find/replace every
On Fri, Jun 8, 2012 at 12:05 PM, Ojan Vafai o...@chromium.org wrote:
We'll still default --exit-after-n-crashes-or-timeouts to 20. That seems
more useful to me since you'd rarely hit this case locally and want to
continue running tests.
We should also increase this number. Non-chromium bots
On Fri, Jun 8, 2012 at 12:12 PM, Ojan Vafai o...@chromium.org wrote:
On Fri, Jun 8, 2012 at 12:08 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Fri, Jun 8, 2012 at 12:05 PM, Ojan Vafai o...@chromium.org wrote:
We'll still default --exit-after-n-crashes-or-timeouts to 20. That seems
more
On Fri, Jun 8, 2012 at 12:18 PM, Jochen Eisinger joc...@chromium.orgwrote:
I've implemented initial support for running layout tests using chromium's
content_shell instead of test_shell as the current DRT implementation does.
It's still a very experimental, but might already be interesting for
On Fri, Jun 8, 2012 at 12:37 PM, Dirk Pranke dpra...@chromium.org wrote:
I have no objection either to increasing the defaults for either of
these numbers or making it possible to have different defaults per
port.
Do you want to suggest different defaults? Should we use ORWT's
(infinite
On Fri, Jun 8, 2012 at 12:51 PM, Jochen Eisinger joc...@chromium.orgwrote:
On Fri, Jun 8, 2012 at 9:41 PM, Ryosuke Niwa rn...@webkit.org wrote:
Per my other thread about sharing IDLs between DumpRenderTree and
WebKitTestRunner, I would like to see us sharing IDL with WebKitTestRunner
instead
On Fri, Jun 8, 2012 at 12:50 PM, Filip Pizlo fpi...@apple.com wrote:
On Jun 8, 2012, at 12:31 PM, Dirk Pranke wrote:
On Fri, Jun 8, 2012 at 10:56 AM, Filip Pizlo fpi...@apple.com wrote:
It's a lot harder to dive into, a lot more cumbersome to improve, and
not
any easier to maintain.
On Fri, Jun 8, 2012 at 1:06 PM, Filip Pizlo fpi...@apple.com wrote:
On Jun 8, 2012, at 1:04 PM, Ryosuke Niwa wrote:
I agree that we've accumulated way too many unit tests in webkitpy and
some of our unit test code is hideous but I think it's quite unrealistic
not to have any unit tests
On Fri, Jun 8, 2012 at 1:09 PM, Jochen Eisinger joc...@chromium.org wrote:
On Fri, Jun 8, 2012 at 9:55 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Fri, Jun 8, 2012 at 12:51 PM, Jochen Eisinger joc...@chromium.orgwrote:
On Fri, Jun 8, 2012 at 9:41 PM, Ryosuke Niwa rn...@webkit.org wrote
On Fri, Jun 8, 2012 at 1:27 PM, Dirk Pranke dpra...@chromium.org wrote:
Most of these abstractions were either added to make testing easier
(and faster since we didn't have to write to a real filesystem)
That sounds like a bad idea.
- Ryosuke
___
On Fri, Jun 8, 2012 at 1:41 PM, Ojan Vafai o...@chromium.org wrote:
On Fri, Jun 8, 2012 at 1:37 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Fri, Jun 8, 2012 at 1:27 PM, Dirk Pranke dpra...@chromium.org wrote:
Most of these abstractions were either added to make testing easier
(and faster
801 - 900 of 1336 matches
Mail list logo
